- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 11 2022
Aug 11 2022
anlambert committed rCJSWH9c6d38a1ad70: jobs/swh-pypi-groovy: Use Sentry auth token when building web assets (authored by anlambert).
jobs/swh-pypi-groovy: Use Sentry auth token when building web assets
anlambert updated the diff for D8233: jobs/swh-pypi-groovy: Use Sentry auth token when building web assets.
Rebase
anlambert committed rCJSWH7b19d5bea208: docker: Mount and clone local swh-jenkins-jobs repo for conf testing (authored by anlambert).
docker: Mount and clone local swh-jenkins-jobs repo for conf testing
anlambert added a comment to D8233: jobs/swh-pypi-groovy: Use Sentry auth token when building web assets.
In D8233#214151, @olasd wrote:Is there a way to use a "service" token rather than one tied to an individual account?
anlambert committed rDWAPPSefa99f8e2ae5: webpack: Use sentry plugin in production mode to upload source maps (authored by anlambert).
webpack: Use sentry plugin in production mode to upload source maps
Aug 10 2022
Aug 10 2022
anlambert requested review of D8234: docker: Mount and clone local swh-jenkins-jobs repo for conf testing.
anlambert requested review of D8233: jobs/swh-pypi-groovy: Use Sentry auth token when building web assets.
Abandoning this as it is not needed after all.
anlambert requested review of D8232: webpack: Use sentry plugin in production mode to upload source maps.
anlambert committed rDWAPPSc874b7d13617: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Looks good to me.
anlambert added a comment to D8230: Add-forge-now: Change word-wrapping of email template to 72 columns.
I would prefer to wrap the text to 72 columns then.
Aug 9 2022
Aug 9 2022
anlambert requested review of D8227: api/RPCClient: Do not raise 404 remote exception if it must be reraised.
I have the following flake8 errors when running tox, those must be fixed as it will break the CI otherwise. Some errors need to be fixed in D8225 too.
(swh) ✔ ~/swh/swh-environment/docker [arcpatch-D8226 L|⚑ 70] 17:12 $ tox flake8 installed: flake8==5.0.4,mccabe==0.7.0,pycodestyle==2.9.1,pyflakes==2.5.0 flake8 run-test-pre: PYTHONHASHSEED='1236590620' flake8 run-test: commands[0] | /home/anlambert/swh/swh-environment/docker/.tox/flake8/bin/python -m flake8 tests tests/conftest.py:41:1: E302 expected 2 blank lines, found 1 tests/conftest.py:45:1: E302 expected 2 blank lines, found 1 tests/conftest.py:63:89: E501 line too long (107 > 88 characters) tests/test_vault.py:95:20: E226 missing whitespace around arithmetic operator tests/test_vault.py:129:89: E501 line too long (93 > 88 characters) tests/test_vault.py:133:5: E303 too many blank lines (3) ERROR: InvocationError for command /home/anlambert/swh/swh-environment/docker/.tox/flake8/bin/python -m flake8 tests (exited with code 1)
anlambert committed rDENV0294ffb27900: docker/tests: Remove shell based tests (authored by anlambert).
docker/tests: Remove shell based tests
docker/tests/conftest.py: Fix typo
anlambert committed rDENVd16f3fbb6c80: docker/test_git_loader: Use dulwich instead of git and add extra checks (authored by anlambert).
docker/test_git_loader: Use dulwich instead of git and add extra checks
anlambert committed rDENVbe4db8d3085d: pre-commit: Fix mypy execution for swh-environment (authored by anlambert).
pre-commit: Fix mypy execution for swh-environment
anlambert requested review of D8222: docker: Remove shell based tests and add extra checks to git loader test.
anlambert committed rDLScee6bcb514ec: maven: Use BeautifulSoup instead of xmltodict for parsing pom files (authored by anlambert).
maven: Use BeautifulSoup instead of xmltodict for parsing pom files
Nice code cleaning !
anlambert updated the diff for D8217: maven: Use BeautifulSoup instead of xmltodict for parsing pom files.
Rebase
Looks good to me.
anlambert updated the diff for D8217: maven: Use BeautifulSoup instead of xmltodict for parsing pom files.
Catch proper exception for lxml parsing error.
Aug 8 2022
Aug 8 2022
Looks good to me, too bad we cannot use sentry scopes due to this limitation.
anlambert requested review of D8217: maven: Use BeautifulSoup instead of xmltodict for parsing pom files.
Should help for debugging indeed, looks good to me.
Looks good to me.
kafka service healthcheck needs to be updated before landing this.
Looks good to me but docstring should be updated.
Jul 21 2022
Jul 21 2022
anlambert committed rDWAPPS6f223dcb669f: templates: Fix add forge now and mailmap menu items highlighting (authored by anlambert).
templates: Fix add forge now and mailmap menu items highlighting
anlambert requested review of D8154: templates: Fix add forge now and mailmap menu items highlighting.
anlambert committed rDWAPPSd641520621dc: templates/layout: Prevent flashing of collapsed sidebar on page load (authored by anlambert).
templates/layout: Prevent flashing of collapsed sidebar on page load
anlambert requested review of D8153: templates/layout: Prevent flashing of collapsed sidebar on page load.
Jul 20 2022
Jul 20 2022
anlambert committed rDWAPPS722cf1e41fc9: Makefile.local: Do not filter out error output when running migrations (authored by anlambert).
Makefile.local: Do not filter out error output when running migrations
anlambert committed rDWAPPS1ca2c7cb68dc: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert committed rDWAPPS0901c69559fa: settings/common: Silence urllib3 debug logging (authored by anlambert).
settings/common: Silence urllib3 debug logging
Fix typo
Looks good to me, apart the renaming of some refs.
Jul 19 2022
Jul 19 2022
anlambert updated the task description for T4398: Create one django application for each webapp feature.
Looks good to me, I am wondering if you should not add a field alias to avoid reindexing but still allow search in intrinsic metadata already stored in elasticsearch ?
Jul 18 2022
Jul 18 2022
anlambert accepted D8129: Prevent 'version' field (and others) from being dynamically infered as double.
Looks good to me !
Jul 15 2022
Jul 15 2022
anlambert committed rDAUTH6c85751c2be0: keycloak: Fix issue in authorization_url since python-keycloak 1.8.1 (authored by anlambert).
keycloak: Fix issue in authorization_url since python-keycloak 1.8.1
anlambert updated the diff for D8125: keycloak: Fix issue in authorization_url since python-keycloak 1.8.1.
Simplify code.
anlambert added inline comments to D8125: keycloak: Fix issue in authorization_url since python-keycloak 1.8.1.
anlambert requested review of D8125: keycloak: Fix issue in authorization_url since python-keycloak 1.8.1.
anlambert committed rPJOS667d2325c8c2: pristine-tar data for python-jose_3.3.0.orig.tar.gz (authored by anlambert).
pristine-tar data for python-jose_3.3.0.orig.tar.gz
anlambert committed rPJOS3ee85095a856: Update upstream source from tag 'debian/upstream/3.3.0' (authored by anlambert).
Update upstream source from tag 'debian/upstream/3.3.0'
debian: Update changelog
New upstream version 3.3.0
Jul 13 2022
Jul 13 2022
anlambert committed rDWAPPSe619d58ee329: common/query: Remove dead uuid parsing code (authored by anlambert).
common/query: Remove dead uuid parsing code
anlambert committed rDSTOfbe3803820a5: postgresql: Increase some timeouts to get origin visits (authored by anlambert).
postgresql: Increase some timeouts to get origin visits
anlambert accepted D8119: Add API endpoint to get the list of metadata authorities on an origin from its URL.
Looks good to me.
Jul 12 2022
Jul 12 2022
anlambert committed rDWAPPS6f9d36afe484: Improve hiring banner embedding for django website (authored by anlambert).
Improve hiring banner embedding for django website
anlambert committed rDWAPPS36f971347d5b: mypy: Turn old type comments into pure type annotations (authored by anlambert).
mypy: Turn old type comments into pure type annotations
Looks good to me.
anlambert added inline comments to D8114: Add support for querying raw-extrinsic-metadata for origins.
Add support for Django 4.x
django: Add support for Django 4.x