Page MenuHomeSoftware Heritage
Feed Advanced Search

Yesterday

anlambert closed D6698: ra: Persist path executable flag in FileState when replaying revisions.
Fri, Nov 26, 5:14 PM
anlambert committed rDLDSVN4bae0f9315d8: ra: Persist path executable flag in FileState when replaying revisions (authored by anlambert).
ra: Persist path executable flag in FileState when replaying revisions
Fri, Nov 26, 5:14 PM
anlambert requested review of D6698: ra: Persist path executable flag in FileState when replaying revisions.
Fri, Nov 26, 5:10 PM
anlambert added a revision to T3695: Investigate revision reconstruction discrepancy with subversion export: D6698: ra: Persist path executable flag in FileState when replaying revisions.
Fri, Nov 26, 5:08 PM · SVN Loader
anlambert accepted D6694: Fix for snapshot content redirection.
Fri, Nov 26, 3:10 PM
anlambert added a comment to D6691: common/archive: Add lookup_origin_snapshots function.

Where is it called from?

Fri, Nov 26, 1:37 PM

Thu, Nov 25

anlambert requested review of D6691: common/archive: Add lookup_origin_snapshots function.
Thu, Nov 25, 4:19 PM
anlambert added a revision to T3631: Make snapshot query parameter mandatory when browsing objects in an origin context: D6691: common/archive: Add lookup_origin_snapshots function.
Thu, Nov 25, 4:01 PM · Web app
anlambert closed D6690: svn: Use a temporary directory when checking if history got altered.
Thu, Nov 25, 3:22 PM
anlambert committed rDLDSVNed3c0c986bfb: svn: Use a temporary directory when checking if history got altered (authored by anlambert).
svn: Use a temporary directory when checking if history got altered
Thu, Nov 25, 3:22 PM
anlambert updated the diff for D6690: svn: Use a temporary directory when checking if history got altered.

Update: Address @ardumont comments

Thu, Nov 25, 3:19 PM
anlambert added inline comments to D6690: svn: Use a temporary directory when checking if history got altered.
Thu, Nov 25, 3:17 PM
anlambert requested review of D6690: svn: Use a temporary directory when checking if history got altered.
Thu, Nov 25, 2:35 PM
anlambert added a revision to T3747: svn: FileExistsError when creating directory: D6690: svn: Use a temporary directory when checking if history got altered.
Thu, Nov 25, 2:33 PM · SVN Loader
anlambert closed D6688: test_serializers: Fix failing test since msgpack-python 1.0.3 release.
Thu, Nov 25, 11:12 AM
anlambert committed rDCORE51fd3073f938: test_serializers: Fix failing test since msgpack-python 1.0.3 release (authored by anlambert).
test_serializers: Fix failing test since msgpack-python 1.0.3 release
Thu, Nov 25, 11:12 AM
anlambert updated the diff for D6688: test_serializers: Fix failing test since msgpack-python 1.0.3 release.

Remove debian folder added by mistake

Thu, Nov 25, 11:05 AM
anlambert requested review of D6688: test_serializers: Fix failing test since msgpack-python 1.0.3 release.
Thu, Nov 25, 11:04 AM

Wed, Nov 24

anlambert closed D6681: misc/iframe: Fix archive link when there is no snapshot context.
Wed, Nov 24, 3:35 PM
anlambert committed rDWAPPS20a9d1855929: misc/iframe: Fix archive link when there is no snapshot context (authored by anlambert).
misc/iframe: Fix archive link when there is no snapshot context
Wed, Nov 24, 3:35 PM
anlambert requested changes to D6640: Add a button to the deposit admin UI to show deposit metadata.

Looks good but some cosmetic improvements can be added, notably:

  • use a dedicated column in the table to display the "Show metadata" button
  • highlight metadata xml code
  • restrain the height of of the popover dialog to avoid overflow when metadata file is large
Wed, Nov 24, 2:55 PM
anlambert requested review of D6681: misc/iframe: Fix archive link when there is no snapshot context.
Wed, Nov 24, 12:17 PM

Tue, Nov 23

anlambert committed rDWAPPS2a646e0e19fe: assets/guided_tour: Improve some sentences based on tester feedbacks (authored by anlambert).
assets/guided_tour: Improve some sentences based on tester feedbacks
Tue, Nov 23, 3:53 PM

Fri, Nov 19

anlambert closed D6662: loader: Apply SvnLoaderFromRemoteDump optimization only for stale repos.
Fri, Nov 19, 12:00 PM
anlambert closed D6661: svn: Ensure proper incremental loading of a repository.
Fri, Nov 19, 12:00 PM
anlambert committed rDLDSVNed0728c8b02e: svn: Ensure proper incremental loading of a repository (authored by anlambert).
svn: Ensure proper incremental loading of a repository
Fri, Nov 19, 12:00 PM
anlambert committed rDLDSVN0e725edbc31a: loader: Apply SvnLoaderFromRemoteDump optimization only for stale repos (authored by anlambert).
loader: Apply SvnLoaderFromRemoteDump optimization only for stale repos
Fri, Nov 19, 12:00 PM
anlambert closed D6660: loader: Ensure to reload from first revision when history got altered.
Fri, Nov 19, 12:00 PM
anlambert committed rDLDSVNc9aaa314df27: loader: Ensure to reload from first revision when history got altered (authored by anlambert).
loader: Ensure to reload from first revision when history got altered
Fri, Nov 19, 12:00 PM
anlambert requested review of D6662: loader: Apply SvnLoaderFromRemoteDump optimization only for stale repos.
Fri, Nov 19, 10:55 AM
anlambert requested review of D6661: svn: Ensure proper incremental loading of a repository.
Fri, Nov 19, 10:54 AM
anlambert requested review of D6660: loader: Ensure to reload from first revision when history got altered.
Fri, Nov 19, 10:53 AM

Thu, Nov 18

anlambert closed D6658: loader: Optimize SvnLoaderFromRemoteDump use on stale repository.
Thu, Nov 18, 7:03 PM
anlambert committed rDLDSVN0237d07b1747: loader: Optimize SvnLoaderFromRemoteDump use on stale repository (authored by anlambert).
loader: Optimize SvnLoaderFromRemoteDump use on stale repository
Thu, Nov 18, 7:03 PM
anlambert updated the diff for D6658: loader: Optimize SvnLoaderFromRemoteDump use on stale repository.

Update: Skip redundant post_load check when revisions are identified as identical in prepare

Thu, Nov 18, 6:52 PM
anlambert requested review of D6658: loader: Optimize SvnLoaderFromRemoteDump use on stale repository.
Thu, Nov 18, 5:31 PM
anlambert added a revision to T3719: loader svn fails to clean up properly disk when it crashes: D6658: loader: Optimize SvnLoaderFromRemoteDump use on stale repository.
Thu, Nov 18, 5:29 PM · SVN Loader
anlambert created P1219 SvnLoaderFromRemoteDump optimization.
Thu, Nov 18, 4:54 PM
anlambert accepted D6647: changelog: Reference the opam coq repository ingestion.
Thu, Nov 18, 3:08 PM
anlambert closed T3737: documentation sidebar: group swh.* module doc under a "API reference" heading as Resolved by committing rDDOC23b479e750d7: docs/index: Group swh.* entries under a top level "API reference" entry.
Thu, Nov 18, 2:16 PM · Documentation
anlambert closed D6656: docs/index: Group swh.* entries under a top level "API reference" entry.
Thu, Nov 18, 2:16 PM
anlambert committed rDDOC23b479e750d7: docs/index: Group swh.* entries under a top level "API reference" entry (authored by anlambert).
docs/index: Group swh.* entries under a top level "API reference" entry
Thu, Nov 18, 2:16 PM
anlambert requested review of D6656: docs/index: Group swh.* entries under a top level "API reference" entry.
Thu, Nov 18, 2:05 PM
anlambert added a revision to T3737: documentation sidebar: group swh.* module doc under a "API reference" heading: D6656: docs/index: Group swh.* entries under a top level "API reference" entry.
Thu, Nov 18, 1:54 PM · Documentation
anlambert closed D6654: ra: Prevent erroneous removing of file state.
Thu, Nov 18, 12:40 PM
anlambert committed rDLDSVN631a2b9d7f7e: ra: Prevent erroneous removing of file state (authored by anlambert).
ra: Prevent erroneous removing of file state
Thu, Nov 18, 12:40 PM
anlambert requested review of D6654: ra: Prevent erroneous removing of file state.
Thu, Nov 18, 12:00 PM
anlambert closed T3736: Add `,` separator in numbers on the archive's home as Resolved by committing rDWAPPS8722d9aa4d6d: misc/coverage: Fix some origin counts formatting.
Thu, Nov 18, 11:05 AM · Web app
anlambert committed rDWAPPS8722d9aa4d6d: misc/coverage: Fix some origin counts formatting (authored by anlambert).
misc/coverage: Fix some origin counts formatting
Thu, Nov 18, 11:05 AM
anlambert closed T3735: Add "you" in the Vault browsing page as Resolved by committing rDWAPPSadc197792243: templates/vault-ui: Fix introduction sentence.
Thu, Nov 18, 11:05 AM · Web app, Easy hack
anlambert committed rDWAPPSadc197792243: templates/vault-ui: Fix introduction sentence (authored by anlambert).
templates/vault-ui: Fix introduction sentence
Thu, Nov 18, 11:05 AM
anlambert closed D6649: pytest_plugin: Increase poll timeout in consume_messages.
Thu, Nov 18, 10:32 AM
anlambert committed rDJNLbac6b474b229: pytest_plugin: Increase poll timeout in consume_messages (authored by anlambert).
pytest_plugin: Increase poll timeout in consume_messages
Thu, Nov 18, 10:32 AM
anlambert closed T3724: Browsing snapshot with only releases does not show anything in the webapp as Resolved.

Fix is now deployed to production, closing this.

Thu, Nov 18, 10:31 AM · Web app
anlambert updated the diff for D6649: pytest_plugin: Increase poll timeout in consume_messages.

Rebase

Thu, Nov 18, 10:28 AM

Wed, Nov 17

anlambert requested review of D6649: pytest_plugin: Increase poll timeout in consume_messages.
Wed, Nov 17, 4:40 PM
anlambert closed D6648: loader: Create temp folder with pattern in SvnLoaderFromRemoteDump.
Wed, Nov 17, 3:04 PM
anlambert committed rDLDSVNfdf526eceaea: loader: Create temp folder with pattern in SvnLoaderFromRemoteDump (authored by anlambert).
loader: Create temp folder with pattern in SvnLoaderFromRemoteDump
Wed, Nov 17, 3:04 PM
anlambert updated the diff for D6648: loader: Create temp folder with pattern in SvnLoaderFromRemoteDump.

Update: Wrap temporary folder creation in a private method

Wed, Nov 17, 2:58 PM
anlambert added inline comments to D6648: loader: Create temp folder with pattern in SvnLoaderFromRemoteDump.
Wed, Nov 17, 2:40 PM
anlambert accepted D6615: Deprecate /origin/content route.

Bye bye duplicated code related to browsing contents, thanks a lot for that !

Wed, Nov 17, 2:38 PM
anlambert requested review of D6648: loader: Create temp folder with pattern in SvnLoaderFromRemoteDump.
Wed, Nov 17, 2:33 PM
anlambert added a revision to T3719: loader svn fails to clean up properly disk when it crashes: D6648: loader: Create temp folder with pattern in SvnLoaderFromRemoteDump.
Wed, Nov 17, 2:32 PM · SVN Loader
anlambert added inline comments to D6615: Deprecate /origin/content route.
Wed, Nov 17, 2:19 PM
anlambert requested changes to D6615: Deprecate /origin/content route.

Overall looks good to me ! I added a couple of nitpick comments to handle before landing this.

Wed, Nov 17, 12:09 PM
anlambert accepted D6636: Add types to the svn module.

Cool, thanks !

Wed, Nov 17, 10:57 AM

Tue, Nov 16

anlambert closed D6641: browse/snapshot_context: Handle snapshot containing only releases.

Forgot to rebase, closed by rDWAPPScd747fd0e79be6e2cfe941c25479f4c2b30bd6bb.

Tue, Nov 16, 7:26 PM
anlambert committed rDWAPPScd747fd0e79b: browse/snapshot_context: Handle snapshots containing only releases (authored by anlambert).
browse/snapshot_context: Handle snapshots containing only releases
Tue, Nov 16, 7:24 PM
anlambert committed rDWAPPS9c874cd715bc: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Tue, Nov 16, 7:24 PM
anlambert added inline comments to D6641: browse/snapshot_context: Handle snapshot containing only releases.
Tue, Nov 16, 4:25 PM
anlambert added inline comments to D6641: browse/snapshot_context: Handle snapshot containing only releases.
Tue, Nov 16, 3:25 PM
anlambert accepted D6646: vault-ui: Show progress details when hovering the progress bar.
Tue, Nov 16, 2:58 PM
anlambert accepted D6642: git_bare: Send progress updates while cooking.

Looks good to me.

Tue, Nov 16, 2:57 PM
anlambert updated the summary of D6641: browse/snapshot_context: Handle snapshot containing only releases.
Tue, Nov 16, 2:46 PM
anlambert updated the diff for D6641: browse/snapshot_context: Handle snapshot containing only releases.

Update:

  • handle @vlorentz comments
  • ensure all get_snapshot_context code is covered by tests
Tue, Nov 16, 2:46 PM
anlambert accepted D6643: webpack: Remove .tox and .mypy from the files to watch.

Great, thanks !

Tue, Nov 16, 2:42 PM
anlambert added inline comments to D6641: browse/snapshot_context: Handle snapshot containing only releases.
Tue, Nov 16, 1:23 PM
anlambert requested review of D6641: browse/snapshot_context: Handle snapshot containing only releases.
Tue, Nov 16, 11:56 AM
anlambert added a revision to T3724: Browsing snapshot with only releases does not show anything in the webapp: D6641: browse/snapshot_context: Handle snapshot containing only releases.
Tue, Nov 16, 11:42 AM · Web app
anlambert added a comment to D6640: Add a button to the deposit admin UI to show deposit metadata.

@anlambert Can you take this diff from here?

Tue, Nov 16, 11:36 AM

Mon, Nov 15

anlambert changed the status of T3724: Browsing snapshot with only releases does not show anything in the webapp from Open to Work in Progress.
Mon, Nov 15, 4:13 PM · Web app
anlambert added inline comments to D6620: ra: Remove global variables..
Mon, Nov 15, 3:15 PM
anlambert accepted D6620: ra: Remove global variables..

Looks good to me, better indeed.

Mon, Nov 15, 1:45 PM
anlambert accepted D6639: Add missing URL escape.
Mon, Nov 15, 1:11 PM
anlambert added a comment to T3695: Investigate revision reconstruction discrepancy with subversion export.

Since D6608 got landed and deployed to production, revision reconstruction discrepancy is detected earlier and there is already a couple reported on sentry,
so keeping this opened.

Mon, Nov 15, 10:55 AM · SVN Loader
anlambert added a comment to T3728: Display snapshots with only releases (or a release as HEAD branch).

Duplicate of T3724 I think

Mon, Nov 15, 10:34 AM · Web app, Data Model
anlambert committed rDWAPPSfe8c3b38bb64: assets/xss-filtering: Ensure to use correct directory (authored by anlambert).
assets/xss-filtering: Ensure to use correct directory
Mon, Nov 15, 10:29 AM
anlambert committed rDWAPPSe0f33695c7b3: assets/xss-filtering: Strip any query parameters from img src attribute (authored by anlambert).
assets/xss-filtering: Strip any query parameters from img src attribute
Mon, Nov 15, 10:29 AM
anlambert closed D6614: assets/xss-filtering: Strip any query parameters from img src attribute.
Mon, Nov 15, 10:29 AM
anlambert claimed T3724: Browsing snapshot with only releases does not show anything in the webapp.
Mon, Nov 15, 10:19 AM · Web app

Mon, Nov 8

anlambert closed D6611: loader: Perform a complete reloading when detecting altered history.
Mon, Nov 8, 2:14 PM
anlambert committed rDLDSVN057e00bf93dc: loader: Perform a complete reloading when detecting altered history (authored by anlambert).
loader: Perform a complete reloading when detecting altered history
Mon, Nov 8, 2:14 PM

Fri, Nov 5

anlambert updated the diff for D6614: assets/xss-filtering: Strip any query parameters from img src attribute.

Update license header

Fri, Nov 5, 1:53 PM
anlambert updated the diff for D6614: assets/xss-filtering: Strip any query parameters from img src attribute.

Update: Ensure to pass a valid url to URL constructor and encode path query parameter value

Fri, Nov 5, 1:51 PM
anlambert added a comment to D6614: assets/xss-filtering: Strip any query parameters from img src attribute.

Then when doing this:

directoryUrl += `?path=${path}`;

directoryUrl will end with ?path=/path&/foo and that's not good

Fri, Nov 5, 1:45 PM
anlambert added a comment to D6614: assets/xss-filtering: Strip any query parameters from img src attribute.

What if there is a & character in the path?

Not an issue, URL object will correctly parse it as part of the path.

>>> s = "http://example.org/path&/foo?service=swh&query=bar"
"http://example.org/path&/foo?service=swh&query=bar"
>>> new URL(s)
URL { href: "http://example.org/path&/foo?service=swh&query=bar", origin: "http://example.org", protocol: "http:", username: "", password: "", host: "example.org", hostname: "example.org", port: "", pathname: "/path&/foo", search: "?service=swh&query=bar" }
Fri, Nov 5, 1:11 PM
anlambert requested review of D6614: assets/xss-filtering: Strip any query parameters from img src attribute.
Fri, Nov 5, 12:26 PM
anlambert accepted D6612: tests: Hide utilities from stack traces.

Cool, nice pytest trick to know !

Fri, Nov 5, 11:22 AM
anlambert accepted D6613: tests: Remove duplicate checks.
Fri, Nov 5, 11:20 AM

Thu, Nov 4

anlambert accepted D6609: Missing tests for origin legacy routes.

Looks good to me.

Thu, Nov 4, 5:16 PM