Page MenuHomeSoftware Heritage
Feed Advanced Search

Wed, May 27

anlambert closed T2424: recaptcha javascript is loaded on every page as Resolved by committing Restricted Diffusion Commit.
Wed, May 27, 6:42 PM · Website
anlambert added a comment to T2424: recaptcha javascript is loaded on every page.

Fixed and deployed.

Wed, May 27, 6:42 PM · Website
anlambert added a comment to T2424: recaptcha javascript is loaded on every page.

Ok, found a way by executing this in functions.php from our custom WP theme.

Wed, May 27, 6:35 PM · Website
anlambert added a comment to T2424: recaptcha javascript is loaded on every page.

This seems to be the standard behavior when the Contact form plugin is used on a WP site.

Wed, May 27, 5:55 PM · Website
anlambert added a comment to T2420: website: Twitter icon missing in footer (missing font?).

Fixed and deployed.

Wed, May 27, 5:33 PM · Website
anlambert added a comment to T2420: website: Twitter icon missing in footer (missing font?).

I needed a break in my move preparations so I looked at the issue.

Wed, May 27, 5:23 PM · Website

Sun, May 24

anlambert added a comment to T2417: Wrong swh:rev anchor in SWHID computed for contents/directories in Permalink box.

Nice catch ! Hopefully the fix is easy.

Sun, May 24, 4:26 PM · Web app

Fri, May 15

anlambert added a revision to T2408: Repeated filename in path qualifier for SWHIDs: D3157: identifiers: Add resolving of new SWHID contextual information.
Fri, May 15, 4:55 PM · Web app
anlambert added a revision to T2342: Add resolving of new SWHIDs contextual information: D3157: identifiers: Add resolving of new SWHID contextual information.
Fri, May 15, 4:55 PM · Web app
anlambert created D3157: identifiers: Add resolving of new SWHID contextual information.
Fri, May 15, 4:55 PM
anlambert updated the diff for D3156: browse: Add snapshot related query parameters in numerous object views.

Update commit id for incoming stacked diff

Fri, May 15, 4:54 PM
anlambert added a revision to T2359: Add snapshot id query parameter in numerous browse views: D3156: browse: Add snapshot related query parameters in numerous object views.
Fri, May 15, 4:51 PM · Web app
anlambert added a revision to T2342: Add resolving of new SWHIDs contextual information: D3156: browse: Add snapshot related query parameters in numerous object views.
Fri, May 15, 4:51 PM · Web app
anlambert created D3156: browse: Add snapshot related query parameters in numerous object views.
Fri, May 15, 4:51 PM

Thu, May 14

anlambert added a comment to T2408: Repeated filename in path qualifier for SWHIDs.

I also spotted the issue while implementing and testing the resolver. This will be fixed soon.

Thu, May 14, 4:10 PM · Web app
anlambert added inline comments to D3152: Tag model entities with their "type".
Thu, May 14, 11:31 AM

Wed, May 13

anlambert added a comment to D3152: Tag model entities with their "type".

I like the idea too (except the naming, should be object_type instead of tag).

Wed, May 13, 7:25 PM
anlambert accepted D3141: Update swhid according to latest specification.

Looks good to me.

Wed, May 13, 11:57 AM · Data Model, SWORD deposit

Tue, May 12

anlambert added a comment to D3145: Fix pep8 violations.

Thanks for the fixes. TIL that I should run pre-commit autoupdate on a regular basis.

(swh) ✔ ~/swh/swh-environment/swh-web [master ↓·1|⚑ 178] 
19:07 $ pre-commit autoupdate
Updating https://github.com/pre-commit/pre-commit-hooks...[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
updating v2.4.0 -> v2.5.0.
Updating https://github.com/codespell-project/codespell...already up to date.
Updating https://github.com/python/black...already up to date.
(swh) ✔ ~/swh/swh-environment/swh-web [master ↓·1|✚ 1⚑ 178] 
19:07 $ make check
pre-commit run --all-files
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Trim Trailing Whitespace.................................................Passed
Flake8 (deprecated, use gitlab.com/pycqa/flake8).........................Failed
hookid: flake8
Tue, May 12, 7:11 PM
anlambert renamed T2342: Add resolving of new SWHIDs contextual information from Add resolving of new PIDs contextual information to Add resolving of new SWHIDs contextual information.
Tue, May 12, 4:06 PM · Web app

Thu, May 7

anlambert added a comment to T2395: Save code now fails on a svn project.

After retrying to load the repository manually, the real cause of the dump that failed to mount is the following:

svnadmin: E125005: Valeur d'une propriété invalide dans le flot de sauvegarde ; envisager de corriger la source ou utiliser l'option --bypass-prop-validation au chargement.
svnadmin: E125005: Propriété 'svn:log' refusée car non codée en UTF-8

Passing the --bypass-prop-validation option effectively fixes the loading issue.
I think we should use it as we already handle properties decoding errors in the loader implementation.

Thu, May 7, 7:26 PM · SVN Loader
anlambert created D3136: loader: Fix SvnRepo parameters ordering.
Thu, May 7, 7:20 PM
anlambert committed rDWAPPS23f07024a291: templates/show-swh-ids: Add display of new SWHID contextual information (authored by anlambert).
templates/show-swh-ids: Add display of new SWHID contextual information
Thu, May 7, 6:08 PM
anlambert closed T2330: Simplify Permalinks box as Resolved by committing rDWAPPS23f07024a291: templates/show-swh-ids: Add display of new SWHID contextual information.
Thu, May 7, 6:08 PM · 2019 UX improvements, Web app
anlambert closed T2330: Simplify Permalinks box, a subtask of T2192: UX improvements, as Resolved.
Thu, May 7, 6:08 PM · Web app, Restricted Project
anlambert closed D3135: templates/show-swh-ids: Add display of new SWHID contextual information.
Thu, May 7, 6:08 PM
anlambert updated the diff for D3135: templates/show-swh-ids: Add display of new SWHID contextual information.

Update: Fix release anchors and add test

Thu, May 7, 5:23 PM
anlambert added a revision to T2330: Simplify Permalinks box: D3135: templates/show-swh-ids: Add display of new SWHID contextual information.
Thu, May 7, 4:12 PM · 2019 UX improvements, Web app
anlambert created D3135: templates/show-swh-ids: Add display of new SWHID contextual information.
Thu, May 7, 4:12 PM
anlambert committed rDWAPPS6d00ef0a2829: common/identifiers: Add SWHIDs contextual information computation (authored by anlambert).
common/identifiers: Add SWHIDs contextual information computation
Thu, May 7, 1:20 PM
anlambert closed D3129: common/identifiers: Add SWHIDs contextual information computation.
Thu, May 7, 1:20 PM
anlambert updated the diff for D3129: common/identifiers: Add SWHIDs contextual information computation.

Rebase

Thu, May 7, 12:47 PM
anlambert committed rDWAPPS486255fea19d: assets/save: Fix browsing URLs for successful save requests (authored by anlambert).
assets/save: Fix browsing URLs for successful save requests
Thu, May 7, 12:46 PM
anlambert closed D3132: assets/save: Fix browsing URLs for successful save requests.
Thu, May 7, 12:46 PM
anlambert created D3132: assets/save: Fix browsing URLs for successful save requests.
Thu, May 7, 11:52 AM

Wed, May 6

anlambert updated the diff for D3129: common/identifiers: Add SWHIDs contextual information computation.

Update: Perform some renaming

Wed, May 6, 7:00 PM
anlambert added inline comments to D3129: common/identifiers: Add SWHIDs contextual information computation.
Wed, May 6, 6:29 PM
anlambert accepted D3130: Refactor the pytest_plugin.

Looks good to me. Just one nitpick, there is some typos in commit messages:

  • instanciation -> instantiation
  • instanciating -> instantiating
Wed, May 6, 5:50 PM
anlambert added inline comments to D3129: common/identifiers: Add SWHIDs contextual information computation.
Wed, May 6, 5:30 PM
anlambert added inline comments to D3129: common/identifiers: Add SWHIDs contextual information computation.
Wed, May 6, 5:28 PM
anlambert added a revision to T1241: Persistent identifiers (PIDs): add a way to describe Merkle DAG paths: D3129: common/identifiers: Add SWHIDs contextual information computation.
Wed, May 6, 4:09 PM · 2019 UX improvements, Web app, General
anlambert added a revision to T2330: Simplify Permalinks box: D3129: common/identifiers: Add SWHIDs contextual information computation.
Wed, May 6, 4:09 PM · 2019 UX improvements, Web app
anlambert created D3129: common/identifiers: Add SWHIDs contextual information computation.
Wed, May 6, 4:09 PM

Tue, May 5

anlambert committed rDWAPPSec0171d93948: HTMLMinifiyMiddleware: Deactivate convert_charrefs of htmlmin.minify (authored by anlambert).
HTMLMinifiyMiddleware: Deactivate convert_charrefs of htmlmin.minify
Tue, May 5, 7:20 PM
anlambert committed rDWAPPSc20d4abae8c4: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Tue, May 5, 7:20 PM
anlambert committed rDWAPPSaffd506bc632: api/vault: Fix 404 handling and improve error messages (authored by anlambert).
api/vault: Fix 404 handling and improve error messages
Tue, May 5, 7:20 PM
anlambert closed D3125: api/vault: Fix 404 handling and improve error messages.
Tue, May 5, 7:20 PM
anlambert closed T2388: Can't create cooking requests in swh-web as Resolved by committing rDWAPPSaffd506bc632: api/vault: Fix 404 handling and improve error messages.
Tue, May 5, 7:20 PM · Vault, Web app
anlambert added a comment to D3125: api/vault: Fix 404 handling and improve error messages.

(some copyright date range headers are off but besides that, cool)

Tue, May 5, 6:09 PM
anlambert updated the diff for D3125: api/vault: Fix 404 handling and improve error messages.

Bump swh.vault in requirements-swh.txt and update years in license headers.

Tue, May 5, 6:08 PM
anlambert updated the diff for D3125: api/vault: Fix 404 handling and improve error messages.

Update: Synchronize with latest changes in swh-vault

Tue, May 5, 6:02 PM
anlambert added inline comments to D3127: Raise NotFoundExc within our RPC framework instead of returning 404..
Tue, May 5, 6:01 PM
anlambert added a comment to D3127: Raise NotFoundExc within our RPC framework instead of returning 404..

We should tag a new vault release once it is landed. I will update D3125 and do the same for swh-web to fix the error in production.

Tue, May 5, 5:50 PM
anlambert accepted D3127: Raise NotFoundExc within our RPC framework instead of returning 404..

Cool, thanks !

Tue, May 5, 5:49 PM
anlambert added a comment to D3125: api/vault: Fix 404 handling and improve error messages.

I don't know why swh-web stopped working, then.

Tue, May 5, 5:08 PM
anlambert added a comment to D3125: api/vault: Fix 404 handling and improve error messages.

I think I can improve on this, let me check if it works

Tue, May 5, 4:40 PM
anlambert added a comment to D3125: api/vault: Fix 404 handling and improve error messages.

er wait, I thought you said you would fix swh-vault??

Tue, May 5, 4:37 PM
anlambert added a revision to T2388: Can't create cooking requests in swh-web: D3125: api/vault: Fix 404 handling and improve error messages.
Tue, May 5, 4:12 PM · Vault, Web app
anlambert created D3125: api/vault: Fix 404 handling and improve error messages.
Tue, May 5, 4:12 PM
anlambert added a comment to T2388: Can't create cooking requests in swh-web.

indeed, I forgot to adapt the vault after a refactoring of swh-core. I'll fix it

Tue, May 5, 3:23 PM · Vault, Web app
anlambert added a comment to T2388: Can't create cooking requests in swh-web.

I think the simple way to fix this is to catch the RemoteException for 404 in the api_lookup function to restore previous behavior.

Tue, May 5, 3:10 PM · Vault, Web app
anlambert added a comment to T2388: Can't create cooking requests in swh-web.

Ok I see what is wrong here. Based on the obtained traceback, this is due to changes in how 404 errors are handled server side:

Traceback (most recent call last):
  File "/home/antoine/swh/swh-environment/swh-web/swh/web/api/apidoc.py", line 358, in documented_view
    response = f(request, **kwargs)
  File "/home/antoine/swh/swh-environment/swh-web/swh/web/api/views/vault.py", line 100, in api_vault_cook_directory
    res = _dispatch_cook_progress(request, "directory", obj_id)
  File "/home/antoine/swh/swh-environment/swh-web/swh/web/api/views/vault.py", line 28, in _dispatch_cook_progress
    request=request,
  File "/home/antoine/swh/swh-environment/swh-web/swh/web/api/views/utils.py", line 67, in api_lookup
    res = lookup_fn(*args)
  File "/home/antoine/swh/swh-environment/swh-web/swh/web/common/service.py", line 1112, in vault_progress
    raise e
  File "/home/antoine/swh/swh-environment/swh-web/swh/web/common/service.py", line 1109, in vault_progress
    return vault.progress(obj_type, obj_id)
  File "/home/antoine/swh/swh-environment/swh-vault/swh/vault/api/client.py", line 29, in progress
    return self.get("progress/{}/{}".format(obj_type, hex_id))
  File "/home/antoine/swh/swh-environment/swh-core/swh/core/api/__init__.py", line 294, in get
    return self._decode_response(response)
  File "/home/antoine/swh/swh-environment/swh-core/swh/core/api/__init__.py", line 352, in _decode_response
    self.raise_for_status(response)
  File "/home/antoine/swh/swh-environment/swh-core/swh/core/api/__init__.py", line 308, in raise_for_status
    raise RemoteException(payload="404 not found", response=response)
swh.core.api.RemoteException: 404 not found
Tue, May 5, 3:01 PM · Vault, Web app

Mon, May 4

anlambert committed rDWAPPS97c8291f0bb3: templates/content-display: Fix view when an image cannot be rendered (authored by anlambert).
templates/content-display: Fix view when an image cannot be rendered
Mon, May 4, 6:25 PM
anlambert closed T2389: "Error 200" when browsing a .psd file as Resolved by committing rDWAPPS97c8291f0bb3: templates/content-display: Fix view when an image cannot be rendered.
Mon, May 4, 6:25 PM · Web app
anlambert closed D3118: templates/content-display: Fix view when an image cannot be rendered.
Mon, May 4, 6:25 PM
anlambert added a revision to T2389: "Error 200" when browsing a .psd file: D3118: templates/content-display: Fix view when an image cannot be rendered.
Mon, May 4, 4:31 PM · Web app
anlambert created D3118: templates/content-display: Fix view when an image cannot be rendered.
Mon, May 4, 4:31 PM
anlambert added a comment to T2389: "Error 200" when browsing a .psd file.

Lol :-) You hit the corner case when an image can not be rendered in the browser due to an unsupported mimetype (here image/vnd.adobe.photoshop). The fix is easy, working on a test right now.

Mon, May 4, 2:55 PM · Web app

Thu, Apr 30

anlambert committed rDWAPPS3cdfd8a03978: tests: Fix new failing ones after swh-storage update (authored by anlambert).
tests: Fix new failing ones after swh-storage update
Thu, Apr 30, 4:31 PM
anlambert closed D3106: tests: Fix new failing ones after swh-storage update.
Thu, Apr 30, 4:31 PM
anlambert created D3106: tests: Fix new failing ones after swh-storage update.
Thu, Apr 30, 3:46 PM
anlambert committed rDWAPPS04cc606c8722: Move get_swh_persistent_ids function in common.identifers module (authored by anlambert).
Move get_swh_persistent_ids function in common.identifers module
Thu, Apr 30, 3:10 PM
anlambert closed D3105: Move get_swh_persistent_ids function in common.identifers module.
Thu, Apr 30, 3:09 PM
anlambert added inline comments to D3105: Move get_swh_persistent_ids function in common.identifers module.
Thu, Apr 30, 3:06 PM
anlambert created D3105: Move get_swh_persistent_ids function in common.identifers module.
Thu, Apr 30, 2:50 PM
anlambert committed rDWAPPSa69e886ca313: Add a pyproject.toml file to target py37 for black (authored by anlambert).
Add a pyproject.toml file to target py37 for black
Thu, Apr 30, 2:03 PM
anlambert closed D3103: Add a pyproject.toml file to target py37 for black.
Thu, Apr 30, 2:03 PM
anlambert committed rCJSWH4a78a3179780: jobs/stage-cypress-tests: Add --no-use-pep517 option to pip install (authored by anlambert).
jobs/stage-cypress-tests: Add --no-use-pep517 option to pip install
Thu, Apr 30, 1:52 PM
anlambert closed D3104: jobs/stage-cypress-tests: Add --no-use-pep517 option to pip install.
Thu, Apr 30, 1:52 PM
anlambert updated the summary of D3103: Add a pyproject.toml file to target py37 for black.
Thu, Apr 30, 1:49 PM
anlambert created D3104: jobs/stage-cypress-tests: Add --no-use-pep517 option to pip install.
Thu, Apr 30, 1:47 PM
anlambert created D3103: Add a pyproject.toml file to target py37 for black.
Thu, Apr 30, 1:44 PM
anlambert closed D3096: browse/revision: Refactor metadata handling and add typing.
Thu, Apr 30, 12:46 PM
anlambert committed rDWAPPS12280e362e3c: browse/revision: Refactor metadata handling and add typing (authored by anlambert).
browse/revision: Refactor metadata handling and add typing
Thu, Apr 30, 12:46 PM
anlambert committed rDWAPPSaa735b9339ac: browse/release: Refactor metadata handling and add typing (authored by anlambert).
browse/release: Refactor metadata handling and add typing
Thu, Apr 30, 12:46 PM
anlambert committed rDWAPPS897d81f1b0df: browse/directory: Refactor metadata handling and add typing (authored by anlambert).
browse/directory: Refactor metadata handling and add typing
Thu, Apr 30, 12:46 PM
anlambert closed D3094: browse/release: Refactor metadata handling and add typing.
Thu, Apr 30, 12:46 PM
anlambert closed D3092: browse/directory: Refactor metadata handling and add typing.
Thu, Apr 30, 12:46 PM
anlambert committed rDWAPPS7bbd64d4e63e: browse/content: Refactor metadata handling and add typing (authored by anlambert).
browse/content: Refactor metadata handling and add typing
Thu, Apr 30, 12:46 PM
anlambert closed D3089: browse/content: Refactor metadata handling and add typing.
Thu, Apr 30, 12:46 PM
anlambert committed rDWAPPS51f2af1e78cd: assets/webapp: Add SWHIDs context related functions (authored by anlambert).
assets/webapp: Add SWHIDs context related functions
Thu, Apr 30, 12:46 PM
anlambert closed D3088: assets/webapp: Add SWHIDs context related functions.
Thu, Apr 30, 12:46 PM
anlambert closed T2387: Clarify visits in SWHIDs as Wontfix.

Alright, closing this then.

Thu, Apr 30, 12:31 PM · Data Model
anlambert added a comment to T2387: Clarify visits in SWHIDs.

Plus numerous visits of a same origin can point to the same snapshot so the confusion here.

Thu, Apr 30, 12:22 PM · Data Model
anlambert added a comment to T2387: Clarify visits in SWHIDs.

I agree that turning visit key into a snapshot one is less confusing.

Thu, Apr 30, 12:16 PM · Data Model
anlambert updated the diff for D3096: browse/revision: Refactor metadata handling and add typing.

Rebase

Thu, Apr 30, 11:50 AM
anlambert updated the diff for D3094: browse/release: Refactor metadata handling and add typing.

Rebase

Thu, Apr 30, 11:49 AM
anlambert updated the diff for D3092: browse/directory: Refactor metadata handling and add typing.

Rebase

Thu, Apr 30, 11:49 AM
anlambert updated the diff for D3089: browse/content: Refactor metadata handling and add typing.

Rebase

Thu, Apr 30, 11:48 AM
anlambert updated the diff for D3088: assets/webapp: Add SWHIDs context related functions.

Rebase

Thu, Apr 30, 11:47 AM