Differential D8128

Fix mypy false positive
ClosedPublic
Actions

Authored by vlorentz on Jul 18 2022, 4:05 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSEA12530b638982: Fix mypy false positive

Summary

'document' is a typed dict, which mypy does not seem to allow here

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 18 2022, 4:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 18 2022, 4:05 PM

vlorentz added a child revision: D8129: Prevent 'version' field (and others) from being dynamically infered as double.Jul 18 2022, 4:06 PM

Build is green

Patch application report for D8128 (id=29360)

Rebasing onto c847e9bbb0...

Current branch diff-target is up to date.

Changes applied before test

commit 12530b63898252cafa732e6b537b763a0173eeb8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 18 16:05:42 2022 +0200

    Fix mypy false positive
    
    'document' is a typed dict, which mypy does not seem to allow here

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/333/ for more details.

Harbormaster completed remote builds in B30437: Diff 29360.Jul 18 2022, 4:09 PM

vlorentz requested review of this revision.Jul 18 2022, 4:09 PM

anlambert accepted this revision.Jul 18 2022, 4:53 PM

This revision is now accepted and ready to land.Jul 18 2022, 4:53 PM

Closed by commit rDSEA12530b638982: Fix mypy false positive (authored by vlorentz). · Explain WhyJul 18 2022, 5:14 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSEA12530b638982: Fix mypy false positive.

Revision Contents
Changeset List

Path

Size

swh/

search/

elasticsearch.py

4 lines

Diff 29367

View Options

swh/search/elasticsearch.py

Fix mypy false positiveClosedPublicActions