Page MenuHomeSoftware Heritage

Improve hiring banner embedding for django website
ClosedPublic

Authored by anlambert on Tue, Jul 12, 6:16 PM.

Details

Summary

Prefer to use a div instead of an iframe to avoid blinking banner
on page load.

Nevertheless, keep the iframe view to ease embedding in external
WordPress website.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz accepted this revision.
This revision is now accepted and ready to land.Tue, Jul 12, 6:18 PM

Build is green

Patch application report for D8118 (id=29330)

Rebasing onto 36f971347d...

Current branch diff-target is up to date.
Changes applied before test
commit 6f9d36afe4840dc3b2424363731c4196b97e14bd
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 12 18:15:34 2022 +0200

    Improve hiring banner embedding for django website
    
    Prefer to use a div instead of an iframe to avoid blinking banner
    on page load.
    
    Nevertheless, keep the iframe view to ease embedding in external
    WordPress website.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1929/ for more details.