Differential D8123

Fix test_origin_sub_directory_view
ClosedPublic
Actions

Authored by vlorentz on Jul 13 2022, 2:24 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPSa7a43afd283d: Fix test_origin_sub_directory_view

Summary

The target and root directory differ in this test, causing this assertion to fail
when the test actually runs

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 13 2022, 2:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 13 2022, 2:24 PM

Build has FAILED

Patch application report for D8123 (id=29348)

Rebasing onto 96fefcf474...

Current branch diff-target is up to date.

Changes applied before test

commit a7a43afd283d1279d619be2da1e6ca95c033b046
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 13 14:24:32 2022 +0200

    Fix test_origin_sub_directory_view
    
    The target and root directory differ in this test, causing this assertion to fail
    when the test actually runs

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1935/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1935/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 13 2022, 2:43 PM

Harbormaster failed remote builds in B30425: Diff 29348!

Build is green

Patch application report for D8123 (id=29348)

Rebasing onto 96fefcf474...

Current branch diff-target is up to date.

Changes applied before test

commit a7a43afd283d1279d619be2da1e6ca95c033b046
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 13 14:24:32 2022 +0200

    Fix test_origin_sub_directory_view
    
    The target and root directory differ in this test, causing this assertion to fail
    when the test actually runs

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1936/ for more details.

Harbormaster completed remote builds in B30425: Diff 29348.Jul 13 2022, 3:07 PM

vlorentz requested review of this revision.Jul 13 2022, 3:07 PM

anlambert accepted this revision.Jul 13 2022, 3:08 PM

This revision is now accepted and ready to land.Jul 13 2022, 3:08 PM

Closed by commit rDWAPPSa7a43afd283d: Fix test_origin_sub_directory_view (authored by vlorentz). · Explain WhyJul 13 2022, 3:10 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPSa7a43afd283d: Fix test_origin_sub_directory_view.