Paths

Table of Contentst

Differential D8142

docs: Reference a register-account documentation
ClosedPublic
Actions

Authored by ardumont on Jul 19 2022, 5:52 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4399: OIN -> SWH deposit connection

Commits

rDDEP635886b04d4e: docs: Reference a register-account documentation

Summary

Related to T4399

Test Plan

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 19 2022, 5:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2022, 5:52 PM

ardumont edited the test plan for this revision. (Show Details)Jul 19 2022, 5:52 PM

ardumont mentioned this in T4399: OIN -> SWH deposit connection.

Build has FAILED

Patch application report for D8142 (id=29392)

Rebasing onto cb79e8f38d...

Current branch diff-target is up to date.

Changes applied before test

commit ed772d485c2d0381b32c5fa68c66bc7ab1c93a70
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 19 17:51:30 2022 +0200

    docs: Reference a register-account documentation
    
    Related to T4399

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/854/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/854/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2022, 5:59 PM

Harbormaster failed remote builds in B30466: Diff 29392!

vlorentz added a subscriber: vlorentz.Jul 19 2022, 6:03 PM

vlorentz added inline comments.

docs/api/user-manual.rst
13–15
docs/internals/prod-environment.rst
55
docs/specs/protocol-reference.rst
76

Adapt according to review

Build has FAILED

Patch application report for D8142 (id=29404)

Rebasing onto cb79e8f38d...

Current branch diff-target is up to date.

Changes applied before test

commit 954c7ee6ca07530ce2dd0d261b17d723eb500c22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 19 17:51:30 2022 +0200

    docs: Reference a register-account documentation
    
    Related to T4399

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/856/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/856/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 20 2022, 11:41 AM

Harbormaster failed remote builds in B30477: Diff 29404!

Build is green

Patch application report for D8142 (id=29404)

Rebasing onto cb79e8f38d...

Current branch diff-target is up to date.

Changes applied before test

commit 954c7ee6ca07530ce2dd0d261b17d723eb500c22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 19 17:51:30 2022 +0200

    docs: Reference a register-account documentation
    
    Related to T4399

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/857/ for more details.

Harbormaster completed remote builds in B30477: Diff 29404.Jul 20 2022, 11:51 AM

ardumont requested review of this revision.Jul 20 2022, 11:51 AM

Looks good to me, apart the renaming of some refs.

docs/api/register-account.rst
1	I would prefix the reference by `swh-deposit` here to avoid name clashes when compiling the whole swh doc.
12	swh-deposit-register-account-as-client

This revision is now accepted and ready to land.Jul 20 2022, 11:59 AM

ardumont added inline comments.Jul 20 2022, 2:37 PM

docs/api/register-account.rst
1	yes, i was wondering as well, i'll adapt.

ardumont marked 5 inline comments as done.Jul 20 2022, 2:38 PM

Further update

This revision was landed with ongoing or failed builds.Jul 20 2022, 2:43 PM

Closed by commit rDDEP635886b04d4e: docs: Reference a register-account documentation (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP635886b04d4e: docs: Reference a register-account documentation.

Build is green

Patch application report for D8142 (id=29409)

Rebasing onto cb79e8f38d...

Current branch diff-target is up to date.

Changes applied before test

commit 635886b04d4ec2b8e364e1b7d04c663b9b7153a4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 19 17:51:30 2022 +0200

    docs: Reference a register-account documentation
    
    Related to T4399

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/858/ for more details.

Harbormaster completed remote builds in B30483: Diff 29409.Jul 20 2022, 2:49 PM