Page MenuHomeSoftware Heritage
Differential D8139

settings/common: Silence urllib3 debug logging
ClosedPublic
Actions

Authored by anlambert on Jul 19 2022, 4:57 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS722cf1e41fc9: Makefile.local: Do not filter out error output when running migrations
rDWAPPS0901c69559fa: settings/common: Silence urllib3 debug logging
Summary

It generates a lof of noise and clutters terminal a lot.

Also, do not filter out error output when running migrations

The error output was filtered out due to the high amount of urllib3 debug
logs but those logs are now longer enabled.

So remove error output filtering to help debugging failed migrations.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 19 2022, 4:57 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2022, 4:57 PM
swh-public-ci added a comment.Jul 19 2022, 5:14 PM

Build has FAILED

Patch application report for D8139 (id=29384)

Rebasing onto e619d58ee3...

Current branch diff-target is up to date.
Changes applied before test
commit a600130a8ab6a4ee893a827e12a484a896b9088f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 19 16:54:16 2022 +0200

    Makefile.local: Do not filter out error output when running migrations
    
    The error output was filtered out due to the high amount of urllib3 debug
    logs but those logs are now longer enabled.
    
    So remove error output filtering to help debugging failed migrations.

commit 17ca93df835a687473a4c57959dc84a129739f42
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 19 16:53:25 2022 +0200

    settings/common: Silent urllib3 debug logging
    
    It generates a lof of noise and clutters terminal a lot.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1938/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1938/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2022, 5:14 PM
Harbormaster failed remote builds in B30458: Diff 29384!
ardumont added a subscriber: ardumont.Jul 20 2022, 11:35 AM

lgtm (can't validate it due to its draft nature)

anlambert updated this revision to Diff 29405.Jul 20 2022, 11:44 AM

Rebase

swh-public-ci added a comment.Jul 20 2022, 12:03 PM

Build is green

Patch application report for D8139 (id=29405)

Rebasing onto 7d1404c206...

Current branch diff-target is up to date.
Changes applied before test
commit 52011af2fb4adc01203f0f132ba9c1f58a41c467
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 19 16:54:16 2022 +0200

    Makefile.local: Do not filter out error output when running migrations
    
    The error output was filtered out due to the high amount of urllib3 debug
    logs but those logs are now longer enabled.
    
    So remove error output filtering to help debugging failed migrations.

commit e55dfdd75e48be7a48f66b1eb8ecd444c1871479
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 19 16:53:25 2022 +0200

    settings/common: Silent urllib3 debug logging
    
    It generates a lof of noise and clutters terminal a lot.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1943/ for more details.

Harbormaster completed remote builds in B30478: Diff 29405.Jul 20 2022, 12:03 PM
anlambert requested review of this revision.Jul 20 2022, 12:03 PM
vlorentz accepted this revision.Jul 20 2022, 12:18 PM
vlorentz added a subscriber: vlorentz.

thanks!

s/Silent/Silence/

This revision is now accepted and ready to land.Jul 20 2022, 12:18 PM
anlambert updated this revision to Diff 29406.Jul 20 2022, 12:30 PM

Fix typo

swh-public-ci added a comment.Jul 20 2022, 12:46 PM

Build is green

Patch application report for D8139 (id=29406)

Rebasing onto 7d1404c206...

Current branch diff-target is up to date.
Changes applied before test
commit 722cf1e41fc94328c2e3a802a485d32d440e807d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 19 16:54:16 2022 +0200

    Makefile.local: Do not filter out error output when running migrations
    
    The error output was filtered out due to the high amount of urllib3 debug
    logs but those logs are now longer enabled.
    
    So remove error output filtering to help debugging failed migrations.

commit 0901c69559faaa1e7614146b690cd52da647eee8
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 19 16:53:25 2022 +0200

    settings/common: Silence urllib3 debug logging
    
    It generates a lof of noise and clutters terminal a lot.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1944/ for more details.

Harbormaster completed remote builds in B30479: Diff 29406.Jul 20 2022, 12:46 PM
Closed by commit rDWAPPS0901c69559fa: settings/common: Silence urllib3 debug logging (authored by anlambert). · Explain WhyJul 20 2022, 1:04 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS0901c69559fa: settings/common: Silence urllib3 debug logging.
anlambert added a commit: rDWAPPS722cf1e41fc9: Makefile.local: Do not filter out error output when running migrations.
vlorentz retitled this revision from settings/common: Silent urllib3 debug logging to settings/common: Silence urllib3 debug logging.Jul 20 2022, 1:51 PM

Revision Contents
Changeset List

PathSize
swh/
web/
settings/
3 lines

Diff 29407

View Options

swh/web/settings/common.py

Loading...
About · Developer information · Legal