Page MenuHomeSoftware Heritage
Differential D8145

Disable Sentry reporting of 4xx status codes
ClosedPublic
Actions

Authored by vlorentz on Jul 20 2022, 10:25 AM.

Details

Reviewers
ardumont
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPSe5d355c5d660: Disable Sentry reporting of 4xx status codes
Summary

eg. https://sentry.softwareheritage.org/share/issue/12730ae3258d4868a087863e7fe1c94a/
is '406 Not Acceptable'

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 20 2022, 10:25 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2022, 10:25 AM
swh-public-ci added a comment.Jul 20 2022, 10:41 AM

Build has FAILED

Patch application report for D8145 (id=29398)

Rebasing onto e619d58ee3...

Current branch diff-target is up to date.
Changes applied before test
commit b21209fd123773c016bdc6ac0b693466e39f8978
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 10:23:46 2022 +0200

    Disable Sentry reporting of 4xx status codes
    
    eg. https://sentry.softwareheritage.org/share/issue/12730ae3258d4868a087863e7fe1c94a/
    is '406 Not Acceptable'

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1939/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1939/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 20 2022, 10:41 AM
Harbormaster failed remote builds in B30471: Diff 29398!
vlorentz requested review of this revision.Jul 20 2022, 10:52 AM

(test failure is unrelated)

vlorentz updated this revision to Diff 29401.Jul 20 2022, 11:06 AM

rebase on D8146 to fix tests

swh-public-ci added a comment.Jul 20 2022, 11:26 AM

Build has FAILED

Patch application report for D8145 (id=29401)

Could not rebase; Attempt merge onto e619d58ee3...

Updating e619d58e..20f436da
Fast-forward
 requirements-swh.txt  |  2 +-
 swh/web/common/exc.py | 14 ++++++++++----
 swh/web/tests/data.py |  4 +---
 3 files changed, 12 insertions(+), 8 deletions(-)
Changes applied before test
commit 20f436daf23e0758eadd8329b5ad4236f6c535f9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 10:23:46 2022 +0200

    Disable Sentry reporting of 4xx status codes
    
    eg. https://sentry.softwareheritage.org/share/issue/12730ae3258d4868a087863e7fe1c94a/
    is '406 Not Acceptable'

commit 7d1404c206543ff79ccfeb082c7bce6627ac79c4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 11:05:02 2022 +0200

    Update test data for swh-search 0.16.0.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1941/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1941/console

Harbormaster failed remote builds in B30474: Diff 29401!Jul 20 2022, 11:26 AM
ardumont accepted this revision.Jul 20 2022, 11:43 AM
ardumont added a subscriber: ardumont.

lgtm, one suggestion inline.

maybe that'd be worth having metrics about those... (if yes, fine to do it later).

swh/web/common/exc.py
134–151

?

This revision is now accepted and ready to land.Jul 20 2022, 11:43 AM
swh-public-ci added a comment.Jul 20 2022, 11:50 AM

Build is green

Patch application report for D8145 (id=29401)

Could not rebase; Attempt merge onto e619d58ee3...

Updating e619d58e..20f436da
Fast-forward
 requirements-swh.txt  |  2 +-
 swh/web/common/exc.py | 14 ++++++++++----
 swh/web/tests/data.py |  4 +---
 3 files changed, 12 insertions(+), 8 deletions(-)
Changes applied before test
commit 20f436daf23e0758eadd8329b5ad4236f6c535f9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 10:23:46 2022 +0200

    Disable Sentry reporting of 4xx status codes
    
    eg. https://sentry.softwareheritage.org/share/issue/12730ae3258d4868a087863e7fe1c94a/
    is '406 Not Acceptable'

commit 7d1404c206543ff79ccfeb082c7bce6627ac79c4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 11:05:02 2022 +0200

    Update test data for swh-search 0.16.0.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1942/ for more details.

Harbormaster completed remote builds in B30474: Diff 29401.Jul 20 2022, 11:50 AM
vlorentz added inline comments.Jul 20 2022, 12:08 PM
swh/web/common/exc.py
134–151

I think it is more readable to keep the two cases separate, each with its own comment

vlorentz added a comment.Jul 20 2022, 12:08 PM
In D8145#211826, @ardumont wrote:

maybe that'd be worth having metrics about those... (if yes, fine to do it later).

:p

anlambert accepted this revision.Jul 20 2022, 2:41 PM
vlorentz updated this revision to Diff 29420.Jul 21 2022, 10:42 AM

rebase

This revision was landed with ongoing or failed builds.Jul 21 2022, 10:42 AM
Closed by commit rDWAPPSe5d355c5d660: Disable Sentry reporting of 4xx status codes (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDWAPPSe5d355c5d660: Disable Sentry reporting of 4xx status codes.
swh-public-ci added a comment.Jul 21 2022, 10:56 AM

Build has FAILED

Patch application report for D8145 (id=29420)

Rebasing onto e5d355c5d6...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1945-D8145.
Changes applied before test



Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1945/

See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1945/console
Harbormaster failed remote builds in B30498: Diff 29420!Jul 21 2022, 10:56 AM
Revision Contents
Changeset List
PathSize
swh/
web/
common/
14 lines
Diff 29421
View Options
swh/web/common/exc.py
Loading...
About · Developer information · Legal