Page MenuHomeSoftware Heritage

Disable Sentry reporting of 4xx status codes
ClosedPublic

Authored by vlorentz on Wed, Jul 20, 10:25 AM.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D8145 (id=29398)

Rebasing onto e619d58ee3...

Current branch diff-target is up to date.
Changes applied before test
commit b21209fd123773c016bdc6ac0b693466e39f8978
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 10:23:46 2022 +0200

    Disable Sentry reporting of 4xx status codes
    
    eg. https://sentry.softwareheritage.org/share/issue/12730ae3258d4868a087863e7fe1c94a/
    is '406 Not Acceptable'

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1939/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1939/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jul 20, 10:41 AM
Harbormaster failed remote builds in B30471: Diff 29398!

(test failure is unrelated)

Build has FAILED

Patch application report for D8145 (id=29401)

Could not rebase; Attempt merge onto e619d58ee3...

Updating e619d58e..20f436da
Fast-forward
 requirements-swh.txt  |  2 +-
 swh/web/common/exc.py | 14 ++++++++++----
 swh/web/tests/data.py |  4 +---
 3 files changed, 12 insertions(+), 8 deletions(-)
Changes applied before test
commit 20f436daf23e0758eadd8329b5ad4236f6c535f9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 10:23:46 2022 +0200

    Disable Sentry reporting of 4xx status codes
    
    eg. https://sentry.softwareheritage.org/share/issue/12730ae3258d4868a087863e7fe1c94a/
    is '406 Not Acceptable'

commit 7d1404c206543ff79ccfeb082c7bce6627ac79c4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 11:05:02 2022 +0200

    Update test data for swh-search 0.16.0.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1941/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1941/console

ardumont added a subscriber: ardumont.

lgtm, one suggestion inline.

maybe that'd be worth having metrics about those... (if yes, fine to do it later).

swh/web/common/exc.py
134–151

?

This revision is now accepted and ready to land.Wed, Jul 20, 11:43 AM

Build is green

Patch application report for D8145 (id=29401)

Could not rebase; Attempt merge onto e619d58ee3...

Updating e619d58e..20f436da
Fast-forward
 requirements-swh.txt  |  2 +-
 swh/web/common/exc.py | 14 ++++++++++----
 swh/web/tests/data.py |  4 +---
 3 files changed, 12 insertions(+), 8 deletions(-)
Changes applied before test
commit 20f436daf23e0758eadd8329b5ad4236f6c535f9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 10:23:46 2022 +0200

    Disable Sentry reporting of 4xx status codes
    
    eg. https://sentry.softwareheritage.org/share/issue/12730ae3258d4868a087863e7fe1c94a/
    is '406 Not Acceptable'

commit 7d1404c206543ff79ccfeb082c7bce6627ac79c4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 20 11:05:02 2022 +0200

    Update test data for swh-search 0.16.0.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1942/ for more details.

swh/web/common/exc.py
134–151

I think it is more readable to keep the two cases separate, each with its own comment

maybe that'd be worth having metrics about those... (if yes, fine to do it later).

:p

This revision was landed with ongoing or failed builds.Thu, Jul 21, 10:42 AM
This revision was automatically updated to reflect the committed changes.

Build has FAILED

Patch application report for D8145 (id=29420)

Rebasing onto e5d355c5d6...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1945-D8145.
Changes applied before test

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1945/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1945/console