Page MenuHomeSoftware Heritage
Differential D8226

docker/tests: add a test for the vault git-bare cooker
ClosedPublic
Actions

Authored by douardda on Aug 9 2022, 5:03 PM.

Details

Reviewers
vlorentz
anlambert
Group Reviewers
Reviewers
Commits
rDENVe4052005b0e8: docker/tests: add a test for the vault git-bare cooker
Summary

Depends on D8225.

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Aug 9 2022, 5:03 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 9 2022, 5:03 PM
douardda requested review of this revision.Aug 9 2022, 5:03 PM
Harbormaster completed remote builds in B30730: Diff 29671.Aug 9 2022, 5:03 PM
vlorentz accepted this revision.Aug 9 2022, 5:09 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
docker/tests/test_vault.py
96–101

you can save an indent level (and some complexity) here

This revision is now accepted and ready to land.Aug 9 2022, 5:09 PM
anlambert requested changes to this revision.Aug 9 2022, 5:15 PM
anlambert added a subscriber: anlambert.

I have the following flake8 errors when running tox, those must be fixed as it will break the CI otherwise. Some errors need to be fixed in D8225 too.

(swh) ✔ ~/swh/swh-environment/docker [arcpatch-D8226 L|⚑ 70] 
17:12 $ tox
flake8 installed: flake8==5.0.4,mccabe==0.7.0,pycodestyle==2.9.1,pyflakes==2.5.0
flake8 run-test-pre: PYTHONHASHSEED='1236590620'
flake8 run-test: commands[0] | /home/anlambert/swh/swh-environment/docker/.tox/flake8/bin/python -m flake8 tests
tests/conftest.py:41:1: E302 expected 2 blank lines, found 1
tests/conftest.py:45:1: E302 expected 2 blank lines, found 1
tests/conftest.py:63:89: E501 line too long (107 > 88 characters)
tests/test_vault.py:95:20: E226 missing whitespace around arithmetic operator
tests/test_vault.py:129:89: E501 line too long (93 > 88 characters)
tests/test_vault.py:133:5: E303 too many blank lines (3)
ERROR: InvocationError for command /home/anlambert/swh/swh-environment/docker/.tox/flake8/bin/python -m flake8 tests (exited with code 1)
This revision now requires changes to proceed.Aug 9 2022, 5:15 PM
douardda updated this revision to Diff 29673.Aug 9 2022, 5:31 PM

apply vlorentz' suggestion and rebase

Harbormaster completed remote builds in B30732: Diff 29673.Aug 9 2022, 5:31 PM
douardda updated this revision to Diff 29674.Aug 9 2022, 5:33 PM

small (black) format fix

Harbormaster completed remote builds in B30733: Diff 29674.Aug 9 2022, 5:33 PM
anlambert accepted this revision.Aug 9 2022, 5:36 PM
This revision is now accepted and ready to land.Aug 9 2022, 5:36 PM
douardda added inline comments.Aug 10 2022, 9:19 AM
docker/tests/test_vault.py
96–101

ah yes thx

Closed by commit rDENVe4052005b0e8: docker/tests: add a test for the vault git-bare cooker (authored by douardda). · Explain WhyAug 10 2022, 9:35 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENVe4052005b0e8: docker/tests: add a test for the vault git-bare cooker.

Revision Contents
Changeset List

PathSize
docker/
tests/
89 lines

Diff 29682

View Options

docker/tests/test_vault.py

Loading...
About · Developer information · Legal