Page MenuHomeSoftware Heritage

Add tests for RPC server's exception handling
ClosedPublic

Authored by vlorentz on Aug 9 2022, 11:12 AM.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8220 (id=29655)

Could not rebase; Attempt merge onto 2d1cd6af71...

Updating 2d1cd6a..c75ab14
Fast-forward
 swh/core/api/__init__.py              | 45 +++++++---------------
 swh/core/api/tests/test_rpc_client.py | 25 +++---------
 swh/core/api/tests/test_rpc_server.py | 72 ++++++++++++++++++++++++++++++++++-
 3 files changed, 89 insertions(+), 53 deletions(-)
Changes applied before test
commit c75ab14ccdc007fa465e421b6aa4290243da96b9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:12:34 2022 +0200

    Add tests for RPC server's exception handling

commit e6497914d42b1f1e36e2850f53e8b9a04443cbe8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 10:48:22 2022 +0200

    Remove support for deprecated exception format
    
    It was removed from all RPC servers years ago.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/463/ for more details.

anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/core/api/tests/test_rpc_server.py
1

2022

This revision is now accepted and ready to land.Aug 9 2022, 11:50 AM

Build is green

Patch application report for D8220 (id=29659)

Could not rebase; Attempt merge onto 2d1cd6af71...

Updating 2d1cd6a..9848432
Fast-forward
 swh/core/api/__init__.py              | 45 ++++++---------------
 swh/core/api/tests/test_rpc_client.py | 25 +++---------
 swh/core/api/tests/test_rpc_server.py | 74 ++++++++++++++++++++++++++++++++++-
 3 files changed, 90 insertions(+), 54 deletions(-)
Changes applied before test
commit 9848432cd77adec649e397c16e76ff8e5865699d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 11:12:34 2022 +0200

    Add tests for RPC server's exception handling

commit e6497914d42b1f1e36e2850f53e8b9a04443cbe8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 10:48:22 2022 +0200

    Remove support for deprecated exception format
    
    It was removed from all RPC servers years ago.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/465/ for more details.