♟ anlambert

Update: Address @vlorentz comments

I managed to track the dependency bump that broke the CI build: it is the upgrade of yarl (dependency of aiohttp) from 1.5.1 to 1.6.0. The issue is surely due to that commit.

jobs/swh-environment: Improve build script

Update: Remove empty line

In D4068#100955, @douardda wrote:

LGTM (except the "rm -f ../$module.log " for which I am not convinced it's a good idea)

tox/black: Pin version to pre-commit one and exclude test resources

setup.py: Remove no more needed vcversioner configuration

SWHIDs: Do not add path qualifier for a root directory

Update: Address @ardumont comment

assets/browse/swhid-utils: Improve SWHID with context display

assets/admin/deposit: Improve SWHID with context link text formatting

SWHIDs: Fix URLs escaping when a qualifier contains escaped chars

Update: Fix cypress test

Hopefully, the issue is related to missing URL escaping in the webapp. I implemented the fix, still some tests to write and I will push a diff during the afternoon.

The issue is not related to the double slash at the end of the permalink but rather from the fact that the origin URL contains a = character in it (https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://cran.r-project.org/package%3DActivePathways). I will fix that asap.

This URL points to the mercurial repositories archived by Octobus in their original form which have not yet been fully loaded into the archive.
Plus we also archive public git repositories from Bitbucket so I do not think replacing the link to bibucket.org is the right thing to do here.

Should this also be removed from the "Permalinks" tab in the webapp ?

package.json: Upgrade dependencies

assets/revision: Enable link to revision changes view with URL fragment

DEBUG log level seems a better choice indeed.

api/apiresponse: Add typing information

Update: Fix and simplify make_api_response code.

common/service: Add lookup_origins_by_sha1s function

Makefile.local: Fix "make test" execution

Add missing newline at end of file

common/origin_save: Fix save request task running status reporting

origin_save: Fix typo in a save task status (s/succeed/succeeded/)

In D4004#99008, @anlambert wrote:

In D4004#98985, @zack wrote:

Caveat: as this results in an API change (I think), it should be announced on the swh-devel mailing list before deployment.

Oh right, it changes a returned value. I will send a mail during the afternoon.

templates/apidoc-header: Add section about UTF-8 decoding errors

common/converters: Harmonize UTF-8 decoding errors handling

In D4004#98985, @zack wrote:

Caveat: as this results in an API change (I think), it should be announced on the swh-devel mailing list before deployment.

auth: Add web UI for API bearer tokens management

Update: Address @ardumont comments

@ardumont, thanks for the review. I will update the diff according to your comments before landing this.

In fact, the "ongoing" task state was captured by swh-web and the save request status was displayed as "running" prior to the model migration towards origin visit statuses.

Update: Fix cypress tests

In D3983#98691, @zack wrote:

In D3983#98386, @anlambert wrote:

The repository is missing configuration for using black. Could you add the pre-commit hook and the black configuration in pyproject.toml as in other swh repos ?

Oops, I didn't notice that, good catch!

Should be done now.

anlambert (Antoine Lambert)
User

Projects (6)
View All

User Details

Recent Activity
View All

Today

Yesterday

Fri, Sep 25

Thu, Sep 24

Wed, Sep 23

Tue, Sep 22

Mon, Sep 21

Fri, Sep 18

anlambert (Antoine Lambert)User

Projects (6)View All