User Details
User Details
- User Since
- Jul 3 2017, 10:14 AM (110 w, 5 d)
Fri, Aug 9
Fri, Aug 9
anlambert added a comment to D1837: cypress: Add tests for the vault features.
@ardumont, you can check the effect of that test through the cypress UI.
anlambert committed rCJSWH3ae832a312fd: jobs/templates: Only fetch master branch in Phabricator Diff related jobs (authored by anlambert).
jobs/templates: Only fetch master branch in Phabricator Diff related jobs
anlambert updated the diff for D1839: Jenkins: Only fetch master branch in Phabricator Diff related jobs.
Update: Fix indentation
Herald added a reviewer for D1839: Jenkins: Only fetch master branch in Phabricator Diff related jobs: Reviewers.
anlambert committed rDWAPPS244a1dbac991: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert committed rCJSWHdf241afe7497: templates/swh-pipeline: Set Phabricator as git repository browser (authored by anlambert).
templates/swh-pipeline: Set Phabricator as git repository browser
anlambert updated the diff for D1834: Jenkins: Set Phabricator as git repository browser.
Update: Use correct repoUrl and add same setting to cypress job
Thu, Aug 8
Thu, Aug 8
anlambert committed rDWAPPS39f81a324556: cypress/support: Prefer to retrieve objects metadata through the API (authored by anlambert).
cypress/support: Prefer to retrieve objects metadata through the API
anlambert committed rDWAPPS1d9ff31a6af9: assets/vault: Fix slow vault UI bootstrapping on Chromium based browsers (authored by anlambert).
assets/vault: Fix slow vault UI bootstrapping on Chromium based browsers
assets: Remove dead code
anlambert committed rDWAPPScffbd902002e: webpack: Optimize generated Javascript bundle sizes (authored by anlambert).
webpack: Optimize generated Javascript bundle sizes
anlambert added inline comments to D1824: swh.loader.package: Implement GNU Loader.
anlambert added inline comments to D1824: swh.loader.package: Implement GNU Loader.
Wed, Aug 7
Wed, Aug 7
anlambert committed rDWAPPScda602a33c07: swh-web: Change 'Save code now' url from /browse/origin/save to /save (authored by anlambert).
swh-web: Change 'Save code now' url from /browse/origin/save to /save
anlambert committed rDWAPPS11924dc3a31f: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert committed rDWAPPS02f5024cee8c: swh-web: Reorganize and cleanup some views implementation and declaration (authored by anlambert).
swh-web: Reorganize and cleanup some views implementation and declaration
anlambert closed T1909: Enable to manually select the programming language to highlight as Resolved.
anlambert accepted D1823: cypress: Refactor tests.
Looks good to me, let's land this !
anlambert committed rCJSWHddae007fed8e: jobs/templates: Add missing curly braces escaping (authored by anlambert).
jobs/templates: Add missing curly braces escaping
anlambert committed rCJSWH40bbd17a9cd0: jobs/templates: Create Harbomaster URI artifact with Jenkins build url (authored by anlambert).
jobs/templates: Create Harbomaster URI artifact with Jenkins build url
anlambert committed rCJSWH06002fe8b11d: jobs/templates: Put swh-pipeline in a separate groovy file (authored by anlambert).
jobs/templates: Put swh-pipeline in a separate groovy file
anlambert added a comment to T1942: Create shorter url redirecting to "Save code now".
That is definitely worth doing, as /browse/origin/save is not really semantically sound.
Herald added a reviewer for D1828: Jenkins: Create Harbomaster URI artifact with build job url: Reviewers.
Tue, Aug 6
Tue, Aug 6
anlambert updated the task description for T1768: Add end to end tests for the frontend part of swh-web.
anlambert updated the task description for T1411: reach a minimum of 80% SLOC coverage across all components.
Looks good to me. This is helpful as I can't count the number of times the auto-trimming feature of my text editor removed those needed spaces.
Mon, Aug 5
Mon, Aug 5
anlambert added a comment to T1942: Create shorter url redirecting to "Save code now".
Maybe renaming the save code now url to https://archive.softwareheritage.org/save/ would be a good mitigation as it is not hard to remember ?
anlambert committed rCJSWH9060ec050d70: Automatically create swh-web admin user for cypress tests (authored by anlambert).
Automatically create swh-web admin user for cypress tests
Herald added a reviewer for D1819: Jenkins: Automatically create swh-web admin user for cypress tests: Reviewers.
anlambert committed rDWAPPS59db5cd69f3a: tests: Use empty database and register admin user for cypress use (authored by anlambert).
tests: Use empty database and register admin user for cypress use
Apart a small nitpick, looks good to me.
anlambert committed rCDFD307ffd6a3783: swh-web/entrypoint: Improve admin user creation script (authored by anlambert).
swh-web/entrypoint: Improve admin user creation script
anlambert closed T1845: Add end to end tests for content rendering, a subtask of T1688: Refactor content rendering, as Resolved.
anlambert committed rDWAPPS8421487367a4: cypress: Add end to end tests for content rendering (authored by anlambert).
cypress: Add end to end tests for content rendering
anlambert committed rDWAPPS12427620b5ad: common/highlightjs: Improve code highlighting of numerous source files (authored by anlambert).
common/highlightjs: Improve code highlighting of numerous source files
anlambert closed T1845: Add end to end tests for content rendering as Resolved by committing rDWAPPS8421487367a4: cypress: Add end to end tests for content rendering.
anlambert updated the diff for D1672: Add end to end tests for content rendering.
Rebase
Fri, Aug 2
Fri, Aug 2
anlambert committed rCJSWHec692539ecdf: Publish test results and code coverage HTML reports for cypress jobs (authored by anlambert).
Publish test results and code coverage HTML reports for cypress jobs
anlambert closed T1913: Generate HTML report for cypress tests, a subtask of T1841: Run swh-web's front-end tests on Jenkins, as Resolved.
anlambert closed T1913: Generate HTML report for cypress tests as Resolved by committing rCJSWHec692539ecdf: Publish test results and code coverage HTML reports for cypress jobs.
anlambert added a comment to D1804: Jenkins: Publish some HTML reports for cypress jobs.
Yes, I was happily surprised by the results too. Notably, the code coverage report will help to write more relevant cypress tests.
anlambert committed rDWAPPSa01295397a91: cypress: Generate code coverage report in HTML using istanbul (authored by anlambert).
cypress: Generate code coverage report in HTML using istanbul
anlambert committed rDWAPPS6694c17fc939: cypress: Generate test results report in HTML using mochawesome (authored by anlambert).
cypress: Generate test results report in HTML using mochawesome
anlambert retitled D1784: cypress: Test revision diff from cypress: Test origin-diff to cypress: Test revision diff.
Thu, Aug 1
Thu, Aug 1
anlambert requested changes to D1784: cypress: Test revision diff.
Thanks for working on this!
anlambert committed rDWAPPS0f43878e5ec5: debian/control: Explicitely add python3-magic in Depends section (authored by anlambert).
debian/control: Explicitely add python3-magic in Depends section
anlambert committed rDWAPPS0721db0ce7e8: browse/utils: Use python-magic when available instead of file-magic (authored by anlambert).
browse/utils: Use python-magic when available instead of file-magic
anlambert committed rDWAPPScd747b23ec7f: browse/utils: Properly fix the issue with file-magic (authored by anlambert).
browse/utils: Properly fix the issue with file-magic
Wed, Jul 31
Wed, Jul 31
anlambert committed rDWAPPS81e9970a507d: requirements-swh.txt: Bump swh-storage version (authored by anlambert).
requirements-swh.txt: Bump swh-storage version
anlambert committed rDWAPPS5c199f9d36b1: debian/control: Bump swh-storage version (authored by anlambert).
debian/control: Bump swh-storage version
anlambert committed rDCIDXf21d14a63329: api/client: use RPCClient instead of deprecated SWHRemoteAPI (authored by anlambert).
api/client: use RPCClient instead of deprecated SWHRemoteAPI
anlambert updated the diff for D1759: Use RPCClient instead of deprecated SWHRemoteAPI.
Rebase
anlambert committed rDWAPPS1e0f9610cd51: README.md: Update dependencies info (authored by anlambert).
README.md: Update dependencies info
anlambert committed rDWAPPS74a7e9021d17: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert committed rDWAPPS1a65f2e86b21: requirements.txt: Bump minimal required django version (authored by anlambert).
requirements.txt: Bump minimal required django version
anlambert committed rDWAPPScd932368723f: swh-web: Fix debian package build on unstable (authored by anlambert).
swh-web: Fix debian package build on unstable
anlambert committed rDWAPPS7b93b537718b: debian/control: Bump required python3-django version (authored by anlambert).
debian/control: Bump required python3-django version
debian/changelog: New build
anlambert committed rPDJR37d982eb8925: Update changelog to bootstrap backport builds (authored by anlambert).
Update changelog to bootstrap backport builds
debian: Bootstrap stretch-swh build
debian: Bootstrap buster-swh build
anlambert committed rPDJR0c2bf195d0ad: Update changelog to bootstrap backport builds (authored by anlambert).
Update changelog to bootstrap backport builds
debian: Bootstrap buster-swh build
debian: Bootstrap stretch-swh build
debian: Bootstrap stretch-swh build
debian: Bootstrap buster-swh build
anlambert committed rPDJR5509e6e5a5b2: pristine-tar data for django-js-reverse_0.9.1.orig.tar.gz (authored by anlambert).
pristine-tar data for django-js-reverse_0.9.1.orig.tar.gz
New upstream version 0.9.1
anlambert committed rPDJRcb1525a98695: Initial packaging for django-js-reverse (authored by anlambert).
Initial packaging for django-js-reverse
anlambert committed rCJSWHa2eb0647b5bb: dependency-packages: Fix indentation (authored by anlambert).
dependency-packages: Fix indentation
anlambert committed rCJSWH7d149e75cb04: Add python3-django-js-reverse dependency package (authored by anlambert).
Add python3-django-js-reverse dependency package
Tue, Jul 30
Tue, Jul 30
anlambert committed rCDFDba4331941b51: Fix swh-vault service by removing calls to deprecated cli (authored by anlambert).
Fix swh-vault service by removing calls to deprecated cli
anlambert committed rDWAPPS0c963102557f: api/vault: Setup a redirection to fetch gitfast archive (authored by anlambert).
api/vault: Setup a redirection to fetch gitfast archive
anlambert committed rDWAPPSd00fea338279: assets: Replace bootstrap-year-calendar-bs4 by js-year-calendar (authored by anlambert).
assets: Replace bootstrap-year-calendar-bs4 by js-year-calendar
anlambert committed rDWAPPSdad2820da2b8: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert added inline comments to D1774: cypress: Add tests for visits.
Looks good to me. Just a small nitpick: can you rename the cypress test file to origin-visits.spec.js before landing this.