Page MenuHomeSoftware Heritage
People anlambert

anlambert (Antoine Lambert)
User

Projects

User Details

User Since
Jul 3 2017, 10:14 AM (120 w, 2 d)

Recent Activity
View All

Today

anlambert updated the task description for T1891: Make 'type' an attribute of origin visits, not origins.
Thu, Oct 24, 2:16 AM · Web app, Storage manager

Yesterday

anlambert created D2175: Remove origin type references.
Wed, Oct 23, 4:05 PM
anlambert accepted D2174: model: make to_dict() properly recursive.

Looks good !

Wed, Oct 23, 2:21 PM
anlambert accepted D2169: Use a wildcard to get the list of SQL files.
Wed, Oct 23, 2:19 PM
anlambert committed rDWAPPSb3c68754b998: browse/content: Handle invalid query parameter path (authored by anlambert).
browse/content: Handle invalid query parameter path
Wed, Oct 23, 2:16 PM
anlambert committed rDWAPPSd57b4c7dcddc: browse/utils: Handle null person in gen_person_mail_link (authored by anlambert).
browse/utils: Handle null person in gen_person_mail_link
Wed, Oct 23, 2:16 PM
anlambert accepted D2173: Remove origin['type'].

Looks good, bye bye origin type !

Wed, Oct 23, 1:21 PM
anlambert accepted D2172: Add missing files to MANIFEST.in.
Wed, Oct 23, 1:18 PM
anlambert accepted D2171: Move hypothesis strategy definitions to swh/storage/tests/conftest.py.
Wed, Oct 23, 1:18 PM
anlambert accepted D2170: Replace unwanted data.originX['type'] in tests.
Wed, Oct 23, 1:18 PM
anlambert committed rDWAPPS7647f873003f: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, Oct 23, 1:13 PM
anlambert committed rDWAPPS729f9bd18fc9: swh-web: Better handle aliases in snapshot content (authored by anlambert).
swh-web: Better handle aliases in snapshot content
Wed, Oct 23, 1:13 PM
anlambert closed D2168: Better handle aliases in snapshot content.
Wed, Oct 23, 1:13 PM
anlambert committed rDWAPPS0a765b7dc026: swh-web: Use type attribute from visit instead of origin (authored by anlambert).
swh-web: Use type attribute from visit instead of origin
Wed, Oct 23, 1:13 PM
anlambert closed D2167: Use type attribute from visit instead of origin.
Wed, Oct 23, 1:13 PM

Tue, Oct 22

anlambert updated the diff for D2168: Better handle aliases in snapshot content.

Rebase

Tue, Oct 22, 4:05 PM
anlambert updated the diff for D2167: Use type attribute from visit instead of origin.

Update: Fix failing test

Tue, Oct 22, 4:04 PM
anlambert added projects to T1891: Make 'type' an attribute of origin visits, not origins: Storage manager, Web app.
Tue, Oct 22, 3:58 PM · Web app, Storage manager
anlambert created D2168: Better handle aliases in snapshot content.
Tue, Oct 22, 3:47 PM
anlambert created D2167: Use type attribute from visit instead of origin.
Tue, Oct 22, 3:42 PM
anlambert closed T2020: Experiment with keycloak: an open source identity and access management solution, a subtask of T1982: Add user authentication and permissions to swh-web, as Resolved.
Tue, Oct 22, 11:25 AM · Web app
anlambert closed T2020: Experiment with keycloak: an open source identity and access management solution as Resolved.

Closing this as time for experiments is over.

Tue, Oct 22, 11:25 AM · System administration, Web app
anlambert triaged T2048: Integrate Keycloak in Django authentication layer as Normal priority.
Tue, Oct 22, 11:23 AM · Web app

Mon, Oct 21

anlambert closed T2047: Add Save Code Now button on the origin browsing page as Invalid.

In fact, the feature you are looking at is already implemented and deployed. You have to select the Take a new snapshot entry from the Actions menu.
However, I agree this action should be visible without having to open a drop-down menu.

Mon, Oct 21, 3:29 PM · Web app

Tue, Oct 15

anlambert updated the summary of D2131: [POC] Add keycloak service and sample SoftwareHeritage realm.
Tue, Oct 15, 6:02 PM
anlambert updated the diff for D2131: [POC] Add keycloak service and sample SoftwareHeritage realm.

Update: Do not expose 8080 port to host and configure nginx reverse proxy to expose keycloak as http://localhost:5080/keycloak

Tue, Oct 15, 6:01 PM
anlambert committed rCDFJ615ea42711d4: base/Dockerfile: Add missing libffi-dev dependency for swh-indexer (authored by anlambert).
base/Dockerfile: Add missing libffi-dev dependency for swh-indexer
Tue, Oct 15, 2:21 PM
anlambert closed D2143: base/Dockerfile: Add missing libffi-dev dependency for swh-indexer.
Tue, Oct 15, 2:21 PM
anlambert updated the diff for D2143: base/Dockerfile: Add missing libffi-dev dependency for swh-indexer.

Rebase

Tue, Oct 15, 2:20 PM
anlambert created D2143: base/Dockerfile: Add missing libffi-dev dependency for swh-indexer.
Tue, Oct 15, 2:18 PM
anlambert added inline comments to D2131: [POC] Add keycloak service and sample SoftwareHeritage realm.
Tue, Oct 15, 12:05 PM
anlambert accepted D2139: npm.tests: Add an integration test on listing with pagination.

Looks good !

Tue, Oct 15, 12:03 PM
anlambert closed T1858: Immediately download archive if already cooked by the vault as Resolved by committing rDWAPPS3d2673cd9fcf: vault: Immediately download archive if already cooked.
Tue, Oct 15, 10:59 AM · Web app
anlambert committed rDWAPPS3d2673cd9fcf: vault: Immediately download archive if already cooked (authored by anlambert).
vault: Immediately download archive if already cooked
Tue, Oct 15, 10:59 AM
anlambert closed D1727: Immediately download archive if already cooked by the vault.
Tue, Oct 15, 10:59 AM
anlambert updated the diff for D1727: Immediately download archive if already cooked by the vault.

Update: Add task reference in commit message

Tue, Oct 15, 10:47 AM

Fri, Oct 11

anlambert retitled D2131: [POC] Add keycloak service and sample SoftwareHeritage realm from [POC] Add keycloack service and sample SoftwareHeritage realm to [POC] Add keycloak service and sample SoftwareHeritage realm.
Fri, Oct 11, 5:45 PM
anlambert updated the summary of D2131: [POC] Add keycloak service and sample SoftwareHeritage realm.
Fri, Oct 11, 5:44 PM
anlambert updated the summary of D2131: [POC] Add keycloak service and sample SoftwareHeritage realm.
Fri, Oct 11, 5:42 PM
anlambert updated the summary of D2130: [POC] Integrate Keycloak to authenticate users and manage permissions.
Fri, Oct 11, 4:57 PM
anlambert created D2131: [POC] Add keycloak service and sample SoftwareHeritage realm.
Fri, Oct 11, 4:57 PM
anlambert created D2130: [POC] Integrate Keycloak to authenticate users and manage permissions.
Fri, Oct 11, 4:51 PM
anlambert updated the summary of D1727: Immediately download archive if already cooked by the vault.
Fri, Oct 11, 1:25 PM

Thu, Oct 10

anlambert updated the diff for D1727: Immediately download archive if already cooked by the vault.

Update: Really fix vault tests and add new ones to validate the new feature

Thu, Oct 10, 5:47 PM
anlambert updated the diff for D1727: Immediately download archive if already cooked by the vault.

Update: Fix vault cypress tests

Thu, Oct 10, 5:16 PM
anlambert updated the summary of D1727: Immediately download archive if already cooked by the vault.
Thu, Oct 10, 5:01 PM
anlambert updated the diff for D1727: Immediately download archive if already cooked by the vault.

Implement new vault UI feature after commandeering the diff.

Thu, Oct 10, 4:59 PM
anlambert committed rDWAPPS128d6e4eba8d: webpack: Reinstate cache-loader use for faster app reload in devserver (authored by anlambert).
webpack: Reinstate cache-loader use for faster app reload in devserver
Thu, Oct 10, 4:58 PM
anlambert retitled D1727: Immediately download archive if already cooked by the vault from [WIP] Immediately download archive if already cooked by the vault to Immediately download archive if already cooked by the vault.
Thu, Oct 10, 4:57 PM
anlambert commandeered D1727: Immediately download archive if already cooked by the vault.

Commandeering this as the diff has not been updated by its original author since two months.

Thu, Oct 10, 4:52 PM
anlambert accepted D2111: Add tests for the api-1-origin-search endpoint..
Thu, Oct 10, 2:23 PM
anlambert accepted D2112: Remove indirection swh.web.wsgi to start server.

I'm not sure we want to integrate it in the makefile though ¯\_(ツ)_/¯

Thu, Oct 10, 1:12 PM
anlambert requested changes to D2112: Remove indirection swh.web.wsgi to start server.
Thu, Oct 10, 12:13 PM
anlambert requested changes to D2112: Remove indirection swh.web.wsgi to start server.

There is also a reference to the wsgi module in Makefile.local

Thu, Oct 10, 12:07 PM
anlambert accepted D2103: Add test for the api-1-origins endpoint..

Looks good to me.

Thu, Oct 10, 10:44 AM

Wed, Oct 9

anlambert committed rDWAPPS89a5e4662a64: browse/snapshot_context: Cleanup some code (authored by anlambert).
browse/snapshot_context: Cleanup some code
Wed, Oct 9, 2:39 PM
anlambert committed rDWAPPS9cb405a3dc98: browse/snapshot_context: Fix regression when requesting invalid branch (authored by anlambert).
browse/snapshot_context: Fix regression when requesting invalid branch
Wed, Oct 9, 2:39 PM
anlambert committed rDWAPPSe65b8a98280c: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, Oct 9, 2:39 PM
anlambert accepted D2098: Deprecate the offset parameter of api_origin_search..
Wed, Oct 9, 2:10 PM
anlambert accepted D2086: Deprecate the origin_from query parameter of api_origins..

Looks good, thanks for the detailed explanation.

Wed, Oct 9, 2:10 PM

Thu, Oct 3

anlambert triaged T2030: Certficate for https://stats.export.softwareheritage.org/ has expired as High priority.
Thu, Oct 3, 10:44 AM · System administration
anlambert accepted D2063: cypress: Vault item removal test.

Looks good, thanks !

Thu, Oct 3, 10:36 AM
anlambert accepted D2070: add optional mypy invocation to the CI pipeline (swh-pipeline).

Looks good to me.

Thu, Oct 3, 10:30 AM

Wed, Oct 2

anlambert accepted D2068: test_storage: Use the db_transaction context manager instead of raw connections.

Looks clearer indeed.

Wed, Oct 2, 5:57 PM
anlambert accepted D2067: test_storage: introduce a db_transaction context manager.
Wed, Oct 2, 5:54 PM
anlambert accepted D2066: Postgres storage: introduce a db() context manager.
Wed, Oct 2, 5:53 PM
anlambert accepted D2065: Replace all 'inmemory' journal writers with 'memory'.

+1, these warnings were so annoying considering their amount

Wed, Oct 2, 5:52 PM
anlambert accepted D2064: test_storage: Close all pool connections on teardown.
Wed, Oct 2, 5:51 PM
anlambert added a comment to T2029: cran lister: Align lister to output list of tarballs per origin (if possible).

In order to list all available versions of a R package hosted on CRAN, the versions package could be used.

Wed, Oct 2, 11:19 AM · Origin-CRAN, Archive coverage
anlambert accepted D2062: cran.lister: Refactor and fix cran lister.
Wed, Oct 2, 11:04 AM
anlambert accepted D2061: Dockerfile: Add missing r-base-core package for lister (cran).

Right, we depend on a R package to list all R packages.

Wed, Oct 2, 10:39 AM

Tue, Oct 1

anlambert committed rDWAPPS0055ed10bec5: requests: Set timeout to prevent hangs when querying external services (authored by anlambert).
requests: Set timeout to prevent hangs when querying external services
Tue, Oct 1, 5:49 PM
anlambert closed D2057: requests: Set timeout to prevent hangs when querying external services.
Tue, Oct 1, 5:49 PM
anlambert created D2057: requests: Set timeout to prevent hangs when querying external services.
Tue, Oct 1, 4:41 PM
anlambert added a comment to T2028: swh-web should use a proper elasticsearch library to do its requests.

Indeed, I forgot the requests module does not set any default timeout value and will hang until the connection is closed.

Tue, Oct 1, 4:20 PM · Web app
anlambert added a project to T2020: Experiment with keycloak: an open source identity and access management solution: System administration.
Tue, Oct 1, 12:00 PM · System administration, Web app
anlambert triaged T2020: Experiment with keycloak: an open source identity and access management solution as Normal priority.
Tue, Oct 1, 11:59 AM · System administration, Web app
anlambert committed rDLDBASE2a0b2edb23e9: core/loader: Retry contents loading on HashCollision errors (authored by anlambert).
core/loader: Retry contents loading on HashCollision errors
Tue, Oct 1, 11:33 AM
anlambert closed D2052: core/loader: Retry contents loading on HashCollision errors.
Tue, Oct 1, 11:33 AM
anlambert raised the priority of T1226: Save code now email notification for submitter from Wishlist to Normal.
Tue, Oct 1, 10:59 AM · Web app
anlambert created D2052: core/loader: Retry contents loading on HashCollision errors.
Tue, Oct 1, 10:55 AM

Mon, Sep 30

anlambert added inline comments to D2041: Add test triggering the race condition in content_add.
Mon, Sep 30, 2:42 PM
anlambert accepted D2041: Add test triggering the race condition in content_add.

Looks good to me ! I was also trying to write such a test but you were faster.

Mon, Sep 30, 2:34 PM

Fri, Sep 27

anlambert committed rDWAPPSe10bae79da35: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Fri, Sep 27, 4:32 PM
anlambert committed rDWAPPSdfc83bba4180: origin-save: Mark a save request as succeed when task completed (authored by anlambert).
origin-save: Mark a save request as succeed when task completed
Fri, Sep 27, 4:32 PM
anlambert committed rDWAPPSd3f6b6c83ee4: templates/homepage: Reinstate counters dropped in eb570673144c (authored by anlambert).
templates/homepage: Reinstate counters dropped in eb570673144c
Fri, Sep 27, 4:32 PM
anlambert committed rDWAPPS74d97d921f5c: templates/homepage: Reorganize layout and add link to Support page (authored by anlambert).
templates/homepage: Reorganize layout and add link to Support page
Fri, Sep 27, 4:32 PM
anlambert closed T2008: phase out wordpress archive page in favor of archive.s.o as Resolved by committing rDWAPPS74d97d921f5c: templates/homepage: Reorganize layout and add link to Support page.
Fri, Sep 27, 4:32 PM · Unknown Object (Project), Web app, Website
anlambert committed rDWAPPS00c006df690d: cypress: Improve tests performance by tweaking coverage tasks (authored by anlambert).
cypress: Improve tests performance by tweaking coverage tasks
Fri, Sep 27, 4:32 PM
anlambert committed rDWAPPSb2a663c8b12d: cypress: Rework code to save coverage for each page in a test (authored by anlambert).
cypress: Rework code to save coverage for each page in a test
Fri, Sep 27, 4:32 PM

Thu, Sep 26

anlambert added a comment to T2008: phase out wordpress archive page in favor of archive.s.o.

Almost all points have been treated and deployed to production (see https://www.softwareheritage.org/).

Thu, Sep 26, 6:26 PM · Unknown Object (Project), Web app, Website
anlambert closed T2011: Revamp "Support" page as Resolved.

Closing this as the revamped support page is now deployed to production for all languages: https://www.softwareheritage.org/support/

Thu, Sep 26, 6:23 PM · Unknown Object (Project), Web app, Website
anlambert closed T2011: Revamp "Support" page, a subtask of T2008: phase out wordpress archive page in favor of archive.s.o, as Resolved.
Thu, Sep 26, 6:23 PM · Unknown Object (Project), Web app, Website
anlambert added a comment to T2008: phase out wordpress archive page in favor of archive.s.o.

We only have counters history data for contents, revisions and origins (see history_counters.json).

Thu, Sep 26, 10:39 AM · Unknown Object (Project), Web app, Website

Wed, Sep 25

anlambert added a comment to T2008: phase out wordpress archive page in favor of archive.s.o.

I have deployed a new version of https://archive.softwareheritage.org including the archive evolution graphs on the homepage.

Wed, Sep 25, 5:50 PM · Unknown Object (Project), Web app, Website
anlambert added a comment to T2011: Revamp "Support" page.

Yes we can. I have updated the page accordingly.

Wed, Sep 25, 5:46 PM · Unknown Object (Project), Web app, Website
anlambert added a comment to T2011: Revamp "Support" page.

First draft of the revamped support page can be found here: https://www-dev.softwareheritage.org/support/

Wed, Sep 25, 5:11 PM · Unknown Object (Project), Web app, Website
anlambert committed rDWAPPS72a539998bac: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, Sep 25, 4:17 PM
anlambert committed rDWAPPSf186e96d86ec: templates/layout.html: Remove archive link in top bar (authored by anlambert).
templates/layout.html: Remove archive link in top bar
Wed, Sep 25, 4:17 PM
anlambert committed rDWAPPSeb570673144c: homepage: Add archive evolution over time graphs (authored by anlambert).
homepage: Add archive evolution over time graphs
Wed, Sep 25, 4:17 PM
About · Developer information · Legal