- User Since
- Jul 3 2017, 10:14 AM (102 w, 3 d)
Oh did not spot this. I think it was originally sorted by endpoints but some columns of the table were removed since then and we forgot to update the ordering.
Well seen !
Tue, Jun 18
The use of Google ReCAPTCHA is now dropped in favor of rate limiting the number of save requests a user can create through the form (10/h).
Great, thanks! You can rebase and land it.
@kalpitk , looks good ! You can land it.
Looks good to me
Mon, Jun 17
I should have read django-simple-captcha doc, indeed its integration is not really straightforward for swh-web.
Diff accepted but let's land D1583 first (see inline comment).
Nice! I agree with @vlorentz , you should split the tests into two spec files: sidebar.spec.js and back-to-top.spec.js. Once it is done, that diff can be landed.
Just a small change to do and I will accept the diff.
Sat, Jun 8
Fri, Jun 7
Update: Ensure grecaptcha is desactivated for e2e tests
Update: Remove unused file and resentence some tests description
Closed by d355d8973205
These tests will be redundant with the end to end ones, so closing that task and prefer to rely on using cypress for frontend testing.
Abandoning this in favor of D1565
Thu, Jun 6
@shisus , I have tested cypress and the tool is indeed quite awesome !
Just a couple of nitpicks for small screens (see screenshot below):
- Can you slightly move the popover to the right in order to see its borders ?
- The Permalinks button should not overlap the popover
Wed, Jun 5
Tue, Jun 4
Thanks for pointing out the cypress tool, it looks pretty interesting.
Based on my understanding, it could be used to write and run unit tests but also end to end ones.
Still some improvements to bring.
Wed, May 29
Better indeed !
Nice improvements but that diff is not landable as is (see my inline comments).
Tue, May 28
In order to implement the unit tests, we will need the following node modules:
Update: Remove the commit related to trailing whitespaces
Mon, May 27
npm is now archived continuously by Software Heritage (see for instance: https://archive.softwareheritage.org/browse/origin/https://www.npmjs.com/package/webpack/).