Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

Projects

User Details

User Since
Jul 3 2017, 10:14 AM (143 w, 2 d)

Recent Activity

Yesterday

anlambert created D2943: tests: Fix new failing ones after changes in swh-model.
Wed, Apr 1, 11:56 PM
anlambert created D2942: hypothesis: Fix some issues in snapshots strategy and add tests.
Wed, Apr 1, 11:54 PM
anlambert committed rDWAPPS577ce651e9df: browse/release: Add link to directory for revision target type (authored by anlambert).
browse/release: Add link to directory for revision target type
Wed, Apr 1, 9:10 PM
anlambert closed D2935: browse/release: Add link to directory for revision target type.
Wed, Apr 1, 9:10 PM
anlambert updated the diff for D2935: browse/release: Add link to directory for revision target type.

Update: Add comment explaining why return value of service.lookup_directory is not used in release view implementation

Wed, Apr 1, 8:57 PM
anlambert added inline comments to D2935: browse/release: Add link to directory for revision target type.
Wed, Apr 1, 8:53 PM
anlambert added inline comments to D2896: Keycloak: add realm and client definition in puppet manifest.
Wed, Apr 1, 6:42 PM
anlambert added inline comments to D2896: Keycloak: add realm and client definition in puppet manifest.
Wed, Apr 1, 6:39 PM
anlambert added inline comments to D2896: Keycloak: add realm and client definition in puppet manifest.
Wed, Apr 1, 6:29 PM
anlambert requested changes to D2896: Keycloak: add realm and client definition in puppet manifest.

Thanks for the improvements !

Wed, Apr 1, 6:09 PM
anlambert created P634 Keycloak puppet run success.
Wed, Apr 1, 6:08 PM
anlambert updated the title for P633 Keycloak puppet run failure from Keycloak puppet run to Keycloak puppet run failure.
Wed, Apr 1, 6:08 PM
anlambert added a comment to T2153: SWH PIDs as an "Alternate Identifier" in Zenodo.

That's great news \o/ !

Wed, Apr 1, 5:36 PM · Scientific Community Building
anlambert created P633 Keycloak puppet run failure.
Wed, Apr 1, 5:06 PM
anlambert updated the diff for D2877: auth: Add OIDC session silent refresh middleware.
  • Rebase
  • Modify comment in middleware
  • Fix typo in test variable
Wed, Apr 1, 2:17 PM
anlambert added inline comments to D2877: auth: Add OIDC session silent refresh middleware.
Wed, Apr 1, 12:43 PM
anlambert added a comment to D2877: auth: Add OIDC session silent refresh middleware.

Sorry I didn't review this sooner, not sure why I didn't see the diff.


What is login_data['prompt']?

Wed, Apr 1, 12:41 PM

Tue, Mar 31

anlambert planned changes to D2936: [WIP] loader-mercurial: Port to swh-model objects instead of dicts.
Tue, Mar 31, 9:49 PM
anlambert created D2936: [WIP] loader-mercurial: Port to swh-model objects instead of dicts.
Tue, Mar 31, 9:48 PM
anlambert created D2935: browse/release: Add link to directory for revision target type.
Tue, Mar 31, 6:45 PM
anlambert added a comment to D2934: Use a shorter format for the git logs shown on Phabricator..

yes, i know.
But i think that's an edge case...

of 1. that diff should be splitted if possible

  1. Also the pb might not be with the git commit too long...
Tue, Mar 31, 5:30 PM
anlambert committed rDWAPPSf9172f8a395b: hypothesis: Fix or ignore deprecation warnings since version 5.6 (authored by anlambert).
hypothesis: Fix or ignore deprecation warnings since version 5.6
Tue, Mar 31, 4:58 PM
anlambert closed D2933: hypothesis: Fix or ignore deprecation warnings since version 5.6.
Tue, Mar 31, 4:58 PM
anlambert updated the diff for D2933: hypothesis: Fix or ignore deprecation warnings since version 5.6.

Update: Use session-scoped fixture instead of module-scoped fixture

Tue, Mar 31, 4:49 PM
anlambert added a comment to D2933: hypothesis: Fix or ignore deprecation warnings since version 5.6.

These fixtures could even be session-scoped

Tue, Mar 31, 4:47 PM
anlambert updated the diff for D2877: auth: Add OIDC session silent refresh middleware.

Rebase

Tue, Mar 31, 4:17 PM
anlambert updated the diff for D2933: hypothesis: Fix or ignore deprecation warnings since version 5.6.

Rebase

Tue, Mar 31, 4:16 PM
anlambert committed rDWAPPS717159e4594e: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Tue, Mar 31, 4:14 PM
anlambert committed rDWAPPSc0baf47fb30e: browse: Fix pagination links display issue in branches / releases views (authored by anlambert).
browse: Fix pagination links display issue in branches / releases views
Tue, Mar 31, 4:14 PM
anlambert closed D2920: browse: Fix pagination links display issue in branches / releases views.
Tue, Mar 31, 4:14 PM
anlambert triaged T2342: Add resolving of new PIDs contextual information as Normal priority.
Tue, Mar 31, 4:13 PM · Web app
anlambert updated the summary of D2933: hypothesis: Fix or ignore deprecation warnings since version 5.6.
Tue, Mar 31, 4:04 PM
anlambert created D2933: hypothesis: Fix or ignore deprecation warnings since version 5.6.
Tue, Mar 31, 4:00 PM
anlambert updated the diff for D2920: browse: Fix pagination links display issue in branches / releases views.

Rebase + add commit upgrading yarn dependencies (notably cypress)

Tue, Mar 31, 3:56 PM
anlambert committed rDWAPPSfc6dc3512610: cypress: Fix flaky tests related to sidebar (authored by anlambert).
cypress: Fix flaky tests related to sidebar
Tue, Mar 31, 3:53 PM
anlambert closed T2341: Flaky frontend test in cypress as Resolved by committing rDWAPPSfc6dc3512610: cypress: Fix flaky tests related to sidebar.
Tue, Mar 31, 3:53 PM · Web app
anlambert closed D2932: cypress: Fix flaky tests related to sidebar.
Tue, Mar 31, 3:53 PM
anlambert updated the diff for D2932: cypress: Fix flaky tests related to sidebar.
  • Set sidebar state (collapsed / expanded) once css animation has finished in order to make associated cypress test reliable.
Tue, Mar 31, 3:11 PM
anlambert added a comment to D2932: cypress: Fix flaky tests related to sidebar.

Current fix is unfortunately not valid. I need to dig further on this.

Tue, Mar 31, 1:40 PM
anlambert added a comment to D2932: cypress: Fix flaky tests related to sidebar.

I will restart the build a couple of times before landing the diff to be sure it effectively fixes the issue.

Tue, Mar 31, 12:58 PM
anlambert created D2932: cypress: Fix flaky tests related to sidebar.
Tue, Mar 31, 12:46 PM
anlambert updated the diff for D2920: browse: Fix pagination links display issue in branches / releases views.

Rebase

Tue, Mar 31, 12:10 PM
anlambert committed rDWAPPSf8ac17e10778: templates/homepage: Fix counters display when storage is empty (authored by anlambert).
templates/homepage: Fix counters display when storage is empty
Tue, Mar 31, 12:09 PM
anlambert closed D2913: templates/homepage: Fix counters display when storage is empty.
Tue, Mar 31, 12:09 PM
anlambert updated the diff for D2913: templates/homepage: Fix counters display when storage is empty.

Rebase

Tue, Mar 31, 11:55 AM
anlambert added a comment to T2341: Flaky frontend test in cypress.

I saw that too, will look at it.

Tue, Mar 31, 11:17 AM · Web app

Mon, Mar 30

anlambert accepted D2930: exclude test resources from radon tests.
Mon, Mar 30, 8:16 PM
anlambert added a comment to T2340: Improve handling of file names with special characters.

I do not encounter any particular issue when trying to browse these files. Their content is equal to their filename so the confusion I think.

Mon, Mar 30, 5:08 PM · Web app
anlambert updated the diff for D2913: templates/homepage: Fix counters display when storage is empty.

Update: Add cypress test

Mon, Mar 30, 2:35 PM
anlambert updated the diff for D2920: browse: Fix pagination links display issue in branches / releases views.

Update: Add new test description in docstring

Mon, Mar 30, 1:53 PM

Fri, Mar 27

anlambert created D2920: browse: Fix pagination links display issue in branches / releases views.
Fri, Mar 27, 6:55 PM
anlambert created D2913: templates/homepage: Fix counters display when storage is empty.
Fri, Mar 27, 4:11 PM
anlambert updated the summary of D2877: auth: Add OIDC session silent refresh middleware.
Fri, Mar 27, 12:27 PM
anlambert committed rDWAPPSd4446bcac766: auth/backends: Simplify and improve OIDC authentication (authored by anlambert).
auth/backends: Simplify and improve OIDC authentication
Fri, Mar 27, 12:27 PM
anlambert closed D2876: auth/backends: Simplify and improve OIDC authentication.
Fri, Mar 27, 12:27 PM
anlambert committed rDENV2979481c2b28: docker: Add optional keycloak service and configure its use in swh-web (authored by anlambert).
docker: Add optional keycloak service and configure its use in swh-web
Fri, Mar 27, 12:25 PM
anlambert closed D2774: docker: Add keycloak service and configure its use in swh-web.
Fri, Mar 27, 12:25 PM
anlambert added a comment to D2896: Keycloak: add realm and client definition in puppet manifest.

I think we might want separate realms for production, staging and "localhost testing". At the very least, we will want separate clients, because I don't think application credentials and user sessions should be shared across the different usecases.

Fri, Mar 27, 12:24 PM
anlambert updated the diff for D2774: docker: Add keycloak service and configure its use in swh-web.

Update commit message

Fri, Mar 27, 12:19 PM
anlambert added a comment to D2896: Keycloak: add realm and client definition in puppet manifest.

If you agree with this I'm happy to pick this diff up to implement the idea.

Fri, Mar 27, 12:11 PM
anlambert committed rCJSWHecf197f4b444: jobs/templates: Fix cypress jobs after Jenkins upgrade (authored by anlambert).
jobs/templates: Fix cypress jobs after Jenkins upgrade
Fri, Mar 27, 12:07 PM
anlambert closed D2904: jobs/templates: Fix cypress jobs after Jenkins upgrade.
Fri, Mar 27, 12:07 PM
anlambert created D2904: jobs/templates: Fix cypress jobs after Jenkins upgrade.
Fri, Mar 27, 12:01 PM
anlambert updated the diff for D2877: auth: Add OIDC session silent refresh middleware.

Rebase

Fri, Mar 27, 10:34 AM
anlambert updated the diff for D2876: auth/backends: Simplify and improve OIDC authentication.

Rebase

Fri, Mar 27, 10:33 AM
anlambert updated the diff for D2896: Keycloak: add realm and client definition in puppet manifest.

Update: Fix missing protocol in redirect uri

Fri, Mar 27, 10:20 AM
anlambert updated the diff for D2896: Keycloak: add realm and client definition in puppet manifest.

Update: Add more redirect uris and add missing calls to lookup

Fri, Mar 27, 10:00 AM
anlambert added inline comments to D2896: Keycloak: add realm and client definition in puppet manifest.
Fri, Mar 27, 9:55 AM

Thu, Mar 26

anlambert updated the diff for D2774: docker: Add keycloak service and configure its use in swh-web.

Update: Remove SoftwareHeritage realm JSON export file and prefer to use
Keycloak admin API through python-keycloak to define realm and swh-web
client when keycloak service starts.

Thu, Mar 26, 11:22 PM
anlambert updated the diff for D2877: auth: Add OIDC session silent refresh middleware.

Rebase

Thu, Mar 26, 9:37 PM
anlambert updated the summary of D2876: auth/backends: Simplify and improve OIDC authentication.
Thu, Mar 26, 9:35 PM
anlambert updated the diff for D2876: auth/backends: Simplify and improve OIDC authentication.

Update: Check groups claim is present in decoded token before trying to read it.

Thu, Mar 26, 9:35 PM
anlambert added a reviewer for D2896: Keycloak: add realm and client definition in puppet manifest: olasd.
Thu, Mar 26, 9:29 PM
anlambert updated the summary of D2896: Keycloak: add realm and client definition in puppet manifest.
Thu, Mar 26, 9:28 PM
anlambert updated the summary of D2896: Keycloak: add realm and client definition in puppet manifest.
Thu, Mar 26, 9:28 PM
anlambert updated the summary of D2896: Keycloak: add realm and client definition in puppet manifest.
Thu, Mar 26, 9:28 PM
anlambert created D2896: Keycloak: add realm and client definition in puppet manifest.
Thu, Mar 26, 9:28 PM
anlambert accepted D2884: model: fix SkippedContent origin to be a str.

Looks good to me but you should add a test. Ci build seems to fail because some landed diffs are still referenced in dependencies stack (2814 -> 2818).

Thu, Mar 26, 12:08 PM

Wed, Mar 25

anlambert closed T2331: Improve handling of GitLab origins in Save Code Now requests as Resolved.

The patch hopefully fixes all type of git repository urls. I think you got mistaken by the frontend test, the real fix is in the regexp modification.
Nervertheless, this is not deployed yet.

Wed, Mar 25, 6:41 PM · Web app
anlambert committed rDWAPPSdc89829a02eb: assets/utils: Validate sub-projects in isGitRepoUrl function (authored by anlambert).
assets/utils: Validate sub-projects in isGitRepoUrl function
Wed, Mar 25, 6:05 PM
anlambert closed T2331: Improve handling of GitLab origins in Save Code Now requests as Resolved by committing rDWAPPSdc89829a02eb: assets/utils: Validate sub-projects in isGitRepoUrl function.
Wed, Mar 25, 6:05 PM · Web app
anlambert closed D2878: assets/utils: Validate sub-projects in isGitRepoUrl function.
Wed, Mar 25, 6:05 PM
anlambert created D2878: assets/utils: Validate sub-projects in isGitRepoUrl function.
Wed, Mar 25, 5:11 PM
anlambert updated the diff for D2877: auth: Add OIDC session silent refresh middleware.

Rebase

Wed, Mar 25, 2:08 PM
anlambert updated the diff for D2876: auth/backends: Simplify and improve OIDC authentication.

Update some comments and docstrings.

Wed, Mar 25, 2:07 PM
anlambert created D2877: auth: Add OIDC session silent refresh middleware.
Wed, Mar 25, 2:04 PM
anlambert created D2876: auth/backends: Simplify and improve OIDC authentication.
Wed, Mar 25, 1:59 PM

Tue, Mar 24

anlambert changed the status of T2267: Check OIDC user session state in backend, a subtask of T2048: Use OpenID Connect to authenticate and authorize users in Django, from Open to Work in Progress.
Tue, Mar 24, 3:28 PM · Web app
anlambert changed the status of T2267: Check OIDC user session state in backend from Open to Work in Progress.
Tue, Mar 24, 3:28 PM · Web app
anlambert committed rDWCLI492be567e272: client: Add OpenID Connect bearer token authentication (authored by anlambert).
client: Add OpenID Connect bearer token authentication
Tue, Mar 24, 12:08 PM
anlambert closed D2869: client: Add OpenID Connect bearer token authentication.
Tue, Mar 24, 12:08 PM
anlambert closed T2268: Add a CLI tool to ease the retrieval of authentication tokens , a subtask of T2219: Authentication / authorization, as Resolved.
Tue, Mar 24, 12:08 PM · Restricted Project
anlambert committed rDWCLI842b7bc7ca92: cli: Add auth command group (authored by anlambert).
cli: Add auth command group
Tue, Mar 24, 12:08 PM
anlambert closed D2861: cli: Add auth command group.
Tue, Mar 24, 12:08 PM
anlambert closed T2268: Add a CLI tool to ease the retrieval of authentication tokens as Resolved by committing rDWCLI842b7bc7ca92: cli: Add auth command group.
Tue, Mar 24, 12:08 PM · Web app
anlambert updated the diff for D2869: client: Add OpenID Connect bearer token authentication.

Update commit message

Tue, Mar 24, 12:06 PM
anlambert updated the summary of D2869: client: Add OpenID Connect bearer token authentication.
Tue, Mar 24, 12:04 PM
anlambert updated the diff for D2869: client: Add OpenID Connect bearer token authentication.

Rebase

Tue, Mar 24, 12:04 PM
anlambert retitled D2861: cli: Add auth command group from cli: Add authentication command groups to cli: Add auth command group.
Tue, Mar 24, 11:57 AM
anlambert updated the diff for D2861: cli: Add auth command group.

Update: Rename command group from authentication to auth

Tue, Mar 24, 11:56 AM