Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

Projects (7)

User Details

User Since
Jul 3 2017, 10:14 AM (224 w, 4 d)

Recent Activity

Today

anlambert closed T3645: cgit: handle "429 Too Many Requests" errors as Resolved.

Fixed in swh-lister v2.2.0 and deployed to production, closing this.

Fri, Oct 22, 5:16 PM · Origin-CGit, CGit lister
anlambert closed T3686: svn: Add missing coverage on svn implementation as Resolved by committing rDLDSVN6578b85dd024: loader: Fix SvnLoaderFromDumpArchive and add test.
Fri, Oct 22, 5:09 PM · SVN Loader
anlambert closed D6542: loader: Fix SvnLoaderFromDumpArchive and add test.
Fri, Oct 22, 5:09 PM
anlambert committed rDLDSVN6578b85dd024: loader: Fix SvnLoaderFromDumpArchive and add test (authored by anlambert).
loader: Fix SvnLoaderFromDumpArchive and add test
Fri, Oct 22, 5:09 PM
anlambert added a revision to T3686: svn: Add missing coverage on svn implementation: D6542: loader: Fix SvnLoaderFromDumpArchive and add test.
Fri, Oct 22, 4:55 PM · SVN Loader
anlambert added a comment to T3675: Investigate why cran origins are marked as non-visited in the scheduler metrics.

drop the computation done in the archive coverage part for those origins.

Fri, Oct 22, 3:36 PM · Scheduling utilities
anlambert closed D6540: cgit: Enable to retry throttled HTTP requests.
Fri, Oct 22, 3:19 PM
anlambert committed rDLS24bc67167900: cgit: Enable to retry throttled HTTP requests (authored by anlambert).
cgit: Enable to retry throttled HTTP requests
Fri, Oct 22, 3:19 PM
anlambert added a revision to T3645: cgit: handle "429 Too Many Requests" errors: D6540: cgit: Enable to retry throttled HTTP requests.
Fri, Oct 22, 3:15 PM · Origin-CGit, CGit lister
anlambert created P1207 (An Untitled Masterwork).
Fri, Oct 22, 2:59 PM
anlambert closed D6539: cran: Fix ListedOrigin visit type.
Fri, Oct 22, 2:57 PM
anlambert committed rDLS20232cc36ea7: cran: Fix ListedOrigin visit type (authored by anlambert).
cran: Fix ListedOrigin visit type
Fri, Oct 22, 2:57 PM
anlambert requested review of D6539: cran: Fix ListedOrigin visit type.
Fri, Oct 22, 2:46 PM
anlambert added a revision to T3675: Investigate why cran origins are marked as non-visited in the scheduler metrics: D6539: cran: Fix ListedOrigin visit type.
Fri, Oct 22, 2:44 PM · Scheduling utilities
anlambert accepted D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
Fri, Oct 22, 12:08 PM
anlambert closed D6533: algos/revisions_walker: Handle case of revision without committer date.
Fri, Oct 22, 11:56 AM
anlambert committed rDSTO49a932c98936: algos/revisions_walker: Handle case of revision without committer date (authored by anlambert).
algos/revisions_walker: Handle case of revision without committer date
Fri, Oct 22, 11:56 AM
anlambert closed D6532: test_revisions_walker: Migrate from unittest to pytest.
Fri, Oct 22, 11:55 AM
anlambert committed rDSTOc02be8ebacf3: test_revisions_walker: Migrate from unittest to pytest (authored by anlambert).
test_revisions_walker: Migrate from unittest to pytest
Fri, Oct 22, 11:55 AM
anlambert added inline comments to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
Fri, Oct 22, 11:54 AM
anlambert requested changes to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
Fri, Oct 22, 11:44 AM
anlambert added a comment to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.

This is the same diff as D6536 no ?

Fri, Oct 22, 11:42 AM
anlambert added a comment to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.

This is the same diff as D6536 no ?

Fri, Oct 22, 11:41 AM
anlambert accepted D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
Fri, Oct 22, 11:39 AM
anlambert added a comment to T3685: Our pip usage is broken since a recent pip release.

The issue has been fixed upstream and will be part of next pip release.

Fri, Oct 22, 11:38 AM · Development environment
anlambert closed D6535: templates/revision-info: Display author fullname when name is None.
Fri, Oct 22, 11:33 AM
anlambert committed rDWAPPS0da5060e6f24: templates/revision-info: Display author fullname when name is None (authored by anlambert).
templates/revision-info: Display author fullname when name is None
Fri, Oct 22, 11:33 AM
anlambert updated the diff for D6533: algos/revisions_walker: Handle case of revision without committer date.

Improve comment

Fri, Oct 22, 11:33 AM
anlambert accepted D6441: Deprecate /browse/origin/log/ URLs.

Looks good to me, thanks ! I added a last batch of nitpick comments to handle before landing this.

Fri, Oct 22, 11:29 AM
anlambert accepted D6536: Restrict the click version to avoid conflict version with celery's.

Looks good to me, I can also reproduce the issues after click upgrade to 8.x.

Fri, Oct 22, 11:13 AM
anlambert added inline comments to D6533: algos/revisions_walker: Handle case of revision without committer date.
Fri, Oct 22, 10:55 AM

Yesterday

anlambert requested review of D6535: templates/revision-info: Display author fullname when name is None.
Thu, Oct 21, 5:40 PM
anlambert added inline comments to D6534: Migrate idrac documentation to sysadm docs.
Thu, Oct 21, 5:36 PM
anlambert requested review of D6533: algos/revisions_walker: Handle case of revision without committer date.
Thu, Oct 21, 5:26 PM
anlambert requested review of D6532: test_revisions_walker: Migrate from unittest to pytest.
Thu, Oct 21, 5:24 PM
anlambert requested changes to D6441: Deprecate /browse/origin/log/ URLs.

This is moving forward, great ! I added a couple of inline comments to handle.

Thu, Oct 21, 4:28 PM
anlambert closed D6531: services/keycloak: Update keycloak_swh_setup.py script.
Thu, Oct 21, 3:20 PM
anlambert committed rDENVaa331105560e: services/keycloak: Update keycloak_swh_setup.py script (authored by anlambert).
services/keycloak: Update keycloak_swh_setup.py script
Thu, Oct 21, 3:20 PM
anlambert requested review of D6531: services/keycloak: Update keycloak_swh_setup.py script.
Thu, Oct 21, 3:06 PM
anlambert closed D6528: keycloak: Add swh.web.admin.list_deposits role to swh-web client.
Thu, Oct 21, 2:34 PM
anlambert committed rSPSITEe7759626904c: keycloak: Add swh.web.admin.list_deposits role to swh-web client (authored by anlambert).
keycloak: Add swh.web.admin.list_deposits role to swh-web client
Thu, Oct 21, 2:34 PM
anlambert added a reviewer for D6528: keycloak: Add swh.web.admin.list_deposits role to swh-web client: Reviewers.
Thu, Oct 21, 2:33 PM
anlambert requested review of D6528: keycloak: Add swh.web.admin.list_deposits role to swh-web client.
Thu, Oct 21, 2:33 PM
anlambert abandoned D6519: Jenkins job for swh-docs diffs test.

Jenkins CI job for building SWH docs when submitting diffs to swh-docs is now properly deployed and configured, time to abandon this.

Thu, Oct 21, 2:21 PM
anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.

Make the build passes again for last test.

Thu, Oct 21, 2:08 PM
anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.

Introduce warning to check the CI build fails

Thu, Oct 21, 1:49 PM
anlambert committed rCJSWHee059076312e: jobs/swh-docs: Add missing Jenkins DDOC folder creation (authored by anlambert).
jobs/swh-docs: Add missing Jenkins DDOC folder creation
Thu, Oct 21, 1:45 PM
anlambert closed T3661: docs: Activate build on docs diff as Resolved by committing rCJSWH6e1bc67c9ee5: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Thu, Oct 21, 1:33 PM · Documentation
anlambert closed D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Thu, Oct 21, 1:33 PM
anlambert committed rCJSWH6e1bc67c9ee5: jobs/swh-docs: Add job to build doc when submitting phabricator diffs (authored by anlambert).
jobs/swh-docs: Add job to build doc when submitting phabricator diffs
Thu, Oct 21, 1:33 PM
anlambert updated the diff for D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.

Remove file committed by mistake

Thu, Oct 21, 1:32 PM
anlambert updated the diff for D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.

Use single quotes for string litteral in groovy script

Thu, Oct 21, 1:31 PM
anlambert requested review of D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Thu, Oct 21, 12:24 PM
anlambert added a revision to T3661: docs: Activate build on docs diff: D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Thu, Oct 21, 12:24 PM · Documentation
anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.

Rebase

Thu, Oct 21, 11:58 AM

Wed, Oct 20

anlambert added a comment to T3661: docs: Activate build on docs diff.

I have created a new Jenkins pipeline job manually to experiment on setting up that new CI build.

Wed, Oct 20, 6:17 PM · Documentation
anlambert committed rCDFJ7d453b55a904: sphinx/Dockerfile: Install pyarcanist in doc build environment (authored by anlambert).
sphinx/Dockerfile: Install pyarcanist in doc build environment
Wed, Oct 20, 5:00 PM
anlambert closed D6522: sphinx/Dockerfile: Install pyarcanist in doc build environment.
Wed, Oct 20, 5:00 PM
anlambert requested review of D6522: sphinx/Dockerfile: Install pyarcanist in doc build environment.
Wed, Oct 20, 4:59 PM
anlambert added a revision to T3661: docs: Activate build on docs diff: D6522: sphinx/Dockerfile: Install pyarcanist in doc build environment.
Wed, Oct 20, 4:59 PM · Documentation
anlambert requested review of D6519: Jenkins job for swh-docs diffs test.
Wed, Oct 20, 4:51 PM
anlambert closed D6518: admin/deposit: Allow users with permission to list their deposits.
Wed, Oct 20, 4:05 PM
anlambert committed rDWAPPSa8cfc14b4a5c: admin/deposit: Allow users with permission to list their deposits (authored by anlambert).
admin/deposit: Allow users with permission to list their deposits
Wed, Oct 20, 4:05 PM
anlambert requested review of D6518: admin/deposit: Allow users with permission to list their deposits.
Wed, Oct 20, 2:57 PM
anlambert added a revision to T3174: Filter deposit-admin view by deposit client on admin (moderation) page: D6518: admin/deposit: Allow users with permission to list their deposits.
Wed, Oct 20, 2:02 PM · Monitoring, SWORD deposit, Web app
anlambert closed T3257: Template the save code now rejection reason to ease operator workflow, a subtask of T3256: Propose reason for rejecting a save code now, as Resolved.
Wed, Oct 20, 12:36 PM · Save Code Now, Easy hack, Web app
anlambert closed T3257: Template the save code now rejection reason to ease operator workflow as Resolved.

It has been implemented and deployed to production, closing this.

Wed, Oct 20, 12:36 PM · Save Code Now, Easy hack, Web app
anlambert closed T3256: Propose reason for rejecting a save code now, a subtask of T3252: Better handling of erroneous origins submitted to save code now, as Resolved.
Wed, Oct 20, 12:36 PM · System administration, Save Code Now, Web app
anlambert closed T3256: Propose reason for rejecting a save code now as Resolved.

It has been implemented and deployed to production, closing this.

Wed, Oct 20, 12:36 PM · Save Code Now, Easy hack, Web app
anlambert closed D6516: docker/conf: Fix memcache URI.
Wed, Oct 20, 12:08 PM
anlambert committed rDENV59aba314af8f: docker/conf: Fix memcache URI (authored by anlambert).
docker/conf: Fix memcache URI
Wed, Oct 20, 12:08 PM
anlambert requested review of D6516: docker/conf: Fix memcache URI.
Wed, Oct 20, 11:44 AM
anlambert closed D6511: tests: Fix execution when building debian packages.
Wed, Oct 20, 11:30 AM
anlambert committed rDWAPPSba1801812eff: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, Oct 20, 11:30 AM
anlambert committed rDWAPPS2603e9cefe4a: tests: Fix execution when building debian packages (authored by anlambert).
tests: Fix execution when building debian packages
Wed, Oct 20, 11:30 AM
anlambert accepted D6514: Add docstring to runner and listener modules.

Looks goo to me.

Wed, Oct 20, 11:19 AM
anlambert accepted D6515: Drop deprecated listener module.
Wed, Oct 20, 10:56 AM

Tue, Oct 19

anlambert closed D6502: assets/origin-save: Display rejection reason in request info popover.
Tue, Oct 19, 4:12 PM
anlambert committed rDWAPPS96b3d287ed50: assets/origin-save: Display rejection reason in request info popover (authored by anlambert).
assets/origin-save: Display rejection reason in request info popover
Tue, Oct 19, 4:12 PM
anlambert committed rDWAPPS6c2792e9090f: assets/admin/origin-save: Enable to add note when rejecting a request (authored by anlambert).
assets/admin/origin-save: Enable to add note when rejecting a request
Tue, Oct 19, 4:12 PM
anlambert closed D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Tue, Oct 19, 4:12 PM
anlambert committed rDWAPPS9cf83ddceafe: Makefile.local: Remove correct sqlite tests database (authored by anlambert).
Makefile.local: Remove correct sqlite tests database
Tue, Oct 19, 4:12 PM
anlambert updated the diff for D6502: assets/origin-save: Display rejection reason in request info popover.

Rebase

Tue, Oct 19, 3:54 PM
anlambert updated the diff for D6501: assets/admin/origin-save: Enable to add note when rejecting a request.

Rebase and fix a couple of typos in cypress test comments

Tue, Oct 19, 3:53 PM
anlambert closed D6503: api/private/deposit_list: Allow to filter deposits by client username.
Tue, Oct 19, 3:52 PM
anlambert committed rDDEP801a0274c44d: api/private/deposit_list: Allow to filter deposits by client username (authored by anlambert).
api/private/deposit_list: Allow to filter deposits by client username
Tue, Oct 19, 3:52 PM
anlambert added a comment to D6502: assets/origin-save: Display rejection reason in request info popover.

lgtm

Tue, Oct 19, 3:48 PM
anlambert added a comment to D6503: api/private/deposit_list: Allow to filter deposits by client username.

That was quick ;)
Thanks.

Tue, Oct 19, 2:41 PM
anlambert closed D6505: browse/content: Fix error when a staff user browses a not found content.
Tue, Oct 19, 2:27 PM
anlambert committed rDWAPPSb72fd7f91746: browse/content: Fix error when a staff user browses a not found content (authored by anlambert).
browse/content: Fix error when a staff user browses a not found content
Tue, Oct 19, 2:27 PM
anlambert requested review of D6505: browse/content: Fix error when a staff user browses a not found content.
Tue, Oct 19, 2:20 PM
anlambert requested review of D6503: api/private/deposit_list: Allow to filter deposits by client username.
Tue, Oct 19, 1:51 PM
anlambert added a revision to T3174: Filter deposit-admin view by deposit client on admin (moderation) page: D6503: api/private/deposit_list: Allow to filter deposits by client username.
Tue, Oct 19, 1:48 PM · Monitoring, SWORD deposit, Web app
anlambert updated the summary of D6502: assets/origin-save: Display rejection reason in request info popover.
Tue, Oct 19, 12:33 PM
anlambert updated the summary of D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Tue, Oct 19, 12:32 PM
anlambert requested review of D6502: assets/origin-save: Display rejection reason in request info popover.
Tue, Oct 19, 12:30 PM
anlambert requested review of D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Tue, Oct 19, 12:28 PM
anlambert added a revision to T3256: Propose reason for rejecting a save code now: D6502: assets/origin-save: Display rejection reason in request info popover.
Tue, Oct 19, 11:21 AM · Save Code Now, Easy hack, Web app
anlambert added a revision to T3256: Propose reason for rejecting a save code now: D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Tue, Oct 19, 11:20 AM · Save Code Now, Easy hack, Web app
anlambert added a revision to T3257: Template the save code now rejection reason to ease operator workflow: D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Tue, Oct 19, 11:20 AM · Save Code Now, Easy hack, Web app