User Details
User Details
- User Since
- Jul 3 2017, 10:14 AM (224 w, 4 d)
Today
Today
Fixed in swh-lister v2.2.0 and deployed to production, closing this.
anlambert closed T3686: svn: Add missing coverage on svn implementation as Resolved by committing rDLDSVN6578b85dd024: loader: Fix SvnLoaderFromDumpArchive and add test.
anlambert committed rDLDSVN6578b85dd024: loader: Fix SvnLoaderFromDumpArchive and add test (authored by anlambert).
loader: Fix SvnLoaderFromDumpArchive and add test
anlambert added a comment to T3675: Investigate why cran origins are marked as non-visited in the scheduler metrics.
drop the computation done in the archive coverage part for those origins.
anlambert committed rDLS24bc67167900: cgit: Enable to retry throttled HTTP requests (authored by anlambert).
cgit: Enable to retry throttled HTTP requests
cran: Fix ListedOrigin visit type
anlambert requested review of D6539: cran: Fix ListedOrigin visit type.
anlambert committed rDSTO49a932c98936: algos/revisions_walker: Handle case of revision without committer date (authored by anlambert).
algos/revisions_walker: Handle case of revision without committer date
anlambert committed rDSTOc02be8ebacf3: test_revisions_walker: Migrate from unittest to pytest (authored by anlambert).
test_revisions_walker: Migrate from unittest to pytest
anlambert added inline comments to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
anlambert requested changes to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
anlambert added a comment to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
anlambert added a comment to D6537: Dockerfile: Avoid pip 21.3 version preventing working container override.
This is the same diff as D6536 no ?
anlambert added a comment to T3685: Our pip usage is broken since a recent pip release.
The issue has been fixed upstream and will be part of next pip release.
anlambert committed rDWAPPS0da5060e6f24: templates/revision-info: Display author fullname when name is None (authored by anlambert).
templates/revision-info: Display author fullname when name is None
anlambert updated the diff for D6533: algos/revisions_walker: Handle case of revision without committer date.
Improve comment
Looks good to me, thanks ! I added a last batch of nitpick comments to handle before landing this.
Looks good to me, I can also reproduce the issues after click upgrade to 8.x.
anlambert added inline comments to D6533: algos/revisions_walker: Handle case of revision without committer date.
Yesterday
Yesterday
anlambert requested review of D6535: templates/revision-info: Display author fullname when name is None.
anlambert added inline comments to D6534: Migrate idrac documentation to sysadm docs.
anlambert requested review of D6533: algos/revisions_walker: Handle case of revision without committer date.
anlambert requested review of D6532: test_revisions_walker: Migrate from unittest to pytest.
anlambert requested changes to D6441: Deprecate /browse/origin/log/ URLs.
This is moving forward, great ! I added a couple of inline comments to handle.
anlambert committed rDENVaa331105560e: services/keycloak: Update keycloak_swh_setup.py script (authored by anlambert).
services/keycloak: Update keycloak_swh_setup.py script
anlambert requested review of D6531: services/keycloak: Update keycloak_swh_setup.py script.
anlambert committed rSPSITEe7759626904c: keycloak: Add swh.web.admin.list_deposits role to swh-web client (authored by anlambert).
keycloak: Add swh.web.admin.list_deposits role to swh-web client
anlambert added a reviewer for D6528: keycloak: Add swh.web.admin.list_deposits role to swh-web client: Reviewers.
anlambert requested review of D6528: keycloak: Add swh.web.admin.list_deposits role to swh-web client.
Jenkins CI job for building SWH docs when submitting diffs to swh-docs is now properly deployed and configured, time to abandon this.
anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.
Make the build passes again for last test.
anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.
Introduce warning to check the CI build fails
anlambert committed rCJSWHee059076312e: jobs/swh-docs: Add missing Jenkins DDOC folder creation (authored by anlambert).
jobs/swh-docs: Add missing Jenkins DDOC folder creation
anlambert closed T3661: docs: Activate build on docs diff as Resolved by committing rCJSWH6e1bc67c9ee5: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
anlambert committed rCJSWH6e1bc67c9ee5: jobs/swh-docs: Add job to build doc when submitting phabricator diffs (authored by anlambert).
jobs/swh-docs: Add job to build doc when submitting phabricator diffs
anlambert updated the diff for D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Remove file committed by mistake
anlambert updated the diff for D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
Use single quotes for string litteral in groovy script
anlambert requested review of D6523: jobs/swh-docs: Add job to build doc when submitting phabricator diffs.
anlambert updated the diff for D6519: Jenkins job for swh-docs diffs test.
Rebase
Wed, Oct 20
Wed, Oct 20
anlambert added a comment to T3661: docs: Activate build on docs diff.
I have created a new Jenkins pipeline job manually to experiment on setting up that new CI build.
anlambert committed rCDFJ7d453b55a904: sphinx/Dockerfile: Install pyarcanist in doc build environment (authored by anlambert).
sphinx/Dockerfile: Install pyarcanist in doc build environment
anlambert requested review of D6522: sphinx/Dockerfile: Install pyarcanist in doc build environment.
anlambert requested review of D6519: Jenkins job for swh-docs diffs test.
anlambert committed rDWAPPSa8cfc14b4a5c: admin/deposit: Allow users with permission to list their deposits (authored by anlambert).
admin/deposit: Allow users with permission to list their deposits
anlambert requested review of D6518: admin/deposit: Allow users with permission to list their deposits.
anlambert closed T3257: Template the save code now rejection reason to ease operator workflow, a subtask of T3256: Propose reason for rejecting a save code now, as Resolved.
anlambert closed T3257: Template the save code now rejection reason to ease operator workflow as Resolved.
It has been implemented and deployed to production, closing this.
anlambert closed T3256: Propose reason for rejecting a save code now, a subtask of T3252: Better handling of erroneous origins submitted to save code now, as Resolved.
It has been implemented and deployed to production, closing this.
docker/conf: Fix memcache URI
anlambert requested review of D6516: docker/conf: Fix memcache URI.
anlambert committed rDWAPPSba1801812eff: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert committed rDWAPPS2603e9cefe4a: tests: Fix execution when building debian packages (authored by anlambert).
tests: Fix execution when building debian packages
Looks goo to me.
Tue, Oct 19
Tue, Oct 19
anlambert committed rDWAPPS96b3d287ed50: assets/origin-save: Display rejection reason in request info popover (authored by anlambert).
assets/origin-save: Display rejection reason in request info popover
anlambert committed rDWAPPS6c2792e9090f: assets/admin/origin-save: Enable to add note when rejecting a request (authored by anlambert).
assets/admin/origin-save: Enable to add note when rejecting a request
anlambert committed rDWAPPS9cf83ddceafe: Makefile.local: Remove correct sqlite tests database (authored by anlambert).
Makefile.local: Remove correct sqlite tests database
anlambert updated the diff for D6502: assets/origin-save: Display rejection reason in request info popover.
Rebase
anlambert updated the diff for D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
Rebase and fix a couple of typos in cypress test comments
anlambert committed rDDEP801a0274c44d: api/private/deposit_list: Allow to filter deposits by client username (authored by anlambert).
api/private/deposit_list: Allow to filter deposits by client username
anlambert added a comment to D6502: assets/origin-save: Display rejection reason in request info popover.
anlambert added a comment to D6503: api/private/deposit_list: Allow to filter deposits by client username.
anlambert committed rDWAPPSb72fd7f91746: browse/content: Fix error when a staff user browses a not found content (authored by anlambert).
browse/content: Fix error when a staff user browses a not found content
anlambert requested review of D6505: browse/content: Fix error when a staff user browses a not found content.
anlambert requested review of D6503: api/private/deposit_list: Allow to filter deposits by client username.
anlambert updated the summary of D6502: assets/origin-save: Display rejection reason in request info popover.
anlambert updated the summary of D6501: assets/admin/origin-save: Enable to add note when rejecting a request.
anlambert requested review of D6502: assets/origin-save: Display rejection reason in request info popover.
anlambert requested review of D6501: assets/admin/origin-save: Enable to add note when rejecting a request.