Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

User Details

User Since
Jul 3 2017, 10:14 AM (255 w, 4 d)

Recent Activity

Fri, May 20

anlambert added inline comments to D7874: Add a schema type for handling binary strings.
Fri, May 20, 4:42 PM
anlambert added inline comments to D7874: Add a schema type for handling binary strings.
Fri, May 20, 4:41 PM
anlambert requested changes to D7874: Add a schema type for handling binary strings.
Fri, May 20, 4:36 PM
anlambert requested review of D7878: svn: Wraps commit info retrieval in a retryable SvnRepo method.
Fri, May 20, 4:14 PM
anlambert closed D7875: svn_retry: Retry operation when server sent a truncated HTTP response.
Fri, May 20, 4:04 PM
anlambert committed rDLDSVN2afad0ee23f5: svn_retry: Retry operation when server sent a truncated HTTP response (authored by anlambert).
svn_retry: Retry operation when server sent a truncated HTTP response
Fri, May 20, 4:04 PM
anlambert closed D7872: cvs2gitdump: Fix local variable 'expkw' referenced before assignment.
Fri, May 20, 4:03 PM
anlambert committed rDLDCVSd52686be9182: cvs2gitdump: Fix local variable 'expkw' referenced before assignment (authored by anlambert).
cvs2gitdump: Fix local variable 'expkw' referenced before assignment
Fri, May 20, 4:03 PM
anlambert accepted D7876: Log summary of filtered objects in store_data.
Fri, May 20, 4:03 PM
anlambert accepted D7873: Add an unweighted average for filtered_objects + fix existing metric name.
Fri, May 20, 4:02 PM
anlambert requested review of D7875: svn_retry: Retry operation when server sent a truncated HTTP response.
Fri, May 20, 3:42 PM
anlambert updated the diff for D7872: cvs2gitdump: Fix local variable 'expkw' referenced before assignment.

Ensure to keep previous test behavior after initializing expkw to 0

Fri, May 20, 2:58 PM
anlambert requested review of D7872: cvs2gitdump: Fix local variable 'expkw' referenced before assignment.
Fri, May 20, 2:45 PM
anlambert accepted D7869: BaseLoader.flush: Return the output of storage.flush.
Fri, May 20, 2:17 PM
anlambert accepted D7870: Use GitHubSession to make canonical computation deal with rate limit.
Fri, May 20, 2:13 PM
anlambert accepted D7871: Add metrics in store_data on ratios of objects already stored.

Looks good to me. There is a typo in commit message though, s/store_date/store_data/.

Fri, May 20, 2:11 PM
anlambert closed D7867: django/models: Map keycloak groups to django ones in OIDCUser model.
Fri, May 20, 1:46 PM
anlambert committed rDAUTH9dcb735cfcc8: django/models: Map keycloak groups to django ones in OIDCUser model (authored by anlambert).
django/models: Map keycloak groups to django ones in OIDCUser model
Fri, May 20, 1:46 PM
anlambert added inline comments to D7867: django/models: Map keycloak groups to django ones in OIDCUser model.
Fri, May 20, 1:42 PM
anlambert accepted D7868: Move store_data from DVCSLoader to a new BaseGitLoader.
Fri, May 20, 12:27 PM
anlambert requested review of D7867: django/models: Map keycloak groups to django ones in OIDCUser model.
Fri, May 20, 12:06 PM

Thu, May 19

anlambert closed T4259: Bump minium required nodejs version to 14.x as Resolved.
Thu, May 19, 3:03 PM · Development environment, Web app
anlambert closed D7861: developer-setup: Bump minimum required nodejs to 14.x.
Thu, May 19, 3:03 PM
anlambert committed rDDOC80bb48c2eb3c: developer-setup: Bump minimum required nodejs to 14.x (authored by anlambert).
developer-setup: Bump minimum required nodejs to 14.x
Thu, May 19, 3:03 PM
anlambert closed D7860: package.json: Bump nodejs to 14.x and upgrade dependencies.
Thu, May 19, 3:02 PM
anlambert committed rDWAPPSb4e6e13e6a36: package.json: Bump nodejs to 14.x and upgrade dependencies (authored by anlambert).
package.json: Bump nodejs to 14.x and upgrade dependencies
Thu, May 19, 3:02 PM
anlambert added inline comments to D7861: developer-setup: Bump minimum required nodejs to 14.x.
Thu, May 19, 2:53 PM
anlambert updated subscribers of D7862: Add functional tests for visit object.

I think it would be better to avoid hardcoding test inputs and expected values in graphql responses.

Thu, May 19, 2:24 PM
anlambert accepted D7863: Use swhid instead of SWHID in the schema fields.
Thu, May 19, 12:31 PM
anlambert requested changes to D7863: Use swhid instead of SWHID in the schema fields.

You must keep SWHID in uppercase in docstrings (see documentation).

Thu, May 19, 12:00 PM
anlambert requested review of D7860: package.json: Bump nodejs to 14.x and upgrade dependencies.
Thu, May 19, 11:36 AM
anlambert requested review of D7861: developer-setup: Bump minimum required nodejs to 14.x.
Thu, May 19, 11:28 AM
anlambert added a revision to T4259: Bump minium required nodejs version to 14.x: D7861: developer-setup: Bump minimum required nodejs to 14.x.
Thu, May 19, 11:14 AM · Development environment, Web app
anlambert added a revision to T4259: Bump minium required nodejs version to 14.x: D7860: package.json: Bump nodejs to 14.x and upgrade dependencies.
Thu, May 19, 11:11 AM · Development environment, Web app
anlambert closed D7852: templates/layout: Ensure to include piwik script in production only.
Thu, May 19, 11:04 AM
anlambert committed rDWAPPS12661f9b3fba: templates/layout: Ensure to include piwik script in production only (authored by anlambert).
templates/layout: Ensure to include piwik script in production only
Thu, May 19, 11:04 AM
anlambert closed D7854: base-buster/Dockerfile: Bump nodejs to 14.x.
Thu, May 19, 10:52 AM
anlambert committed rCDFJ22f37aae8504: base-buster/Dockerfile: Bump nodejs to 14.x (authored by anlambert).
base-buster/Dockerfile: Bump nodejs to 14.x
Thu, May 19, 10:52 AM
anlambert closed D7853: docker/Dockerfile: Bump nodejs to 14.x.
Thu, May 19, 10:52 AM
anlambert committed rDENV1256bb58d5d6: docker/Dockerfile: Bump nodejs to 14.x (authored by anlambert).
docker/Dockerfile: Bump nodejs to 14.x
Thu, May 19, 10:52 AM

Wed, May 18

anlambert accepted D7817: Add first set of functional tests.

Looks good to me.

Wed, May 18, 4:56 PM
anlambert requested review of D7854: base-buster/Dockerfile: Bump nodejs to 14.x.
Wed, May 18, 4:41 PM
anlambert added a revision to T4259: Bump minium required nodejs version to 14.x: D7854: base-buster/Dockerfile: Bump nodejs to 14.x.
Wed, May 18, 4:41 PM · Development environment, Web app
anlambert requested review of D7853: docker/Dockerfile: Bump nodejs to 14.x.
Wed, May 18, 4:41 PM
anlambert added a revision to T4259: Bump minium required nodejs version to 14.x: D7853: docker/Dockerfile: Bump nodejs to 14.x.
Wed, May 18, 4:41 PM · Development environment, Web app
anlambert requested review of D7852: templates/layout: Ensure to include piwik script in production only.
Wed, May 18, 4:27 PM
anlambert triaged T4259: Bump minium required nodejs version to 14.x as Normal priority.
Wed, May 18, 3:59 PM · Development environment, Web app
anlambert closed D7848: add_forge_now: Harmonize moderator permission management.
Wed, May 18, 3:21 PM
anlambert committed rDWAPPSb548d2f261ab: add_forge_now: Harmonize moderator permission management (authored by anlambert).
add_forge_now: Harmonize moderator permission management
Wed, May 18, 3:21 PM
anlambert accepted D7851: Include counters in the the main docker-compose file.
Wed, May 18, 3:20 PM
anlambert accepted D7849: webapp: fix the inbound email command name.
Wed, May 18, 2:13 PM
anlambert requested review of D7848: add_forge_now: Harmonize moderator permission management.
Wed, May 18, 2:01 PM
anlambert added a revision to T4254: [Add forge now] missing contact info: D7848: add_forge_now: Harmonize moderator permission management.
Wed, May 18, 1:39 PM · Add Forge Now , Web app
anlambert closed T4240: Do not accept save requests with credentials leaked in the origin URL as Resolved.

This has been implemented and deployed.

Wed, May 18, 1:37 PM · Save Code Now, Web app
anlambert added a comment to T4254: [Add forge now] missing contact info.

Thanks for the investigation :)
I'll close the related issues

The remaining question is : should we consider all staff users as moderators or should we rely on the permission above only ?

Considering all staff members as moderators seems to make sense to me

Wed, May 18, 11:48 AM · Add Forge Now , Web app
anlambert closed D7843: origin_save: Reject save request when origin URL contains a password.
Wed, May 18, 11:12 AM
anlambert committed rDWAPPSf2d6fec278db: origin_save: Reject save request when origin URL contains a password (authored by anlambert).
origin_save: Reject save request when origin URL contains a password
Wed, May 18, 11:12 AM

Tue, May 17

anlambert requested review of D7843: origin_save: Reject save request when origin URL contains a password.
Tue, May 17, 7:49 PM
anlambert added a comment to T4257: [add forge now] missing submitter name in admin dashboard.

See T4254#85310 for the cause of the issue.

Tue, May 17, 6:03 PM · Add Forge Now , Web app
anlambert added a comment to T4255: [add forge now] moderator comments not displayed.

See T4254#85310 for the cause of the issue.

Tue, May 17, 6:00 PM · Add Forge Now , Web app
anlambert added a comment to T4254: [Add forge now] missing contact info.

The issue was due to the missing permission swh.web.add_forge_now.moderator for your user account on staging.
I just granted it to you so you should now be able to see the missing info.

Tue, May 17, 5:59 PM · Add Forge Now , Web app
anlambert added projects to T4254: [Add forge now] missing contact info: Web app, Add Forge Now .
Tue, May 17, 5:43 PM · Add Forge Now , Web app
anlambert added projects to T4255: [add forge now] moderator comments not displayed: Web app, Add Forge Now .
Tue, May 17, 5:42 PM · Add Forge Now , Web app
anlambert added projects to T4256: [add forge now] link to original message doesn't work: Web app, Add Forge Now .
Tue, May 17, 5:42 PM · Add Forge Now , Web app
anlambert added projects to T4257: [add forge now] missing submitter name in admin dashboard: Web app, Add Forge Now .
Tue, May 17, 5:42 PM · Add Forge Now , Web app
anlambert added a revision to T4240: Do not accept save requests with credentials leaked in the origin URL: D7843: origin_save: Reject save request when origin URL contains a password.
Tue, May 17, 5:34 PM · Save Code Now, Web app
anlambert accepted D7841: Extract reusable github tests fixtures into its own pytest_plugin.

Looks good to me.

Tue, May 17, 4:41 PM
anlambert closed D7842: test_db/test_db_copy_to: Fix hypothesis FailedHealthCheck error.
Tue, May 17, 2:39 PM
anlambert committed rDCOREe77c68ab91bc: test_db/test_db_copy_to: Fix hypothesis FailedHealthCheck error (authored by anlambert).
test_db/test_db_copy_to: Fix hypothesis FailedHealthCheck error
Tue, May 17, 2:39 PM
anlambert updated the diff for D7842: test_db/test_db_copy_to: Fix hypothesis FailedHealthCheck error.

Rebase

Tue, May 17, 2:35 PM
anlambert created P1365 (An Untitled Masterwork).
Tue, May 17, 1:43 PM
anlambert requested review of D7842: test_db/test_db_copy_to: Fix hypothesis FailedHealthCheck error.
Tue, May 17, 1:31 PM
anlambert committed rDWAPPSf65bb5bc8446: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Tue, May 17, 11:39 AM
anlambert committed rDWAPPS0241018e0aba: misc/coverage: Fix display of nixguix origin counts (authored by anlambert).
misc/coverage: Fix display of nixguix origin counts
Tue, May 17, 11:17 AM
anlambert accepted D7840: Refactor swh.lister.github.utils to swh.core.github.utils.

Looks good to me.

Tue, May 17, 11:06 AM
anlambert added inline comments to D7817: Add first set of functional tests.
Tue, May 17, 10:59 AM
anlambert committed rDDOCc181c6dd0c3e: user/loaders: Fix typo in URL (authored by anlambert).
user/loaders: Fix typo in URL
Tue, May 17, 10:47 AM
anlambert closed D7837: templates/layout: Remove no longer used topbar.
Tue, May 17, 10:47 AM
anlambert committed rDDOC2d59a18b56af: templates/layout: Remove no longer used topbar (authored by anlambert).
templates/layout: Remove no longer used topbar
Tue, May 17, 10:47 AM

Mon, May 16

anlambert requested review of D7837: templates/layout: Remove no longer used topbar.
Mon, May 16, 8:00 PM
anlambert accepted D7836: Add utility to sanitize and retrieve canonical github urls.

Looks good to me.

Mon, May 16, 4:19 PM
anlambert requested changes to D7817: Add first set of functional tests.
Mon, May 16, 3:37 PM
anlambert added inline comments to D7836: Add utility to sanitize and retrieve canonical github urls.
Mon, May 16, 3:11 PM
anlambert accepted D7835: Don't assume all GitClient instances have a 'dumb' attribute.

Thanks mypy !

Mon, May 16, 3:04 PM
anlambert closed D7638: user: Bootstrap listers high-level documentation.
Mon, May 16, 2:16 PM
anlambert committed rDDOC4cb48b564ffd: user: Bootstrap listers high-level documentation (authored by anlambert).
user: Bootstrap listers high-level documentation
Mon, May 16, 2:16 PM
anlambert closed D7637: user: Bootstrap loaders high-level documentation.
Mon, May 16, 2:16 PM
anlambert committed rDDOCdc96f6a8ecb7: user: Bootstrap loaders high-level documentation (authored by anlambert).
user: Bootstrap loaders high-level documentation
Mon, May 16, 2:16 PM
anlambert closed D7833: loader: Ensure success is False when entering exception handler.
Mon, May 16, 2:04 PM
anlambert committed rDLDBASEd9a6ba057707: loader: Ensure success is False when entering exception handler (authored by anlambert).
loader: Ensure success is False when entering exception handler
Mon, May 16, 2:04 PM
anlambert updated the diff for D7638: user: Bootstrap listers high-level documentation.

Rebase

Mon, May 16, 1:58 PM
anlambert updated the diff for D7637: user: Bootstrap loaders high-level documentation.

Update Bazaar loader status as it is now deployed to production.

Mon, May 16, 1:58 PM
anlambert requested review of D7833: loader: Ensure success is False when entering exception handler.
Mon, May 16, 12:19 PM
anlambert closed T4226: Restrict the query of /raw/(swhid)/ Web API endpoint to privileged users as Resolved.

This has been implemented and deployed.

Mon, May 16, 10:55 AM · Web app
anlambert accepted D7796: Updated Gitlab Logo.

Looks good, thanks ! You will have to rebase the diff before landing it.

Mon, May 16, 10:52 AM
anlambert closed D7830: templates/coverage: Add missing favicon to coverage page.
Mon, May 16, 10:50 AM
anlambert committed rDWAPPSe49b84bcfb3a: templates/coverage: Add missing favicon to coverage page (authored by anlambert).
templates/coverage: Add missing favicon to coverage page
Mon, May 16, 10:50 AM
anlambert added a comment to T3854: Fix daily dump of mysql database.

It's fixed see details in T3862.

Mon, May 16, 10:40 AM · Website

Sat, May 14

anlambert closed T4246: URLs on moderation dashboard aren't sanitized as Invalid.

@anirudhlakhotia, sorry but you are wrong here, forge URLs are santized in the moderation dashboard. This is exactly the purpose of the use of the $.fn.dataTable.render.text() render function (see Security doc of datatables).

Sat, May 14, 3:41 PM

Fri, May 13

anlambert updated the summary of D7638: user: Bootstrap listers high-level documentation.
Fri, May 13, 5:54 PM