User Details
- User Since
- Jul 3 2017, 10:14 AM (186 w, 3 d)
Today
Remove debian folder committed by mistake
- add a test to check lister instantiation with configuration file
Note that this lister seems to need some writing improvments though.
It seemed to have flushed the writing only at the end of the listing.
If that's the real behavior (i'll need to check), that won't bode well for relatively high dimensioned instance like the cgit eclispe instance for example.
LGTM. Other ported listers might have the same issue so I guess they should be fixed too.
Yesterday
Legacy option should be removed soon so no tests needed here ;-)
This would be cleaner to process the url in the lister constructor instead (same as in debian one).
Looks good !
You should rather catch the requests.exceptions.HTTPError originally raised by _get_and_parse method.
Looks good to me !
Thanks for tackling this !
Tue, Jan 26
Rebase
Rebase and remove conftest.py file
Looks good but the commit message could be more detailed and rephrased to something like:
Looks good to me ! I added a comment regarding further improvements that could be added to the lister but not related to that diff.
Rebase
Following URLs are now redirected to the desired page:
Rebase
Update: Add test for parse_packaged_date and fix implementation.
Update: Address some @tenma comments
On a related note, I found this list of Community-Hosted GitLab Instances. Most of them have public access and could be added to the set of Gitlab instances listed by Software Heritage.
Mon, Jan 25
Sorry I accepted the diff before seeing you used Basic Auth which I think is not working.
I do not see any section regarding basic HTTP authentication for API requests in Gitlab API doc. Are you sure it is working ?
You should add a test to check the last_update field value in scheduler database is not None.
Remove debian/conftest.py modified by black from the commit.
Looks good to me !
Looks good to me !
Rebase
Great !
Rebase
Looks good to me !
Looks good to me !