I think its was originally there to handle browsers with no JavaScript or with JavaScript disabled.

Oh did not spot this. I think it was originally sorted by endpoints but some columns of the table were removed since then and we forgot to update the ordering.

Well seen !

Nice one, thanks !

The use of Google ReCAPTCHA is now dropped in favor of rate limiting the number of save requests a user can create through the form (10/h).

Great, thanks! You can rebase and land it.

@kalpitk , looks good ! You can land it.

Looks good to me

Currently the WordPress plugin we are using to interact with Stripe does not yet support SCA but it will be added during the summer.

I should have read django-simple-captcha doc, indeed its integration is not really straightforward for swh-web.

Diff accepted but let's land D1583 first (see inline comment).

Nice! I agree with @vlorentz , you should split the tests into two spec files: sidebar.spec.js and back-to-top.spec.js. Once it is done, that diff can be landed.

Just a small change to do and I will accept the diff.

Update: Ensure grecaptcha is desactivated for e2e tests

Update: Remove unused file and resentence some tests description

Closed by d355d8973205

These tests will be redundant with the end to end ones, so closing that task and prefer to rely on using cypress for frontend testing.

Abandoning this in favor of D1565

Looks good, thanks !

@shisus , I have tested cypress and the tool is indeed quite awesome !

Just a couple of nitpicks for small screens (see screenshot below):

• Can you slightly move the popover to the right in order to see its borders ?
• The Permalinks button should not overlap the popover

Let's land this !

Thanks for pointing out the cypress tool, it looks pretty interesting.
Based on my understanding, it could be used to write and run unit tests but also end to end ones.

Still some improvements to bring.

Better indeed !

Nice improvements but that diff is not landable as is (see my inline comments).

In order to implement the unit tests, we will need the following node modules:

• mocha tests runner combined with an assertion library
• mocha-webpack to generate test bundles and execute them
• jsdom to emulate a browser environment in node
• json-global to ease jsdom use with mocha

Rebase

Update: Remove the commit related to trailing whitespaces

npm is now archived continuously by Software Heritage (see for instance: https://archive.softwareheritage.org/browse/origin/https://www.npmjs.com/package/webpack/).