♟ anlambert

svn_retry: Retry operation when server sent a truncated HTTP response

cvs2gitdump: Fix local variable 'expkw' referenced before assignment

Ensure to keep previous test behavior after initializing expkw to 0

Looks good to me. There is a typo in commit message though, s/store_date/store_data/.

django/models: Map keycloak groups to django ones in OIDCUser model

developer-setup: Bump minimum required nodejs to 14.x

package.json: Bump nodejs to 14.x and upgrade dependencies

I think it would be better to avoid hardcoding test inputs and expected values in graphql responses.

You must keep SWHID in uppercase in docstrings (see documentation).

templates/layout: Ensure to include piwik script in production only

base-buster/Dockerfile: Bump nodejs to 14.x

docker/Dockerfile: Bump nodejs to 14.x

add_forge_now: Harmonize moderator permission management

This has been implemented and deployed.

In T4254#85326, @bchauvet wrote:

Thanks for the investigation :)
I'll close the related issues

The remaining question is : should we consider all staff users as moderators or should we rely on the permission above only ?

Considering all staff members as moderators seems to make sense to me

origin_save: Reject save request when origin URL contains a password

See T4254#85310 for the cause of the issue.

The issue was due to the missing permission swh.web.add_forge_now.moderator for your user account on staging.
I just granted it to you so you should now be able to see the missing info.

test_db/test_db_copy_to: Fix hypothesis FailedHealthCheck error

package.json: Upgrade dependencies

misc/coverage: Fix display of nixguix origin counts

user/loaders: Fix typo in URL

templates/layout: Remove no longer used topbar

user: Bootstrap listers high-level documentation

user: Bootstrap loaders high-level documentation

loader: Ensure success is False when entering exception handler

Update Bazaar loader status as it is now deployed to production.

This has been implemented and deployed.

Looks good, thanks ! You will have to rebase the diff before landing it.

templates/coverage: Add missing favicon to coverage page

It's fixed see details in T3862.

@anirudhlakhotia, sorry but you are wrong here, forge URLs are santized in the moderation dashboard. This is exactly the purpose of the use of the $.fn.dataTable.render.text() render function (see Security doc of datatables).

anlambert (Antoine Lambert)
User

Projects (8)
View All

User Details

Recent Activity
View All

Fri, May 20

Thu, May 19

Wed, May 18

Tue, May 17

Mon, May 16

Sat, May 14

Fri, May 13

anlambert (Antoine Lambert)User

Projects (8)View All