Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

Projects (6)

User Details

User Since
Jul 3 2017, 10:14 AM (169 w, 1 d)

Recent Activity

Today

anlambert updated the diff for D4077: api: Add /graph endpoint proxying Software Heritage Graph service.

Update: Address @vlorentz comments

Tue, Sep 29, 5:06 PM
anlambert added inline comments to D4077: api: Add /graph endpoint proxying Software Heritage Graph service.
Tue, Sep 29, 4:42 PM
anlambert added a comment to T2642: swh-graph: fix CI.

I managed to track the dependency bump that broke the CI build: it is the upgrade of yarl (dependency of aiohttp) from 1.5.1 to 1.6.0. The issue is surely due to that commit.

Tue, Sep 29, 4:15 PM · Graph service
anlambert added inline comments to D4077: api: Add /graph endpoint proxying Software Heritage Graph service.
Tue, Sep 29, 3:50 PM
anlambert updated the diff for D4077: api: Add /graph endpoint proxying Software Heritage Graph service.

Update docs

Tue, Sep 29, 2:28 PM
anlambert committed rCJSWH1139eec872a2: jobs/swh-environment: Improve build script (authored by anlambert).
jobs/swh-environment: Improve build script
Tue, Sep 29, 2:16 PM
anlambert closed D4068: jobs/swh-environment: Improve build script.
Tue, Sep 29, 2:16 PM
anlambert updated the diff for D4077: api: Add /graph endpoint proxying Software Heritage Graph service.

Update: Remove empty line

Tue, Sep 29, 2:12 PM
anlambert added a revision to T2589: expose swh-graph API at archive.s.o/api/1/graph/: D4077: api: Add /graph endpoint proxying Software Heritage Graph service.
Tue, Sep 29, 2:10 PM · System administration, Web app, Graph service
anlambert created D4077: api: Add /graph endpoint proxying Software Heritage Graph service.
Tue, Sep 29, 2:10 PM
anlambert added a comment to D4068: jobs/swh-environment: Improve build script.

LGTM (except the "rm -f ../$module.log " for which I am not convinced it's a good idea)

Tue, Sep 29, 12:10 PM
anlambert committed rDWAPPS504f0db36850: tox/black: Pin version to pre-commit one and exclude test resources (authored by anlambert).
tox/black: Pin version to pre-commit one and exclude test resources
Tue, Sep 29, 10:49 AM
anlambert closed D4070: tox/black: Pin version to pre-commit one and exclude test resources.
Tue, Sep 29, 10:49 AM

Yesterday

anlambert created D4070: tox/black: Pin version to pre-commit one and exclude test resources.
Mon, Sep 28, 6:42 PM
anlambert updated the summary of D4068: jobs/swh-environment: Improve build script.
Mon, Sep 28, 4:41 PM
anlambert created D4068: jobs/swh-environment: Improve build script.
Mon, Sep 28, 4:41 PM
anlambert accepted D4066: Fix buffer interface protocol and impls.
Mon, Sep 28, 4:19 PM
anlambert created P787 storage flush - no more default value for object_types argument.
Mon, Sep 28, 2:39 PM
anlambert accepted D4062: declare the swh-docker-dev job.
Mon, Sep 28, 2:11 PM
anlambert added inline comments to D4061: Add documentation to test locally.
Mon, Sep 28, 2:11 PM

Fri, Sep 25

anlambert committed rDWAPPSe547df3dec76: setup.py: Remove no more needed vcversioner configuration (authored by anlambert).
setup.py: Remove no more needed vcversioner configuration
Fri, Sep 25, 5:03 PM
anlambert committed rDWAPPS3e8584e9f805: SWHIDs: Do not add path qualifier for a root directory (authored by anlambert).
SWHIDs: Do not add path qualifier for a root directory
Fri, Sep 25, 3:20 PM
anlambert closed D4050: SWHIDs: Do not add path qualifier for a root directory.
Fri, Sep 25, 3:20 PM
anlambert updated the diff for D4050: SWHIDs: Do not add path qualifier for a root directory.

Update: Address @ardumont comment

Fri, Sep 25, 3:10 PM
anlambert added inline comments to D4050: SWHIDs: Do not add path qualifier for a root directory.
Fri, Sep 25, 3:06 PM
anlambert added a revision to T2636: Modify generation of full-context SWHID for root artifacts by omitting path classifier : D4050: SWHIDs: Do not add path qualifier for a root directory.
Fri, Sep 25, 2:43 PM · Web app, SWORD deposit, Data Model
anlambert created D4050: SWHIDs: Do not add path qualifier for a root directory.
Fri, Sep 25, 2:43 PM
anlambert committed rDWAPPS7ac279dfd033: assets/browse/swhid-utils: Improve SWHID with context display (authored by anlambert).
assets/browse/swhid-utils: Improve SWHID with context display
Fri, Sep 25, 11:18 AM
anlambert committed rDWAPPSedf2dfda9607: assets/admin/deposit: Improve SWHID with context link text formatting (authored by anlambert).
assets/admin/deposit: Improve SWHID with context link text formatting
Fri, Sep 25, 11:18 AM
anlambert closed D4037: Improve SWHID with context link text formatting.
Fri, Sep 25, 11:18 AM

Thu, Sep 24

anlambert updated the summary of D4037: Improve SWHID with context link text formatting.
Thu, Sep 24, 7:31 PM
anlambert changed the visibility for F4032266: image.png.
Thu, Sep 24, 7:31 PM
anlambert updated the summary of D4037: Improve SWHID with context link text formatting.
Thu, Sep 24, 7:29 PM
anlambert retitled D4037: Improve SWHID with context link text formatting from assets/admin/deposit: Improve SWHID with context link text formatting to Improve SWHID with context link text formatting.
Thu, Sep 24, 7:29 PM
anlambert created D4037: Improve SWHID with context link text formatting.
Thu, Sep 24, 7:27 PM
anlambert committed rDWAPPS1d48edfb2eba: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars (authored by anlambert).
SWHIDs: Fix URLs escaping when a qualifier contains escaped chars
Thu, Sep 24, 7:24 PM
anlambert closed T2641: Fix SWHID resolving when origin qualifier has an equal character in its value as Resolved by committing rDWAPPS1d48edfb2eba: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.
Thu, Sep 24, 7:24 PM · Web app
anlambert closed D4035: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.
Thu, Sep 24, 7:24 PM
anlambert updated the diff for D4035: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.

Update: Fix cypress test

Thu, Sep 24, 6:54 PM
anlambert added a revision to T2641: Fix SWHID resolving when origin qualifier has an equal character in its value: D4035: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.
Thu, Sep 24, 5:39 PM · Web app
anlambert created D4035: SWHIDs: Fix URLs escaping when a qualifier contains escaped chars.
Thu, Sep 24, 5:39 PM
anlambert added a project to T2636: Modify generation of full-context SWHID for root artifacts by omitting path classifier : Web app.
Thu, Sep 24, 12:52 PM · Web app, SWORD deposit, Data Model
anlambert added a comment to T2641: Fix SWHID resolving when origin qualifier has an equal character in its value.

Hopefully, the issue is related to missing URL escaping in the webapp. I implemented the fix, still some tests to write and I will push a diff during the afternoon.

Thu, Sep 24, 12:22 PM · Web app
anlambert renamed T2641: Fix SWHID resolving when origin qualifier has an equal character in its value from Fix permalink with double // at the end to Fix SWHID resolving when origin qualifier has an equal character in its value.
Thu, Sep 24, 11:30 AM · Web app
anlambert added a comment to T2641: Fix SWHID resolving when origin qualifier has an equal character in its value.

The issue is not related to the double slash at the end of the permalink but rather from the fact that the origin URL contains a = character in it (https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://cran.r-project.org/package%3DActivePathways). I will fix that asap.

Thu, Sep 24, 11:29 AM · Web app
anlambert added a comment to T2640: Add link from the main archive to the Bitbucket mercurial case (https://bitbucket-archive.softwareheritage.org/).

This URL points to the mercurial repositories archived by Octobus in their original form which have not yet been fully loaded into the archive.
Plus we also archive public git repositories from Bitbucket so I do not think replacing the link to bibucket.org is the right thing to do here.

Thu, Sep 24, 11:20 AM · Web app
anlambert added a comment to T2636: Modify generation of full-context SWHID for root artifacts by omitting path classifier .

Should this also be removed from the "Permalinks" tab in the webapp ?

Thu, Sep 24, 10:25 AM · Web app, SWORD deposit, Data Model

Wed, Sep 23

anlambert committed rDWAPPSef0f7ae0e726: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, Sep 23, 4:08 PM
anlambert committed rDWAPPS67b63a4ed443: assets/revision: Enable link to revision changes view with URL fragment (authored by anlambert).
assets/revision: Enable link to revision changes view with URL fragment
Wed, Sep 23, 4:08 PM
anlambert closed D4020: assets/revision: Enable link to revision changes view with URL fragment.
Wed, Sep 23, 4:08 PM
anlambert created D4020: assets/revision: Enable link to revision changes view with URL fragment.
Wed, Sep 23, 2:59 PM

Tue, Sep 22

anlambert accepted D4011: core.config: Decrease configuration loaded path log message to debug.

DEBUG log level seems a better choice indeed.

Tue, Sep 22, 5:18 PM
anlambert committed rDWAPPS023f0e60dc22: api/apiresponse: Add typing information (authored by anlambert).
api/apiresponse: Add typing information
Tue, Sep 22, 4:50 PM
anlambert closed D4010: api/apiresponse: Add typing information.
Tue, Sep 22, 4:50 PM
anlambert updated the diff for D4010: api/apiresponse: Add typing information.

Update: Fix and simplify make_api_response code.

Tue, Sep 22, 4:20 PM
anlambert created D4010: api/apiresponse: Add typing information.
Tue, Sep 22, 4:15 PM
anlambert committed rDWAPPS5f070f05d3a4: common/service: Add lookup_origins_by_sha1s function (authored by anlambert).
common/service: Add lookup_origins_by_sha1s function
Tue, Sep 22, 4:14 PM
anlambert closed D4009: common/service: Add lookup_origins_by_sha1s function.
Tue, Sep 22, 4:14 PM
anlambert changed the status of T2589: expose swh-graph API at archive.s.o/api/1/graph/ from Open to Work in Progress.
Tue, Sep 22, 3:39 PM · System administration, Web app, Graph service
anlambert added a revision to T2113: swh-graph: add support to optionally resolve ori PIDs to origin URLs: D4009: common/service: Add lookup_origins_by_sha1s function.
Tue, Sep 22, 3:39 PM · Graph service
anlambert added a revision to T2589: expose swh-graph API at archive.s.o/api/1/graph/: D4009: common/service: Add lookup_origins_by_sha1s function.
Tue, Sep 22, 3:39 PM · System administration, Web app, Graph service
anlambert created D4009: common/service: Add lookup_origins_by_sha1s function.
Tue, Sep 22, 3:39 PM
anlambert committed rDCOREbfca0a8d63ff: Makefile.local: Fix "make test" execution (authored by anlambert).
Makefile.local: Fix "make test" execution
Tue, Sep 22, 3:11 PM
anlambert closed D4008: Makefile.local: Fix "make test" execution.
Tue, Sep 22, 3:11 PM
anlambert updated the diff for D4008: Makefile.local: Fix "make test" execution.

Add missing newline at end of file

Tue, Sep 22, 2:59 PM
anlambert created D4008: Makefile.local: Fix "make test" execution.
Tue, Sep 22, 2:58 PM
anlambert added a project to T2613: Web UI: make "save code now" icon consistent (and look like a camera): Easy hack.
Tue, Sep 22, 2:22 PM · Easy hack, Web app
anlambert committed rDWAPPSbaaefd62d8c5: common/origin_save: Fix save request task running status reporting (authored by anlambert).
common/origin_save: Fix save request task running status reporting
Tue, Sep 22, 2:20 PM
anlambert closed D4005: common/origin_save: Fix save request task running status reporting.
Tue, Sep 22, 2:20 PM
anlambert committed rDWAPPSc53756359a43: origin_save: Fix typo in a save task status (s/succeed/succeeded/) (authored by anlambert).
origin_save: Fix typo in a save task status (s/succeed/succeeded/)
Tue, Sep 22, 2:20 PM
anlambert closed T2614: Web UI: add status "ongoing" for "save code now" requests as Resolved by committing rDWAPPSbaaefd62d8c5: common/origin_save: Fix save request task running status reporting.
Tue, Sep 22, 2:20 PM · Web app
anlambert closed T2615: Web UI: typo in success status for save code now requests: "succeed" -> "succeeded" as Resolved by committing rDWAPPSc53756359a43: origin_save: Fix typo in a save task status (s/succeed/succeeded/).
Tue, Sep 22, 2:20 PM · Easy hack, Web app
anlambert closed D4004: origin_save: Fix typo in a save task status (s/succeed/succeeded/).
Tue, Sep 22, 2:20 PM
anlambert added a comment to D4004: origin_save: Fix typo in a save task status (s/succeed/succeeded/).
In D4004#98985, @zack wrote:

Caveat: as this results in an API change (I think), it should be announced on the swh-devel mailing list before deployment.

Oh right, it changes a returned value. I will send a mail during the afternoon.

Tue, Sep 22, 2:19 PM
anlambert updated the diff for D4005: common/origin_save: Fix save request task running status reporting.

Rebase

Tue, Sep 22, 1:53 PM
anlambert updated the diff for D4004: origin_save: Fix typo in a save task status (s/succeed/succeeded/).

Rebase

Tue, Sep 22, 1:51 PM
anlambert committed rDWAPPS1694f6b03f9b: templates/apidoc-header: Add section about UTF-8 decoding errors (authored by anlambert).
templates/apidoc-header: Add section about UTF-8 decoding errors
Tue, Sep 22, 1:49 PM
anlambert closed T2617: Improve UTF8 UnicodeDecodeError handling in JSON conversion layer and update API documentation as Resolved by committing rDWAPPS1694f6b03f9b: templates/apidoc-header: Add section about UTF-8 decoding errors.
Tue, Sep 22, 1:49 PM · Web app
anlambert committed rDWAPPSc56cbbb64bdb: common/converters: Harmonize UTF-8 decoding errors handling (authored by anlambert).
common/converters: Harmonize UTF-8 decoding errors handling
Tue, Sep 22, 1:49 PM
anlambert closed D4003: common/converters: Harmonize UTF-8 decoding errors handling.
Tue, Sep 22, 1:49 PM
anlambert added a comment to D4004: origin_save: Fix typo in a save task status (s/succeed/succeeded/).
In D4004#98985, @zack wrote:

Caveat: as this results in an API change (I think), it should be announced on the swh-devel mailing list before deployment.

Tue, Sep 22, 1:47 PM
anlambert added a revision to T2614: Web UI: add status "ongoing" for "save code now" requests: D4005: common/origin_save: Fix save request task running status reporting.
Tue, Sep 22, 12:38 PM · Web app
anlambert created D4005: common/origin_save: Fix save request task running status reporting.
Tue, Sep 22, 12:38 PM
anlambert added a revision to T2615: Web UI: typo in success status for save code now requests: "succeed" -> "succeeded": D4004: origin_save: Fix typo in a save task status (s/succeed/succeeded/).
Tue, Sep 22, 12:30 PM · Easy hack, Web app
anlambert created D4004: origin_save: Fix typo in a save task status (s/succeed/succeeded/).
Tue, Sep 22, 12:30 PM
anlambert added a revision to T2617: Improve UTF8 UnicodeDecodeError handling in JSON conversion layer and update API documentation: D4003: common/converters: Harmonize UTF-8 decoding errors handling.
Tue, Sep 22, 12:22 PM · Web app
anlambert created D4003: common/converters: Harmonize UTF-8 decoding errors handling.
Tue, Sep 22, 12:22 PM
anlambert committed rDWAPPSc45a6af2f7e0: auth: Add web UI for API bearer tokens management (authored by anlambert).
auth: Add web UI for API bearer tokens management
Tue, Sep 22, 12:21 PM
anlambert closed T2569: Add Web UI to generate and revoke bearer tokens as Resolved by committing rDWAPPSc45a6af2f7e0: auth: Add web UI for API bearer tokens management.
Tue, Sep 22, 12:21 PM · Web app
anlambert closed T2569: Add Web UI to generate and revoke bearer tokens, a subtask of T1927: Web app: rate limiting based on per-client API tokens, as Resolved.
Tue, Sep 22, 12:21 PM · Web app
anlambert closed D3996: auth: Add web UI for API bearer tokens management.
Tue, Sep 22, 12:21 PM
anlambert updated the diff for D3996: auth: Add web UI for API bearer tokens management.

Update: Address @ardumont comments

Tue, Sep 22, 11:03 AM
anlambert added a comment to D3996: auth: Add web UI for API bearer tokens management.

@ardumont, thanks for the review. I will update the diff according to your comments before landing this.

Tue, Sep 22, 10:48 AM

Mon, Sep 21

anlambert added a comment to T2614: Web UI: add status "ongoing" for "save code now" requests.

In fact, the "ongoing" task state was captured by swh-web and the save request status was displayed as "running" prior to the model migration towards origin visit statuses.

Mon, Sep 21, 3:32 PM · Web app
anlambert triaged T2617: Improve UTF8 UnicodeDecodeError handling in JSON conversion layer and update API documentation as Normal priority.
Mon, Sep 21, 3:23 PM · Web app

Fri, Sep 18

anlambert updated the diff for D3996: auth: Add web UI for API bearer tokens management.

Update: Fix cypress tests

Fri, Sep 18, 5:21 PM
anlambert accepted D3983: blackify: auto format python code with black.
In D3983#98691, @zack wrote:

The repository is missing configuration for using black. Could you add the pre-commit hook and the black configuration in pyproject.toml as in other swh repos ?

Oops, I didn't notice that, good catch!

Should be done now.

Fri, Sep 18, 5:20 PM
anlambert added a revision to T2569: Add Web UI to generate and revoke bearer tokens: D3996: auth: Add web UI for API bearer tokens management.
Fri, Sep 18, 4:59 PM · Web app
anlambert created D3996: auth: Add web UI for API bearer tokens management.
Fri, Sep 18, 4:59 PM
anlambert accepted D3993: Small fix in the graph replayer to prevent a wrong warning.
Fri, Sep 18, 4:48 PM