Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

Projects (7)

User Details

User Since
Jul 3 2017, 10:14 AM (197 w, 5 d)

Recent Activity

Fri, Apr 16

anlambert requested review of D5550: tox: Add a sphinx environment to check sane doc build.
Fri, Apr 16, 7:17 PM
anlambert closed D5547: docs/Makefile: Remove no longer needed target.
Fri, Apr 16, 4:34 PM
anlambert committed rDLDBASE227c78ca28c7: docs/Makefile: Remove no longer needed target (authored by anlambert).
docs/Makefile: Remove no longer needed target
Fri, Apr 16, 4:34 PM
anlambert requested review of D5548: exporters/edges: Fix sphinx warning.
Fri, Apr 16, 3:26 PM
anlambert added a revision to T2265: Building the documentation should not show any warning.: D5548: exporters/edges: Fix sphinx warning.
Fri, Apr 16, 3:26 PM · Easy hack, Documentation
anlambert added a comment to T2265: Building the documentation should not show any warning..

\o/ https://jenkins.softwareheritage.org/job/DDOC/job/dev/5528/

Fri, Apr 16, 2:54 PM · Easy hack, Documentation
anlambert closed D5546: cli: Fix sphinx warning.
Fri, Apr 16, 2:38 PM
anlambert committed rDGRPH04a1656c104e: cli: Fix sphinx warning (authored by anlambert).
cli: Fix sphinx warning
Fri, Apr 16, 2:38 PM
anlambert updated the diff for D5546: cli: Fix sphinx warning.

Use :file: role instead of escaping *.

Fri, Apr 16, 2:34 PM
anlambert requested review of D5546: cli: Fix sphinx warning.
Fri, Apr 16, 2:26 PM
anlambert requested review of D5547: docs/Makefile: Remove no longer needed target.
Fri, Apr 16, 2:24 PM
anlambert added a comment to D5544: docs/cli: Fix sphinx warning.

Arf, still two warnings remaining but no clear indication where they come from: https://jenkins.softwareheritage.org/job/DDOC/job/dev/5526/artifact/swh-docs/docs/errors.log/*view*/

Fri, Apr 16, 2:16 PM
anlambert accepted D5545: phabricator: Emphasize the 'arc diff --update' message should not be the default one..
Fri, Apr 16, 2:15 PM
anlambert added a revision to T2265: Building the documentation should not show any warning.: D5546: cli: Fix sphinx warning.
Fri, Apr 16, 2:14 PM · Easy hack, Documentation
anlambert added a comment to D5544: docs/cli: Fix sphinx warning.

Arf, still two warnings remaining but no clear indication where they come from: https://jenkins.softwareheritage.org/job/DDOC/job/dev/5526/artifact/swh-docs/docs/errors.log/*view*/

Fri, Apr 16, 12:55 PM
anlambert closed D5544: docs/cli: Fix sphinx warning.
Fri, Apr 16, 12:44 PM
anlambert committed rDCORE80832699e01d: docs/cli: Fix sphinx warning (authored by anlambert).
docs/cli: Fix sphinx warning
Fri, Apr 16, 12:44 PM
anlambert added a comment to D5544: docs/cli: Fix sphinx warning.

Uh? That wasn't an issue for me

Fri, Apr 16, 12:43 PM
anlambert requested review of D5544: docs/cli: Fix sphinx warning.
Fri, Apr 16, 12:31 PM
anlambert added a comment to D5543: multiplexer_objstorage: Fix sphinx warning and napoleon style.

Oh, looks like I forgot to submit my commit for this...

Ack, there is also a remaining warning in swh-core. I guess you must have forgot to push that fix too ?

Fri, Apr 16, 12:30 PM
anlambert added a revision to T2265: Building the documentation should not show any warning.: D5544: docs/cli: Fix sphinx warning.
Fri, Apr 16, 12:30 PM · Easy hack, Documentation
anlambert closed D5543: multiplexer_objstorage: Fix sphinx warning and napoleon style.
Fri, Apr 16, 12:26 PM
anlambert committed rDOBJSe92746e15d8d: multiplexer_objstorage: Fix sphinx warning and napoleon style (authored by anlambert).
multiplexer_objstorage: Fix sphinx warning and napoleon style
Fri, Apr 16, 12:26 PM
anlambert added a comment to D5543: multiplexer_objstorage: Fix sphinx warning and napoleon style.

Oh, looks like I forgot to submit my commit for this...

Fri, Apr 16, 12:25 PM
anlambert requested review of D5543: multiplexer_objstorage: Fix sphinx warning and napoleon style.
Fri, Apr 16, 12:07 PM
anlambert added a revision to T2265: Building the documentation should not show any warning.: D5543: multiplexer_objstorage: Fix sphinx warning and napoleon style.
Fri, Apr 16, 12:06 PM · Easy hack, Documentation
anlambert updated the diff for D5484: assets/webapp-utils: Add SWHID validation in search inputs.

Rebase

Fri, Apr 16, 11:55 AM
anlambert added a comment to T3252: Better handling of erroneous origins submitted to save code now.

+1, can you create a task about it ? This could be handled by a GSOC student who chooses to
work on the webapp.

sure done respectively T3256 then T3257.

Fri, Apr 16, 11:54 AM · Roadmap 2021, System administrators, Web app
anlambert added a comment to T3252: Better handling of erroneous origins submitted to save code now.
In T3252#63374, @zack wrote:

but adding an email field (auto filled for registered users) to send a notification after the origin was loaded seems a good tradeoff. To implement the email notification, we will have to add a journal client in swh-web processing origin visit messages.

Adding an email field is a poor UX solution (it needs to be reentered every time or saved in a cookie) which we used for the vault at the time because we didn't have user registration.
Now that we have user registration we can just tell users that if they want to be notified, they should login. (Which is indeed something independent from requiring user registration for being able to submit.) That will encourage users to register to have added-value functionalitlies, like notifications.
And then we should go back to all places that could use notifications (vault, save code now, deposit, "save again" button) and uniform things.

Fri, Apr 16, 11:48 AM · Roadmap 2021, System administrators, Web app
anlambert added a comment to D5484: assets/webapp-utils: Add SWHID validation in search inputs.

Nice! Why the green labels/checkboxes/dropdowns?

Fri, Apr 16, 11:17 AM
anlambert added a comment to T3252: Better handling of erroneous origins submitted to save code now.

As a first step towards giving more feedback for users who submitted wrong origins for
ingestion (e.g. organization links, tarballs with wrong visit type, link to html page
probably for listing, etc...). We could allow the operator which rejects the origins a
free form input field so they could explain the reason of the rejection. It'd be less
brutal a rejection.

This does not require the user registration part discussed above nor does it exclude it.

Bonus point for this, it's an easy hack ;)

As an incremental step after that, we could make that a configurable predefined template
selection box of rejecting reasons as I don't think there are so many different reasons
after all (unsupported for now, not an origin of type <type>, not a repository link,
...). Drawing stats from the first implementation could help in designing the initial
templates of rejection.

Which could be another easy hack once the first part is done (if we want).

As suggested to @anlambert recently (@antoine, given it a bit more thought and added the
second incremental part since then thus the ping ;)

Fri, Apr 16, 11:13 AM · Roadmap 2021, System administrators, Web app
anlambert added a comment to T3252: Better handling of erroneous origins submitted to save code now.
In T3252#63315, @zack wrote:

Oh, and now that we have user profile pages, we should have a list of "my" save code now requests with their status visible in the user profile, for those who want to check synchronously the status of their requests (and might have disabled email notifications).

Fri, Apr 16, 11:11 AM · Roadmap 2021, System administrators, Web app
anlambert added a comment to T3252: Better handling of erroneous origins submitted to save code now.
In T3252#63314, @zack wrote:

It would be desirable to provide the user with feedback that helps fix the issue.

Totally.

Now that we have a decent user registration system I think we should consider:

  1. requiring user registration for submitting save code now requests (which will also provide an audit trail for users that repeatedly submit bogus if not actively harmful requests)
  2. send by default email notifications about the outcome of save code now requests, both successes and failures, with the possibility of disabling email notifications in the user profile

This will make the overall UX of interacting with the archive feel much more "reliable" for users, whereas right now it feels much like a leap of faith whether it will work or not, in good part due to the lack of systematic out-of-band notifications.

Fri, Apr 16, 11:11 AM · Roadmap 2021, System administrators, Web app

Thu, Apr 15

anlambert accepted D5538: cassandra: Use prepared statements in extid_index_*.
Thu, Apr 15, 4:11 PM
anlambert closed D5532: developer-setup: Add nodejs 12 install instructions.
Thu, Apr 15, 3:46 PM
anlambert committed rDDOCc67b75fbfc48: developer-setup: Add nodejs 12 install instructions (authored by anlambert).
developer-setup: Add nodejs 12 install instructions
Thu, Apr 15, 3:46 PM
anlambert updated the diff for D5532: developer-setup: Add nodejs 12 install instructions.

Rebase

Thu, Apr 15, 3:45 PM
anlambert updated the diff for D4629: [POC] OpenAPI and Django REST Framework to specify / implement API v2.

Rebase

Thu, Apr 15, 3:14 PM
anlambert accepted D5535: tests: Complete checks on message with priority consumption.

Looks good to me.

Thu, Apr 15, 3:00 PM
anlambert closed D5533: developer-setup: Ensure lsb_release for dependencies installation.
Thu, Apr 15, 2:25 PM
anlambert committed rDDOC4b153225b2b3: developer-setup: Ensure lsb_release for dependencies installation (authored by anlambert).
developer-setup: Ensure lsb_release for dependencies installation
Thu, Apr 15, 2:25 PM
anlambert requested changes to D5535: tests: Complete checks on message with priority consumption.
Thu, Apr 15, 2:21 PM
anlambert closed D5534: cypress/origin-save: Fix a flaky test.
Thu, Apr 15, 1:49 PM
anlambert committed rDWAPPSb095564e54d4: cypress/origin-save: Fix a flaky test (authored by anlambert).
cypress/origin-save: Fix a flaky test
Thu, Apr 15, 1:49 PM
anlambert accepted D5537: Disable colors when running sphinx-build.
Thu, Apr 15, 1:43 PM
anlambert accepted D5536: Enable sphinx-build --color by default.
Thu, Apr 15, 1:42 PM
anlambert added a comment to D5533: developer-setup: Ensure lsb_release for dependencies installation.

why is it needed?

Thu, Apr 15, 12:41 PM
anlambert requested review of D5534: cypress/origin-save: Fix a flaky test.
Thu, Apr 15, 12:26 PM
anlambert accepted D5514: Fix various Sphinx warnings.
Thu, Apr 15, 12:01 PM
anlambert closed D5519: urls: Remove trailing slash in SWHID resolving URL.
Thu, Apr 15, 12:00 PM
anlambert committed rDWAPPS1fde4999ff7b: urls: Remove trailing slash in SWHID resolving URL (authored by anlambert).
urls: Remove trailing slash in SWHID resolving URL
Thu, Apr 15, 12:00 PM
anlambert requested review of D5533: developer-setup: Ensure lsb_release for dependencies installation.
Thu, Apr 15, 11:59 AM
anlambert requested review of D5532: developer-setup: Add nodejs 12 install instructions.
Thu, Apr 15, 11:54 AM
anlambert updated the diff for D5519: urls: Remove trailing slash in SWHID resolving URL.

Rebase

Thu, Apr 15, 11:25 AM
anlambert closed T3248: FileNotFoundError when autodocumenting highlightjs.py, a subtask of T2265: Building the documentation should not show any warning., as Resolved.
Thu, Apr 15, 10:51 AM · Easy hack, Documentation
anlambert closed D5530: django_settings: Ensure swh-web can find its static files with autodoc.
Thu, Apr 15, 10:51 AM
anlambert closed T3248: FileNotFoundError when autodocumenting highlightjs.py as Resolved by committing rDDOC6a380d85e4c1: django_settings: Ensure swh-web can find its static files with autodoc.
Thu, Apr 15, 10:51 AM · Web app, Documentation
anlambert committed rDDOC6a380d85e4c1: django_settings: Ensure swh-web can find its static files with autodoc (authored by anlambert).
django_settings: Ensure swh-web can find its static files with autodoc
Thu, Apr 15, 10:51 AM
anlambert updated the diff for D5530: django_settings: Ensure swh-web can find its static files with autodoc.

Rebase

Thu, Apr 15, 10:51 AM

Wed, Apr 14

anlambert added a comment to T3248: FileNotFoundError when autodocumenting highlightjs.py.

Proper fix is in D5530.

Wed, Apr 14, 9:01 PM · Web app, Documentation
anlambert requested review of D5530: django_settings: Ensure swh-web can find its static files with autodoc.
Wed, Apr 14, 9:01 PM
anlambert added a revision to T3248: FileNotFoundError when autodocumenting highlightjs.py: D5530: django_settings: Ensure swh-web can find its static files with autodoc.
Wed, Apr 14, 9:01 PM · Web app, Documentation
anlambert closed D5528: sql/Makefile: Also call dropdb prior createdb when using pifpaf.
Wed, Apr 14, 6:51 PM
anlambert committed rDSTOb999952e076b: sql/Makefile: Also call dropdb prior createdb when using pifpaf (authored by anlambert).
sql/Makefile: Also call dropdb prior createdb when using pifpaf
Wed, Apr 14, 6:50 PM
anlambert requested review of D5528: sql/Makefile: Also call dropdb prior createdb when using pifpaf.
Wed, Apr 14, 6:47 PM
anlambert committed rDDOC99375de4fd27: Makefile.local: Properly install swh.docs and requirements with pip (authored by anlambert).
Makefile.local: Properly install swh.docs and requirements with pip
Wed, Apr 14, 6:44 PM
anlambert closed D5523: cypress: Upgrade to 7.x.
Wed, Apr 14, 6:13 PM
anlambert committed rDWAPPS4c487ce6ac73: cypress: Upgrade to 7.x (authored by anlambert).
cypress: Upgrade to 7.x
Wed, Apr 14, 6:13 PM
anlambert updated the diff for D5523: cypress: Upgrade to 7.x.

Rebase

Wed, Apr 14, 6:00 PM
anlambert added inline comments to D5520: Route priority tasks to dedicated save code now queues.
Wed, Apr 14, 5:55 PM
anlambert committed rDDOCb05a6f5b9edf: Makefile.local/pip-install-swh-dev: Add missing requirements install (authored by anlambert).
Makefile.local/pip-install-swh-dev: Add missing requirements install
Wed, Apr 14, 5:44 PM
anlambert requested review of D5523: cypress: Upgrade to 7.x.
Wed, Apr 14, 5:40 PM
anlambert committed rDDOC05ea2af58bbe: tox/sphinx-dev: s/allowlist_externals/whitelist_externals/ (authored by anlambert).
tox/sphinx-dev: s/allowlist_externals/whitelist_externals/
Wed, Apr 14, 5:29 PM
anlambert closed D5525: tox/sphinx-dev: Workaround really long dependencies installation.
Wed, Apr 14, 5:17 PM
anlambert committed rDDOC31bf3482e3f9: tox/sphinx-dev: Workaround really long dependencies installation (authored by anlambert).
tox/sphinx-dev: Workaround really long dependencies installation
Wed, Apr 14, 5:17 PM
anlambert added a comment to D5525: tox/sphinx-dev: Workaround really long dependencies installation.

lgtm

plus it matches how we do it in the bin/install (or update or both) we mention in the docs.

Wed, Apr 14, 5:17 PM
anlambert closed D5521: base-buster: Upgrade nodejs from 10.x to 12.x.
Wed, Apr 14, 5:12 PM
anlambert committed rCDFJ35f6509a0a3a: base-buster: Upgrade nodejs from 10.x to 12.x (authored by anlambert).
base-buster: Upgrade nodejs from 10.x to 12.x
Wed, Apr 14, 5:12 PM
anlambert updated the summary of D5521: base-buster: Upgrade nodejs from 10.x to 12.x.
Wed, Apr 14, 4:53 PM
anlambert added a reviewer for D5521: base-buster: Upgrade nodejs from 10.x to 12.x: Reviewers.
Wed, Apr 14, 4:53 PM
anlambert requested review of D5525: tox/sphinx-dev: Workaround really long dependencies installation.
Wed, Apr 14, 4:39 PM
anlambert accepted D5524: Add the configuration for the source of object counters.

Looks good to me.

Wed, Apr 14, 3:57 PM
anlambert added a comment to T3202: Help new users discover the features available in the archive browsing view.

chardin.js library is also interesting, it creates a simple overlay to display instructions on existent elements instead of using popups.

Wed, Apr 14, 3:17 PM · Web app
anlambert added a comment to T3202: Help new users discover the features available in the archive browsing view.

Bootstrap Tour also looks great, simple to use, easy configuration, also a good candidate.

Wed, Apr 14, 2:59 PM · Web app
anlambert added a comment to T3202: Help new users discover the features available in the archive browsing view.

The intro.js library seems pretty simple to use, can be configured through JSON, can provide guided tour but also UI hints and is highly customizable.

Wed, Apr 14, 2:51 PM · Web app
anlambert accepted D5520: Route priority tasks to dedicated save code now queues.

Looks good to me.

Wed, Apr 14, 2:03 PM
anlambert requested review of D5521: base-buster: Upgrade nodejs from 10.x to 12.x.
Wed, Apr 14, 1:43 PM
anlambert added a revision to T3247: Implement SWHID validation in frontend: D5484: assets/webapp-utils: Add SWHID validation in search inputs.
Wed, Apr 14, 11:43 AM · Web app
anlambert updated the summary of D5484: assets/webapp-utils: Add SWHID validation in search inputs.
Wed, Apr 14, 11:43 AM
anlambert updated the diff for D5484: assets/webapp-utils: Add SWHID validation in search inputs.

Rebase

Wed, Apr 14, 11:43 AM
anlambert requested review of D5519: urls: Remove trailing slash in SWHID resolving URL.
Wed, Apr 14, 11:42 AM
anlambert added a revision to T3234: Handle gracefully trailing slashes when resolving SWHID in search box: D5519: urls: Remove trailing slash in SWHID resolving URL.
Wed, Apr 14, 11:35 AM · Web app

Tue, Apr 13

anlambert added a comment to D5497: Remove old lister tutorial..

You can mark the file as orphan to fix the warning and avoid removing it.

Tue, Apr 13, 5:33 PM
anlambert accepted D5500: Fix syntax of reference to persistent-identifiers..
Tue, Apr 13, 5:31 PM
anlambert accepted D5499: docs: Fix db-schema.svg generation to use pifpaf-created database.
Tue, Apr 13, 5:31 PM
anlambert updated the summary of D5484: assets/webapp-utils: Add SWHID validation in search inputs.
Tue, Apr 13, 5:11 PM
anlambert updated the summary of D5484: assets/webapp-utils: Add SWHID validation in search inputs.
Tue, Apr 13, 5:08 PM
anlambert retitled D5484: assets/webapp-utils: Add SWHID validation in search inputs from assets/webapp-utils: Automatically fix malformed SWHID in search inputs to assets/webapp-utils: Add SWHID validation in search inputs.
Tue, Apr 13, 5:07 PM
anlambert updated the diff for D5484: assets/webapp-utils: Add SWHID validation in search inputs.

Update: Validate SWHID and report any parsing errors instead of autofixing it.

Tue, Apr 13, 5:06 PM
anlambert closed D5487: identifiers: Fix parsing of SWHID qualifier value containing '='.
Tue, Apr 13, 3:27 PM