Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

Projects

User Details

User Since
Jul 3 2017, 10:14 AM (110 w, 5 d)

Recent Activity

Fri, Aug 9

anlambert added a comment to D1837: cypress: Add tests for the vault features.

@ardumont, you can check the effect of that test through the cypress UI.

Fri, Aug 9, 5:05 PM
anlambert committed rCJSWH3ae832a312fd: jobs/templates: Only fetch master branch in Phabricator Diff related jobs (authored by anlambert).
jobs/templates: Only fetch master branch in Phabricator Diff related jobs
Fri, Aug 9, 4:44 PM
anlambert closed D1839: Jenkins: Only fetch master branch in Phabricator Diff related jobs.
Fri, Aug 9, 4:44 PM
anlambert updated the diff for D1839: Jenkins: Only fetch master branch in Phabricator Diff related jobs.

Update: Fix indentation

Fri, Aug 9, 4:40 PM
Herald added a reviewer for D1839: Jenkins: Only fetch master branch in Phabricator Diff related jobs: Reviewers.
Fri, Aug 9, 4:39 PM
Herald added a reviewer for D1837: cypress: Add tests for the vault features: Reviewers.
Fri, Aug 9, 3:15 PM
anlambert committed rDWAPPS244a1dbac991: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Fri, Aug 9, 2:43 PM
anlambert committed rCJSWHdf241afe7497: templates/swh-pipeline: Set Phabricator as git repository browser (authored by anlambert).
templates/swh-pipeline: Set Phabricator as git repository browser
Fri, Aug 9, 1:20 PM
anlambert closed D1834: Jenkins: Set Phabricator as git repository browser.
Fri, Aug 9, 1:20 PM
anlambert updated the diff for D1834: Jenkins: Set Phabricator as git repository browser.

Update: Use correct repoUrl and add same setting to cypress job

Fri, Aug 9, 1:19 PM

Thu, Aug 8

Herald added a reviewer for D1834: Jenkins: Set Phabricator as git repository browser: Reviewers.
Thu, Aug 8, 6:02 PM
anlambert committed rDWAPPS39f81a324556: cypress/support: Prefer to retrieve objects metadata through the API (authored by anlambert).
cypress/support: Prefer to retrieve objects metadata through the API
Thu, Aug 8, 5:32 PM
anlambert committed rDWAPPS1d9ff31a6af9: assets/vault: Fix slow vault UI bootstrapping on Chromium based browsers (authored by anlambert).
assets/vault: Fix slow vault UI bootstrapping on Chromium based browsers
Thu, Aug 8, 5:32 PM
anlambert committed rDWAPPS0fde53871125: assets: Remove dead code (authored by anlambert).
assets: Remove dead code
Thu, Aug 8, 5:32 PM
anlambert committed rDWAPPScffbd902002e: webpack: Optimize generated Javascript bundle sizes (authored by anlambert).
webpack: Optimize generated Javascript bundle sizes
Thu, Aug 8, 5:32 PM
anlambert added inline comments to D1824: swh.loader.package: Implement GNU Loader.
Thu, Aug 8, 1:54 PM
anlambert added inline comments to D1824: swh.loader.package: Implement GNU Loader.
Thu, Aug 8, 1:52 PM

Wed, Aug 7

anlambert committed rDWAPPScda602a33c07: swh-web: Change 'Save code now' url from /browse/origin/save to /save (authored by anlambert).
swh-web: Change 'Save code now' url from /browse/origin/save to /save
Wed, Aug 7, 5:15 PM
anlambert committed rDWAPPS11924dc3a31f: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, Aug 7, 5:15 PM
anlambert committed rDWAPPS02f5024cee8c: swh-web: Reorganize and cleanup some views implementation and declaration (authored by anlambert).
swh-web: Reorganize and cleanup some views implementation and declaration
Wed, Aug 7, 5:15 PM
anlambert closed T1909: Enable to manually select the programming language to highlight as Resolved.

Closed by rDWAPPS393deaa5b18c602a27a550836d7e05f049986804

Wed, Aug 7, 5:00 PM · GSoC 2019, Web app
anlambert accepted D1823: cypress: Refactor tests.

Looks good to me, let's land this !

Wed, Aug 7, 3:01 PM
anlambert committed rCJSWHddae007fed8e: jobs/templates: Add missing curly braces escaping (authored by anlambert).
jobs/templates: Add missing curly braces escaping
Wed, Aug 7, 2:47 PM
anlambert closed D1830: Jenkins: Add missing curly braces escaping.
Wed, Aug 7, 2:47 PM
Herald added a reviewer for D1830: Jenkins: Add missing curly braces escaping: Reviewers.
Wed, Aug 7, 2:43 PM
anlambert committed rCJSWH40bbd17a9cd0: jobs/templates: Create Harbomaster URI artifact with Jenkins build url (authored by anlambert).
jobs/templates: Create Harbomaster URI artifact with Jenkins build url
Wed, Aug 7, 2:23 PM
anlambert closed D1828: Jenkins: Create Harbomaster URI artifact with build job url.
Wed, Aug 7, 2:23 PM
anlambert committed rCJSWH06002fe8b11d: jobs/templates: Put swh-pipeline in a separate groovy file (authored by anlambert).
jobs/templates: Put swh-pipeline in a separate groovy file
Wed, Aug 7, 2:23 PM
anlambert closed D1827: Jenkins: Put swh-pipeline in a separate groovy file.
Wed, Aug 7, 2:23 PM
anlambert added a comment to T1942: Create shorter url redirecting to "Save code now".

That is definitely worth doing, as /browse/origin/save is not really semantically sound.

Wed, Aug 7, 2:01 PM · Website
Herald added a reviewer for D1828: Jenkins: Create Harbomaster URI artifact with build job url: Reviewers.
Wed, Aug 7, 1:54 PM
Herald added a reviewer for D1827: Jenkins: Put swh-pipeline in a separate groovy file: Reviewers.
Wed, Aug 7, 1:44 PM

Tue, Aug 6

anlambert added a parent task for T1768: Add end to end tests for the frontend part of swh-web: T1411: reach a minimum of 80% SLOC coverage across all components.
Tue, Aug 6, 11:32 AM · GSoC 2019, Web app
anlambert added a subtask for T1411: reach a minimum of 80% SLOC coverage across all components: T1768: Add end to end tests for the frontend part of swh-web.
Tue, Aug 6, 11:32 AM · Development environment, Sprint 2018 12
anlambert updated the task description for T1768: Add end to end tests for the frontend part of swh-web.
Tue, Aug 6, 11:32 AM · GSoC 2019, Web app
anlambert updated the task description for T1411: reach a minimum of 80% SLOC coverage across all components.
Tue, Aug 6, 11:31 AM · Development environment, Sprint 2018 12
anlambert accepted D1820: defaults: Move gpg/certificate blocks to a dedicated config file.

Looks good to me. This is helpful as I can't count the number of times the auto-trimming feature of my text editor removed those needed spaces.

Tue, Aug 6, 11:21 AM · System administration

Mon, Aug 5

anlambert added a comment to T1942: Create shorter url redirecting to "Save code now".

Maybe renaming the save code now url to https://archive.softwareheritage.org/save/ would be a good mitigation as it is not hard to remember ?

Mon, Aug 5, 5:09 PM · Website
anlambert committed rCJSWH9060ec050d70: Automatically create swh-web admin user for cypress tests (authored by anlambert).
Automatically create swh-web admin user for cypress tests
Mon, Aug 5, 4:24 PM
anlambert closed D1819: Jenkins: Automatically create swh-web admin user for cypress tests.
Mon, Aug 5, 4:24 PM
Herald added a reviewer for D1819: Jenkins: Automatically create swh-web admin user for cypress tests: Reviewers.
Mon, Aug 5, 4:15 PM
anlambert committed rDWAPPS59db5cd69f3a: tests: Use empty database and register admin user for cypress use (authored by anlambert).
tests: Use empty database and register admin user for cypress use
Mon, Aug 5, 3:45 PM
anlambert accepted D1818: npm: Fix crash on invalid 'author' field..
Mon, Aug 5, 3:16 PM
anlambert accepted D1756: cypress: Test Language-select.

Apart a small nitpick, looks good to me.

Mon, Aug 5, 2:55 PM
anlambert committed rCDFD307ffd6a3783: swh-web/entrypoint: Improve admin user creation script (authored by anlambert).
swh-web/entrypoint: Improve admin user creation script
Mon, Aug 5, 1:06 PM
anlambert closed T1845: Add end to end tests for content rendering, a subtask of T1688: Refactor content rendering, as Resolved.
Mon, Aug 5, 11:14 AM · Web app
anlambert committed rDWAPPS8421487367a4: cypress: Add end to end tests for content rendering (authored by anlambert).
cypress: Add end to end tests for content rendering
Mon, Aug 5, 11:14 AM
anlambert committed rDWAPPS12427620b5ad: common/highlightjs: Improve code highlighting of numerous source files (authored by anlambert).
common/highlightjs: Improve code highlighting of numerous source files
Mon, Aug 5, 11:14 AM
anlambert closed T1845: Add end to end tests for content rendering as Resolved by committing rDWAPPS8421487367a4: cypress: Add end to end tests for content rendering.
Mon, Aug 5, 11:14 AM · Web app
anlambert closed D1672: Add end to end tests for content rendering.
Mon, Aug 5, 11:14 AM
anlambert updated the diff for D1672: Add end to end tests for content rendering.

Rebase

Mon, Aug 5, 11:03 AM

Fri, Aug 2

anlambert accepted D1784: cypress: Test revision diff.

Nice work, thanks !

Fri, Aug 2, 4:38 PM
anlambert closed T1841: Run swh-web's front-end tests on Jenkins as Resolved.
Fri, Aug 2, 4:34 PM · Continuous Integration, Web app
anlambert committed rCJSWHec692539ecdf: Publish test results and code coverage HTML reports for cypress jobs (authored by anlambert).
Publish test results and code coverage HTML reports for cypress jobs
Fri, Aug 2, 4:27 PM
anlambert closed T1913: Generate HTML report for cypress tests, a subtask of T1841: Run swh-web's front-end tests on Jenkins, as Resolved.
Fri, Aug 2, 4:27 PM · Continuous Integration, Web app
anlambert closed T1913: Generate HTML report for cypress tests as Resolved by committing rCJSWHec692539ecdf: Publish test results and code coverage HTML reports for cypress jobs.
Fri, Aug 2, 4:27 PM · Continuous Integration, Web app
anlambert closed D1804: Jenkins: Publish some HTML reports for cypress jobs.
Fri, Aug 2, 4:27 PM
anlambert added a comment to D1804: Jenkins: Publish some HTML reports for cypress jobs.

Yes, I was happily surprised by the results too. Notably, the code coverage report will help to write more relevant cypress tests.

Fri, Aug 2, 4:26 PM
Herald added a reviewer for D1804: Jenkins: Publish some HTML reports for cypress jobs: Reviewers.
Fri, Aug 2, 4:12 PM
anlambert committed rDWAPPSa01295397a91: cypress: Generate code coverage report in HTML using istanbul (authored by anlambert).
cypress: Generate code coverage report in HTML using istanbul
Fri, Aug 2, 3:19 PM
anlambert committed rDWAPPS6694c17fc939: cypress: Generate test results report in HTML using mochawesome (authored by anlambert).
cypress: Generate test results report in HTML using mochawesome
Fri, Aug 2, 3:18 PM
anlambert retitled D1784: cypress: Test revision diff from cypress: Test origin-diff to cypress: Test revision diff.
Fri, Aug 2, 2:59 PM

Thu, Aug 1

anlambert requested changes to D1784: cypress: Test revision diff.

Thanks for working on this!

Thu, Aug 1, 4:08 PM
anlambert committed rDWAPPS0f43878e5ec5: debian/control: Explicitely add python3-magic in Depends section (authored by anlambert).
debian/control: Explicitely add python3-magic in Depends section
Thu, Aug 1, 3:44 PM
anlambert committed rDWAPPS0721db0ce7e8: browse/utils: Use python-magic when available instead of file-magic (authored by anlambert).
browse/utils: Use python-magic when available instead of file-magic
Thu, Aug 1, 3:38 PM
anlambert committed rDWAPPScd747b23ec7f: browse/utils: Properly fix the issue with file-magic (authored by anlambert).
browse/utils: Properly fix the issue with file-magic
Thu, Aug 1, 3:38 PM

Wed, Jul 31

anlambert committed rDWAPPS81e9970a507d: requirements-swh.txt: Bump swh-storage version (authored by anlambert).
requirements-swh.txt: Bump swh-storage version
Wed, Jul 31, 5:37 PM
anlambert committed rDWAPPS5c199f9d36b1: debian/control: Bump swh-storage version (authored by anlambert).
debian/control: Bump swh-storage version
Wed, Jul 31, 5:35 PM
anlambert committed rDCIDXf21d14a63329: api/client: use RPCClient instead of deprecated SWHRemoteAPI (authored by anlambert).
api/client: use RPCClient instead of deprecated SWHRemoteAPI
Wed, Jul 31, 4:19 PM
anlambert closed D1759: Use RPCClient instead of deprecated SWHRemoteAPI.
Wed, Jul 31, 4:19 PM
anlambert updated the diff for D1759: Use RPCClient instead of deprecated SWHRemoteAPI.

Rebase

Wed, Jul 31, 4:16 PM
anlambert committed rDWAPPS1e0f9610cd51: README.md: Update dependencies info (authored by anlambert).
README.md: Update dependencies info
Wed, Jul 31, 4:14 PM
anlambert committed rDWAPPS74a7e9021d17: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, Jul 31, 4:14 PM
anlambert committed rDWAPPS1a65f2e86b21: requirements.txt: Bump minimal required django version (authored by anlambert).
requirements.txt: Bump minimal required django version
Wed, Jul 31, 4:14 PM
anlambert committed rDWAPPScd932368723f: swh-web: Fix debian package build on unstable (authored by anlambert).
swh-web: Fix debian package build on unstable
Wed, Jul 31, 4:14 PM
anlambert committed rDWAPPS7b93b537718b: debian/control: Bump required python3-django version (authored by anlambert).
debian/control: Bump required python3-django version
Wed, Jul 31, 4:14 PM
anlambert committed rPDJRd0dbac0c9b19: debian/changelog: New build (authored by anlambert).
debian/changelog: New build
Wed, Jul 31, 2:29 PM
anlambert committed rPDJR37d982eb8925: Update changelog to bootstrap backport builds (authored by anlambert).
Update changelog to bootstrap backport builds
Wed, Jul 31, 2:06 PM
anlambert committed rPDJR08eeb0a00b50: debian: Bootstrap stretch-swh build (authored by anlambert).
debian: Bootstrap stretch-swh build
Wed, Jul 31, 2:06 PM
anlambert committed rPDJR8efa861d3ad4: debian: Bootstrap buster-swh build (authored by anlambert).
debian: Bootstrap buster-swh build
Wed, Jul 31, 2:06 PM
anlambert committed rPDJR0c2bf195d0ad: Update changelog to bootstrap backport builds (authored by anlambert).
Update changelog to bootstrap backport builds
Wed, Jul 31, 1:58 PM
anlambert committed rPDJR9eeffd1e100c: debian: Bootstrap buster-swh build (authored by anlambert).
debian: Bootstrap buster-swh build
Wed, Jul 31, 1:58 PM
anlambert committed rPDJR538f5588945d: debian: Bootstrap stretch-swh build (authored by anlambert).
debian: Bootstrap stretch-swh build
Wed, Jul 31, 1:58 PM
anlambert committed rPDJR848bd8aa776f: debian: Bootstrap stretch-swh build (authored by anlambert).
debian: Bootstrap stretch-swh build
Wed, Jul 31, 1:37 PM
anlambert committed rPDJRbb2eaf2b5bcc: debian: Bootstrap buster-swh build (authored by anlambert).
debian: Bootstrap buster-swh build
Wed, Jul 31, 1:37 PM
anlambert committed rPDJR5509e6e5a5b2: pristine-tar data for django-js-reverse_0.9.1.orig.tar.gz (authored by anlambert).
pristine-tar data for django-js-reverse_0.9.1.orig.tar.gz
Wed, Jul 31, 12:14 PM
anlambert committed rPDJR22faf54667e0: New upstream version 0.9.1 (authored by anlambert).
New upstream version 0.9.1
Wed, Jul 31, 12:14 PM
anlambert committed rPDJRcb1525a98695: Initial packaging for django-js-reverse (authored by anlambert).
Initial packaging for django-js-reverse
Wed, Jul 31, 12:14 PM
anlambert committed rCJSWHa2eb0647b5bb: dependency-packages: Fix indentation (authored by anlambert).
dependency-packages: Fix indentation
Wed, Jul 31, 12:00 PM
anlambert closed D1786: dependency-packages: Fix indentation.
Wed, Jul 31, 12:00 PM
Herald added a reviewer for D1786: dependency-packages: Fix indentation: Reviewers.
Wed, Jul 31, 11:58 AM
anlambert committed rCJSWH7d149e75cb04: Add python3-django-js-reverse dependency package (authored by anlambert).
Add python3-django-js-reverse dependency package
Wed, Jul 31, 11:56 AM
anlambert closed D1785: Add python3-django-js-reverse dependency package.
Wed, Jul 31, 11:56 AM
Herald added a reviewer for D1785: Add python3-django-js-reverse dependency package: Reviewers.
Wed, Jul 31, 11:50 AM

Tue, Jul 30

anlambert committed rCDFDba4331941b51: Fix swh-vault service by removing calls to deprecated cli (authored by anlambert).
Fix swh-vault service by removing calls to deprecated cli
Tue, Jul 30, 5:33 PM
anlambert committed rDWAPPS0c963102557f: api/vault: Setup a redirection to fetch gitfast archive (authored by anlambert).
api/vault: Setup a redirection to fetch gitfast archive
Tue, Jul 30, 3:54 PM
anlambert committed rDWAPPSd00fea338279: assets: Replace bootstrap-year-calendar-bs4 by js-year-calendar (authored by anlambert).
assets: Replace bootstrap-year-calendar-bs4 by js-year-calendar
Tue, Jul 30, 3:54 PM
anlambert committed rDWAPPSdad2820da2b8: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Tue, Jul 30, 3:54 PM
anlambert added inline comments to D1774: cypress: Add tests for visits.
Tue, Jul 30, 1:31 PM
anlambert accepted D1774: cypress: Add tests for visits.

Looks good to me. Just a small nitpick: can you rename the cypress test file to origin-visits.spec.js before landing this.

Tue, Jul 30, 12:01 PM