Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

User Details

User Since
Jul 3 2017, 10:14 AM (274 w, 3 d)

Recent Activity

Yesterday

anlambert added inline comments to D8171: crates: Loader implements incremental mode.
Thu, Oct 6, 10:41 AM
anlambert accepted D8632: nixguix: Refactor by renaming success or failure the different datasets.
Thu, Oct 6, 10:38 AM

Wed, Oct 5

anlambert added inline comments to D8171: crates: Loader implements incremental mode.
Wed, Oct 5, 5:03 PM
anlambert accepted D8454: Crates.io: Add last_update for each version of a crate.

LGTM, thanks !

Wed, Oct 5, 4:52 PM
anlambert accepted D8631: nixguix: Deal with manifest entries without an integrity field.
Wed, Oct 5, 4:36 PM
anlambert added inline comments to D8631: nixguix: Deal with manifest entries without an integrity field.
Wed, Oct 5, 4:36 PM
anlambert added inline comments to D8631: nixguix: Deal with manifest entries without an integrity field.
Wed, Oct 5, 4:19 PM
anlambert requested changes to D8454: Crates.io: Add last_update for each version of a crate.

Looks good to me, some minor changes to handle before I can accept it though.

Wed, Oct 5, 3:53 PM
anlambert accepted D8630: {Cnt|Dir}Loader: Fix standard/nar hash mismatch behavior to fail loading.
Wed, Oct 5, 3:13 PM
anlambert closed D8628: base-buster/Dockerfile: Use https scheme in all extra apt repositories.
Wed, Oct 5, 1:34 PM
anlambert committed rCDFJceab3633a68a: base-buster/Dockerfile: Use https scheme in all extra apt repositories (authored by anlambert).
base-buster/Dockerfile: Use https scheme in all extra apt repositories
Wed, Oct 5, 1:34 PM
anlambert requested review of D8628: base-buster/Dockerfile: Use https scheme in all extra apt repositories.
Wed, Oct 5, 1:32 PM
anlambert accepted D8626: nixguix: Improve is_tarball detection pattern.
Wed, Oct 5, 12:10 PM
anlambert closed D8627: base-buster/Dockerfile: Install nix binaries in buster image.
Wed, Oct 5, 11:58 AM
anlambert committed rCDFJb7f329d73d65: base-buster/Dockerfile: Install nix binaries in buster image (authored by anlambert).
base-buster/Dockerfile: Install nix binaries in buster image
Wed, Oct 5, 11:58 AM
anlambert closed D8625: docker: Install nix binaries in swh/stack image.
Wed, Oct 5, 11:58 AM
anlambert committed rDENV8e164268c784: docker: Install nix binaries in swh/stack image (authored by anlambert).
docker: Install nix binaries in swh/stack image
Wed, Oct 5, 11:58 AM
anlambert requested review of D8627: base-buster/Dockerfile: Install nix binaries in buster image.
Wed, Oct 5, 11:56 AM
anlambert created P1480 (An Untitled Masterwork).
Wed, Oct 5, 11:42 AM
anlambert requested review of D8625: docker: Install nix binaries in swh/stack image.
Wed, Oct 5, 11:28 AM
anlambert closed D8622: docker/conf: Declare task queues for new nixguix lister and loaders.
Wed, Oct 5, 11:24 AM
anlambert committed rDENV44a2bba3765f: docker/conf: Declare task queues for new nixguix lister and loaders (authored by anlambert).
docker/conf: Declare task queues for new nixguix lister and loaders
Wed, Oct 5, 11:24 AM
anlambert accepted D8624: nixguix: Improve further tarball detection.
Wed, Oct 5, 11:18 AM
anlambert accepted D8623: core.tarball: Add missing mimetype to the list.
Wed, Oct 5, 11:16 AM
anlambert requested review of D8622: docker/conf: Declare task queues for new nixguix lister and loaders.
Wed, Oct 5, 10:58 AM
anlambert added inline comments to D8619: nixguix: Improve tarball detection.
Wed, Oct 5, 10:47 AM

Tue, Oct 4

anlambert created P1478 (An Untitled Masterwork).
Tue, Oct 4, 9:21 PM
anlambert created P1477 (An Untitled Masterwork).
Tue, Oct 4, 9:16 PM
anlambert requested review of D8616: cpan: Align loader implementation with latest lister improvements.
Tue, Oct 4, 5:28 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8616: cpan: Align loader implementation with latest lister improvements.
Tue, Oct 4, 5:24 PM · CPAN lister, Archive coverage
anlambert requested review of D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Tue, Oct 4, 5:22 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Tue, Oct 4, 5:17 PM · CPAN lister, Archive coverage
anlambert added inline comments to D8614: nixguix: Add support for listing origins with "recursive" integrity.
Tue, Oct 4, 5:01 PM
anlambert accepted D8612: nixguix: Add support for pseudo url with missing schema.
Tue, Oct 4, 4:43 PM
anlambert closed D8613: test: Deduplicate tests implementation for loader tasks creation.
Tue, Oct 4, 4:22 PM
anlambert committed rDLDBASEb26b98810d54: test: Deduplicate tests implementation for loader tasks creation (authored by anlambert).
test: Deduplicate tests implementation for loader tasks creation
Tue, Oct 4, 4:22 PM
anlambert requested review of D8613: test: Deduplicate tests implementation for loader tasks creation.
Tue, Oct 4, 4:10 PM
anlambert accepted D8611: nixguix: Deal with connection error with server.
Tue, Oct 4, 3:48 PM
anlambert accepted D8607: nixguix: Deal with impossible communication with server.
Tue, Oct 4, 2:33 PM
anlambert accepted D8606: nixguix: Deal with mistyped origins.
Tue, Oct 4, 2:32 PM
anlambert created P1473 nix recursive hash computation.
Tue, Oct 4, 2:09 PM
anlambert accepted D8341: Add nixguix lister.

Looks good to me, better fixing issues that might araise when testing the lister in new diffs.

Tue, Oct 4, 1:52 PM
anlambert edited P1472 (An Untitled Masterwork).
Tue, Oct 4, 1:47 PM
anlambert created P1472 (An Untitled Masterwork).
Tue, Oct 4, 1:47 PM
anlambert created P1471 (An Untitled Masterwork).
Tue, Oct 4, 1:31 PM
anlambert added inline comments to D8606: nixguix: Deal with mistyped origins.
Tue, Oct 4, 1:29 PM
anlambert added inline comments to D8379: Hackage: Loads Hackage Listed origins.
Tue, Oct 4, 10:59 AM
anlambert accepted D8601: {Content|Directory}Loader: Register tasks.

Looks good to me, makes me think that I should deduplicate the tests for the tasks created from ListedOrigins in loaders through a fixture and add missing ones, I will push a diff for that.

Tue, Oct 4, 10:53 AM

Mon, Oct 3

anlambert added inline comments to D8341: Add nixguix lister.
Mon, Oct 3, 4:28 PM
anlambert closed D8602: pre-commit: Fix tests data exclusion from codespell check.
Mon, Oct 3, 4:12 PM
anlambert committed rDLDBASEc631349aea8f: pre-commit: Fix tests data exclusion from codespell check (authored by anlambert).
pre-commit: Fix tests data exclusion from codespell check
Mon, Oct 3, 4:12 PM
anlambert requested review of D8602: pre-commit: Fix tests data exclusion from codespell check.
Mon, Oct 3, 4:00 PM
anlambert closed D8600: cli: Use memory storage as fallback when no configuration detected.
Mon, Oct 3, 3:35 PM
anlambert committed rDLDBASE13e9bf4d698d: cli: Use memory storage as fallback when no configuration detected (authored by anlambert).
cli: Use memory storage as fallback when no configuration detected
Mon, Oct 3, 3:35 PM
anlambert updated the diff for D8600: cli: Use memory storage as fallback when no configuration detected.

Use warning log level instead of info.

Mon, Oct 3, 3:31 PM
anlambert requested review of D8600: cli: Use memory storage as fallback when no configuration detected.
Mon, Oct 3, 3:22 PM
anlambert closed D8596: package/utils: Fix download function documentation.
Mon, Oct 3, 3:14 PM
anlambert committed rDLDBASEf6a3ed11b4f8: package/utils: Fix download function documentation (authored by anlambert).
package/utils: Fix download function documentation
Mon, Oct 3, 3:14 PM
anlambert requested changes to D8601: {Content|Directory}Loader: Register tasks.

I recalled it is also important to test the loader parameters when created from ListedOrigin instances so I have added this test below:

diff --git a/swh/loader/core/tests/test_tasks.py b/swh/loader/core/tests/test_tasks.py
index bf8d2e1..c0ab361 100644
--- a/swh/loader/core/tests/test_tasks.py
+++ b/swh/loader/core/tests/test_tasks.py
@@ -3,8 +3,13 @@
 # License: GNU General Public License version 3, or any later version
 # See top-level LICENSE file for more information
Mon, Oct 3, 3:12 PM
anlambert updated the diff for D8596: package/utils: Fix download function documentation.

rebase

Mon, Oct 3, 2:53 PM
anlambert updated the diff for D8596: package/utils: Fix download function documentation.

Rebase

Mon, Oct 3, 2:50 PM
anlambert requested review of D8596: package/utils: Fix download function documentation.
Mon, Oct 3, 2:46 PM
anlambert added inline comments to D8587: {Content|Directory}Loader: Adapt support for checksums.
Mon, Oct 3, 2:32 PM
anlambert added inline comments to D8566: Conda: Anaconda packages archive loader.
Mon, Oct 3, 2:08 PM
anlambert accepted D8598: Fix compatibility issue with latest dependency version.
Mon, Oct 3, 2:01 PM
anlambert added inline comments to D8598: Fix compatibility issue with latest dependency version.
Mon, Oct 3, 1:56 PM
anlambert accepted D8589: api/asynchronous: Do not log/report client exceptions.
Mon, Oct 3, 12:34 PM
anlambert added inline comments to D8587: {Content|Directory}Loader: Adapt support for checksums.
Mon, Oct 3, 12:02 PM
anlambert accepted D8584: Add Directory Loader to allow tarball ingestion as Directory.

Looks good to me !

Mon, Oct 3, 11:49 AM
anlambert closed D8595: Use tarball checksum to check download integrity in package loaders.
Mon, Oct 3, 10:55 AM
anlambert committed rDLDBASE5482a48ea1bd: Use tarball checksum to check download integrity in package loaders (authored by anlambert).
Use tarball checksum to check download integrity in package loaders
Mon, Oct 3, 10:55 AM
anlambert closed D8594: Send package artifact checksums to loaders when info is available.
Mon, Oct 3, 10:54 AM
anlambert committed rDLSfa1205c4dfb6: Send package artifact checksums to loaders when info is available (authored by anlambert).
Send package artifact checksums to loaders when info is available
Mon, Oct 3, 10:54 AM

Fri, Sep 30

anlambert requested review of D8595: Use tarball checksum to check download integrity in package loaders.
Fri, Sep 30, 6:52 PM
anlambert requested review of D8594: Send package artifact checksums to loaders when info is available.
Fri, Sep 30, 6:51 PM
anlambert added inline comments to D8379: Hackage: Loads Hackage Listed origins.
Fri, Sep 30, 6:02 PM
anlambert added inline comments to D8584: Add Directory Loader to allow tarball ingestion as Directory.
Fri, Sep 30, 5:30 PM
anlambert added inline comments to D8584: Add Directory Loader to allow tarball ingestion as Directory.
Fri, Sep 30, 5:19 PM
anlambert added inline comments to D8584: Add Directory Loader to allow tarball ingestion as Directory.
Fri, Sep 30, 4:52 PM
anlambert closed D8585: svn: Add support to basic subversion authentication in SvnRepo.
Fri, Sep 30, 4:47 PM
anlambert committed rDLDSVN8e735c953ba5: svn: Add support to basic subversion authentication in SvnRepo (authored by anlambert).
svn: Add support to basic subversion authentication in SvnRepo
Fri, Sep 30, 4:47 PM
anlambert requested changes to D8379: Hackage: Loads Hackage Listed origins.

LGTM, just a couple of nitpicks to handle and I will accept it.

Fri, Sep 30, 4:37 PM
anlambert requested changes to D8566: Conda: Anaconda packages archive loader.

LGTM, two small comments to handle before I can accept it.

Fri, Sep 30, 4:26 PM
anlambert added a comment to D8379: Hackage: Loads Hackage Listed origins.

@franckbret , you updated the wrong diff (conda instead of hackage)

Fri, Sep 30, 4:15 PM
anlambert closed D8586: hashutil: Add sha512 support in MultiHash class.
Fri, Sep 30, 3:23 PM
anlambert committed rDMOD9b8beef15819: hashutil: Add sha512 support in MultiHash class (authored by anlambert).
hashutil: Add sha512 support in MultiHash class
Fri, Sep 30, 3:23 PM
anlambert updated the diff for D8586: hashutil: Add sha512 support in MultiHash class.

Improve tests

Fri, Sep 30, 3:18 PM
anlambert requested review of D8586: hashutil: Add sha512 support in MultiHash class.
Fri, Sep 30, 3:02 PM
anlambert updated the diff for D8585: svn: Add support to basic subversion authentication in SvnRepo.

Address @vlorentz comments.

Fri, Sep 30, 2:38 PM
anlambert accepted D8579: http_client: Add max_matching_nodes parameter to visit_nodes().
Fri, Sep 30, 2:37 PM
anlambert added inline comments to D8579: http_client: Add max_matching_nodes parameter to visit_nodes().
Fri, Sep 30, 2:22 PM
anlambert accepted D8583: SimpleTraversal.visitNode: Remove redundant boolean.
Fri, Sep 30, 2:18 PM
anlambert requested review of D8585: svn: Add support to basic subversion authentication in SvnRepo.
Fri, Sep 30, 2:17 PM
anlambert added a project to T4590: swh-scanner - improve distribution, documentation and usability: Code scanner.
Fri, Sep 30, 2:16 PM · Code scanner
anlambert added a project to T4592: swh-scanner - generic bug fixing, robustness and performance improvements: Code scanner.
Fri, Sep 30, 2:16 PM · Code scanner

Thu, Sep 29

anlambert added inline comments to D8582: Allow more checksum computations in Content model.
Thu, Sep 29, 7:42 PM
anlambert added inline comments to D8379: Hackage: Loads Hackage Listed origins.
Thu, Sep 29, 6:28 PM
anlambert added a comment to D8379: Hackage: Loads Hackage Listed origins.

Here the problems is that the cabal file isn't formatted as the naïve parser expect.. we expect each line to be something like {k}: {v}\n but in this case its {k}: \n \t {v} \n and we end with an empty value..

Thu, Sep 29, 6:10 PM
anlambert added inline comments to D8569: Add rubygems loader.
Thu, Sep 29, 5:57 PM
anlambert closed D8535: docker/conf: Declare task queues for new listers and loaders.
Thu, Sep 29, 5:33 PM