User Details
- User Since
- Jul 3 2017, 10:14 AM (127 w, 1 d)
Today
Rebase
Yes I agree, I ended up using statsd in D2419 after all. django-prometheus could be interesting to use but it maybe redundant with the upcoming sentry integration in swh-web.
Yesterday
Looks good to me !
Looks good !
Sure. I'm also moving these env vars in a dedicated file instead of putting them directly in the docker-compose file.
Remove commit from D2407
Rebase to master in order for the tests to pass
Great ! Could you also add that configuration to the swh-web service ? I am currently working on T1214 and I have added a couple of statsd metric to the webapp.
All good !
I totally agree on this. You miss some replacements in the tests though.
Looks good !
Looks good to me !
Fri, Dec 6
Apart a trailing comma in a function call, looks good !
Looks good !
We could use prometheus_client (packaged in debian) to generate and export Prometheus metrics for swh-web.
Looks good !
Looks good !
Looks good !
Looks good to me !
Wed, Dec 4
Tue, Dec 3
Looks good, thanks !
Abandoning this as the issue is more global than it seems and the whole URLs scheme of swh-web/browse needs to be disambiguated (T2135).
Rebase
Mon, Dec 2
Update: There was no cycles generation between aliases issue after all, probably myself that messed up somewhere
when playing with hypothesis.
If there's a bug here it should be fixed in that function (and a regression test should be added).
Apart a couple of nitpicks to handle, looks good !
Rebase
Rebase
Update: Need to test against 'alias' instead of TargetType.ALIAS to avoid hypothesis.errors.Flaky
Sat, Nov 30
Fri, Nov 29
Update: Forgot to process Directory model
Update: Rename a variable
Update: Rebase and address @vlorentz comments
Update: Forgot to remove print statement
Update: Rebase, fix a comment and a test as there is now an origin that contains the empty directory in tests data