Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

Projects

User Details

User Since
Jul 3 2017, 10:14 AM (102 w, 3 d)

Recent Activity

Today

anlambert created P445 get_links.
Thu, Jun 20, 1:57 PM

Yesterday

anlambert committed rDWAPPScfa46c5c5021: assets/browse/origin-save: Robustify save code now request status reporting (authored by anlambert).
assets/browse/origin-save: Robustify save code now request status reporting
Wed, Jun 19, 5:42 PM
anlambert accepted D1619: Remove the duplicate endpoints list with <noscript>..

I think its was originally there to handle browsers with no JavaScript or with JavaScript disabled.

Wed, Jun 19, 5:20 PM
anlambert accepted D1618: Sort endpoint list by URL instead of description..

Oh did not spot this. I think it was originally sorted by endpoints but some columns of the table were removed since then and we forgot to update the ordering.

Wed, Jun 19, 5:03 PM
anlambert accepted D1615: Unify hash case handling in the vault endpoints with other endpoints..

Well seen !

Wed, Jun 19, 4:46 PM
anlambert accepted D1609: Add Tests for Home Page.

Nice one, thanks !

Wed, Jun 19, 2:33 PM

Tue, Jun 18

anlambert closed T1815: Use a FOSS alternative or drop Google ReCAPTCHA use as Resolved.

The use of Google ReCAPTCHA is now dropped in favor of rate limiting the number of save requests a user can create through the form (10/h).

Tue, Jun 18, 5:24 PM · Web app
anlambert changed the visibility for F3541442: image.png.
Tue, Jun 18, 5:23 PM
anlambert committed rCDFD9be73e3693c3: conf/web: Remove now useless ReCAPTCHA configuration (authored by anlambert).
conf/web: Remove now useless ReCAPTCHA configuration
Tue, Jun 18, 5:02 PM
anlambert committed rSPSITE32b0fbfc117b: Remove ReCAPTCHA configuration for swh-web (authored by anlambert).
Remove ReCAPTCHA configuration for swh-web
Tue, Jun 18, 4:58 PM
anlambert closed D1605: Remove ReCAPTCHA configuration for swh-web.
Tue, Jun 18, 4:58 PM
anlambert accepted D1598: Add Sidebar tests for mobile.

Great, thanks! You can rebase and land it.

Tue, Jun 18, 4:41 PM
Herald added a reviewer for D1605: Remove ReCAPTCHA configuration for swh-web: Reviewers.
Tue, Jun 18, 4:27 PM
anlambert committed rDWAPPSdc16c2caadf6: swh-web: Drop ReCAPTCHA use in save code now forms (authored by anlambert).
swh-web: Drop ReCAPTCHA use in save code now forms
Tue, Jun 18, 4:22 PM
anlambert committed rDWAPPSced93c685a83: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Tue, Jun 18, 4:22 PM
anlambert renamed T1815: Use a FOSS alternative or drop Google ReCAPTCHA use from Use a FOSS alternative to Google ReCAPTCHA to Use a FOSS alternative or drop Google ReCAPTCHA use.
Tue, Jun 18, 3:28 PM · Web app
anlambert added a comment to D1577: Add tests for sidebar, back-to-top.

@kalpitk , looks good ! You can land it.

Tue, Jun 18, 10:47 AM
anlambert accepted D1594: phabricator: model: Reference the forge's instance name in model.

Looks good to me

Tue, Jun 18, 10:22 AM

Mon, Jun 17

anlambert accepted D1592: Fix ImportError: module 'swh.vault.cli' has no attribute 'cli'.
Mon, Jun 17, 5:43 PM
anlambert abandoned D1358: Add extra configuration to kafka consumer from journal.client.
Mon, Jun 17, 5:42 PM
anlambert accepted D1577: Add tests for sidebar, back-to-top.
Mon, Jun 17, 5:41 PM
anlambert added a comment to T1814: Update donation forms.

Currently the WordPress plugin we are using to interact with Stripe does not yet support SCA but it will be added during the summer.

Mon, Jun 17, 5:25 PM · Website
anlambert updated the task description for T1814: Update donation forms.
Mon, Jun 17, 5:16 PM · Website
anlambert added a comment to T1815: Use a FOSS alternative or drop Google ReCAPTCHA use.

I should have read django-simple-captcha doc, indeed its integration is not really straightforward for swh-web.

Mon, Jun 17, 2:52 PM · Web app
anlambert accepted D1583: Fix sidebar not opening first time.
Mon, Jun 17, 11:51 AM
anlambert triaged T1815: Use a FOSS alternative or drop Google ReCAPTCHA use as Normal priority.
Mon, Jun 17, 11:48 AM · Web app
anlambert triaged T1814: Update donation forms as High priority.
Mon, Jun 17, 11:22 AM · Website
anlambert accepted D1528: Stop using hypothesis for tests that don't need it..
Mon, Jun 17, 11:09 AM
anlambert accepted D1567: Move Permalinks tabSlideout down in xs screens.

Diff accepted but let's land D1583 first (see inline comment).

Mon, Jun 17, 11:02 AM
anlambert requested changes to D1577: Add tests for sidebar, back-to-top.

Nice! I agree with @vlorentz , you should split the tests into two spec files: sidebar.spec.js and back-to-top.spec.js. Once it is done, that diff can be landed.

Mon, Jun 17, 11:00 AM
anlambert requested changes to D1583: Fix sidebar not opening first time.

Just a small change to do and I will accept the diff.

Mon, Jun 17, 10:47 AM

Sat, Jun 8

anlambert updated subscribers of D1565: [WIP] Bootstrap end to end tests with cypress.
Sat, Jun 8, 2:35 AM
anlambert added a project to T1768: Add end to end tests for the frontend part of swh-web: GSoC 2019.
Sat, Jun 8, 2:34 AM · GSoC 2019, Web app

Fri, Jun 7

anlambert updated the diff for D1565: [WIP] Bootstrap end to end tests with cypress.

Update: Ensure grecaptcha is desactivated for e2e tests

Fri, Jun 7, 11:09 PM
anlambert updated the diff for D1565: [WIP] Bootstrap end to end tests with cypress.

Update: Remove unused file and resentence some tests description

Fri, Jun 7, 6:36 PM
anlambert closed T1786: Improve popovers display on small screens, a subtask of T1477: Improve swh-web design for mobile browsing , as Resolved.
Fri, Jun 7, 6:30 PM · GSoC 2019, Web app
anlambert closed T1786: Improve popovers display on small screens as Resolved.

Closed by d355d8973205

Fri, Jun 7, 6:30 PM · GSoC 2019, Web app
anlambert updated subscribers of D1565: [WIP] Bootstrap end to end tests with cypress.
Fri, Jun 7, 6:14 PM
anlambert updated the task description for T1768: Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:13 PM · GSoC 2019, Web app
anlambert assigned T1768: Add end to end tests for the frontend part of swh-web to kalpitk.
Fri, Jun 7, 6:11 PM · GSoC 2019, Web app
anlambert merged task T1770: Add end to end tests into T1768: Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:11 PM · GSoC 2019, Web app
anlambert merged T1770: Add end to end tests into T1768: Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:11 PM · GSoC 2019, Web app
anlambert renamed T1768: Add end to end tests for the frontend part of swh-web from Add tests for the frontend part of swh-web to Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:10 PM · GSoC 2019, Web app
anlambert closed T1769: Add unit tests for Javascript code as Wontfix.

These tests will be redundant with the end to end ones, so closing that task and prefer to rely on using cypress for frontend testing.

Fri, Jun 7, 6:08 PM · Web app
anlambert closed T1769: Add unit tests for Javascript code, a subtask of T1768: Add end to end tests for the frontend part of swh-web, as Wontfix.
Fri, Jun 7, 6:08 PM · GSoC 2019, Web app
anlambert abandoned D1524: [WIP] Add frontend unit tests.

Abandoning this in favor of D1565

Fri, Jun 7, 6:04 PM
anlambert updated the summary of D1565: [WIP] Bootstrap end to end tests with cypress.
Fri, Jun 7, 6:03 PM
Herald added a reviewer for D1565: [WIP] Bootstrap end to end tests with cypress: Reviewers.
Fri, Jun 7, 6:02 PM
anlambert committed rDWAPPS82027bbd911d: Makefile.local: Silent django management outputs (authored by anlambert).
Makefile.local: Silent django management outputs
Fri, Jun 7, 4:01 PM
anlambert committed rDWAPPScc29a3ba851b: webpack: Add build progress bar and disable verbose output (authored by anlambert).
webpack: Add build progress bar and disable verbose output
Fri, Jun 7, 2:30 PM
anlambert accepted D1553: Improve mobile popovers.

Looks good, thanks !

Fri, Jun 7, 11:10 AM
anlambert committed rDWAPPS4fc5aecd4121: assets: Upgrade to core-js 3 (authored by anlambert).
assets: Upgrade to core-js 3
Fri, Jun 7, 11:10 AM

Thu, Jun 6

anlambert added inline comments to D1553: Improve mobile popovers.
Thu, Jun 6, 7:47 PM
anlambert updated subscribers of T1768: Add end to end tests for the frontend part of swh-web.

@shisus , I have tested cypress and the tool is indeed quite awesome !

Thu, Jun 6, 7:40 PM · GSoC 2019, Web app
anlambert updated the task description for T1787: Browsing revisions log ends up with errors when going back far in time.
Thu, Jun 6, 4:58 PM · Web app
anlambert requested changes to D1553: Improve mobile popovers.

Just a couple of nitpicks for small screens (see screenshot below):

  • Can you slightly move the popover to the right in order to see its borders ?
  • The Permalinks button should not overlap the popover
Thu, Jun 6, 4:23 PM
anlambert changed the visibility for F3532373: Screen Shot 2019-06-06 at 16.18.53.png.
Thu, Jun 6, 4:23 PM
anlambert changed the visibility for F3532376: Screen Shot 2019-06-06 at 16.15.06.png.
Thu, Jun 6, 4:22 PM
anlambert committed rDWAPPSc800a1ab64b1: swh-web: Version 0.0.201 (authored by anlambert).
swh-web: Version 0.0.201
Thu, Jun 6, 4:02 PM
anlambert committed rDWAPPSd835f53a7228: package.json: Upgrade dev dependencies (authored by anlambert).
package.json: Upgrade dev dependencies
Thu, Jun 6, 4:02 PM
anlambert committed rDWAPPS35190ebed08b: assets/diff-utils: Handle all possible diff hunk range format (authored by anlambert).
assets/diff-utils: Handle all possible diff hunk range format
Thu, Jun 6, 4:02 PM
anlambert committed rDWAPPS09e0657f0043: browse: Prevent UI flashes on page load (authored by anlambert).
browse: Prevent UI flashes on page load
Thu, Jun 6, 4:02 PM
anlambert closed T1787: Browsing revisions log ends up with errors when going back far in time as Resolved by committing rDWAPPS00bc23308c99: browse/revision_log: Optimize memcached entry size.
Thu, Jun 6, 4:02 PM · Web app
anlambert committed rDWAPPS00bc23308c99: browse/revision_log: Optimize memcached entry size (authored by anlambert).
browse/revision_log: Optimize memcached entry size
Thu, Jun 6, 4:02 PM
anlambert triaged T1787: Browsing revisions log ends up with errors when going back far in time as Normal priority.
Thu, Jun 6, 1:37 PM · Web app

Wed, Jun 5

anlambert renamed T1770: Add end to end tests from Add end to end tests using Selenium to Add end to end tests .
Wed, Jun 5, 11:38 AM · GSoC 2019, Web app
anlambert updated the task description for T1786: Improve popovers display on small screens.
Wed, Jun 5, 11:31 AM · GSoC 2019, Web app
anlambert triaged T1786: Improve popovers display on small screens as Normal priority.
Wed, Jun 5, 11:30 AM · GSoC 2019, Web app
anlambert changed the visibility for F3530778: Screen Shot 2019-06-05 at 11.26.27.png.
Wed, Jun 5, 11:27 AM
anlambert changed the visibility for F3530776: Screen Shot 2019-06-05 at 11.24.18.png.
Wed, Jun 5, 11:26 AM
anlambert accepted D1515: Make DataTables responsive.

Let's land this !

Wed, Jun 5, 11:10 AM

Tue, Jun 4

anlambert added a comment to T1768: Add end to end tests for the frontend part of swh-web.

Thanks for pointing out the cypress tool, it looks pretty interesting.
Based on my understanding, it could be used to write and run unit tests but also end to end ones.

Tue, Jun 4, 3:21 PM · GSoC 2019, Web app
anlambert requested changes to D1515: Make DataTables responsive.

Still some improvements to bring.

Tue, Jun 4, 2:49 PM
anlambert added inline comments to D1528: Stop using hypothesis for tests that don't need it..
Tue, Jun 4, 1:26 PM
anlambert accepted D1526: Add support for snapshots in enrich_object..
Tue, Jun 4, 1:20 PM
anlambert accepted D1527: Fix decoding of non-utf8 branch targets..
Tue, Jun 4, 1:19 PM
anlambert accepted D1529: Add a 'py3-slow' tox profile..
Tue, Jun 4, 11:55 AM

Wed, May 29

Herald added a reviewer for D1524: [WIP] Add frontend unit tests: Reviewers.
Wed, May 29, 6:02 PM
anlambert accepted D1522: Deduplicate implementations of _enrich_origin_visit..

Better indeed !

Wed, May 29, 3:58 PM
anlambert committed rDWAPPS82b003c11095: swh-web: Version 0.0.200 (authored by anlambert).
swh-web: Version 0.0.200
Wed, May 29, 3:23 PM
anlambert committed rDWAPPS6b19ab476af5: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Wed, May 29, 3:23 PM
anlambert committed rDWAPPSd65c32e7f031: tests: Fix warnings related to django templates rendering (authored by anlambert).
tests: Fix warnings related to django templates rendering
Wed, May 29, 3:23 PM
anlambert committed rDWAPPS4120c11702c4: swh-web: Handle possible null branches in snapshot (authored by anlambert).
swh-web: Handle possible null branches in snapshot
Wed, May 29, 3:23 PM
anlambert requested changes to D1515: Make DataTables responsive.

Nice improvements but that diff is not landable as is (see my inline comments).

Wed, May 29, 12:15 PM

Tue, May 28

anlambert added a comment to T1769: Add unit tests for Javascript code.

In order to implement the unit tests, we will need the following node modules:

Tue, May 28, 4:19 PM · Web app
anlambert committed rSPSITE946372ba41c9: data/defaults.yaml: Exempt DINSIC from swh-web api rate limiting (authored by anlambert).
data/defaults.yaml: Exempt DINSIC from swh-web api rate limiting
Tue, May 28, 2:48 PM
anlambert closed T1746: Web API: whitelist DINSIC IP address as Resolved by committing rSPSITE946372ba41c9: data/defaults.yaml: Exempt DINSIC from swh-web api rate limiting.
Tue, May 28, 2:48 PM · Web app
anlambert closed D1512: Exempt DINSIC from swh-web rate limiting.
Tue, May 28, 2:48 PM
anlambert updated the diff for D1512: Exempt DINSIC from swh-web rate limiting.

Rebase

Tue, May 28, 2:47 PM
anlambert committed rDLDNPMe9ae74a59ae5: npm.client: Handle corrupted package release tarballs (authored by anlambert).
npm.client: Handle corrupted package release tarballs
Tue, May 28, 2:44 PM
anlambert closed D1517: Handle corrupted package release tarballs.
Tue, May 28, 2:44 PM
anlambert updated the summary of D1512: Exempt DINSIC from swh-web rate limiting.
Tue, May 28, 2:40 PM
anlambert updated the diff for D1512: Exempt DINSIC from swh-web rate limiting.

Update: Remove the commit related to trailing whitespaces

Tue, May 28, 2:39 PM
Herald added a reviewer for D1517: Handle corrupted package release tarballs: Reviewers.
Tue, May 28, 2:14 PM
anlambert triaged T1770: Add end to end tests as Normal priority.
Tue, May 28, 1:38 PM · GSoC 2019, Web app
anlambert triaged T1769: Add unit tests for Javascript code as Normal priority.
Tue, May 28, 1:31 PM · Web app
anlambert triaged T1768: Add end to end tests for the frontend part of swh-web as Normal priority.
Tue, May 28, 1:28 PM · GSoC 2019, Web app

Mon, May 27

anlambert triaged T1766: Write blog post about the npm ingestion as Normal priority.
Mon, May 27, 3:39 PM · Origin-npm, Blog, Website, Unknown Object (Project)
anlambert added inline comments to D1504: implement listers as plugins.
Mon, May 27, 2:20 PM
anlambert closed T1378: Ingest npm into the Software Heritage archive (meta task) as Resolved.

npm is now archived continuously by Software Heritage (see for instance: https://archive.softwareheritage.org/browse/origin/https://www.npmjs.com/package/webpack/).

Mon, May 27, 1:58 PM · Origin-npm, Archive coverage