- User Since
- Jul 3 2017, 10:14 AM (143 w, 2 d)
Update: Add comment explaining why return value of service.lookup_directory is not used in release view implementation
Thanks for the improvements !
That's great news \o/ !
- Modify comment in middleware
- Fix typo in test variable
Tue, Mar 31
yes, i know.
But i think that's an edge case...
of 1. that diff should be splitted if possible
- Also the pb might not be with the git commit too long...
Update: Use session-scoped fixture instead of module-scoped fixture
Rebase + add commit upgrading yarn dependencies (notably cypress)
- Set sidebar state (collapsed / expanded) once css animation has finished in order to make associated cypress test reliable.
Current fix is unfortunately not valid. I need to dig further on this.
I will restart the build a couple of times before landing the diff to be sure it effectively fixes the issue.
I saw that too, will look at it.
Mon, Mar 30
I do not encounter any particular issue when trying to browse these files. Their content is equal to their filename so the confusion I think.
Update: Add cypress test
Update: Add new test description in docstring
Fri, Mar 27
I think we might want separate realms for production, staging and "localhost testing". At the very least, we will want separate clients, because I don't think application credentials and user sessions should be shared across the different usecases.
Update commit message
If you agree with this I'm happy to pick this diff up to implement the idea.
Update: Fix missing protocol in redirect uri
Update: Add more redirect uris and add missing calls to lookup
Thu, Mar 26
Update: Remove SoftwareHeritage realm JSON export file and prefer to use
Keycloak admin API through python-keycloak to define realm and swh-web
client when keycloak service starts.
Update: Check groups claim is present in decoded token before trying to read it.
Looks good to me but you should add a test. Ci build seems to fail because some landed diffs are still referenced in dependencies stack (2814 -> 2818).
Wed, Mar 25
The patch hopefully fixes all type of git repository urls. I think you got mistaken by the frontend test, the real fix is in the regexp modification.
Nervertheless, this is not deployed yet.
Update some comments and docstrings.
Tue, Mar 24
Update commit message