Page MenuHomeSoftware Heritage
People anlambert

anlambert (Antoine Lambert)
User

Projects

User Details

User Since
Jul 3 2017, 10:14 AM (157 w, 5 d)

Recent Activity
View All

Fri, Jul 10

anlambert added a comment to T2354: Add Software Heritage theme for Keycloak.

I have created rTKCT to hold the theme development and maintenance.

Fri, Jul 10, 5:17 PM · System administration
anlambert committed rTKCTe06c74da73e5: Initial commit: Add admin console and login screen themes (authored by anlambert).
Initial commit: Add admin console and login screen themes
Fri, Jul 10, 5:12 PM
anlambert committed rDSTO9219a23606c8: in_memory: Fix snapshot_get_branches regression with target_types (authored by anlambert).
in_memory: Fix snapshot_get_branches regression with target_types
Fri, Jul 10, 4:26 PM
anlambert closed D3500: in_memory: Fix snapshot_get_branches regression with target_types.
Fri, Jul 10, 4:26 PM
anlambert updated the diff for D3500: in_memory: Fix snapshot_get_branches regression with target_types.

Update: Sort branches only once

Fri, Jul 10, 4:16 PM
anlambert created D3500: in_memory: Fix snapshot_get_branches regression with target_types.
Fri, Jul 10, 4:06 PM
anlambert created P723 (An Untitled Masterwork).
Fri, Jul 10, 12:08 PM

Thu, Jul 9

anlambert triaged T2489: Git origin without smart transfer protocol support cannot be loaded as Normal priority.
Thu, Jul 9, 8:22 PM · Git loader
anlambert accepted D3490: Drop useless use of pifpaf.
Thu, Jul 9, 7:46 PM
anlambert accepted D3489: Rework dia -> pdf pipeline for inkscape 1.0.
Thu, Jul 9, 7:37 PM
anlambert committed rDWAPPS41f67245e546: assets/save: Try to set origin type when clicking on "Save again" (authored by anlambert).
assets/save: Try to set origin type when clicking on "Save again"
Thu, Jul 9, 3:58 PM
anlambert closed T2475: Save again functionality: VCS type not pre-selected as Resolved by committing rDWAPPS41f67245e546: assets/save: Try to set origin type when clicking on "Save again".
Thu, Jul 9, 3:58 PM · Web app
anlambert closed D3429: assets/save: Try to set origin type when clicking on "Save again".
Thu, Jul 9, 3:58 PM
anlambert updated the diff for D3429: assets/save: Try to set origin type when clicking on "Save again".

Update: Really fix cypress test

Thu, Jul 9, 3:45 PM
anlambert added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Thu, Jul 9, 2:50 PM
anlambert updated the diff for D3429: assets/save: Try to set origin type when clicking on "Save again".

Update: Fix cypress test

Thu, Jul 9, 2:45 PM
anlambert accepted D3475: setup: Do no expose the pytest-plugin any longer.

Looks good to me.

Thu, Jul 9, 2:41 PM

Wed, Jul 8

anlambert updated the diff for D3429: assets/save: Try to set origin type when clicking on "Save again".

Rebase

Wed, Jul 8, 7:18 PM
anlambert committed rDWAPPS2a91164b696d: api/identifiers: Adapt to swh-model >= 0.5.0 (authored by anlambert).
api/identifiers: Adapt to swh-model >= 0.5.0
Wed, Jul 8, 7:17 PM
anlambert closed D3467: api/identifiers: Adapt to swh-model >= 0.5.0.
Wed, Jul 8, 7:17 PM
anlambert updated the diff for D3467: api/identifiers: Adapt to swh-model >= 0.5.0.

Rebase

Wed, Jul 8, 7:03 PM
anlambert committed rDWAPPS0af42367cd17: pytest.ini: Prevent swh-storage pytest plugin loading (authored by anlambert).
pytest.ini: Prevent swh-storage pytest plugin loading
Wed, Jul 8, 7:02 PM
anlambert closed D3474: pytest.ini: Prevent swh-storage pytest plugin loading.
Wed, Jul 8, 7:02 PM
anlambert created P721 (An Untitled Masterwork).
Wed, Jul 8, 6:58 PM
anlambert created P720 (An Untitled Masterwork).
Wed, Jul 8, 6:53 PM
anlambert created D3474: pytest.ini: Prevent swh-storage pytest plugin loading.
Wed, Jul 8, 6:51 PM
anlambert committed rDSCHece598c41c6c: requirements.txt: Remove future dependency (authored by anlambert).
requirements.txt: Remove future dependency
Wed, Jul 8, 6:39 PM
anlambert closed D3472: requirements.txt: Set future version to >= 0.16.0.
Wed, Jul 8, 6:39 PM
anlambert updated the diff for D3472: requirements.txt: Set future version to >= 0.16.0.

Rebase

Wed, Jul 8, 6:33 PM
anlambert added a comment to D3470: debian: Add pybuild.testfiles fixing tests execution in package build.
In D3470#85320, @olasd wrote:

Please add a newline at the end of the file.

Wed, Jul 8, 6:27 PM
anlambert committed rDSCH9322643f94e5: debian/pybuild.testfiles: Add missing new line at end of file (authored by anlambert).
debian/pybuild.testfiles: Add missing new line at end of file
Wed, Jul 8, 6:27 PM
anlambert updated the diff for D3472: requirements.txt: Set future version to >= 0.16.0.

Update: Drop future dependency and update commit message

Wed, Jul 8, 6:23 PM
anlambert committed rDSCH024c981078e7: debian: Add pybuild.testfiles fixing tests execution in package build (authored by anlambert).
debian: Add pybuild.testfiles fixing tests execution in package build
Wed, Jul 8, 6:14 PM
anlambert closed D3470: debian: Add pybuild.testfiles fixing tests execution in package build.
Wed, Jul 8, 6:14 PM
anlambert created D3472: requirements.txt: Set future version to >= 0.16.0.
Wed, Jul 8, 6:13 PM
anlambert created D3470: debian: Add pybuild.testfiles fixing tests execution in package build.
Wed, Jul 8, 6:10 PM
anlambert added a comment to D3465: identifiers: Add to_dict method to SWHID class.
In D3465#85259, @vlorentz wrote:

What's wrong with attr.asdict?

Wed, Jul 8, 5:41 PM
anlambert committed rDMOD0547a516e6b1: identifiers: Add to_dict method to SWHID class (authored by anlambert).
identifiers: Add to_dict method to SWHID class
Wed, Jul 8, 5:20 PM
anlambert closed D3465: identifiers: Add to_dict method to SWHID class.
Wed, Jul 8, 5:20 PM
anlambert updated the summary of D3465: identifiers: Add to_dict method to SWHID class.
Wed, Jul 8, 4:47 PM
anlambert created D3467: api/identifiers: Adapt to swh-model >= 0.5.0.
Wed, Jul 8, 4:46 PM
anlambert created D3465: identifiers: Add to_dict method to SWHID class.
Wed, Jul 8, 4:20 PM
anlambert committed rDLDHG52869875d333: loader: Adapt to swh-model >= 0.4.0 (authored by anlambert).
loader: Adapt to swh-model >= 0.4.0
Wed, Jul 8, 4:08 PM
anlambert closed D3463: loader: Adapt to swh-model >= 0.4.0.
Wed, Jul 8, 4:08 PM
anlambert created D3463: loader: Adapt to swh-model >= 0.4.0.
Wed, Jul 8, 3:35 PM
anlambert added a revision to T2423: Extract the `extra_headers` away from `Revision.metadata` into a top-level immutable object: D3463: loader: Adapt to swh-model >= 0.4.0.
Wed, Jul 8, 3:35 PM · Data Model
anlambert accepted D3454: Adapt the git loader to swh-model >0.4.
Wed, Jul 8, 2:53 PM
anlambert accepted D3460: test_serializers: Move to pytest for that specific erratic assertion.
Wed, Jul 8, 1:21 PM
anlambert accepted D3452: Move sharable fixtures out of conftest into a dedicated pytest plugin.

Looks good. Phabricator diffs are indeed surprising and misleading here, feels like a bug to me.

Wed, Jul 8, 11:25 AM
anlambert accepted D3458: Migrate from vcversioner to setuptools-scm.
Wed, Jul 8, 11:17 AM
anlambert accepted D3455: Migrate to new swhid naming.

Looks good !

Wed, Jul 8, 11:10 AM

Tue, Jul 7

anlambert added a comment to T2354: Add Software Heritage theme for Keycloak.

Work in progress.

Tue, Jul 7, 7:06 PM · System administration
anlambert changed the status of T2354: Add Software Heritage theme for Keycloak, a subtask of T2219: Authentication / authorization, from Open to Work in Progress.
Tue, Jul 7, 7:04 PM · Restricted Project
anlambert changed the status of T2354: Add Software Heritage theme for Keycloak from Open to Work in Progress.
Tue, Jul 7, 7:04 PM · System administration
anlambert accepted D3426: Extract revision's extra_header as a top level attribute.
Tue, Jul 7, 4:51 PM
anlambert accepted D3448: mercurial.loader: Refactor remaining tests to use pytest.

Looks good !

Tue, Jul 7, 4:26 PM
anlambert added inline comments to D3426: Extract revision's extra_header as a top level attribute.
Tue, Jul 7, 4:19 PM
anlambert requested changes to D3426: Extract revision's extra_header as a top level attribute.
Tue, Jul 7, 4:16 PM
anlambert accepted D3447: Make SWHID immutable and hashable..
Tue, Jul 7, 3:42 PM
anlambert accepted D3445: Allow passing an ImmutableDict as argument to ImmutableDict's constructor..
Tue, Jul 7, 3:40 PM
anlambert accepted D3446: Implement ImmutableDict.__hash__..
Tue, Jul 7, 3:39 PM
anlambert accepted D3444: loaders.tests: Simplify and add coverage to check-snapshot.
Tue, Jul 7, 1:52 PM
anlambert accepted D3441: pytest.ini: Drop filterwarnings which never worked.

Looking at the latest CI log of scheduler, the warning to filter does not appear anymore so this can be removed indeed.

Tue, Jul 7, 1:13 PM
anlambert added inline comments to D3441: pytest.ini: Drop filterwarnings which never worked.
Tue, Jul 7, 1:10 PM

Mon, Jul 6

anlambert added a revision to T2475: Save again functionality: VCS type not pre-selected: D3429: assets/save: Try to set origin type when clicking on "Save again".
Mon, Jul 6, 2:33 PM · Web app
anlambert created D3429: assets/save: Try to set origin type when clicking on "Save again".
Mon, Jul 6, 2:33 PM
anlambert added a comment to T2475: Save again functionality: VCS type not pre-selected.

The "Save again" button currently copies the previously provided parameters to the request form.

Mon, Jul 6, 11:18 AM · Web app

Fri, Jul 3

anlambert committed rDWAPPS423ac84653c0: Rename all references of swh PIDs to SWHIDs for consistency (authored by anlambert).
Rename all references of swh PIDs to SWHIDs for consistency
Fri, Jul 3, 6:21 PM
anlambert closed D3419: Rename all references of swh PIDs to SWHIDs for consistency.
Fri, Jul 3, 6:21 PM
anlambert updated the diff for D3419: Rename all references of swh PIDs to SWHIDs for consistency.

Update requirements-swh.txt

Fri, Jul 3, 5:48 PM
anlambert created D3419: Rename all references of swh PIDs to SWHIDs for consistency.
Fri, Jul 3, 5:44 PM
anlambert committed rDTSCNef83cf24893d: Fix import errors after swh-model update and move from PIDs to SWHIDs (authored by anlambert).
Fix import errors after swh-model update and move from PIDs to SWHIDs
Fri, Jul 3, 4:15 PM
anlambert closed D3415: Fix import errors after swh-model update and move from PIDs to SWHIDs.
Fri, Jul 3, 4:15 PM
anlambert created D3415: Fix import errors after swh-model update and move from PIDs to SWHIDs.
Fri, Jul 3, 4:11 PM
anlambert committed rDMOD1ff05161e795: identifiers: Rename some functions and types related to SWHIDs (authored by anlambert).
identifiers: Rename some functions and types related to SWHIDs
Fri, Jul 3, 4:07 PM
anlambert closed D3412: identifiers: Rename some functions and types related to SWHIDs.
Fri, Jul 3, 4:07 PM
anlambert accepted D3413: svn.loader: Fix uneventful visit case.

Tests refactoring which uncover bugs, nice !

Fri, Jul 3, 2:36 PM
anlambert accepted D3411: tests: Drop dead code.

\o/

Fri, Jul 3, 2:34 PM
anlambert accepted D3410: tests: Refactor repository with tampered information scenario.

Nice improvement !

Fri, Jul 3, 2:33 PM
anlambert created D3412: identifiers: Rename some functions and types related to SWHIDs.
Fri, Jul 3, 2:22 PM
anlambert accepted D3409: tests: Refactor repository with user-defined properties scenario.
Fri, Jul 3, 1:30 PM
anlambert accepted D3408: tests: Refactor svn load from remote dump scenario.
Fri, Jul 3, 1:29 PM
anlambert accepted D3407: tests: Refactor repository with wrong symlinks scenario.
Fri, Jul 3, 1:25 PM
anlambert accepted D3406: tests: Refactor repository with symlinks scenario.
Fri, Jul 3, 1:25 PM
anlambert accepted D3405: tests: Refactor repository with svn:externals property scenario.
Fri, Jul 3, 1:23 PM
anlambert updated subscribers of D3405: tests: Refactor repository with svn:externals property scenario.

Looks good.

Fri, Jul 3, 1:23 PM
anlambert accepted D3404: tests: Refactor mixed crlf lf scenario.
Fri, Jul 3, 1:11 PM

Thu, Jul 2

anlambert committed rDWAPPS299ed02cbebd: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Thu, Jul 2, 3:52 PM
anlambert committed rDWAPPSa4da1d819a45: common/service: Ensure to get last status when looking up origin visit (authored by anlambert).
common/service: Ensure to get last status when looking up origin visit
Thu, Jul 2, 3:52 PM
anlambert closed D3395: common/service: Ensure to get last status when looking up origin visit.
Thu, Jul 2, 3:52 PM
anlambert created D3395: common/service: Ensure to get last status when looking up origin visit.
Thu, Jul 2, 3:01 PM
anlambert added inline comments to D3390: Unify object_type some more within the merkle and from_disk modules.
Thu, Jul 2, 2:57 PM
anlambert accepted D3393: loader.svn: Reuse swh.model.from_disk.iter_directory function.
Thu, Jul 2, 2:45 PM
anlambert accepted D3392: loader-core: Reuse swh.model.from_disk.iter_directory function.
Thu, Jul 2, 2:44 PM
anlambert accepted D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.

Looks good, I added some nitpicking comments.

Thu, Jul 2, 2:44 PM
anlambert accepted D3390: Unify object_type some more within the merkle and from_disk modules.

LGTM, maybe you could set object_type type as Final like in other model classes (see inline comment).

Thu, Jul 2, 2:35 PM
anlambert committed rDWAPPS76d9162807e0: origin_visits/get_origin_visit: Improve default visit picking strategy (authored by anlambert).
origin_visits/get_origin_visit: Improve default visit picking strategy
Thu, Jul 2, 11:39 AM
anlambert closed D3385: origin_visits/get_origin_visit: Improve default visit picking strategy.
Thu, Jul 2, 11:39 AM
anlambert updated the diff for D3385: origin_visits/get_origin_visit: Improve default visit picking strategy.

Update: Improve tests implementation

Thu, Jul 2, 11:24 AM

Wed, Jul 1

anlambert updated the diff for D3385: origin_visits/get_origin_visit: Improve default visit picking strategy.
  • Use new swh.storage.algos.origin.origin_get_latest_visit_status utility function in revised get_origin_visit implementation
Wed, Jul 1, 6:15 PM
About · Developer information · Legal