Page MenuHomeSoftware Heritage
People anlambert

anlambert (Antoine Lambert)
User

Projects

User Details

User Since
Jul 3 2017, 10:14 AM (127 w, 1 d)

Recent Activity
View All

Today

anlambert accepted D2423: Add sentry integration to swh-web.

Looks good to me !

Tue, Dec 10, 2:57 PM
anlambert committed rDWAPPSf219e18699bb: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Tue, Dec 10, 2:48 PM
anlambert committed rDWAPPS74b9c1ebbb6d: common/origin_save: Fix scheduler task parameters (authored by anlambert).
common/origin_save: Fix scheduler task parameters
Tue, Dec 10, 2:48 PM
anlambert closed D2422: Save code now: Fix scheduler task parameters.
Tue, Dec 10, 2:48 PM
anlambert added inline comments to D2423: Add sentry integration to swh-web.
Tue, Dec 10, 2:44 PM
anlambert created D2422: Save code now: Fix scheduler task parameters.
Tue, Dec 10, 1:59 PM
anlambert updated the diff for D2419: origin_save: Add some statsd monitoring metrics.

Rebase

Tue, Dec 10, 11:49 AM
anlambert committed rDWAPPScd034e8da87e: tests: Fix data initialization after git loader api changes (authored by anlambert).
tests: Fix data initialization after git loader api changes
Tue, Dec 10, 11:48 AM
anlambert closed D2407: Fix tests data initialization after git loader api changes.
Tue, Dec 10, 11:48 AM
anlambert added a comment to T2124: Save Code Now: monitoring of admin infra.

Yes I agree, I ended up using statsd in D2419 after all. django-prometheus could be interesting to use but it maybe redundant with the upcoming sentry integration in swh-web.

Tue, Dec 10, 11:26 AM · Sprint 2019/12 (Monitor and Conquer)

Yesterday

anlambert accepted D2412: vault: Fix tests data initialization after git loader api changes.

Looks good to me !

Mon, Dec 9, 5:33 PM
anlambert accepted D2417: docker/compose: add rabbitmq_exporter service.

Looks good !

Mon, Dec 9, 5:23 PM
anlambert added a comment to D2416: docker/compose: configure the statsd endpoint for most of the containers.

Sure. I'm also moving these env vars in a dedicated file instead of putting them directly in the docker-compose file.

Mon, Dec 9, 5:05 PM
anlambert updated the summary of D2419: origin_save: Add some statsd monitoring metrics.
Mon, Dec 9, 5:00 PM
anlambert updated the diff for D2419: origin_save: Add some statsd monitoring metrics.

Remove commit from D2407

Mon, Dec 9, 5:00 PM
anlambert updated the diff for D2419: origin_save: Add some statsd monitoring metrics.

Rebase to master in order for the tests to pass

Mon, Dec 9, 4:59 PM
anlambert created D2419: origin_save: Add some statsd monitoring metrics.
Mon, Dec 9, 4:55 PM
anlambert accepted D2416: docker/compose: configure the statsd endpoint for most of the containers.

Great ! Could you also add that configuration to the swh-web service ? I am currently working on T1214 and I have added a couple of statsd metric to the webapp.

Mon, Dec 9, 4:41 PM
anlambert accepted D2413: Rename swh-scheduler-api as swh-scheduler and swh-vault-api as swh-vault.

All good !

Mon, Dec 9, 4:38 PM
anlambert requested changes to D2413: Rename swh-scheduler-api as swh-scheduler and swh-vault-api as swh-vault.

I totally agree on this. You miss some replacements in the tests though.

Mon, Dec 9, 4:27 PM
anlambert added inline comments to D2408: hg/git: Align lister's output (load-hg/git tasks) with loader's new format.
Mon, Dec 9, 3:05 PM
anlambert accepted D2408: hg/git: Align lister's output (load-hg/git tasks) with loader's new format.

Looks good !

Mon, Dec 9, 2:51 PM
anlambert accepted D2410: loader.hg: Unify tasks' message format with other loaders.
Mon, Dec 9, 2:12 PM
anlambert accepted D2409: tasks: Migrate load-git task message format.

Looks good to me !

Mon, Dec 9, 2:09 PM
anlambert moved T2124: Save Code Now: monitoring of admin infra from Backlog to in progress on the Sprint 2019/12 (Monitor and Conquer) board.
Mon, Dec 9, 1:54 PM · Sprint 2019/12 (Monitor and Conquer)
anlambert added inline comments to D2408: hg/git: Align lister's output (load-hg/git tasks) with loader's new format.
Mon, Dec 9, 11:57 AM
anlambert added inline comments to D2409: tasks: Migrate load-git task message format.
Mon, Dec 9, 11:54 AM

Fri, Dec 6

anlambert added inline comments to D2408: hg/git: Align lister's output (load-hg/git tasks) with loader's new format.
Fri, Dec 6, 6:03 PM
anlambert updated the summary of D2407: Fix tests data initialization after git loader api changes.
Fri, Dec 6, 5:38 PM
anlambert added a comment to D2407: Fix tests data initialization after git loader api changes.
In D2407#56857, @swh-public-ci wrote:

Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/831/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/831/console

Fri, Dec 6, 5:37 PM
anlambert created D2407: Fix tests data initialization after git loader api changes.
Fri, Dec 6, 5:32 PM
anlambert committed rDWAPPS713c6c4844ad: admin/origin_save: Add missing parameters to staff_member_required (authored by anlambert).
admin/origin_save: Add missing parameters to staff_member_required
Fri, Dec 6, 5:24 PM
anlambert accepted D2406: npm: Align lister's loader output tasks with expected format.

Apart a trailing comma in a function call, looks good !

Fri, Dec 6, 5:03 PM
anlambert accepted D2399: mercurial: Unify loader constructor + register worker (tasks, cli).
Fri, Dec 6, 3:11 PM
anlambert accepted D2405: svn.loader: Migrate to new buffer/filter behavior.

Looks good !

Fri, Dec 6, 3:02 PM
anlambert added a comment to T2124: Save Code Now: monitoring of admin infra.

We could use prometheus_client (packaged in debian) to generate and export Prometheus metrics for swh-web.

Fri, Dec 6, 2:25 PM · Sprint 2019/12 (Monitor and Conquer)
anlambert accepted D2403: core.loader: Drop deprecated behavior.

All good !

Fri, Dec 6, 2:21 PM
anlambert added inline comments to D2397: loader.cli: Reference new cli.
Fri, Dec 6, 2:08 PM · Core Loader, SWH command line interface
anlambert added inline comments to D2399: mercurial: Unify loader constructor + register worker (tasks, cli).
Fri, Dec 6, 1:52 PM
anlambert added a comment to D2399: mercurial: Unify loader constructor + register worker (tasks, cli).

Looks good !

Fri, Dec 6, 1:46 PM
anlambert added inline comments to D2400: git: Unify loaders constructor + register worker (tasks, cli).
Fri, Dec 6, 1:37 PM
anlambert accepted D2398: svn: Unify loader constructor + register worker (tasks, cli).

Looks good !

Fri, Dec 6, 1:36 PM
anlambert accepted D2400: git: Unify loaders constructor + register worker (tasks, cli).

Looks good !

Fri, Dec 6, 1:24 PM
anlambert accepted D2397: loader.cli: Reference new cli.

Looks good to me !

Fri, Dec 6, 1:21 PM · Core Loader, SWH command line interface
anlambert accepted D2401: deposit.api: Add a basic api page to https://deposit.s.o/1.
Fri, Dec 6, 12:04 PM
anlambert accepted D2402: deposit.loader: Remove no longer used deprecated loader.
Fri, Dec 6, 11:58 AM

Wed, Dec 4

anlambert triaged T2138: Return full URIS in next links of web API responses as Normal priority.
Wed, Dec 4, 3:29 PM · Web app
anlambert committed rDWAPPS2687043e78d4: misc/badges: Use blue color for non origin badges (authored by anlambert).
misc/badges: Use blue color for non origin badges
Wed, Dec 4, 1:30 PM

Tue, Dec 3

anlambert committed rDDEP19fefb761f53: requirements: Pin mypy and django-stubs version (authored by anlambert).
requirements: Pin mypy and django-stubs version
Tue, Dec 3, 3:49 PM
anlambert closed D2391: requirements: Pin mypy and django-stubs version.
Tue, Dec 3, 3:49 PM
anlambert created D2391: requirements: Pin mypy and django-stubs version.
Tue, Dec 3, 3:31 PM
anlambert accepted D2387: Build origin search regexps server-side..

Looks good, thanks !

Tue, Dec 3, 3:03 PM
anlambert added a subtask for T2135: Disambiguate browse URL regexps: T2115: Directories named 'directory' cannot be browsed in snapshot context views.
Tue, Dec 3, 2:58 PM · Web app
anlambert added a parent task for T2115: Directories named 'directory' cannot be browsed in snapshot context views: T2135: Disambiguate browse URL regexps.
Tue, Dec 3, 2:58 PM · Web app
anlambert accepted D2378: Paginate origin search results using the Link header instead of offsets..
Tue, Dec 3, 2:51 PM
anlambert abandoned D2369: Fix display of directories named 'directory' in some views.

Abandoning this as the issue is more global than it seems and the whole URLs scheme of swh-web/browse needs to be disambiguated (T2135).

Tue, Dec 3, 2:38 PM
anlambert triaged T2135: Disambiguate browse URL regexps as Normal priority.
Tue, Dec 3, 2:36 PM · Web app
anlambert added inline comments to D2369: Fix display of directories named 'directory' in some views.
Tue, Dec 3, 2:27 PM
anlambert committed rDWAPPS11cf6b1b2766: api/snapshot: Handle aliases chain when resolving real branch target (authored by anlambert).
api/snapshot: Handle aliases chain when resolving real branch target
Tue, Dec 3, 2:03 PM
anlambert closed D2384: api/snapshot: Handle aliases chain when resolving real branch target.
Tue, Dec 3, 2:03 PM
anlambert accepted D2386: Add throttle scope swh_api_origin_search to swh-web config..
Tue, Dec 3, 2:00 PM
anlambert updated the diff for D2384: api/snapshot: Handle aliases chain when resolving real branch target.

Rebase

Tue, Dec 3, 10:39 AM
anlambert committed rDMOD7b6f474533cb: hypothesis_strategies/snapshots: Explain last post-processing step (authored by anlambert).
hypothesis_strategies/snapshots: Explain last post-processing step
Tue, Dec 3, 10:38 AM
anlambert closed D2383: hypothesis_strategies/snapshots: Explain last post-processing step.
Tue, Dec 3, 10:38 AM

Mon, Dec 2

anlambert updated the test plan for D2384: api/snapshot: Handle aliases chain when resolving real branch target.
Mon, Dec 2, 8:04 PM
anlambert retitled D2383: hypothesis_strategies/snapshots: Explain last post-processing step from hypothesis: Forbid branch alias cycles generation in snapshots strategy to hypothesis_strategies/snapshots: Explain last post-processing step.
Mon, Dec 2, 8:02 PM
anlambert updated the diff for D2383: hypothesis_strategies/snapshots: Explain last post-processing step.

Update: There was no cycles generation between aliases issue after all, probably myself that messed up somewhere
when playing with hypothesis.

Mon, Dec 2, 8:00 PM
anlambert added a comment to D2383: hypothesis_strategies/snapshots: Explain last post-processing step.

If there's a bug here it should be fixed in that function (and a regression test should be added).

Mon, Dec 2, 7:49 PM
anlambert added a comment to D2383: hypothesis_strategies/snapshots: Explain last post-processing step.
In D2383#56176, @olasd wrote:

Cycle detection in snapshots is supposed to be handled in the snapshot_identifier function; that's why it's called in a loop when generating the snapshot id.
If there's a bug here it should be fixed in that function (and a regression test should be added).

Mon, Dec 2, 7:17 PM
anlambert requested changes to D2378: Paginate origin search results using the Link header instead of offsets..

Apart a couple of nitpicks to handle, looks good !

Mon, Dec 2, 5:13 PM
anlambert committed rDWAPPS5ee7811741ab: templates/search.html: Fix Previous/Next button text color (authored by anlambert).
templates/search.html: Fix Previous/Next button text color
Mon, Dec 2, 4:52 PM
anlambert committed rDWAPPS42168a7686e1: templates: Integrate swh badges in Permalinks tab (authored by anlambert).
templates: Integrate swh badges in Permalinks tab
Mon, Dec 2, 4:29 PM
anlambert closed D2320: Integrate swh badges in Permalinks tab.
Mon, Dec 2, 4:29 PM
anlambert committed rDWAPPSd1a53752a25f: misc: Add new endpoints to generate swh badges (authored by anlambert).
misc: Add new endpoints to generate swh badges
Mon, Dec 2, 4:29 PM
anlambert closed D2310: Add new endpoints to generate swh badges.
Mon, Dec 2, 4:29 PM
anlambert updated the diff for D2320: Integrate swh badges in Permalinks tab.

Rebase

Mon, Dec 2, 3:58 PM
anlambert updated the diff for D2310: Add new endpoints to generate swh badges.

Rebase

Mon, Dec 2, 3:58 PM
anlambert committed rDWAPPSeab486bf7ff7: requirements: Pin mypy and django-stubs version (authored by anlambert).
requirements: Pin mypy and django-stubs version
Mon, Dec 2, 3:56 PM
anlambert closed D2382: requirements: Pin mypy and django-stubs version.
Mon, Dec 2, 3:56 PM
anlambert created D2384: api/snapshot: Handle aliases chain when resolving real branch target.
Mon, Dec 2, 3:28 PM
anlambert updated the diff for D2383: hypothesis_strategies/snapshots: Explain last post-processing step.

Update: Need to test against 'alias' instead of TargetType.ALIAS to avoid hypothesis.errors.Flaky

Mon, Dec 2, 3:21 PM
anlambert created D2383: hypothesis_strategies/snapshots: Explain last post-processing step.
Mon, Dec 2, 2:31 PM
anlambert created D2382: requirements: Pin mypy and django-stubs version.
Mon, Dec 2, 2:08 PM

Sat, Nov 30

anlambert added a comment to D2369: Fix display of directories named 'directory' in some views.
In D2369#56033, @swh-public-ci wrote:

Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/818/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/818/console

Sat, Nov 30, 12:41 AM

Fri, Nov 29

anlambert closed D2375: Add automatic object identifier computation support.
Fri, Nov 29, 4:27 PM
anlambert committed rDMOD4e4c4ff26b83: model: Add automatic object identifier computation support (authored by anlambert).
model: Add automatic object identifier computation support
Fri, Nov 29, 4:27 PM
anlambert updated the diff for D2375: Add automatic object identifier computation support.

Update: Forgot to process Directory model

Fri, Nov 29, 3:52 PM
anlambert added inline comments to D2375: Add automatic object identifier computation support.
Fri, Nov 29, 3:50 PM
anlambert updated the diff for D2375: Add automatic object identifier computation support.

Update: Rename a variable

Fri, Nov 29, 2:51 PM
anlambert updated the diff for D2375: Add automatic object identifier computation support.

Update: Rebase and address @vlorentz comments

Fri, Nov 29, 2:47 PM
anlambert updated the summary of D2375: Add automatic object identifier computation support.
Fri, Nov 29, 2:46 PM
anlambert committed rDMODda6475615221: identifiers: Fix release_identifier for snapshot target (authored by anlambert).
identifiers: Fix release_identifier for snapshot target
Fri, Nov 29, 2:05 PM
anlambert closed D2373: Fix release_identifier for snapshot target.
Fri, Nov 29, 2:05 PM
anlambert updated the diff for D2373: Fix release_identifier for snapshot target.

Update: Forgot to remove print statement

Fri, Nov 29, 2:02 PM
anlambert updated the diff for D2369: Fix display of directories named 'directory' in some views.

Update: Rebase, fix a comment and a test as there is now an origin that contains the empty directory in tests data

Fri, Nov 29, 11:37 AM
anlambert committed rDWAPPSd28771ea5aaf: package.json: Upgrade depdendencies (authored by anlambert).
package.json: Upgrade depdendencies
Fri, Nov 29, 11:28 AM
anlambert committed rDWAPPSc2fb796eb903: browse: Hide history link for empty snapshot (authored by anlambert).
browse: Hide history link for empty snapshot
Fri, Nov 29, 11:28 AM
anlambert closed T2111: Clicking "History" on the empty snapshot page adds "None/" at the end of the URL as Resolved by committing rDWAPPSc2fb796eb903: browse: Hide history link for empty snapshot.
Fri, Nov 29, 11:28 AM · Web app
anlambert closed D2370: Hide history link for empty snapshot.
Fri, Nov 29, 11:28 AM
anlambert accepted D2372: replay: ensure a revision is present only once in a batch.
Fri, Nov 29, 11:26 AM
About · Developer information · Legal