Page MenuHomeSoftware Heritage

anlambert (Antoine Lambert)
User

Projects

User Details

User Since
Jul 3 2017, 10:14 AM (94 w, 3 d)

Recent Activity

Yesterday

anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.

Rebase

Wed, Apr 24, 5:08 PM
anlambert committed rDWAPPS65501f32f226: assets/webapp: Add missing filterXSS function export (authored by anlambert).
assets/webapp: Add missing filterXSS function export
Wed, Apr 24, 5:04 PM
anlambert committed rCDFD875c50aa3920: conf/web.yml: Disable swh web api rate limiting (authored by anlambert).
conf/web.yml: Disable swh web api rate limiting
Wed, Apr 24, 4:43 PM
anlambert added a comment to D1430: Correct typo "scrapping" -> "scraping".

That's only because I've (erroneously, this time) used arc land instead of arc land --squash.

Wed, Apr 24, 2:24 PM
anlambert added a comment to D1430: Correct typo "scrapping" -> "scraping".

Third: everyone else: once a change is accepted, you can land it yourself by doing first arc diff D1430 and then arc land

Wed, Apr 24, 2:11 PM
anlambert added a comment to D1430: Correct typo "scrapping" -> "scraping".

@vlorentz, looking at the commits history of the documentation repository, only team members have pushed on it (which are de facto members of the Developers project)

Wed, Apr 24, 1:17 PM
anlambert added a comment to D1430: Correct typo "scrapping" -> "scraping".

Ok, so the fact that you are not able to push is that you are not a member of the Developers phabricator project.
As you can see on the repository policies, there is a push restriction on that specific users group.

Wed, Apr 24, 12:32 PM
anlambert triaged T1688: Refactor content rendering as Normal priority.
Wed, Apr 24, 11:52 AM · Web app
Herald added a reviewer for D1431: Revisions walker: Add methods to query produced history state: Reviewers.
Wed, Apr 24, 11:34 AM
anlambert added a comment to D1430: Correct typo "scrapping" -> "scraping".

Hi @mcv21 , did you try to land that diff directly from the web interface by clicking on the "Land revision" link on the top left part of that page ?

Wed, Apr 24, 11:28 AM
anlambert triaged T1687: Add filename as an optional part in persistent identifiers as Normal priority.
Wed, Apr 24, 11:24 AM · Data Model
anlambert added a comment to D1369: Guess extension from detected mime type to add to filename.

Currently, you can pass a filename as a query parameter to the content view of swh-web
(see https://archive.softwareheritage.org/browse/content/sha1_git:d0158ee2e79b461bf25b5b66e6778671c2114263/?path=xmlrpc.php
as an example).

Wed, Apr 24, 11:20 AM
anlambert added a comment to T1685: move main website from www.s.o to s.o.

According to Gandi documentation, if we switch to their LiveDNS feature, there will be no downtime.

Wed, Apr 24, 11:14 AM · System administration, Website
anlambert added a comment to T1685: move main website from www.s.o to s.o.

@zack, I tried to handle that task but I do not have access to domains configuration from the Gandi interface.

Wed, Apr 24, 10:51 AM · System administration, Website

Tue, Apr 23

anlambert closed T1655: Web API: more user friendly answer when checking state of non existent save code now requests as Resolved by committing rDWAPPS9a2be798a039: api/origin_save: Return a 404 error when querying non existent request state.
Tue, Apr 23, 3:17 PM · Web app
anlambert committed rDWAPPS9a2be798a039: api/origin_save: Return a 404 error when querying non existent request state (authored by anlambert).
api/origin_save: Return a 404 error when querying non existent request state
Tue, Apr 23, 3:17 PM

Fri, Apr 19

anlambert updated subscribers of D1415: Add support for client side rendering of Jupyter notebooks.

There are a million different file formats out there, why are we rendering Markdown and Jupyter notebooks and not something else?

Fri, Apr 19, 8:09 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.

Update: Check that hljs supports the notebook language prior calling the highlight function

Fri, Apr 19, 7:40 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.

Update: last CSS polishing

Fri, Apr 19, 5:53 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.

Update: Fix url in notebook.css comment

Fri, Apr 19, 4:02 PM
anlambert added inline comments to D1415: Add support for client side rendering of Jupyter notebooks.
Fri, Apr 19, 4:00 PM
anlambert triaged T1680: Properly bundle MathJax once version 3.0 is released as Normal priority.
Fri, Apr 19, 3:55 PM · Web app
anlambert committed rDWAPPS1cf93d8223c7: assets: XSS filtering improvements (authored by anlambert).
assets: XSS filtering improvements
Fri, Apr 19, 3:39 PM
anlambert closed D1425: assets: XSS filtering improvements.
Fri, Apr 19, 3:39 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.
  • address comments
Fri, Apr 19, 3:37 PM
anlambert updated the diff for D1425: assets: XSS filtering improvements.

Update: address latest olasd comment ('..' => '../')

Fri, Apr 19, 3:34 PM
anlambert added a comment to T1667: Fix confusing duplication of "Archive" links on the main website.

If we remove it from the main website, we should also remove it everywhere for consistency.

Fri, Apr 19, 1:29 PM · Website, Unknown Object (Project)
anlambert added inline comments to D1425: assets: XSS filtering improvements.
Fri, Apr 19, 12:08 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.

Rebase

Fri, Apr 19, 12:03 PM
anlambert updated the diff for D1425: assets: XSS filtering improvements.
  • address comments
Fri, Apr 19, 12:03 PM
anlambert added a comment to T1667: Fix confusing duplication of "Archive" links on the main website.

How about dropping the top navbar ? It is not consistent across all or our website (it is missing on our forge for instance) and all links it contain can be easily found from our main website.

Fri, Apr 19, 10:43 AM · Website, Unknown Object (Project)

Thu, Apr 18

anlambert added inline comments to D1415: Add support for client side rendering of Jupyter notebooks.
Thu, Apr 18, 6:37 PM
anlambert added inline comments to D1425: assets: XSS filtering improvements.
Thu, Apr 18, 6:20 PM
anlambert committed rDSTO6510b5ec4d83: algos.revisions_walker: Handle truncated/shallow histories (authored by anlambert).
algos.revisions_walker: Handle truncated/shallow histories
Thu, Apr 18, 5:55 PM
anlambert closed D1424: algos.revisions_walker: Handle missing revisions in the archive.
Thu, Apr 18, 5:55 PM
anlambert closed T1675: Fix message and error for artifact history view bug as Resolved by committing rDSTO6510b5ec4d83: algos.revisions_walker: Handle truncated/shallow histories.
Thu, Apr 18, 5:55 PM · Storage manager, Web app
anlambert added inline comments to D1425: assets: XSS filtering improvements.
Thu, Apr 18, 5:48 PM
anlambert updated the diff for D1424: algos.revisions_walker: Handle missing revisions in the archive.

Update: Address comments

Thu, Apr 18, 5:34 PM
anlambert added a comment to D1424: algos.revisions_walker: Handle missing revisions in the archive.

T1677 created for implementing missing revision data notification.

Thu, Apr 18, 5:25 PM
anlambert triaged T1677: Revisions walker: Add notification for truncated/shallow histories as Normal priority.
Thu, Apr 18, 5:24 PM · Storage manager
anlambert added a comment to D1424: algos.revisions_walker: Handle missing revisions in the archive.

Could we find a way to return a flag saying "history truncated", "parent revision not found" or something more explicit than just returning "invalid" results silently?

Thu, Apr 18, 5:09 PM
anlambert retitled D1415: Add support for client side rendering of Jupyter notebooks from [WIP] Add support for client side rendering of Jupyter notebooks to Add support for client side rendering of Jupyter notebooks.
Thu, Apr 18, 5:02 PM
anlambert updated the summary of D1415: Add support for client side rendering of Jupyter notebooks.
Thu, Apr 18, 5:02 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.
  • move the XSS filtering improvements in a separate diff (D1425)
Thu, Apr 18, 5:02 PM
Herald added a reviewer for D1425: assets: XSS filtering improvements: Reviewers.
Thu, Apr 18, 4:58 PM
anlambert committed rDWAPPSb28e13b66f65: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Thu, Apr 18, 4:57 PM
anlambert committed rDWAPPS3bb1a7090a4c: assets/config/bootstrap-pre-customize: Improve some stylesheets (authored by anlambert).
assets/config/bootstrap-pre-customize: Improve some stylesheets
Thu, Apr 18, 4:57 PM
Herald added a reviewer for D1424: algos.revisions_walker: Handle missing revisions in the archive: Reviewers.
Thu, Apr 18, 4:20 PM
anlambert added a project to T1675: Fix message and error for artifact history view bug: Storage manager.
Thu, Apr 18, 4:17 PM · Storage manager, Web app
anlambert added a comment to T1675: Fix message and error for artifact history view bug.

The bug is related to the fact that the parent revision of that deposit is not present in the archive (see https://archive.softwareheritage.org/browse/revision/3d4aadc83990ccda9cc94a554ca69f6dedb1e071/?origin=https://hal.archives-ouvertes.fr/hal-01897934).

Thu, Apr 18, 3:42 PM · Storage manager, Web app

Wed, Apr 17

anlambert planned changes to D1415: Add support for client side rendering of Jupyter notebooks.
Wed, Apr 17, 10:39 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.
  • Add support for image rendering in the notebook when the src url is relative to a directory present in the swh archive
Wed, Apr 17, 10:38 PM
anlambert committed rDWAPPS76bba3681611: Makefile.local: Add test-fast target using swh-web-fast hypothesis profile (authored by anlambert).
Makefile.local: Add test-fast target using swh-web-fast hypothesis profile
Wed, Apr 17, 4:23 PM
anlambert committed rDWAPPS17e61eb7758e: browse: Code and swh objects metadata cleanup (authored by anlambert).
browse: Code and swh objects metadata cleanup
Wed, Apr 17, 4:23 PM

Tue, Apr 16

anlambert claimed T1655: Web API: more user friendly answer when checking state of non existent save code now requests.

Indeed, returning a 404 error seems the best option here. Will fix that asap.

Tue, Apr 16, 7:33 PM · Web app
anlambert planned changes to D1415: Add support for client side rendering of Jupyter notebooks.
Tue, Apr 16, 5:58 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.

Fix tests

Tue, Apr 16, 5:39 PM
anlambert updated the diff for D1415: Add support for client side rendering of Jupyter notebooks.
  • add support for math typesetting upon notebook rendering through the use of the MathJax library
Tue, Apr 16, 5:28 PM
anlambert committed rDWAPPS0706c426accd: package.json: Upgrade depedencies (authored by anlambert).
package.json: Upgrade depedencies
Tue, Apr 16, 5:26 PM
anlambert closed T1652: Allow editor role to use the WordPress customizer as Resolved.

Fixed in production by adding theme permissions to the Editor role through the use of the WP plugin mentioned above.

Tue, Apr 16, 2:19 PM · Website
anlambert triaged T1652: Allow editor role to use the WordPress customizer as Normal priority.
Tue, Apr 16, 1:45 PM · Website

Mon, Apr 15

anlambert committed rDWAPPS6cbad0ef83c3: assets/readme-rendering: Use dompurify as XSS filter instead of xss (authored by anlambert).
assets/readme-rendering: Use dompurify as XSS filter instead of xss
Mon, Apr 15, 10:45 AM
anlambert closed T1642: Images with src within repo dont render in Readme as Resolved by committing rDWAPPS6cbad0ef83c3: assets/readme-rendering: Use dompurify as XSS filter instead of xss.
Mon, Apr 15, 10:45 AM · Web app
anlambert closed D1412: assets/readme-rendering: Use dompurify as XSS filter.
Mon, Apr 15, 10:45 AM
anlambert updated the diff for D1412: assets/readme-rendering: Use dompurify as XSS filter.

Rebase

Mon, Apr 15, 10:41 AM

Fri, Apr 12

anlambert planned changes to D1415: Add support for client side rendering of Jupyter notebooks.
Fri, Apr 12, 6:25 PM
anlambert added a comment to T1641: Jupyter notebooks rendering.

I started working on this by adding client side rendering of notebooks in the archive web application (see D1415).

Fri, Apr 12, 6:25 PM · Easy hack, Web app
Herald added a reviewer for D1415: Add support for client side rendering of Jupyter notebooks: Reviewers.
Fri, Apr 12, 6:18 PM
anlambert updated the summary of D1412: assets/readme-rendering: Use dompurify as XSS filter.
Fri, Apr 12, 3:08 PM
anlambert updated the diff for D1412: assets/readme-rendering: Use dompurify as XSS filter.

Update: Simplify code and add XSS filtering for all supported README types

Fri, Apr 12, 3:06 PM
anlambert added a comment to T1642: Images with src within repo dont render in Readme.

@kalpitk , I have submitted D1412 fixing the observed issues. What do you think ?

Fri, Apr 12, 2:53 PM · Web app
Herald added a reviewer for D1412: assets/readme-rendering: Use dompurify as XSS filter: Reviewers.
Fri, Apr 12, 2:52 PM
anlambert committed rDLDNPMd045ec32afa0: debian/control: Add python3-chardet dependency (authored by anlambert).
debian/control: Add python3-chardet dependency
Fri, Apr 12, 10:51 AM
anlambert committed rDLDNPMd34a1343f708: tests: Add test for package.json file non utf8 encoded (authored by anlambert).
tests: Add test for package.json file non utf8 encoded
Fri, Apr 12, 10:48 AM
anlambert committed rDLDNPMb234386f8ad5: npm.client: Handle parsing of package.json file non utf8 encoded (authored by anlambert).
npm.client: Handle parsing of package.json file non utf8 encoded
Fri, Apr 12, 10:48 AM
anlambert closed T1644: Fix errors detected after a first loading batch as Resolved by committing rDLDNPMb234386f8ad5: npm.client: Handle parsing of package.json file non utf8 encoded.
Fri, Apr 12, 10:48 AM · Origin-npm
anlambert closed D1410: npm.client: Handle parsing of package.json file non utf8 encoded.
Fri, Apr 12, 10:48 AM
anlambert closed T1644: Fix errors detected after a first loading batch, a subtask of T1629: Deploy the npm ingestion in production, as Resolved.
Fri, Apr 12, 10:48 AM · Origin-npm

Thu, Apr 11

anlambert updated the diff for D1410: npm.client: Handle parsing of package.json file non utf8 encoded.

Update: Remove debug log

Thu, Apr 11, 6:16 PM
anlambert updated the summary of D1410: npm.client: Handle parsing of package.json file non utf8 encoded.
Thu, Apr 11, 6:14 PM
anlambert updated the summary of D1410: npm.client: Handle parsing of package.json file non utf8 encoded.
Thu, Apr 11, 6:14 PM
Herald added a reviewer for D1410: npm.client: Handle parsing of package.json file non utf8 encoded: Reviewers.
Thu, Apr 11, 6:13 PM
anlambert committed rDLDNPMd5599ee37eea: npm.client: Handle packages with no versions (authored by anlambert).
npm.client: Handle packages with no versions
Thu, Apr 11, 4:38 PM
anlambert closed D1409: npm.client: Handle packages with no versions.
Thu, Apr 11, 4:38 PM
anlambert updated the diff for D1409: npm.client: Handle packages with no versions.

Rebase

Thu, Apr 11, 4:38 PM
anlambert committed rDLDNPMf6cd8d609448: extract_npm_package_author: Handle list of dict authors layout (authored by anlambert).
extract_npm_package_author: Handle list of dict authors layout
Thu, Apr 11, 4:37 PM
anlambert closed D1408: extract_npm_package_author: Handle list of dict authors layout.
Thu, Apr 11, 4:37 PM
anlambert added a comment to D1408: extract_npm_package_author: Handle list of dict authors layout.

The deposit loader uses the tar loader under the hood which makes the author or each produced revision to Software Heritage <robot@softwareheritage.org>[1].
The real information about authors can be found in the revision metadata, see [2] as an example.

Thu, Apr 11, 4:36 PM
anlambert triaged T1645: Associating multiple authors to a revision as Normal priority.
Thu, Apr 11, 4:35 PM · Data Model
anlambert committed rCDFDca58318d9a24: Add npm loader and its configuration (authored by anlambert).
Add npm loader and its configuration
Thu, Apr 11, 4:11 PM
anlambert closed D1403: conf/loader.yml: Add npm loader task configuration.
Thu, Apr 11, 4:11 PM
anlambert updated the diff for D1403: conf/loader.yml: Add npm loader task configuration.

Update: Install swh-loader-npm in the Dockerfile (did not spot this due to the local mount of it through my docker-compose.override.yml file)

Thu, Apr 11, 4:10 PM
Herald added a reviewer for D1409: npm.client: Handle packages with no versions: Reviewers.
Thu, Apr 11, 3:35 PM
anlambert updated the diff for D1408: extract_npm_package_author: Handle list of dict authors layout.

Update commit message

Thu, Apr 11, 3:12 PM
anlambert updated the summary of D1408: extract_npm_package_author: Handle list of dict authors layout.
Thu, Apr 11, 3:10 PM
anlambert triaged T1644: Fix errors detected after a first loading batch as Normal priority.
Thu, Apr 11, 3:08 PM · Origin-npm
Herald added a reviewer for D1408: extract_npm_package_author: Handle list of dict authors layout: Reviewers.
Thu, Apr 11, 2:50 PM
anlambert committed R65:7137c57269fe: debian/rules: Exclude hypothesis generated data from package (authored by anlambert).
debian/rules: Exclude hypothesis generated data from package
Thu, Apr 11, 12:19 PM
anlambert committed R65:daea1d3cbea3: New upstream version 0.0.115 (authored by anlambert).
New upstream version 0.0.115
Thu, Apr 11, 12:19 PM
anlambert committed R65:2f4f58cbbd70: Update upstream source from tag 'debian/upstream/0.0.115' (authored by anlambert).
Update upstream source from tag 'debian/upstream/0.0.115'
Thu, Apr 11, 12:19 PM