Page MenuHomeSoftware Heritage
Differential D8215

Tag Sentry events with object ids
ClosedPublic
Actions

Authored by vlorentz on Aug 8 2022, 2:00 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDCIDXe29700bd96cc: Tag Sentry events with object ids
Summary

Without these tags, it is often impossible to find what object
caused a given crash without guesswork based on the object's
content and swh-graph.

Depends on D8214.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 8 2022, 2:00 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 8 2022, 2:00 PM
vlorentz updated this revision to Diff 29616.Aug 8 2022, 2:02 PM

rebase

swh-public-ci added a comment.Aug 8 2022, 2:09 PM

Build is green

Patch application report for D8215 (id=29614)

Could not rebase; Attempt merge onto 98153fb7ed...

Updating 98153fb..d3a4134
Fast-forward
 swh/indexer/indexer.py                    | 172 +++++++++++++++++-------------
 swh/indexer/metadata.py                   |  36 ++++---
 swh/indexer/tests/conftest.py             |  54 ++++++++++
 swh/indexer/tests/test_indexer.py         |  81 +++++++++++---
 swh/indexer/tests/test_origin_metadata.py |  62 ++++++++++-
 5 files changed, 300 insertions(+), 105 deletions(-)
Changes applied before test
commit d3a4134e0418b7bc7c926c8bd0f4954b83314cab
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:59:29 2022 +0200

    Tag Sentry events with object ids
    
    Without these tags, it is often impossible to find what object
    caused a given crash without guesswork based on the object's
    content and swh-graph.

commit f6547d2860338a3c54599d87f3dd159521bd40d7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:49:33 2022 +0200

    Add tests for Sentry reporting + add inconsistent capturing

commit 5975d32319ef71abe1c91192b9a1adde537cc783
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 12:03:06 2022 +0200

    Fix support of old RawExtrinsicMetadata objects with no id

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/404/ for more details.

Harbormaster completed remote builds in B30679: Diff 29614.Aug 8 2022, 2:09 PM
swh-public-ci added a comment.Aug 8 2022, 2:11 PM

Build is green

Patch application report for D8215 (id=29616)

Could not rebase; Attempt merge onto 98153fb7ed...

Updating 98153fb..d9388a2
Fast-forward
 swh/indexer/indexer.py                    | 172 +++++++++++++++++-------------
 swh/indexer/metadata.py                   |  36 ++++---
 swh/indexer/tests/conftest.py             |  54 ++++++++++
 swh/indexer/tests/test_indexer.py         |  81 +++++++++++---
 swh/indexer/tests/test_origin_metadata.py |  62 ++++++++++-
 5 files changed, 300 insertions(+), 105 deletions(-)
Changes applied before test
commit d9388a2092cc833b42a5066f906580520a1a7e4a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:59:29 2022 +0200

    Tag Sentry events with object ids
    
    Without these tags, it is often impossible to find what object
    caused a given crash without guesswork based on the object's
    content and swh-graph.

commit b6b437e8ca1f5936c5ffcf1663a2d89aff3e0b8d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:49:33 2022 +0200

    Add tests for Sentry reporting + fix inconsistent capturing

commit 5975d32319ef71abe1c91192b9a1adde537cc783
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 12:03:06 2022 +0200

    Fix support of old RawExtrinsicMetadata objects with no id

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/406/ for more details.

Harbormaster completed remote builds in B30681: Diff 29616.Aug 8 2022, 2:11 PM
vlorentz requested review of this revision.Aug 8 2022, 2:11 PM
vlorentz updated this revision to Diff 29625.Aug 8 2022, 2:55 PM

rebase

swh-public-ci added a comment.Aug 8 2022, 3:04 PM

Build is green

Patch application report for D8215 (id=29625)

Could not rebase; Attempt merge onto 5975d32319...

Updating 5975d32..b780b13
Fast-forward
 swh/indexer/indexer.py                    | 172 +++++++++++++++++-------------
 swh/indexer/metadata.py                   |  31 ++++--
 swh/indexer/tests/conftest.py             |  38 +++++++
 swh/indexer/tests/test_indexer.py         |  72 ++++++++++---
 swh/indexer/tests/test_origin_metadata.py |  54 +++++++++-
 5 files changed, 267 insertions(+), 100 deletions(-)
Changes applied before test
commit b780b13db5d44489ab1b870271973a64b300a43f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:59:29 2022 +0200

    Tag Sentry events with object ids
    
    Without these tags, it is often impossible to find what object
    caused a given crash without guesswork based on the object's
    content and swh-graph.

commit 50a42eb3e89d6700927b20a4bcf9c9747fa8c010
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:49:33 2022 +0200

    Add tests for Sentry reporting + fix inconsistent capturing

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/409/ for more details.

Harbormaster completed remote builds in B30691: Diff 29625.Aug 8 2022, 3:04 PM
anlambert accepted this revision.Aug 8 2022, 3:16 PM
anlambert added a subscriber: anlambert.

Should help for debugging indeed, looks good to me.

swh/indexer/indexer.py
624

could save a line here by concatenating with comment line above

This revision is now accepted and ready to land.Aug 8 2022, 3:16 PM
vlorentz updated this revision to Diff 29627.Aug 8 2022, 3:26 PM

remove extra line break

This revision was landed with ongoing or failed builds.Aug 8 2022, 3:27 PM
Closed by commit rDCIDXe29700bd96cc: Tag Sentry events with object ids (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCIDXe29700bd96cc: Tag Sentry events with object ids.
swh-public-ci added a comment.Aug 8 2022, 3:34 PM

Build is green

Patch application report for D8215 (id=29627)

Could not rebase; Attempt merge onto 5975d32319...

Updating 5975d32..e29700b
Fast-forward
 swh/indexer/indexer.py                    | 171 +++++++++++++++++-------------
 swh/indexer/metadata.py                   |  31 ++++--
 swh/indexer/tests/conftest.py             |  38 +++++++
 swh/indexer/tests/test_indexer.py         |  72 ++++++++++---
 swh/indexer/tests/test_origin_metadata.py |  54 +++++++++-
 5 files changed, 266 insertions(+), 100 deletions(-)
Changes applied before test
commit e29700bd96cca20166f3443cfebc7b25029da674
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:59:29 2022 +0200

    Tag Sentry events with object ids
    
    Without these tags, it is often impossible to find what object
    caused a given crash without guesswork based on the object's
    content and swh-graph.

commit 50a42eb3e89d6700927b20a4bcf9c9747fa8c010
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 13:49:33 2022 +0200

    Add tests for Sentry reporting + fix inconsistent capturing

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/410/ for more details.

Harbormaster completed remote builds in B30693: Diff 29627.Aug 8 2022, 3:34 PM

Revision Contents
Changeset List

PathSize
swh/
indexer/
176 lines
31 lines
tests/
16 lines
13 lines

Diff 29629

View Options

swh/indexer/indexer.py

Loading...
View Options

swh/indexer/metadata.py

Loading...
View Options

swh/indexer/tests/test_indexer.py

Loading...
View Options

swh/indexer/tests/test_origin_metadata.py

Loading...
About · Developer information · Legal