Page MenuHomeSoftware Heritage

mypy: Turn old type comments into pure type annotations
ClosedPublic

Authored by anlambert on Tue, Jul 12, 3:39 PM.

Details

Summary

Remains of when we were using Python 3.5 in production.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D8117 (id=29321)

Rebasing onto b80d078ee1...

Current branch diff-target is up to date.
Changes applied before test
commit 36f971347d5b957dc0da0dcc20a7f4b181bc604c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 12 15:10:10 2022 +0200

    mypy: Turn old type comments into pure type annotations

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1926/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1926/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jul 12, 4:02 PM
Harbormaster failed remote builds in B30404: Diff 29321!

Build is green

Patch application report for D8117 (id=29321)

Rebasing onto b80d078ee1...

Current branch diff-target is up to date.
Changes applied before test
commit 36f971347d5b957dc0da0dcc20a7f4b181bc604c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 12 15:10:10 2022 +0200

    mypy: Turn old type comments into pure type annotations

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1927/ for more details.

This revision is now accepted and ready to land.Tue, Jul 12, 5:13 PM