Differential D8130

Rename "intrinsic_metadata" field to "jsonld"
ClosedPublic
Actions

Authored by vlorentz on Jul 19 2022, 10:26 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSEA19a825889cfe: Rename "intrinsic_metadata" field to "jsonld"

Summary

It will soon be used to store and query extrinsic metadata as well

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 19 2022, 10:26 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2022, 10:26 AM

Build is green

Patch application report for D8130 (id=29369)

Rebasing onto 132b3b1238...

Current branch diff-target is up to date.

Changes applied before test

commit 19a825889cfeac4f9019dcffe121508cf7a41c51
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 10:24:57 2022 +0200

    Rename "intrinsic_metadata" field to "jsonld"
    
    It will soon be used to store and query extrinsic metadata as well

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/336/ for more details.

Harbormaster completed remote builds in B30443: Diff 29369.Jul 19 2022, 10:30 AM

vlorentz requested review of this revision.Jul 19 2022, 10:30 AM

Looks good to me, I am wondering if you should not add a field alias to avoid reindexing but still allow search in intrinsic metadata already stored in elasticsearch ?

anlambert accepted this revision.Jul 19 2022, 10:47 AM

This revision is now accepted and ready to land.Jul 19 2022, 10:47 AM

good point, I didn't think of that.

However, we will migrate this at the same time as T4397, so it's not worth it

Closed by commit rDSEA19a825889cfe: Rename "intrinsic_metadata" field to "jsonld" (authored by vlorentz). · Explain WhyJul 19 2022, 12:52 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSEA19a825889cfe: Rename "intrinsic_metadata" field to "jsonld".