Details
Details
- Reviewers
olasd anlambert vsellier - Group Reviewers
Reviewers - Commits
- rDENVb41653635e50: docker: update the list of created topics
Diff Detail
Diff Detail
- Repository
- rDENV Development environment
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| docker/docker-compose.yml | ||
|---|---|---|
| 23 | TIL the possibility to specify the cleanup policy here. Shouldn't this be specified for all the topics? | |
Comment Actions
kafka service healthcheck needs to be updated before landing this.
| docker/docker-compose.yml | ||
|---|---|---|
| 44–45 | Since you have added new kafka topics, the healthcheck condition should be updated to ensure all topics got created before starting services depending on those, healthcheck: test: "[ `JMX_PORT= kafka-topics.sh --list --zookeeper zookeeper:2181 | wc -l` -ge `echo $$KAFKA_CREATE_TOPICS | tr ',' '\n' | wc -l` ]" | |
Comment Actions
apply/fix comments
- make all topics compact
- add privileged topics
- update healthcheck test