Page MenuHomeSoftware Heritage

olasd (Nicolas Dandrimont)
UserAdministrator

Projects (7)

User Details

User Since
Sep 7 2015, 3:25 PM (253 w, 1 d)
Roles
Administrator

Recent Activity

Thu, Jul 9

olasd committed rDDEPd7f22611d9fa: Clean up the swh.scheduler / swh.storage pytest plugin imports (authored by olasd).
Clean up the swh.scheduler / swh.storage pytest plugin imports
Thu, Jul 9, 7:44 PM
olasd closed D3487: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 7:44 PM
olasd created D3490: Drop useless use of pifpaf.
Thu, Jul 9, 7:43 PM
olasd committed rDSTO124e76d294bb: Rework dia -> pdf pipeline for inkscape 1.0 (authored by olasd).
Rework dia -> pdf pipeline for inkscape 1.0
Thu, Jul 9, 7:40 PM
olasd committed rDMODbf4353663b2c: Rework dia -> pdf pipeline for inkscape 1.0 (authored by olasd).
Rework dia -> pdf pipeline for inkscape 1.0
Thu, Jul 9, 7:40 PM
olasd closed D3489: Rework dia -> pdf pipeline for inkscape 1.0.
Thu, Jul 9, 7:40 PM
olasd created D3489: Rework dia -> pdf pipeline for inkscape 1.0.
Thu, Jul 9, 7:36 PM
olasd accepted D3475: setup: Do no expose the pytest-plugin any longer.
Thu, Jul 9, 7:29 PM
olasd committed rDCIDX706250793b70: Drop useless use of pifpaf (authored by olasd).
Drop useless use of pifpaf
Thu, Jul 9, 7:03 PM
olasd committed rDCIDX0ab302044ae5: Clean up the swh.scheduler and swh.storage pytest plugin imports (authored by olasd).
Clean up the swh.scheduler and swh.storage pytest plugin imports
Thu, Jul 9, 7:03 PM
olasd closed D3488: Clean up the swh.scheduler pytest plugin imports.
Thu, Jul 9, 7:03 PM
olasd updated the diff for D3488: Clean up the swh.scheduler pytest plugin imports.

cleaner cleanup

Thu, Jul 9, 7:00 PM
olasd created D3488: Clean up the swh.scheduler pytest plugin imports.
Thu, Jul 9, 6:49 PM
olasd created D3487: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 6:34 PM
olasd closed D3486: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 6:33 PM
olasd committed rDLDHG385dacfae84d: Clean up the swh.scheduler / swh.storage pytest plugin imports (authored by olasd).
Clean up the swh.scheduler / swh.storage pytest plugin imports
Thu, Jul 9, 6:33 PM
olasd created D3486: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 6:31 PM
olasd committed rDLDG94d13f79c4e2: Clean up the swh.scheduler / swh.storage pytest plugin imports (authored by olasd).
Clean up the swh.scheduler / swh.storage pytest plugin imports
Thu, Jul 9, 5:58 PM
olasd closed D3483: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 5:58 PM
olasd created D3483: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 5:56 PM
olasd committed rDLDSVNefe886a0b8b1: Clean up the swh.scheduler / swh.storage pytest plugin imports (authored by olasd).
Clean up the swh.scheduler / swh.storage pytest plugin imports
Thu, Jul 9, 5:48 PM
olasd closed D3482: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 5:48 PM
olasd added inline comments to D3481: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 5:48 PM
olasd created D3482: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 5:40 PM
olasd committed rDLSc9963d4302b9: Use the new names for the swh.scheduler test fixtures (authored by olasd).
Use the new names for the swh.scheduler test fixtures
Thu, Jul 9, 5:34 PM
olasd closed D3480: Use the new names for the swh.scheduler test fixtures.
Thu, Jul 9, 5:34 PM
olasd committed rDLDBASEed4e0b38c15b: Clean up the swh.scheduler / swh.storage pytest plugin imports (authored by olasd).
Clean up the swh.scheduler / swh.storage pytest plugin imports
Thu, Jul 9, 5:33 PM
olasd closed D3481: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 5:33 PM
olasd created D3481: Clean up the swh.scheduler / swh.storage pytest plugin imports.
Thu, Jul 9, 5:27 PM
olasd updated the diff for D3425: Intoduce a simpler base pattern for lister implementations..

rebase

Thu, Jul 9, 5:19 PM
olasd created D3480: Use the new names for the swh.scheduler test fixtures.
Thu, Jul 9, 5:16 PM
olasd accepted D3477: Fix a typo in previous revision.
Thu, Jul 9, 12:26 PM
olasd accepted D3476: Convert ImmutableDict to dict before passing it to json.dumps..
Thu, Jul 9, 11:35 AM
olasd added a comment to D3475: setup: Do no expose the pytest-plugin any longer.

The documentation should read pytest_plugins = ["swh.storage.pytest_plugin"]. You also need to add that line to your own conftest.py if you're depending on that fixture.

Thu, Jul 9, 10:28 AM

Wed, Jul 8

olasd accepted D3472: requirements.txt: Set future version to >= 0.16.0.
Wed, Jul 8, 6:32 PM
olasd committed rDSCH7009c3bfc210: Move all celery-related fixtures to the swh.scheduler pytest plugin (authored by olasd).
Move all celery-related fixtures to the swh.scheduler pytest plugin
Wed, Jul 8, 6:31 PM
olasd closed D3469: Move all celery-related fixtures to the swh.scheduler pytest plugin.
Wed, Jul 8, 6:31 PM
olasd added a comment to D3470: debian: Add pybuild.testfiles fixing tests execution in package build.

Please add a newline at the end of the file.

Wed, Jul 8, 6:19 PM
olasd requested changes to D3472: requirements.txt: Set future version to >= 0.16.0.

Please drop the line. Celery 4.4.4 isn't used anymore.

Wed, Jul 8, 6:19 PM
olasd created D3469: Move all celery-related fixtures to the swh.scheduler pytest plugin.
Wed, Jul 8, 6:00 PM
olasd committed rSPSITE6a463d714014: Enable non-free and microcode on granet (authored by olasd).
Enable non-free and microcode on granet
Wed, Jul 8, 10:47 AM

Tue, Jul 7

olasd added a comment to D3454: Adapt the git loader to swh-model >0.4.

Oh, that needs a requirements-swh.txt bump as well, I guess.

Tue, Jul 7, 9:09 PM
olasd accepted D3454: Adapt the git loader to swh-model >0.4.

Nice!

Tue, Jul 7, 9:09 PM
olasd added inline comments to D3425: Intoduce a simpler base pattern for lister implementations..
Tue, Jul 7, 4:09 PM
olasd accepted D3426: Extract revision's extra_header as a top level attribute.
Tue, Jul 7, 4:02 PM

Mon, Jul 6

olasd updated the diff for D3425: Intoduce a simpler base pattern for lister implementations..

Apply some review comments

Mon, Jul 6, 5:22 PM
olasd committed rDSCHb2cbb9ba856c: Move shareable fixtures out of conftest into a dedicated pytest plugin (authored by olasd).
Move shareable fixtures out of conftest into a dedicated pytest plugin
Mon, Jul 6, 4:47 PM
olasd closed D3430: Move sharable fixtures out of conftest into a dedicated pytest plugin.
Mon, Jul 6, 4:47 PM
olasd updated the diff for D3430: Move sharable fixtures out of conftest into a dedicated pytest plugin.

Reword

Mon, Jul 6, 4:42 PM
olasd accepted D3432: Move common test utility function to the top-level arborescence.
Mon, Jul 6, 4:41 PM
olasd accepted D3431: Define common test helper function.
Mon, Jul 6, 4:29 PM
olasd added inline comments to D3425: Intoduce a simpler base pattern for lister implementations..
Mon, Jul 6, 4:18 PM
olasd added a comment to D3428: Migrate loader tests to use pytest.

Build has FAILED

Mon, Jul 6, 4:14 PM
olasd added a comment to D3428: Migrate loader tests to use pytest.

That's pretty nice, thanks.

Mon, Jul 6, 3:39 PM
olasd added a comment to D3426: Extract revision's extra_header as a top level attribute.

Looks nice.

Mon, Jul 6, 3:32 PM
olasd created D3430: Move sharable fixtures out of conftest into a dedicated pytest plugin.
Mon, Jul 6, 2:57 PM
olasd committed rDLS014c446d0594: Switch over to setuptools-scm (authored by olasd).
Switch over to setuptools-scm
Mon, Jul 6, 2:28 PM
olasd closed D3424: Switch over to setuptools-scm.
Mon, Jul 6, 2:28 PM
olasd committed rSPSITE35c85a2785bb: Enable the mercurial loader again (authored by olasd).
Enable the mercurial loader again
Mon, Jul 6, 2:19 PM
olasd closed T998: Mercurial loader sometimes creates snapshots that point to revisions that haven't been loaded, a subtask of T995: Investigate and fix snapshots with broken links, as Resolved.
Mon, Jul 6, 1:33 PM · Archive content
olasd closed T998: Mercurial loader sometimes creates snapshots that point to revisions that haven't been loaded as Resolved.

I expect this has been fixed now...

Mon, Jul 6, 1:33 PM · Mercurial loader
olasd committed rDSCH5b373ceb36e4: Introduce a get_listed_origins endpoint (authored by olasd).
Introduce a get_listed_origins endpoint
Mon, Jul 6, 12:16 PM
olasd committed rDSCHaefc5c97f80a: Don't recurse into attrs objects when serializing (authored by olasd).
Don't recurse into attrs objects when serializing
Mon, Jul 6, 12:16 PM
olasd closed D3423: Introduce a get_listed_origins endpoint.
Mon, Jul 6, 12:16 PM
olasd closed D3422: Don't recurse into attrs objects when serializing.
Mon, Jul 6, 12:16 PM
olasd updated the diff for D3423: Introduce a get_listed_origins endpoint.

Add test for get_listed_origins()

Mon, Jul 6, 11:51 AM
olasd updated the diff for D3423: Introduce a get_listed_origins endpoint.

Drop limits checking

Mon, Jul 6, 11:32 AM
olasd updated the diff for D3423: Introduce a get_listed_origins endpoint.

Add db upgrade script

Mon, Jul 6, 11:09 AM
olasd added inline comments to D3423: Introduce a get_listed_origins endpoint.
Mon, Jul 6, 10:55 AM
olasd created D3425: Intoduce a simpler base pattern for lister implementations..
Mon, Jul 6, 10:39 AM
olasd created D3424: Switch over to setuptools-scm.
Mon, Jul 6, 10:38 AM
olasd created D3423: Introduce a get_listed_origins endpoint.
Mon, Jul 6, 9:52 AM
olasd created D3422: Don't recurse into attrs objects when serializing.
Mon, Jul 6, 9:52 AM

Sat, Jul 4

olasd added a comment to D3417: Add a new ImmutableDict class, and use it in model objects..

That's great, thanks!

Sat, Jul 4, 1:54 PM

Fri, Jul 3

olasd accepted D3420: pg-storage: Add missing cur parameter passing.

Thanks!

Fri, Jul 3, 6:12 PM
olasd added a comment to D3416: storage.db: Drop db.origin_visit_upsert behavior.

The change by itself looks fine, but the cursor manipulation logic is not sparking joy :-)

Fri, Jul 3, 4:50 PM
olasd accepted D3389: Extract the extra_headers from metadata on the Revision model class.

Accepted, with the following caveat: I'm still not sure what the plan is to deploy this now? In the current state of this diff, as soon as we deploy this on workers, data loss will occur (as the new extra_headers field isn't supported by swh.storage).

Fri, Jul 3, 2:56 PM
olasd committed rDCOREce1e4523834b: Add type annotations for swh.core.db.BaseDb (authored by olasd).
Add type annotations for swh.core.db.BaseDb
Fri, Jul 3, 2:37 PM
olasd closed D3398: Add type annotations for swh.core.db.BaseDb.
Fri, Jul 3, 2:37 PM
olasd committed rDCORE7124063e497a: Reimplement PostgreSQL COPY escaping from first principles (authored by olasd).
Reimplement PostgreSQL COPY escaping from first principles
Fri, Jul 3, 2:37 PM
olasd closed D3394: Improve test coverage and type coverage for copy_to.
Fri, Jul 3, 2:37 PM
olasd created D3398: Add type annotations for swh.core.db.BaseDb.
Fri, Jul 3, 1:24 AM
olasd updated the diff for D3394: Improve test coverage and type coverage for copy_to.

Reimplement copy_to escaping from the ground up.

Fri, Jul 3, 1:24 AM

Thu, Jul 2

olasd committed rCJSWH4ca591ff184a: Drop obsolete args for the automatic backport job (authored by olasd).
Drop obsolete args for the automatic backport job
Thu, Jul 2, 5:25 PM
olasd created D3394: Improve test coverage and type coverage for copy_to.
Thu, Jul 2, 1:32 PM

Wed, Jul 1

olasd edited P708 non bytes extra_headers.
Wed, Jul 1, 5:16 PM
olasd updated the language for P708 non bytes extra_headers from autodetect to remarkup.
Wed, Jul 1, 5:12 PM
olasd created P708 non bytes extra_headers.
Wed, Jul 1, 5:12 PM
olasd added a comment to D3389: Extract the extra_headers from metadata on the Revision model class.

I'm not sure about popping the extra_headers off of the incoming metadata field right now. This feels like something we want to do long term, but if you do that right now, it means you're putting upgrades of swh.model and swh.storage (with support with the new field) and all loaders in lockstep of one another. If you upgrade swh.model now, you'll lose the extra_headers until swh.storage will be able to store them.

Wed, Jul 1, 4:00 PM

Tue, Jun 30

olasd committed rSPSITE17a919051277: Update logstash configuration (authored by olasd).
Update logstash configuration
Tue, Jun 30, 11:55 AM
olasd committed rSPSITE504225ff5efd: Add resource record for oturtle-desktop (authored by olasd).
Add resource record for oturtle-desktop
Tue, Jun 30, 11:39 AM

Mon, Jun 29

olasd committed rSPSITE817a7225fec4: Move to elk 7.8.0 (authored by olasd).
Move to elk 7.8.0
Mon, Jun 29, 11:18 AM

Thu, Jun 25

olasd added a comment to T2466: Re design the lazy loading feature for Content objects.

Lazy loading for content objects (stored as files on the filesystem) gives us a choice where to put the cursor between the two ends of the eternal tradeoff between:

Thu, Jun 25, 4:15 PM · Core Loader
olasd added a project to T2466: Re design the lazy loading feature for Content objects: Core Loader.
Thu, Jun 25, 4:07 PM · Core Loader

Wed, Jun 24

olasd accepted D3344: journal_data: Make origin-visit optional fields to None.

Maybe the asserts should be in an actual test function? Feels a bit wrong to have top-level asserts in that file.

Wed, Jun 24, 6:09 PM
olasd added a comment to D3344: journal_data: Make origin-visit optional fields to None.

(the suggested test should check that, for each ORIGIN_VISIT_STATUS, the date is > to the one of the matching ORIGIN_VISIT)

Wed, Jun 24, 3:56 PM
olasd requested changes to D3344: journal_data: Make origin-visit optional fields to None.
Wed, Jun 24, 3:55 PM
olasd committed rCJSWHb21f76da449f: Allow all jobs to copy artifacts from swh-pypi (authored by olasd).
Allow all jobs to copy artifacts from swh-pypi
Wed, Jun 24, 10:44 AM

Tue, Jun 23

olasd added inline comments to D3307: loader: Read snapshot out of the last origin visit status.
Tue, Jun 23, 11:56 AM

Mon, Jun 22

olasd committed rSPSITEd639f438a729: Update rabbitmq plugin arguments with the proper values (authored by olasd).
Update rabbitmq plugin arguments with the proper values
Mon, Jun 22, 7:51 PM