- User Since
- Sep 7 2015, 3:25 PM (263 w, 2 h)
Fri, Sep 18
Yeah, this definitely needs to happen before the new swh.loader.core is deployed.
Thu, Sep 17
Btw, sqitch uses the native scripting for the database engine (in case of postgres, psql scripts), so if we ever end up using it, we can keep this approach.
So, I've first attempted something along the lines of https://www.depesz.com/2008/06/18/conditional-ddl/, which uses a function to execute DDL commands stored in a string.
remove spurious flag on an \else block
Begrudgingly giving this an Accept.
+1 to the idea (and to the specific config as I have already bikeshed it)
I really hate this, but save from making *_add able to take generators as arguments again, this is probably the most decent way out.
It took me a bit to understand what the sorteds were achieving (dedup the list while keeping it ordered), so I wouldn't mind if you turned them into an explicit loop, or at least if you added a comment.
I'm okay with this change. But I think other team members should have a stab at the color of the bikeshed too.
Wed, Sep 16
Fix flake8 issue that snuck past pre-commit thanks to rebase shenanigans
Thanks! This indeed looks much less fragile than the concat version.
I don't like using concat and ERB templates to generate yaml files at all:
I agree with the switch to yaml, but I don't think we should have plain text yaml files in the hiera variables.
Tue, Sep 15
This has been pushed to production now.
- Improve networks profile module documentation
After doing the basic kafka config, I've done the following to create the topics: