Page MenuHomeSoftware Heritage

Remove support for deprecated exception format
ClosedPublic

Authored by vlorentz on Aug 9 2022, 10:48 AM.

Details

Summary

It was removed from all RPC servers years ago.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8219 (id=29647)

Rebasing onto 2d1cd6af71...

Current branch diff-target is up to date.
Changes applied before test
commit e6497914d42b1f1e36e2850f53e8b9a04443cbe8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 9 10:48:22 2022 +0200

    Remove support for deprecated exception format
    
    It was removed from all RPC servers years ago.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/462/ for more details.

anlambert added a subscriber: anlambert.

Nice code cleaning !

swh/core/api/__init__.py
356

Are you sure we do not need to catch the TypeError anymore ? Is it not thrown by self._decode_response ?

This revision is now accepted and ready to land.Aug 9 2022, 11:22 AM
swh/core/api/__init__.py
356

I can't think of a way to trigger it