The use of Google ReCAPTCHA is now dropped in favor of rate limiting the number of save requests a user can create through the form (10/h).
Mon, Jun 17
Getting rid of ReCaptcha for save code now LGTM too.
I just wasn't sure that rate limit applies to Web UI submissions (e.g., will API requests come from our own IP? and if so, is that whitelisted?); I'm assuming that is what @anlambert plans to check.
FWIW https://grafana.softwareheritage.org/d/jScG7g6mk/objstorage-object-counts?orgId=1 is a (not great) implementation of this.
I should have read django-simple-captcha doc, indeed its integration is not really straightforward for swh-web.
With the post-hoc moderation of Save Code Now requests, do we really need a captcha? Isn't the base rate limiting enough?
Django-simple-captcha works best out of the box using Forms or ModelForms. But the origin/save page is not rendered using forms, its plain HTML. One possible solution is to use a Form for origin save submission, the other is to write custom captcha template in and include it in the page. Which one did you have in mind?
Fri, Jun 14
Can we have the feature which will return the content of File Type, Language Type, and License not its URL
Wed, Jun 12
I plan to add the following e2e tests-
- Test basic webapp functionalities like 'sidebar', 'back-to-top'
- Test home page displays positive stats for directories, authors,...
- Test the origin-search with different combinations of checkboxes
- Test basic functionality of directory view.
- Test file being displayed (for some known format, maybe .txt)
- Test error being displayed when invalid sha1 or unknown origin url
Sat, Jun 8
Fri, Jun 7
Closed by d355d8973205
These tests will be redundant with the end to end ones, so closing that task and prefer to rely on using cypress for frontend testing.
Thu, Jun 6
@shisus , I have tested cypress and the tool is indeed quite awesome !
No problem, I want to contribute to this project, so I'm looking where I would be able to work with.
Do you plan to add cypress in the web repository or Is it still a POC?
Is there a chance to work with you in setting up the cypress environment?
Wed, Jun 5
Tue, Jun 4
Thanks for pointing out the cypress tool, it looks pretty interesting.
Based on my understanding, it could be used to write and run unit tests but also end to end ones.
Sat, Jun 1
Hello everyone, I've some questions:
Fri, May 31
I think, we need to run the docker (with overridden swh-web) manually. And then run the selenium test cases. (I couldn't find a better approach)
Tue, May 28
In order to implement the unit tests, we will need the following node modules:
Sat, May 25
We've discussed this back then, and decided in the end to leave it at the Django layer. Closing.
this is now done, at least based on IP addresses, we'll need (if it doesn't exist yet) a dedicated task for how to do it differently, e.g., using API keys