Page MenuHomeSoftware Heritage

Web appFolder
ActivePublic

Members

  • This project does not have any members.

Details

Recent Activity

Yesterday

anlambert closed T1815: Use a FOSS alternative or drop Google ReCAPTCHA use as Resolved.

The use of Google ReCAPTCHA is now dropped in favor of rate limiting the number of save requests a user can create through the form (10/h).

Tue, Jun 18, 5:24 PM · Web app
anlambert renamed T1815: Use a FOSS alternative or drop Google ReCAPTCHA use from Use a FOSS alternative to Google ReCAPTCHA to Use a FOSS alternative or drop Google ReCAPTCHA use.
Tue, Jun 18, 3:28 PM · Web app

Mon, Jun 17

zack added a comment to T1815: Use a FOSS alternative or drop Google ReCAPTCHA use.

Getting rid of ReCaptcha for save code now LGTM too.
I just wasn't sure that rate limit applies to Web UI submissions (e.g., will API requests come from our own IP? and if so, is that whitelisted?); I'm assuming that is what @anlambert plans to check.

Mon, Jun 17, 4:34 PM · Web app
olasd added a comment to T1815: Use a FOSS alternative or drop Google ReCAPTCHA use.

I should have read django-simple-captcha doc, indeed its integration is not really straightforward for swh-web.
Currently, only the api endpoint for creating save requests is rate limited while the save code now form is submitted using Javascript
(validating input then setting the appropriate Django CSRF token before sending the POST request).
So without captcha, it will still be difficult for a dumb bot to spam us.
I would go for removing the captcha but add rate limiting to the form submission just in case.

Mon, Jun 17, 4:22 PM · Web app
olasd added a comment to T693: public page showing the amount of objects (content count et al.) in 3rd party mirrors.

FWIW https://grafana.softwareheritage.org/d/jScG7g6mk/objstorage-object-counts?orgId=1 is a (not great) implementation of this.

Mon, Jun 17, 4:12 PM · Web app, Website
anlambert added a comment to T1815: Use a FOSS alternative or drop Google ReCAPTCHA use.

I should have read django-simple-captcha doc, indeed its integration is not really straightforward for swh-web.

Mon, Jun 17, 2:52 PM · Web app
olasd added a comment to T1815: Use a FOSS alternative or drop Google ReCAPTCHA use.

As an alternative, we could just set the Django CSRF token on the form using a bit of Javascript code rather than the view sending it directly in the form, which would thwart most dumb bots (that's the "ReCAPTCHA alternatives for uncustomized spam > Javascript" section of the aforementioned article).

Mon, Jun 17, 2:29 PM · Web app
olasd added a comment to T1815: Use a FOSS alternative or drop Google ReCAPTCHA use.

With the post-hoc moderation of Save Code Now requests, do we really need a captcha? Isn't the base rate limiting enough?

Mon, Jun 17, 2:24 PM · Web app
twitu added a comment to T1815: Use a FOSS alternative or drop Google ReCAPTCHA use.

Django-simple-captcha works best out of the box using Forms or ModelForms. But the origin/save page is not rendered using forms, its plain HTML. One possible solution is to use a Form for origin save submission, the other is to write custom captcha template in and include it in the page. Which one did you have in mind?

Mon, Jun 17, 2:18 PM · Web app
vlorentz updated the task description for T1805: Public API v2 (meta task).
Mon, Jun 17, 1:12 PM · Web app
vlorentz updated the task description for T1805: Public API v2 (meta task).
Mon, Jun 17, 12:31 PM · Web app
anlambert triaged T1815: Use a FOSS alternative or drop Google ReCAPTCHA use as Normal priority.
Mon, Jun 17, 11:48 AM · Web app

Fri, Jun 14

zack added a comment to T1789: batch API to check for the presence of content in the archive.

Can we have the feature which will return the content of File Type, Language Type, and License not its URL

Fri, Jun 14, 1:13 PM · Web app
sandipbhuyan added a comment to T1789: batch API to check for the presence of content in the archive.

Can we have the feature which will return the content of File Type, Language Type, and License not its URL

Fri, Jun 14, 12:22 PM · Web app
vlorentz triaged T1805: Public API v2 (meta task) as Normal priority.
Fri, Jun 14, 12:06 PM · Web app

Wed, Jun 12

kalpitk updated subscribers of T1768: Add end to end tests for the frontend part of swh-web.
Wed, Jun 12, 9:28 AM · GSoC 2019, Web app
kalpitk added a comment to T1768: Add end to end tests for the frontend part of swh-web.

I plan to add the following e2e tests-

  1. Test basic webapp functionalities like 'sidebar', 'back-to-top'
  2. Test home page displays positive stats for directories, authors,...
  3. Test the origin-search with different combinations of checkboxes
  4. Test basic functionality of directory view.
  5. Test file being displayed (for some known format, maybe .txt)
  6. Test error being displayed when invalid sha1 or unknown origin url
Wed, Jun 12, 9:20 AM · GSoC 2019, Web app

Sat, Jun 8

anlambert added a project to T1768: Add end to end tests for the frontend part of swh-web: GSoC 2019.
Sat, Jun 8, 2:34 AM · GSoC 2019, Web app

Fri, Jun 7

shisus added a watcher for Web app: shisus.
Fri, Jun 7, 7:26 PM
anlambert closed T1786: Improve popovers display on small screens, a subtask of T1477: Improve swh-web design for mobile browsing , as Resolved.
Fri, Jun 7, 6:30 PM · GSoC 2019, Web app
anlambert closed T1786: Improve popovers display on small screens as Resolved.

Closed by d355d8973205

Fri, Jun 7, 6:30 PM · GSoC 2019, Web app
anlambert updated the task description for T1768: Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:13 PM · GSoC 2019, Web app
anlambert assigned T1768: Add end to end tests for the frontend part of swh-web to kalpitk.
Fri, Jun 7, 6:11 PM · GSoC 2019, Web app
anlambert merged task T1770: Add end to end tests into T1768: Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:11 PM · GSoC 2019, Web app
anlambert merged T1770: Add end to end tests into T1768: Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:11 PM · GSoC 2019, Web app
anlambert renamed T1768: Add end to end tests for the frontend part of swh-web from Add tests for the frontend part of swh-web to Add end to end tests for the frontend part of swh-web.
Fri, Jun 7, 6:10 PM · GSoC 2019, Web app
anlambert closed T1769: Add unit tests for Javascript code as Wontfix.

These tests will be redundant with the end to end ones, so closing that task and prefer to rely on using cypress for frontend testing.

Fri, Jun 7, 6:08 PM · Web app
anlambert closed T1769: Add unit tests for Javascript code, a subtask of T1768: Add end to end tests for the frontend part of swh-web, as Wontfix.
Fri, Jun 7, 6:08 PM · GSoC 2019, Web app
zack triaged T1791: Web API: do not leak internal, non-intrinsic origin identifiers as Low priority.
Fri, Jun 7, 3:38 PM · Web app
zack triaged T1789: batch API to check for the presence of content in the archive as Normal priority.
Fri, Jun 7, 10:44 AM · Web app

Thu, Jun 6

anlambert updated subscribers of T1768: Add end to end tests for the frontend part of swh-web.

@shisus , I have tested cypress and the tool is indeed quite awesome !

Thu, Jun 6, 7:40 PM · GSoC 2019, Web app
shisus added a comment to T1768: Add end to end tests for the frontend part of swh-web.

No problem, I want to contribute to this project, so I'm looking where I would be able to work with.
Do you plan to add cypress in the web repository or Is it still a POC?
Is there a chance to work with you in setting up the cypress environment?

Thu, Jun 6, 7:29 PM · GSoC 2019, Web app
anlambert updated the task description for T1787: Browsing revisions log ends up with errors when going back far in time.
Thu, Jun 6, 4:58 PM · Web app
anlambert closed T1787: Browsing revisions log ends up with errors when going back far in time as Resolved by committing rDWAPPS00bc23308c99: browse/revision_log: Optimize memcached entry size.
Thu, Jun 6, 4:02 PM · Web app
anlambert triaged T1787: Browsing revisions log ends up with errors when going back far in time as Normal priority.
Thu, Jun 6, 1:37 PM · Web app
rdicosmo added a comment to T1419: hg/svn support in save code now.
Thu, Jun 6, 9:34 AM · Web app, Sprint 2018 12

Wed, Jun 5

anlambert renamed T1770: Add end to end tests from Add end to end tests using Selenium to Add end to end tests .
Wed, Jun 5, 11:38 AM · GSoC 2019, Web app
anlambert updated the task description for T1786: Improve popovers display on small screens.
Wed, Jun 5, 11:31 AM · GSoC 2019, Web app
anlambert triaged T1786: Improve popovers display on small screens as Normal priority.
Wed, Jun 5, 11:30 AM · GSoC 2019, Web app

Tue, Jun 4

anlambert added a comment to T1768: Add end to end tests for the frontend part of swh-web.

Thanks for pointing out the cypress tool, it looks pretty interesting.
Based on my understanding, it could be used to write and run unit tests but also end to end ones.

Tue, Jun 4, 3:21 PM · GSoC 2019, Web app

Sat, Jun 1

shisus added a comment to T1768: Add end to end tests for the frontend part of swh-web.

Hello everyone, I've some questions:

Sat, Jun 1, 1:14 PM · GSoC 2019, Web app

Fri, May 31

kalpitk claimed T1770: Add end to end tests .

I think, we need to run the docker (with overridden swh-web) manually. And then run the selenium test cases. (I couldn't find a better approach)

Fri, May 31, 3:38 PM · GSoC 2019, Web app

Tue, May 28

anlambert added a comment to T1769: Add unit tests for Javascript code.

In order to implement the unit tests, we will need the following node modules:

Tue, May 28, 4:19 PM · Web app
anlambert closed T1746: Web API: whitelist DINSIC IP address as Resolved by committing rSPSITE946372ba41c9: data/defaults.yaml: Exempt DINSIC from swh-web api rate limiting.
Tue, May 28, 2:48 PM · Web app
anlambert triaged T1770: Add end to end tests as Normal priority.
Tue, May 28, 1:38 PM · GSoC 2019, Web app
anlambert triaged T1769: Add unit tests for Javascript code as Normal priority.
Tue, May 28, 1:31 PM · Web app
anlambert triaged T1768: Add end to end tests for the frontend part of swh-web as Normal priority.
Tue, May 28, 1:28 PM · GSoC 2019, Web app

Sat, May 25

zack closed T1329: Move rate limit processing to the Varnish layer ? as Wontfix.

We've discussed this back then, and decided in the end to leave it at the Django layer. Closing.

Sat, May 25, 5:27 PM · Web app
zack closed T1353: Allow adjusting API rate limits for some users as Resolved.

this is now done, at least based on IP addresses, we'll need (if it doesn't exist yet) a dedicated task for how to do it differently, e.g., using API keys

Sat, May 25, 4:48 PM · Web app

Fri, May 24

rdicosmo triaged T1751: Add explanatory tooltips on the pictos for the revision history as Normal priority.
Fri, May 24, 12:06 PM · Web app