Page MenuHomeSoftware Heritage

Store/represent time offsets as strings
Open, NormalPublic

Description

instead of int + negative_utc boolean

The plan:

  1. Add offset_bytes attribute to TimestampWithTimezone, fill it from offset and negative_utc if not provided
  2. Make offset and negative_utc optional (fill the attributes from offset_bytes)
  3. Raise DeprecationWarning when they are passed to the constructor (but from_dict should not raise it)
  4. Remove explicit uses in the constructor (track down deprecation warnings)
  5. Remove use of negative_utc (there is one in swh-web/swh/web/common/converters.py)
  6. Remove them from the constructor (but not from_dict, because kafka), remove offset and negative_utc entirely
  7. Rename offset_bytes to offset

Postgresql must be migrated somewhere between 1 and 6 (exclusive). Kafka does not need to be migratet as long as we keep the compat in from_dict methods.

Revisions and Commits

rDLDG Git loader
D6939
D6923
D6894
rDSEA Archive search
D6913
rDWAPPS Web applications
Closed
D6927
rDDEP Push deposit
D7006
D6929
rDLDBASE Generic VCS/Package Loader
D7007
D6938
D6935
D6910
rDCIDX Metadata indexer
Abandoned
rDMFCD ClearlyDefined metadata fetcher
rDSTO Storage manager
Closed
D7008
D6937
rDMOD Data model
D7005
D6936
D6936
D6890
D6776
rDDOC Development documentation
Changes Planned
rDCNT Archive counters
D6908
rDLDSVN Subversion (SVN) loader
Closed
D6940

Related Objects

Event Timeline

vlorentz triaged this task as Normal priority.Nov 26 2021, 4:42 PM
vlorentz created this task.