Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3752: Store/represent time offsets as strings

Commits

rDMODa654060bf246: Add method 'TimestampWithTimezone.offset_minutes'

Summary

A future commit will remove the 'offset' attribute, and rename
'offset_bytes' to 'offset'.

Modules using the .offset attribute will need to switch to this new
method to keep working.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 21 2022, 12:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 21 2022, 12:53 PM

Build is green

Patch application report for D7005 (id=25401)

Rebasing onto f43f9ac98c...

Current branch diff-target is up to date.

Changes applied before test

commit a654060bf246aa8dc2a40cceaf86ea449f55068c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jan 21 12:47:58 2022 +0100

    Add method 'TimestampWithTimezone.offset_minutes'
    
    A future commit will remove the 'offset' attribute, and rename
    'offset_bytes' to 'offset'.
    
    Modules using the `.offset` attribute will need to switch to this new
    method to keep working.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/453/ for more details.

Harbormaster completed remote builds in B26244: Diff 25401.Jan 21 2022, 12:55 PM

vlorentz requested review of this revision.Jan 21 2022, 12:55 PM

vlorentz added a child revision: D7007: Stop using the deprecated 'TimestampWithTimezone.offset' attribute.Jan 21 2022, 12:57 PM

vlorentz added a child revision: D7006: Stop using the deprecated 'TimestampWithTimezone.offset' attribute.Jan 21 2022, 12:58 PM

vlorentz added a parent revision: D6937: Remove 'offset' and 'negative_utc'.

vlorentz added a child revision: D7008: Stop using the deprecated 'TimestampWithTimezone.offset' attribute.Jan 21 2022, 1:02 PM

vlorentz added a task: T3752: Store/represent time offsets as strings.Jan 21 2022, 1:29 PM