Page MenuHomeSoftware Heritage

douardda (David Douard)
User

User Details

User Since
Jul 10 2018, 12:38 PM (230 w, 3 d)

Recent Activity

Yesterday

douardda updated the diff for D8939: Rework the replaying exception handling.

Bump copyright dates

Fri, Dec 9, 3:03 PM
douardda added a comment to D8939: Rework the replaying exception handling.

Could you use a logger instance,

what do you mean by "use a logger instance"?

and add if logger.isEnabledFor(logging.DEBUG): before logger.debug statements that use hash_to_hex?

sure

Actually, why would this be needed? I mean I don't expect has_to_hex() to be a fat cpu burner, do I?

Fri, Dec 9, 2:58 PM
douardda added a comment to D8939: Rework the replaying exception handling.

Could you use a logger instance,

what do you mean by "use a logger instance"?

and add if logger.isEnabledFor(logging.DEBUG): before logger.debug statements that use hash_to_hex?

sure

Fri, Dec 9, 2:52 PM
douardda added a comment to D8939: Rework the replaying exception handling.

Could you use a logger instance,

Fri, Dec 9, 2:48 PM

Thu, Dec 8

douardda accepted D8935: Add dataset name to the export id.
Thu, Dec 8, 11:26 AM
douardda added inline comments to D8940: cli.add_forge_now: Open `register-lister` with sensible defaults.
Thu, Dec 8, 11:22 AM

Wed, Dec 7

douardda updated the summary of D8939: Rework the replaying exception handling.
Wed, Dec 7, 4:51 PM
douardda updated the summary of D8939: Rework the replaying exception handling.
Wed, Dec 7, 4:51 PM
douardda accepted D8877: Fix incorrect error messages when failing to connect.

(no test? worth it?)

Wed, Dec 7, 4:43 PM
douardda requested review of D8939: Rework the replaying exception handling.
Wed, Dec 7, 4:33 PM

Mon, Nov 28

douardda triaged T4704: Publish objects that has been subject to a TDN in a (series of) kafka topic as High priority.
Mon, Nov 28, 10:57 AM · Roadmap 2022, meta-task, Roadmap 2021, Web app
douardda added a comment to T4657: Allow object removal from journal.
In T4657#98361, @lunar wrote:

[...]
@douardda: would you agree?

Mon, Nov 28, 10:52 AM · Journal

Wed, Nov 23

douardda committed rDPROV869f9f168255: kafka: improve the message schema for the journal writer (authored by douardda).
kafka: improve the message schema for the journal writer
Wed, Nov 23, 11:52 AM
douardda committed rDPROV6730f2fdbda6: Fix typo (orign -> origin) (authored by douardda).
Fix typo (orign -> origin)
Wed, Nov 23, 11:52 AM

Tue, Nov 22

douardda created P1530 (An Untitled Masterwork).
Tue, Nov 22, 11:35 AM

Nov 2 2022

douardda accepted D8634: Prepare the tests to run in Jenkins.
Nov 2 2022, 5:37 PM
douardda committed rDPROVe4795882d3aa: sql: only insert entities that we really need to insert in relation_add (authored by douardda).
sql: only insert entities that we really need to insert in relation_add
Nov 2 2022, 4:56 PM
douardda committed rDPROVc89763f01c8d: tests: set journal writer auto_flush to False (authored by douardda).
tests: set journal writer auto_flush to False
Nov 2 2022, 4:56 PM
douardda closed D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.
Nov 2 2022, 4:56 PM
douardda committed rDPROV90a4250a2c57: tests: simplify and (possibly) fix the grpc_server helper context manager (authored by douardda).
tests: simplify and (possibly) fix the grpc_server helper context manager
Nov 2 2022, 4:56 PM
douardda updated the diff for D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.

also add rabbitmq marker in pytest.ini

Nov 2 2022, 4:55 PM

Oct 21 2022

douardda closed D8740: tests: only flush() the kafka journal writer once per test.
Oct 21 2022, 5:48 PM
douardda committed rDSTO0e8da810ac96: tests: only flush() the kafka journal writer once per test (authored by douardda).
tests: only flush() the kafka journal writer once per test
Oct 21 2022, 5:48 PM
douardda added a comment to D8740: tests: only flush() the kafka journal writer once per test.

On the outstanding sample of one execution on jenkins: 11min 44s vs 13min 39s (previous execution, before this diff)

Oct 21 2022, 5:43 PM
douardda requested review of D8740: tests: only flush() the kafka journal writer once per test.
Oct 21 2022, 5:38 PM
douardda committed rDSTOfe0eaee8718b: Make the replayer not crash on kafka messages that fail to be converted as… (authored by douardda).
Make the replayer not crash on kafka messages that fail to be converted as…
Oct 21 2022, 4:59 PM
douardda closed D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.
Oct 21 2022, 4:59 PM
douardda committed rDSTO242e37a7be35: Add a comment that should have been "kept" from 850a7553b (authored by douardda).
Add a comment that should have been "kept" from 850a7553b
Oct 21 2022, 4:59 PM
douardda updated the diff for D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.

rebase

Oct 21 2022, 4:43 PM
douardda closed D8705: writer: make calling flush() in write_addition(s)() optional.
Oct 21 2022, 4:31 PM
douardda committed rDJNL7c83ee11ecab: writer: make calling flush() in write_addition(s)() optional (authored by douardda).
writer: make calling flush() in write_addition(s)() optional
Oct 21 2022, 4:31 PM
douardda closed D8697: tests: make the kafka_server_base fixture a function scoped one.
Oct 21 2022, 4:31 PM
douardda committed rDJNL04a84dba6a17: tests: make the kafka_server_base fixture a function scoped one (authored by douardda).
tests: make the kafka_server_base fixture a function scoped one
Oct 21 2022, 4:31 PM
douardda updated the diff for D8705: writer: make calling flush() in write_addition(s)() optional.

typos

Oct 21 2022, 4:26 PM
douardda updated the diff for D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.

fix typos as reported by anlambert

Oct 21 2022, 4:22 PM
douardda updated the diff for D8705: writer: make calling flush() in write_addition(s)() optional.

Add the missing docstring entry

Oct 21 2022, 4:19 PM
douardda added a comment to D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.

Looks good to me , just noticed some remaining typos: one in code and another in commit message (s/sctructure/structure).

Oct 21 2022, 4:10 PM
douardda requested review of D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.
Oct 21 2022, 2:39 PM

Oct 20 2022

douardda added a comment to D8697: tests: make the kafka_server_base fixture a function scoped one.

I don't see the difference comparing the master build or the diff build times but wny not ;)

Oct 20 2022, 3:18 PM
douardda added a comment to D8747: conda: Yield listed origins after all artifacts in a page are processed.

shouldn't this fix come with a test of some sort?

Oct 20 2022, 3:18 PM
douardda added a comment to D8748: Nuget: Implement incremental listing.

it's unclear to me whether this actually implements the iteration protocol described in the API doc (https://learn.microsoft.com/en-us/nuget/api/catalog-resource#iterating-over-catalog-items) or not.

Oct 20 2022, 3:18 PM
douardda added a comment to D8747: conda: Yield listed origins after all artifacts in a page are processed.

I believe the commit title lacks a verb, doesn't it? ("conda: Yield listed origins after all artifacts in a page are processed" or something similar?)

Oct 20 2022, 3:18 PM
douardda added a comment to D8748: Nuget: Implement incremental listing.

it's unclear to me whether this actually implements the iteration protocol described in the API doc (https://learn.microsoft.com/en-us/nuget/api/catalog-resource#iterating-over-catalog-items) or not.

Oct 20 2022, 3:18 PM

Oct 19 2022

douardda requested changes to D8634: Prepare the tests to run in Jenkins.

with the same idea as the inline comment, it would be better to rename the network like 'swh-mirror' rather than 'swhtest-mirror'.

Oct 19 2022, 11:00 AM
douardda closed D8737: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 19 2022, 10:48 AM
douardda committed rDWAPPS176799962e82: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 19 2022, 10:48 AM
douardda committed rDPROV4ed652e03d12: Move all non pytest-related functions from conftest to utils.py (authored by douardda).
Move all non pytest-related functions from conftest to utils.py
Oct 19 2022, 10:33 AM
douardda closed D8695: Move all non pytest-related functions from conftest to utils.py.
Oct 19 2022, 10:33 AM
douardda committed rDPROVb686e9a516e0: tests: small fixes in test_journal_client.py (authored by douardda).
tests: small fixes in test_journal_client.py
Oct 19 2022, 10:33 AM

Oct 18 2022

douardda requested review of D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.
Oct 18 2022, 8:33 PM
douardda requested review of D8737: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 8:32 PM
douardda closed D8345: remove now unneeded mypy missing entries.

closed by da5c23bdbdd06e919e9b45576c378623990b8b57

Oct 18 2022, 8:20 PM
douardda requested review of D8705: writer: make calling flush() in write_addition(s)() optional.
Oct 18 2022, 8:19 PM
douardda updated the diff for D8695: Move all non pytest-related functions from conftest to utils.py.

rebase (+ a small fix)

Oct 18 2022, 8:18 PM
douardda requested review of D8697: tests: make the kafka_server_base fixture a function scoped one.
Oct 18 2022, 8:18 PM
douardda closed D8741: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 8:17 PM
douardda committed rDPROV60c5a5c463ec: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 8:17 PM
douardda closed D8718: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 8:01 PM
douardda committed rDJNL2c6d9e05eca6: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 8:00 PM
douardda closed D8736: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:59 PM
douardda committed rDVAUb033a2e19ede: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:59 PM
douardda closed D8735: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:59 PM
douardda committed rDSTOc1c2dbf01bce: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:59 PM
douardda closed D8734: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:59 PM
douardda committed rDSEA2912b17c611b: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:58 PM
douardda committed rDSCHaeb870a7009a: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:58 PM
douardda closed D8732: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:58 PM
douardda committed rDSCRUBafacc488cd3d: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:58 PM
douardda updated the diff for D8732: pre-commit, tox: Bump pre-commit, codespell, black and flake8.

rebase

Oct 18 2022, 7:58 PM
douardda closed D8731: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:56 PM
douardda committed rDTSCN8c6974fa8069: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:56 PM
douardda closed D8730: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:56 PM
douardda committed rDTPLd6d658a078f1: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:56 PM
douardda closed D8729: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:55 PM
douardda committed rDOPH8142df4b7b49: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:55 PM
douardda closed D8728: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:55 PM
douardda committed rDOBJSRPL5461a1f7c2b9: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:55 PM
douardda closed D8727: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:55 PM
douardda committed rDOBJSc97160b5b1bc: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:55 PM
douardda closed D8726: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:54 PM
douardda committed rDMODfe8d55588a9b: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:54 PM
douardda closed D8725: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:54 PM
douardda committed rDLDSVN8e38d524c0a6: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:54 PM
douardda committed rDLDMD3246b8d6b955: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:54 PM
douardda closed D8724: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:54 PM
douardda committed rDLDHG856dbe83f04f: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:54 PM
douardda closed D8723: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:53 PM
douardda committed rDLDGfc0c81305fbb: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:53 PM
douardda closed D8722: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:53 PM
douardda committed rDLDCVSadb3199b1d00: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:53 PM
douardda closed D8721: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:53 PM
douardda committed rDLDBASE6d8e2abac501: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:53 PM
douardda closed D8720: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:52 PM
douardda committed rDLDBZR7b0f9a9766ba: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:52 PM
douardda closed D8719: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:52 PM
douardda committed rDLS8778b9cdbfe1: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:52 PM
douardda closed D8717: pre-commit, tox: Bump pre-commit, codespell, black and flake8.
Oct 18 2022, 7:52 PM
douardda committed rDCIDXe6895ba5cf80: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:51 PM
douardda committed rDICP43b1843e1809: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
Oct 18 2022, 7:51 PM
douardda committed rDICP6378298b228c: python: Reformat code with black 22.10.0 (authored by douardda).
python: Reformat code with black 22.10.0
Oct 18 2022, 7:51 PM