♟ douardda

no need to keep the cli plugins in a dict

Add requests to requirements.txt since it does come with swh.core any more

kill the PostresHandler instead of "shuffling it around" (© olasd)

In D1427#31359, @olasd wrote:

The PostgresHandler has been dead code for two years, I think we can just remove it rather than shuffling it around.

Reorder a few import statements

This also requires we can install only a very light base version of swh.core (typically without db or aiohttp/flask dependencies).

A possible way of doing such a thing is to have an almost empty swh.cli package that declares the main entry point: the swh command group (using click) which defines a few very command command line options (like --log-level), and a mecanism to load installed SWH cli plugins via setuptools' pkg_resources

This generic swh cli should be done so that is minimal dependency installed especially for "pure client" commands (e.g. swh.deposit's deposit or swh.model's identify tools).

It is these graphs we are still missing.

Indeed it is the object of T1428. That's why I am a bit puzzled the work you have in progress does not simply target T1356. I was expecting some response to this very task in your grafanalib based code, which I did not find. So I was wondering if I missed something, that some data where still in munin only.

In T1442#30575, @ftigeot wrote:

When I asked where to put such work-in-progress, you suggested the snippets repository.

In T1442#30564, @ftigeot wrote:

Work-in-progress Grafanalib dashboards have been added to the https://forge.softwareheritage.org/source/snippets/ repository.

As discussed, this task should be actually the first step of a more generic software-heritage cli client module (using HTTP based AIPs/RPCs).

LGTM but I'm not very familiar with this code.

could you explain in the commit message why this solves a cnx leak?

few minor fixes to be make, then should be ok.

lgtm (but I'm obviously biased)

cli: fix logging setup

config: do not overwrite the DJANGO_SETTINGS_MODULE if already defined

cli/admin/user: add a user existence check

cli: kill the unneeded dry-run option

client: use a global logger

cli: split the cli.py module in a package with submodules

cli/admin/user: provide more information at creation

cli: fix service document parsing to retrieve collection

model: kill DepositRequestType

setup: extract server specific requirements in a dedicated 'server' extra

API: simplify a bit the RemoteStorage class

API: refactor the /directory/ls endpoint

tasks: fix handling of unsupported promise.save() calls

In D1404#30533, @vlorentz wrote:

That code (and the lines before) look very similar to each other.

ok but see my comment plz

lister: allways run the db initialization step

replica: ensure entrypoints are defined in replica related services

dockerfile: install python packages in a venv under the swh user

entrypoint: pgsql has been moved to ~swh/

Remove entrypoint.sh files from the Dockerfile

Dockerfile: small readability refactoring

Factorise the pip install of source repos in a shell function

Add support for a kafka-powered replica of the graph.

lister: Use explicit postgresql URLs as a workaround for a sqlalchemy issue

swh-web: enforce the database file to be created in either $HOME or /tmp

bump dependencies to swh.storage>=0.0.138 and swh.model>=0.0.34

compose: fix inconsistent dependency

I'm not very fond adding this kind of service in the main docker-compose file.
I would prefer a dedicated docker-compose file to be used as an override, eg:

templates: increase unit tests timeout to 10mn

douardda (David Douard)
User

Projects

User Details

Recent Activity
View All

Fri, Apr 19

Thu, Apr 18

Tue, Apr 16

Mon, Apr 15

Fri, Apr 12

Thu, Apr 11

Wed, Apr 10

Fri, Apr 5

Tue, Apr 2

douardda (David Douard)User