- User Since
- Jul 10 2018, 12:38 PM (104 w, 3 d)
Forgot one occurrence
Reading the code dealing with snapshot branches in several storage implementations, it really seems to me that storing them as a dict-like structure has no advantage.
But I'd like to use the opportunity of this cleanup to go a bit further than "the minimal amount of work for pedantic correctness", and actually make changes that have a conceptual meaning.
Thu, Jul 9
make sure there is no doubt on who the dumb fellow is
simplify the diff by killing map_optional()
Not sure I buy the map_optional here. When I read a line of code with [x if x else f(x)] I understand it right away. With map_optional, I need to go get the definition of that oneliner function.
Plus you have the type annotation headache...
Wed, Jul 8
looks fine, as far as I can tell
typo (thx ardumont)
small simplification as suggested by anlambert
fix MANIFEST.in to include the git bundle file
Thx, looks good. Just a small question about the modification of the swhid() API.
Tue, Jul 7
object 9768d0b576dbaaecd80abedad6dfd0d72f1476da type commit tag v0.0.1 tagger David Douard <firstname.lastname@example.org> 1594138133 +0200
git cat-file -p 9768d0b576dbaaecd80abedad6dfd0d72f1476da
author Stefano Zacchiroli <email@example.com> 1443083765 +0200
committer Stefano Zacchiroli <firstname.lastname@example.org> 1443083765 +0200
fix sql schema and simplify the migration script
typos/fixes in 158.sql
add a test for "true" bw compat, aka old data in pg still works
As said on IRC, I'd rather see this diff depends on D3417, but otherwise I'm fine with it.
knowing this is still WIP, I have a few comments/questions:
Mon, Jul 6
use frozen<list<list<blob>>> in cassandra's schema for extra_headers
bump deps for swh-journal and swh-core
bump dep swh-model>= 0.4.0
split the 2 test functions in parts, and fix the bwcompat hook
Fri, Jul 3
not sure about the db space as an argument, but the CPU is by itself worth the move IMHO.
Any reason not to use type_validator() in these new schema entities?
LGTM but I'd prefer the commit message be self-contained, i.e. explicitly explain the unttest->pytest conversion rather then delegating this to a task in the forge.
Thx a lot, LGTM (can't say I've reviewed the tests very carefully though.)
Thu, Jul 2
Looks globally fine to me, but I have a few comments/requests.
Wed, Jul 1
more mypy vs. attrs-strict fighting
make mypy happy (hopefully)
restrict extra_headers to (bytes, bytes) only
improve bw-compat support, tests and hypothesis strategies
This origin also fails to be mirrored with:
Tue, Jun 30
Rereading this task, I have a few comments/questions.