Page MenuHomeSoftware Heritage

douardda (David Douard)
User

User Details

User Since
Jul 10 2018, 12:38 PM (49 w, 2 d)

Recent Activity

Today

douardda updated subscribers of T1826: bitbucket lister does not work.
Thu, Jun 20, 11:02 AM · Bitbucket lister, Lister

Yesterday

douardda committed rDJNL693b8f407fb4: cli: add a --concurrency cli option to content-replay (authored by douardda).
cli: add a --concurrency cli option to content-replay
Wed, Jun 19, 2:40 PM
douardda committed rDJNL022baee25827: replay: parallelize the copy of objects from a polled set (authored by douardda).
replay: parallelize the copy of objects from a polled set
Wed, Jun 19, 2:40 PM
douardda committed rDJNL253d150b5d0b: client: allow to specify any cfg parameter to KafkaConsumer() (authored by douardda).
client: allow to specify any cfg parameter to KafkaConsumer()
Wed, Jun 19, 2:40 PM
douardda closed D1608: client: allow to specify any cfg parameter to KafkaConsumer().
Wed, Jun 19, 2:40 PM
douardda created P441 comments in pyarc diff.
Wed, Jun 19, 2:38 PM
douardda committed rTPYARCd25ba395c37b: Add support for listing comments with diffs (authored by douardda).
Add support for listing comments with diffs
Wed, Jun 19, 2:36 PM
douardda committed rTPYARCc55da2739f90: diff: refactor the diff command and improve a bit the rendering (authored by douardda).
diff: refactor the diff command and improve a bit the rendering
Wed, Jun 19, 2:36 PM
douardda updated the diff for D1608: client: allow to specify any cfg parameter to KafkaConsumer().

Improve a bit JournalClient's docstring

Wed, Jun 19, 2:32 PM
Herald added a reviewer for D1608: client: allow to specify any cfg parameter to KafkaConsumer(): Reviewers.
Wed, Jun 19, 10:40 AM

Tue, Jun 18

douardda accepted D1563: Refactor the journal client using the new style functions..

"bon d'accord !"

Tue, Jun 18, 11:50 AM

Fri, Jun 14

douardda committed rDOBJS2b2ac1fc38c8: pathslicing: fix PathSlicingObjStorage.check() method (authored by douardda).
pathslicing: fix PathSlicingObjStorage.check() method
Fri, Jun 14, 5:32 PM
douardda committed rDOBJS869fe75ea5eb: tests/pathslicing: add a test for check() that ensure it does work (authored by douardda).
tests/pathslicing: add a test for check() that ensure it does work
Fri, Jun 14, 5:32 PM
douardda committed rDOBJSc8e349bf4a94: pathslicing: fix the 'not a gzip' error message in check() (authored by douardda).
pathslicing: fix the 'not a gzip' error message in check()
Fri, Jun 14, 5:32 PM
douardda committed rDOBJS605a0b5dfd9c: tests/pathslicing: improve tests for the check() method (authored by douardda).
tests/pathslicing: improve tests for the check() method
Fri, Jun 14, 5:32 PM
douardda closed D1587: pathslicing: fix PathSlicingObjStorage.check() method.
Fri, Jun 14, 5:32 PM
douardda updated the diff for D1587: pathslicing: fix PathSlicingObjStorage.check() method.

apply vlorentz' suggestions

Fri, Jun 14, 4:13 PM
douardda added inline comments to D1587: pathslicing: fix PathSlicingObjStorage.check() method.
Fri, Jun 14, 4:10 PM
Herald added a reviewer for D1587: pathslicing: fix PathSlicingObjStorage.check() method: Reviewers.
Fri, Jun 14, 3:39 PM
douardda accepted D1581: Add a new origin_visit_get_latest endpoint..
Fri, Jun 14, 1:27 PM
douardda accepted D1585: Ignore Hypothesis timeout error for test_add_arbitrary..
Fri, Jun 14, 1:25 PM
douardda accepted D1580: Actually run the remote-pg-storage tests on a remote-pg..

LGTM.
Now. what you do not understand "I don't understand why..." Is it "why the code does not behaves how it was intended to?" or "why the code was written so it actually uses a local storage?"

Fri, Jun 14, 10:47 AM
douardda requested changes to D1581: Add a new origin_visit_get_latest endpoint..

LGTM but please fix the abstract class's docstring as stated in the comment above.

Fri, Jun 14, 10:41 AM

Thu, Jun 13

douardda accepted D1579: lister.core: Remove origin creation from lister behavior.
Thu, Jun 13, 3:39 PM
douardda requested changes to D1579: lister.core: Remove origin creation from lister behavior.
Thu, Jun 13, 2:41 PM
douardda accepted D1573: Use origin URLs instead of numeric ids in the Git loader..
Thu, Jun 13, 2:33 PM
douardda added inline comments to D1547: Add test for content_get_range..
Thu, Jun 13, 2:30 PM
douardda requested changes to D1564: Manipulate origin URLs instead of origin ids..
Thu, Jun 13, 2:26 PM
douardda requested changes to D1563: Refactor the journal client using the new style functions..
Thu, Jun 13, 2:20 PM
douardda added inline comments to D1547: Add test for content_get_range..
Thu, Jun 13, 2:14 PM
douardda accepted D1544: Add tests for content_missing..
Thu, Jun 13, 2:06 PM
douardda committed rDCORE9d6aed3056ba: cli/db: do not attempt to create the DB by default (authored by douardda).
cli/db: do not attempt to create the DB by default
Thu, Jun 13, 2:03 PM
douardda closed D1576: cli/db: do not attempt to create the DB by default.
Thu, Jun 13, 2:03 PM
douardda accepted D1538: Add test for date parsing of origin_visit_add..
Thu, Jun 13, 2:02 PM
douardda accepted D1552: Test date parsing of origin_metadata_add..
Thu, Jun 13, 2:01 PM
douardda updated the diff for D1576: cli/db: do not attempt to create the DB by default.

update the docstring

Thu, Jun 13, 9:46 AM
Herald added a reviewer for D1576: cli/db: do not attempt to create the DB by default: Reviewers.
Thu, Jun 13, 9:45 AM
douardda committed rDSCH237e8c564406: cli: rename a admin cli commands (authored by douardda).
cli: rename a admin cli commands
Thu, Jun 13, 9:29 AM
douardda closed D1502: cli: rename a admin cli commands.
Thu, Jun 13, 9:29 AM
douardda updated the diff for D1502: cli: rename a admin cli commands.

rebased

Thu, Jun 13, 9:29 AM

Wed, Jun 12

douardda committed rDJNL71ed469d5769: Bump dependency on swh.storage to v0.0.141 (authored by douardda).
Bump dependency on swh.storage to v0.0.141
Wed, Jun 12, 1:49 PM
douardda committed rDJNL88c544ea8aba: cli: do only listen to required kafka topic in content-replay command (authored by douardda).
cli: do only listen to required kafka topic in content-replay command
Wed, Jun 12, 1:48 PM
douardda committed rDJNLf86f3baf0903: cli: fix handling of get_journal_client's 'brokers' argument (authored by douardda).
cli: fix handling of get_journal_client's 'brokers' argument
Wed, Jun 12, 1:48 PM
douardda committed rDJNL433b85b4bc62: replay: do not crash if process_replay_objects_content() fails on one object (authored by douardda).
replay: do not crash if process_replay_objects_content() fails on one object
Wed, Jun 12, 1:48 PM
douardda committed rDJNL7ed426b34a20: JournalClient: change the prefix init argument dafault value to None (authored by douardda).
JournalClient: change the prefix init argument dafault value to None
Wed, Jun 12, 1:48 PM
douardda closed D1571: cli: fix brokers argument handling (+ a pile of small refactorings).
Wed, Jun 12, 1:48 PM
douardda requested changes to D1552: Test date parsing of origin_metadata_add..

I'm not very fond of testing several things at once. This does not "Test date parsing of origin_metadata_add" as such, it adds this testing as a side effect, in the middle of an unrelated test. Which is not a good idea. I mean, the test is named 'test_origin_metadata_get' and it does already too many things. Having the test named 'test_origin_metadata_get' fail because of bug in parsing dates in origin_metadata_add does not help the poor guy fixing these...

Wed, Jun 12, 12:32 PM
douardda accepted D1551: Test that content_find filters out contents that don't match..
Wed, Jun 12, 12:27 PM
douardda accepted D1549: Fix key names in the in-mem impl of metadata_provider_{get,add}.
Wed, Jun 12, 12:26 PM
douardda accepted D1548: Add a test checking that directory_ls does not recurse into subdirs by default..

It's not that straightforward that this test does indeed do what the commit message pretends... A comment or 2 in the code of the test would not hurt. But meh

Wed, Jun 12, 12:24 PM
douardda added inline comments to D1547: Add test for content_get_range..
Wed, Jun 12, 12:21 PM
douardda accepted D1546: Add test for content_add when one of the content is already known..
Wed, Jun 12, 12:19 PM
douardda accepted D1543: Add test for snapshot_get_branches with both filter and pagination..
Wed, Jun 12, 12:18 PM
douardda accepted D1542: Add test for ctime in content_add..
Wed, Jun 12, 12:17 PM
douardda accepted D1539: Add origin_visit counter to the in-mem storage + Add test for snapshot/release counters..

Ok, but I would have loved to see a word or 2 explaining why this revision is needed in the commit message.

Wed, Jun 12, 12:16 PM
douardda requested changes to D1538: Add test for date parsing of origin_visit_add..
Wed, Jun 12, 11:54 AM
douardda accepted D1572: Deploy new listers in production.
Wed, Jun 12, 11:43 AM · Lister
douardda updated the diff for D1571: cli: fix brokers argument handling (+ a pile of small refactorings).

log an exception if process_replay_objects_content() fails

Wed, Jun 12, 11:42 AM
Herald added a reviewer for D1571: cli: fix brokers argument handling (+ a pile of small refactorings): Reviewers.
Wed, Jun 12, 10:56 AM

Tue, Jun 11

douardda accepted D1562: Add option object_types to get_journal_client..
Tue, Jun 11, 4:31 PM
douardda committed rDSTOd8f0a7b0e5ef: storage: small typo in Storage.content_add_metadata's doc string (authored by douardda).
storage: small typo in Storage.content_add_metadata's doc string
Tue, Jun 11, 10:12 AM
douardda committed rDMOD0815880accd0: setup: register the 'identify' cli subcommand (authored by douardda).
setup: register the 'identify' cli subcommand
Tue, Jun 11, 10:09 AM
douardda committed rDMODd7ec4a61647a: cli: add support for --help on the 'identify' cli tool (authored by douardda).
cli: add support for --help on the 'identify' cli tool
Tue, Jun 11, 10:09 AM
douardda committed rDMOD60c3f7d4fb3d: cli: the 'objects' argument is in fact mandatory (authored by douardda).
cli: the 'objects' argument is in fact mandatory
Tue, Jun 11, 10:09 AM
douardda closed D1473: setup: register the 'identify' cli subcommand.
Tue, Jun 11, 10:09 AM
douardda updated the diff for D1473: setup: register the 'identify' cli subcommand.

rebase

Tue, Jun 11, 10:08 AM

Fri, Jun 7

douardda committed rDJNL2cb86247f815: replay: make unexpectedly received object_type log a warning (authored by douardda).
replay: make unexpectedly received object_type log a warning
Fri, Jun 7, 4:07 PM
douardda committed rDJNL46db4e82a19b: cli: extract the JournalClient instanciation in a dedicated function (authored by douardda).
cli: extract the JournalClient instanciation in a dedicated function
Fri, Jun 7, 4:07 PM
douardda committed rDJNL1e2aa47c931a: Add a content replayer service (authored by douardda).
Add a content replayer service
Fri, Jun 7, 4:07 PM
douardda closed D1541: add a content replayer service.
Fri, Jun 7, 4:07 PM
douardda committed rDJNLbf0cf9d62dc7: backfill: use consistent 'prefix' config key instead of 'final_prefix' (authored by douardda).
backfill: use consistent 'prefix' config key instead of 'final_prefix'
Fri, Jun 7, 4:06 PM
douardda committed rDJNLd2b34040863b: cli: improve the CLI (authored by douardda).
cli: improve the CLI
Fri, Jun 7, 4:06 PM
douardda committed rDJNL74998fe39ae6: Ensure a default value for JournalClient's prefix parameter (authored by douardda).
Ensure a default value for JournalClient's prefix parameter
Fri, Jun 7, 4:06 PM
douardda committed rDJNLfc174641b95c: client: simplify a bit the JournalClient class (authored by douardda).
client: simplify a bit the JournalClient class
Fri, Jun 7, 4:06 PM
douardda committed rDJNLfc0738eb58d4: tests: refactor replayer tests (authored by douardda).
tests: refactor replayer tests
Fri, Jun 7, 4:06 PM
douardda committed rDJNLcf58471dac46: cli: register the 'journal' cli subcommand (authored by douardda).
cli: register the 'journal' cli subcommand
Fri, Jun 7, 4:06 PM
douardda closed D1540: cli: register the 'journal' cli subcommand and improve it.
Fri, Jun 7, 4:06 PM
douardda updated the diff for D1541: add a content replayer service.

fix the fix

Fri, Jun 7, 4:05 PM
douardda updated the diff for D1541: add a content replayer service.

small fix

Fri, Jun 7, 4:01 PM
douardda updated the diff for D1541: add a content replayer service.
  • Add a content replayer service
  • cli: extract the JournalClient instanciation in a dedicated function
  • replay: make unexpectedly received object_type log a warning
Fri, Jun 7, 2:31 PM
douardda updated the diff for D1540: cli: register the 'journal' cli subcommand and improve it.

ok ok, I did split the kafka mock class in 2

Fri, Jun 7, 2:31 PM
douardda updated the diff for D1541: add a content replayer service.

add a TODO in test_cli about content-replay

Fri, Jun 7, 2:02 PM
douardda updated the diff for D1541: add a content replayer service.

replay: log warnings in case of unexpected object types

Fri, Jun 7, 1:59 PM
douardda added a comment to D1541: add a content replayer service.

Also, your new CLI needs tests :)

Fri, Jun 7, 1:39 PM
douardda updated the diff for D1540: cli: register the 'journal' cli subcommand and improve it.

fix an error (brokers can be a tuple) making test_cli fails

Fri, Jun 7, 1:32 PM

Thu, Jun 6

douardda accepted D1492: CRAN Lister.

The diffs looks fine, but I'd like to have confirmation the code works properly in real conditions (in a docker session) before we merge this.

Thu, Jun 6, 2:51 PM
douardda added inline comments to D1541: add a content replayer service.
Thu, Jun 6, 10:49 AM
douardda updated the diff for D1541: add a content replayer service.

fix commit msg

Thu, Jun 6, 10:15 AM
douardda updated the diff for D1541: add a content replayer service.

should address vlortenz's comments

Thu, Jun 6, 10:13 AM
douardda updated the diff for D1540: cli: register the 'journal' cli subcommand and improve it.

Several refactorings and git history cleanups

Thu, Jun 6, 10:12 AM

Wed, Jun 5

douardda added inline comments to D1540: cli: register the 'journal' cli subcommand and improve it.
Wed, Jun 5, 4:26 PM
douardda abandoned D1472: cli: register the 'journal' cli subcommand.

this is now part of D1540

Wed, Jun 5, 4:22 PM
douardda added inline comments to D1541: add a content replayer service.
Wed, Jun 5, 2:59 PM
douardda updated the diff for D1502: cli: rename a admin cli commands.

rebase + fix typo

Wed, Jun 5, 2:43 PM
douardda added inline comments to D1541: add a content replayer service.
Wed, Jun 5, 2:38 PM
douardda accepted D1537: Make origin_visit_upsert parse date strings..
Wed, Jun 5, 2:30 PM
douardda accepted D1545: Add test for content_get on missing content..
Wed, Jun 5, 2:29 PM
douardda added inline comments to D1537: Make origin_visit_upsert parse date strings..
Wed, Jun 5, 2:16 PM
douardda requested changes to D1537: Make origin_visit_upsert parse date strings..
Wed, Jun 5, 1:48 PM
douardda accepted D1536: Prevent Hypothesis from writing the null character in the 'reason' field..
Wed, Jun 5, 1:41 PM