♟ douardda

In D4909#123805, @vlorentz wrote:

Yes, but that's not inconsistent as we can discover origins that we didn't know about.

I'm really not sure to understand what the simulated model looks like in the end. Do I get it right that, including this diff:

thanks. I think however, given its purpose, this example code should be heavily commented: each constant (eg. MyPageType) and each method should be commented (not docstrings but comments exaplaining what the method/variable is used for).

Not very fond of this "one week => dead" embedded in there, but meh.

ok, but it would have been nice to have an explanation of why this is necessary in the commit message.

In D4920#123571, @vlorentz wrote:

In D4920#123533, @douardda wrote:

why not (cli option), but why (keep it deterministic)?

reproducibility, so we can run the simulator twice with different code, and be sure that differences in behavior are not caused by randomness

Add a --num-origins option to the fill-test-data cli command

Simulation: log at info level recorded metrics

In D4920#123548, @douardda wrote:

In D4920#123533, @douardda wrote:

In D4920#123465, @vlorentz wrote:

I'd like to keep the simulator deterministic. What about adding a CLI option with a seed?

why not (cli option), but why (keep it deterministic)?

Also, a given seed will not be enough here: there is also the maxts = int(utcnow().timestamp()) that will kill the deterministic property...

In D4920#123533, @douardda wrote:

In D4920#123465, @vlorentz wrote:

I'd like to keep the simulator deterministic. What about adding a CLI option with a seed?

why not (cli option), but why (keep it deterministic)?

In D4920#123465, @vlorentz wrote:

I'd like to keep the simulator deterministic. What about adding a CLI option with a seed?

kill unnedded dependency on D4920

type + vorentz' comment

Simplify journal client tests

Revert "Make sure swh.scheduler.cli.journal is loaded in test_cli_journal.py"

Make the max_date() helper function accept *dates as argument

In D4891#122658, @ardumont wrote:

This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.

I'd be fine with that indeed.

I think we entertain the idea with @douardda and @vsellier

Make sure swh.scheduler.cli.journal is loaded in test_cli_journal.py

Looks ok to me. I'd like however to have a description of implemented metrics in the commit message (and in the documentation, but this may come later)

Move the `last_scheduled` ts from ListedOrigin to OriginVisitStatus

Make the journal-client cli subcommand automagically loaded

Use olasd's version os the SQL query

overall looks good to me, but it could benefit from more comments and explanations. Not easy to get in as is.

Add a 'Data model and specifications' section in the main index

forget the migration script

thanks, looks a good starting point.

Allow to use the JAVA_HOME environment for cassandra tests

Enforce hypothesis <6 to prevent test breakage

Add a paragraph in the README file

Make the CREATE_TABLES_QUERIES in cassandra/schema.py an explicit list

douardda (David Douard)
User

Projects (8)
View All

User Details

Recent Activity
View All

Today

Fri, Jan 22

Thu, Jan 21

Wed, Jan 20

Tue, Jan 19

Mon, Jan 18

Fri, Jan 15

Wed, Jan 13

Tue, Jan 12

douardda (David Douard)User

Projects (8)View All