- User Since
- Jul 10 2018, 12:38 PM (159 w, 3 d)
return itertools.chain([res], stream_results(f, page_token = res.page_token, **kwargs))
why not something like:
Wed, Jul 28
move _relation_uses_location_table at the end of the class
fix typos reported by ardumont and vlorentz (thx)
Tue, Jul 27
I am not fond at all of the code duplication (between R-C and O-R synth file parsers), looks to me at least parts of it could be kept factorised in a dedicated module (I agree it should not live in conftest any more: too much code and logic now). It would then be best to have these test-helper functions tested themselves (as unitary as possible).
rebase and cpitalize sql queries
capitalize sql querie
LGTM but see my questions (not sure they make really sense, but who knows)
Mon, Jul 26
Potential issues/weakness of our current infra:
Thu, Jul 22
I would have loved to also replace the logic in relation_add() and _relation_get() by stored SQL functions, but it's above my poor SQL skills...
Wed, Jul 21
Mon, Jul 19
sorry I don't understand everything here:
Fri, Jul 2
I still disagree with the implementation of get_dates() but meh
I've made several small comments / nitpicks, fell free to address them or not.
okay but as stated, I don't like too much the general usage of the RealDictCursor; sometimes it helps, but sometimes it does not. Ideally both should be available (depending on the query).
Thu, Jul 1
ok but please remove print statements before
Jul 1 2021
ok but the SQL query could be improved to not return unwanted dates
Jun 29 2021
This initial proposal from CINES has not been selected because it de facto normalize a number of relations of the SWH graph making it unfit to storage in a solution like Vitam (too many objects, hard to manage incremental updates).
- Proposal from CINES
Jun 28 2021
Jun 25 2021
I think I'd rather like to have an explicit list of excluded fields (when these extra fields are added). So I'd prefer see this diff be something that compares dicts (as a result of BaseObject.to_dict()), possibly filtered to exclude some fields.
Jun 23 2021
Also, at some point we might want to use better templating to write these SQL queries, or use stored procedures (with the proper "variation" being chosen at db creation time on the selected flavor; would simplify the python code a lot.
reword a bit the ci message and kill a few tabs in 30-schema.sql
yes I know, names for the subqueries are horrible...
rebase, adapt and implement denormalization for content_in_dir and dir_in_rev
Jun 22 2021
we keep it for now
overall ok but see the comment
Jun 21 2021
ok but some questions/remarks have not been addressed...
Thanks for the DatetimeCache & co.
I agree having access to the logs of the task (more or less) in real-time would be very handy (as one can expect on any CI-like tool nowadays).
Jun 18 2021
but please add a comment in the ArchivePostgreSQL's version of snapshot_get_heads explaining why it's (for now) a duplication of the other implementation, thanks
thanks, the diff looks much simpler now :-)
I know I am rambling, but could it come with some testing?
use 'branches' instead of "revisions" as section in the yaml file
Mostly nitpicking comments, but I'd really prefer that:
- the cache is kept properly typed
- the cache clearing thing gets its own git revision
Add a revision to fix the annotation of InMemory's value_sanitizer
small simplification in the docstring
use get_journal_writer in test_stream
fix docstring, thx ardumont