♟ douardda

In D1176#25026, @ardumont wrote:

What does this do?

Since the current status of munin's pg monitoring is inconsistent (eg. awure's dbreplica0 has not pg curve), let's get rid of all munin's pg monitors so there is less confusion, and is one step towards T1356.

Please add an entry_point in the setup.py for this cli.

config: use already loaded swh config, if any, when instantiating an Indexer

No idea whether if it's of some interest for our subject, but we may also have a look at openio

Update vault service config for vault 0.0.23

rebased and fix requirements-swh.txt

cli: add a --runs option to 'swh-scheduler task list' tool

Keep the main loaded configuration as swh.scheduler.CONFIG

celery_backend: remove debug statements and reduce info level verbosity

add tests... and consequently fix the client part of the new backend method

One interesting project we can look at is seaweedfs which implements ideas presented in this paper of fb's Haystack.

Thanks @olasd for this piece of information.

Rewrite tests using pytest's fixtures and adapt them to recent refactorings

Normalize the configuration of VaultBackend and cooker

Make it possible to specify the config file via SWH_CONFIG_FILENAME env var

Refactor the VaultBackend to use BaseDb and pool-based db access

Add a swh.vault.api.wsgi module to instanciate the (singleton) wsgi app object

Extract the main cli command in a dedicated cli.py module and make it an…

Few additions to the original diff

fix typo reported by ardumont

Commit missing stuff.
Fix commit again.
Fix requirements.txt
Add missing tests.

Please give a bit of context in your commit messages (in git). Like these 2 commits are dealing with tests for example. And 'More keys' is not a good commit message. Like 'fix a bug' is not a valid commit message, generally speaking.

A bit 'how you doing' there, but 1/ it's kind of consistent with other similar modules in other swh packages, and 2/ who cares?

LGTM, but hey, these are puppets!

listener: make the listener's queue name independent from the hostname

runner: fix task_run configuration bootstrap

sql: add the swh-lister-bitbucket-* task types

task: do not send the task-result-exception event in Task.on_failure()

Add the vault services (api and worker) and make them avaible in swh-web

Deploy a djangossettings.py for swh-web that allows to set a dumd asmin password

Move options and arguments of the swh manage command as COMMAND

Fix indentation in swh-vault/entrypoint.sh

Important rework of the config handling

I'm (re)working this diff, so wait a bit before spending time reviewing it.

Very beginning of a grafana service

Update the lister entrypoint to make latest cli updates

Split the getting-started guide in 3 parts

Let's keep on, but I really don't like the turn this code takes...

rebased and fixes reported by aardumont and vlorentz

Add missing hunks in tox.ini and requirement-test.txt

I'm a bit puzzled that with so many comments, this diff has been accepted! It should not have been so IMHO.

In D1090#23117, @vlorentz wrote:

In D1090#23077, @douardda wrote:

One drawback of this function extraction is that you now have to keep an intermediate result (the origins list). Couldn't this be avoided using generators?

That's a very small list (I'd be surprised if it ever gets over 10KB). And starting with D1092, we'll download the whole list at once anyway.

Fix the DumpMountAndLoadSvnRepository task

In D1080#23137, @vlorentz wrote:

(Actually, after thinking more about this, a class with setUp and tearDown looks like better than my decorator solution.)

douardda (David Douard)
User

Projects

User Details

Recent Activity
View All

Today

Yesterday

Wed, Feb 20

Tue, Feb 19

Fri, Feb 15

Thu, Feb 14

Wed, Feb 13

Tue, Feb 12

Mon, Feb 11

Fri, Feb 8

Thu, Feb 7

douardda (David Douard)User