Page MenuHomeSoftware Heritage

Remove strdate_to_timestamp
ClosedPublic

Authored by vlorentz on Tue, Jan 11, 12:58 PM.

Details

Summary

It duplicates TimestampWithTimezone.from_datetime().

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6911 (id=25051)

Rebasing onto 1b13c5c19e...

Current branch diff-target is up to date.
Changes applied before test
commit 9264db9a58bca8632a86cfce9c104b528ce9417c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 12:57:46 2022 +0100

    Remove strdate_to_timestamp
    
    It duplicates TimestampWithTimezone.from_datetime().

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/226/ for more details.

Build is green

Patch application report for D6911 (id=25052)

Rebasing onto 1b13c5c19e...

Current branch diff-target is up to date.
Changes applied before test
commit 3c9cbceb9ede842fd5c312898e4e9ad85c30e073
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 12:57:46 2022 +0100

    Remove strdate_to_timestamp
    
    It duplicates TimestampWithTimezone.from_datetime().

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/227/ for more details.

anlambert added inline comments.
swh/loader/svn/converters.py
27–28

Yes it is, svn revision dates are stored using ISO8601 format with UTC timezone so you can drop the python-dateutil dependency and use iso8601 as in other swh components.

swh/loader/svn/converters.py
27–28

thanks, done in D6912.

This revision is now accepted and ready to land.Tue, Jan 11, 2:06 PM
This revision was automatically updated to reflect the committed changes.