Page MenuHomeSoftware Heritage

vlorentz (Valentin Lorentz)
User

Projects

User Details

User Since
Oct 1 2018, 11:23 AM (77 w, 5 d)

Recent Activity

Yesterday

vlorentz added a comment to D2923: bin/update add support for (re)installing packages after update.

Just a couple of nitpicks.

Sat, Mar 28, 4:12 PM
vlorentz accepted D2922: make "make distclean" remove tox and mypy caches.
Sat, Mar 28, 4:09 PM
vlorentz added inline comments to D2924: Extend SWH PID definition with additional context qualifiers..
Sat, Mar 28, 4:06 PM
vlorentz updated the summary of D2924: Extend SWH PID definition with additional context qualifiers..
Sat, Mar 28, 3:58 PM

Fri, Mar 27

vlorentz accepted D2920: browse: Fix pagination links display issue in branches / releases views.

Could you add a short docstring to the test, explaining the same thing as the diff's description?

Fri, Mar 27, 9:32 PM
vlorentz accepted D2919: test: make test data properly typed.
Fri, Mar 27, 5:08 PM
vlorentz requested changes to D2913: templates/homepage: Fix counters display when storage is empty.

Could you add a test for this? (eg. using Cypress to mock calls to the counter API)

Fri, Mar 27, 5:08 PM
vlorentz requested changes to D2918: GitLoader: instantiate SnapshotBranch object using the from_dict factory.

DULWICH_TARGET_TYPES are already the right enum values.

Fri, Mar 27, 5:01 PM
vlorentz accepted D2917: converters: fix types of TimestampWithTimezone arguments.
Fri, Mar 27, 5:00 PM
vlorentz requested changes to D2916: Adapt cassandra backend to validating model types.

This is going in the right direction, but I don't like the CassObject thing. I think you made it because you are conflating two uses of my "Frankenstein's model objects":

Fri, Mar 27, 4:59 PM
vlorentz accepted D2915: test: get rid of normalized_xxx in tests.

yay

Fri, Mar 27, 4:53 PM
vlorentz requested changes to D2914: test: ensure timestamp in test data are properly typed.

This remove test coverage of swh.storage.converters.date_to_db.

Fri, Mar 27, 4:52 PM
vlorentz accepted D2914: test: ensure timestamp in test data are properly typed.
Fri, Mar 27, 4:50 PM
vlorentz accepted D2912: test: add a small test to check for type validation (using release_add).
Fri, Mar 27, 4:49 PM
vlorentz accepted D2911: validate: fix type annotation for origin_visit_add.
Fri, Mar 27, 4:48 PM
vlorentz accepted D2910: validate: ensure StorageArgumentException is always encodable.
Fri, Mar 27, 4:47 PM
vlorentz accepted D2909: writer: fix skipped_content_add type declaration to use SkippedContent.

Why didn't mypy catch this?

Fri, Mar 27, 4:46 PM
vlorentz accepted D2908: tests: fix types of several test data sets.
Fri, Mar 27, 4:45 PM
vlorentz requested changes to D2906: model: add support for ctime in [Skipped]Content.from_[data,dict]().
Fri, Mar 27, 4:44 PM
vlorentz requested changes to D2905: hypothesis: split hypothesis strategies as a dict + entity instance.

You should rewrite all the object-generating strategies:

Fri, Mar 27, 4:39 PM
vlorentz accepted D2904: jobs/templates: Fix cypress jobs after Jenkins upgrade.
Fri, Mar 27, 12:02 PM
vlorentz added a comment to D2863: scanner: show result with a sunburst chart.

Thanks! I will check a solution for that; anyways, i didn't have problem testing directories that have the same name, could you provide me an example, so i can replicate your test?

Fri, Mar 27, 11:04 AM
vlorentz requested changes to D2863: scanner: show result with a sunburst chart.

Sorry I didn't do it earlier, but I finally got around to actually running this code, and I found a bug: if two directories have the same name (or if there's one named "total"), then the swh-scanner process exits early, and nothing is shown in the browser.

Fri, Mar 27, 10:44 AM

Thu, Mar 26

vlorentz accepted D2893: storage*: Update origin_visit_update to make status parameter mandatory.
Thu, Mar 26, 5:16 PM
vlorentz accepted D2892: indexer: Remove type from origin_add calls.
Thu, Mar 26, 5:11 PM
vlorentz added a comment to D2890: Rename --max-messages to --stop-after-objects..

(Landing the diff nonetheless, because the build fails because of a pending change by @ardumont)

Thu, Mar 26, 4:59 PM
vlorentz committed rDCIDX49ea33cad55b: Rename --max-messages to --stop-after-objects. (authored by vlorentz).
Rename --max-messages to --stop-after-objects.
Thu, Mar 26, 4:59 PM
vlorentz closed D2890: Rename --max-messages to --stop-after-objects..
Thu, Mar 26, 4:59 PM
vlorentz added a comment to D2891: tests: Specify status when calling origin_visit_update.

Note: this is needed because we will make this argument mandatory

Thu, Mar 26, 4:55 PM
vlorentz accepted D2891: tests: Specify status when calling origin_visit_update.
Thu, Mar 26, 4:54 PM
vlorentz committed rDCOREad8bf9c09f6b: Run Black on setup.py. (authored by vlorentz).
Run Black on setup.py.
Thu, Mar 26, 4:49 PM
vlorentz updated the summary of D2890: Rename --max-messages to --stop-after-objects..
Thu, Mar 26, 4:41 PM
vlorentz created D2890: Rename --max-messages to --stop-after-objects..
Thu, Mar 26, 4:40 PM
vlorentz accepted D2889: core.loader: Remove origin_visit_update call from DVCSLoader class.
Thu, Mar 26, 4:11 PM
vlorentz accepted D2888: svn.loader: Let core loader update snapshot & visit at the same time.
Thu, Mar 26, 3:54 PM
vlorentz accepted D2887: core.loader: Allow core loader to update origin_visit in one call.
Thu, Mar 26, 3:32 PM
vlorentz accepted D2886: svn: test_loader: Add missing assertions on visit status.
Thu, Mar 26, 3:21 PM
vlorentz committed rDSTO0a22e72d957d: Respec discovery_date as a Python datetime instead of an ISO string. (authored by vlorentz).
Respec discovery_date as a Python datetime instead of an ISO string.
Thu, Mar 26, 2:18 PM
vlorentz closed D2885: Respec discovery_date as a Python datetime instead of an ISO string..
Thu, Mar 26, 2:18 PM
vlorentz requested changes to D2863: scanner: show result with a sunburst chart.

This time I reviewed plot.py.

Thu, Mar 26, 2:06 PM
vlorentz created D2885: Respec discovery_date as a Python datetime instead of an ISO string..
Thu, Mar 26, 1:04 PM
vlorentz accepted D2883: test: Adapt origin validation test according to latest model changes.
Thu, Mar 26, 11:12 AM
vlorentz committed rDSTO74fd15e6b368: origin_visit_add: Add missing db/cur argument to call to origin_get. (authored by vlorentz).
origin_visit_add: Add missing db/cur argument to call to origin_get.
Thu, Mar 26, 11:08 AM
vlorentz committed rDLDSVN72a8b05a69fc: Fix crash on None snapshot. (authored by vlorentz).
Fix crash on None snapshot.
Thu, Mar 26, 11:05 AM
vlorentz closed D2769: Fix crash on None snapshot..
Thu, Mar 26, 11:05 AM
vlorentz requested changes to D2883: test: Adapt origin validation test according to latest model changes.

It tests for the missing url, so it's still relevant.

Thu, Mar 26, 11:00 AM

Wed, Mar 25

vlorentz added a comment to T2310: Mutability of origin visits.

Current plan:

Wed, Mar 25, 2:23 PM · Storage manager, Data Model
vlorentz updated the task description for T2310: Mutability of origin visits.
Wed, Mar 25, 1:57 PM · Storage manager, Data Model
vlorentz updated the diff for D2769: Fix crash on None snapshot..

remove annotation.

Wed, Mar 25, 12:04 PM

Tue, Mar 24

vlorentz added a comment to D2872: storage*: Hex encode content hashes in HashCollision exception.
In D2872#69251, @olasd wrote:

I think there's general value in keeping exception arguments inambiguous and human-readable.

Having to fish out and copy/paste a repr'd bytes object is really annoying when you want to quickly check whether something is in the database or not, for instance. Also, I don't trust our exception handling utilities (be that logging, sentry, serialization in the RPC protocol, ...) to handle arbitrary bytes unharmed.

Tue, Mar 24, 5:54 PM
vlorentz created P628 (An Untitled Masterwork).
Tue, Mar 24, 5:15 PM
vlorentz created P627 (An Untitled Masterwork).
Tue, Mar 24, 5:06 PM
vlorentz edited P626 error: Cannot assign to a method.
Tue, Mar 24, 5:02 PM
vlorentz created P626 error: Cannot assign to a method.
Tue, Mar 24, 5:02 PM
vlorentz added a comment to D2872: storage*: Hex encode content hashes in HashCollision exception.

I understand this is to work around the sentry issue, but I think it's a bad idea. We don't want parts of the API to use hex encoding while everything else uses bytes.

Tue, Mar 24, 1:38 PM
vlorentz committed rDSTOb7477e57d1ae: Add format of discovery_date in the metadata specification. (authored by vlorentz).
Add format of discovery_date in the metadata specification.
Tue, Mar 24, 12:47 PM
vlorentz closed D2871: Add format of discovery_date in the metadata specification..
Tue, Mar 24, 12:47 PM
vlorentz created D2871: Add format of discovery_date in the metadata specification..
Tue, Mar 24, 12:14 PM
vlorentz added a parent task for T2306: Generic storage for extrinsic, qualified metadata related to any node of the swh archive: T2311: Update the deposit of metadata with a regular zip deposit.
Tue, Mar 24, 12:06 PM · Metadata workflow, Restricted Project
vlorentz added a subtask for T2311: Update the deposit of metadata with a regular zip deposit: T2306: Generic storage for extrinsic, qualified metadata related to any node of the swh archive.
Tue, Mar 24, 12:06 PM · Metadata workflow, Restricted Project
vlorentz added a subtask for T2202: Extrinsic metadata: T2311: Update the deposit of metadata with a regular zip deposit.
Tue, Mar 24, 12:05 PM · Metadata workflow, Restricted Project
vlorentz removed a subtask for T2306: Generic storage for extrinsic, qualified metadata related to any node of the swh archive: T2311: Update the deposit of metadata with a regular zip deposit.
Tue, Mar 24, 12:05 PM · Metadata workflow, Restricted Project
vlorentz edited parent tasks for T2311: Update the deposit of metadata with a regular zip deposit, added: T2202: Extrinsic metadata; removed: T2306: Generic storage for extrinsic, qualified metadata related to any node of the swh archive.
Tue, Mar 24, 12:05 PM · Metadata workflow, Restricted Project
vlorentz claimed T2306: Generic storage for extrinsic, qualified metadata related to any node of the swh archive.
Tue, Mar 24, 12:04 PM · Metadata workflow, Restricted Project
vlorentz accepted D2870: package.loader: Fix status visit to 'partial'.

Needs a test, though

Tue, Mar 24, 10:12 AM

Mon, Mar 23

vlorentz committed rDSTO92a87ea4d030: Store the value of token(partition_key) in skipped_content_by_* table, instead… (authored by vlorentz).
Store the value of token(partition_key) in skipped_content_by_* table, instead…
Mon, Mar 23, 5:17 PM
vlorentz closed D2866: Store the value of token(partition_key) in skipped_content_by_* table, instead of three hashes..
Mon, Mar 23, 5:17 PM
vlorentz updated the diff for D2866: Store the value of token(partition_key) in skipped_content_by_* table, instead of three hashes..

fix docstring.

Mon, Mar 23, 3:51 PM
vlorentz created D2866: Store the value of token(partition_key) in skipped_content_by_* table, instead of three hashes..
Mon, Mar 23, 3:50 PM
vlorentz committed rDSTOa24ab3f22bf8: Store the value of token(partition_key) in content_by_* table, instead of three… (authored by vlorentz).
Store the value of token(partition_key) in content_by_* table, instead of three…
Mon, Mar 23, 3:21 PM
vlorentz closed D2796: Store the value of token(partition_key) in content_by_* table, instead of three hashes..
Mon, Mar 23, 3:21 PM
vlorentz added a comment to D2796: Store the value of token(partition_key) in content_by_* table, instead of three hashes..

As the cassandra cluster is paused indefinitely, I'm landing this diff now

Mon, Mar 23, 3:21 PM
vlorentz updated the diff for D2796: Store the value of token(partition_key) in content_by_* table, instead of three hashes..

rebase

Mon, Mar 23, 3:17 PM
vlorentz committed rDWCM73eac8968f10: Add buttons to flip authors, and remove text that their order doesn't matter. (authored by vlorentz).
Add buttons to flip authors, and remove text that their order doesn't matter.
Mon, Mar 23, 2:41 PM
vlorentz committed rDWCMa010d3e1162b: Fix typos. (authored by vlorentz).
Fix typos.
Mon, Mar 23, 2:20 PM
vlorentz added a comment to T2046: [CodeMeta] Add checker that file is complete for citation.

see mandatory fields for citation

Mon, Mar 23, 1:27 PM · CodeMeta Generator, Metadata workflow
vlorentz closed T2036: [CodeMeta] Validate codemeta.json output, a subtask of T2035: Create codemeta generator tool, as Resolved.
Mon, Mar 23, 1:13 PM · CodeMeta Generator, Metadata workflow
vlorentz closed T2036: [CodeMeta] Validate codemeta.json output as Resolved.

Now it does

Mon, Mar 23, 1:13 PM · CodeMeta Generator, Metadata workflow
vlorentz added a comment to T2329: Extend CodeMeta vocabulary.

I do like the idea of adding a role to author, but the way schema.org is organized, is by adding properties with specific roles

Mon, Mar 23, 10:20 AM · Scientific Community Building, Metadata workflow

Sat, Mar 21

vlorentz added a comment to T2329: Extend CodeMeta vocabulary.

Taxon map:

Sat, Mar 21, 12:30 PM · Scientific Community Building, Metadata workflow
vlorentz edited P623 json-ld person affiliations.
Sat, Mar 21, 12:10 PM
vlorentz edited P623 json-ld person affiliations.
Sat, Mar 21, 12:06 PM
vlorentz updated the language for P623 json-ld person affiliations from autodetect to json.
Sat, Mar 21, 12:06 PM
vlorentz created P623 json-ld person affiliations.
Sat, Mar 21, 12:06 PM

Fri, Mar 20

vlorentz committed rDWCMd2da513f2d9a: Add some styling, similar to the main codemeta website. (authored by vlorentz).
Add some styling, similar to the main codemeta website.
Fri, Mar 20, 11:30 PM
vlorentz committed rDWCM3dbc0b3bca9e: Rename Codemeta -> codemeta.json when refering to the generated file. (authored by vlorentz).
Rename Codemeta -> codemeta.json when refering to the generated file.
Fri, Mar 20, 11:30 PM
vlorentz committed rDWCMfe921dd20705: Run validator on generated output just in case. (authored by vlorentz).
Run validator on generated output just in case.
Fri, Mar 20, 10:08 PM
vlorentz committed rDWCM4c05005ad907: Deduplicate 'URI instead of Thing' logic. (authored by vlorentz).
Deduplicate 'URI instead of Thing' logic.
Fri, Mar 20, 9:42 PM
vlorentz committed rDWCM5ac1fd287712: Add validation for CreativeWorks. (authored by vlorentz).
Add validation for CreativeWorks.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCM03191c644bc4: Accept an URI in place of all Things. (authored by vlorentz).
Accept an URI in place of all Things.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCMe08528b99cfd: Split js/validation.js into smaller files. (authored by vlorentz).
Split js/validation.js into smaller files.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCM94e7041b0328: Deduplicate field dispatch, and add Organization validation. (authored by vlorentz).
Deduplicate field dispatch, and add Organization validation.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCMdecbaa5a530f: Deduplicate @type checking. (authored by vlorentz).
Deduplicate @type checking.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCMaa3746a79de2: Deduplicate @type validation in validateCreativeWork. (authored by vlorentz).
Deduplicate @type validation in validateCreativeWork.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCM55edfe2b81c8: Check unknown fields raise an error. (authored by vlorentz).
Check unknown fields raise an error.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCM1846b0461f8e: Add comment on 'creator' removal. (authored by vlorentz).
Add comment on 'creator' removal.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCMd21296f8bbea: Add Person validation. (authored by vlorentz).
Add Person validation.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCM165156866606: Remove irrelevant comment (authored by vlorentz).
Remove irrelevant comment
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCM9353cae55330: Add test for fields with no validation. (authored by vlorentz).
Add test for fields with no validation.
Fri, Mar 20, 9:38 PM
vlorentz committed rDWCM75320595147d: Deduplicate array vs single item logic. (authored by vlorentz).
Deduplicate array vs single item logic.
Fri, Mar 20, 9:38 PM