rebase (thx for the script)

rebase

rebase

rebase

fix names

Wouldn't it make sense to have this in swh.storage.algos instead?

undo changes to the API return format

Oh, I guess you meant replacing it to use writer = KafkaJournalWriter[BaseModel](, right?

In D4082#108323, @douardda wrote:

Looks like the only user of the KafkaJournalWriter class outside the journal is swh.objstorage.replayer, which would be impacted by this diff (unless I'm mistaken) but this is indeed a minor issue.

oh yes, my bad. could you add a test for it?

Wouldn't it help the transition to also set an id attribute on instance? (You tell me, I don't know if it's actually used)

wait, what? It would be easier to just use POST everywhere, we just need to change the vault's protocol

fix pypi json format

or move it to a new file (eg. swh/core/db/db_testing.py), that doesn't get transitively imported by swh-web

Why don't you make the pytest_postgresql import optional in swh-core?

rebase

fix type

In D4080#107053, @olasd wrote:

I'm not a fan of the sanitizer name (I know I probably introduced it :P). Something along the lines of object_filter may be more appropriate?

In D4082#107582, @douardda wrote:

Wouldn't it make a bit easier to name the generic version of the journal writer something like GenericKafkaJournalWriter and have KafkaJournalWriter = GenericKafkaJournalWriter[BaseModel] ? (for bw compat)

In D4307#107125, @olasd wrote:

In D4307#107124, @vlorentz wrote:

And it's confusing why compute_hash can't just return self.id; I think I liked it better as a staticmethod.

Is it? It's an initialization method that's mostly used when you don't have a self.id.

And it's confusing why compute_hash can't just return self.id; I think I liked it better as a staticmethod.

shouldn't you add -> bytes to all the compute_hash methods?

rebase

rebase

rebase

Are there tests for the backend_factory/backend_class stuff?

Thanks for the report and sorry for the delay.