User Details
User Details
- User Since
- Oct 1 2018, 11:23 AM (19 w, 6 d)
Fri, Feb 15
Fri, Feb 15
vlorentz added inline comments to D1146: cli: add a --runs option to 'swh-scheduler task list' tool.
vlorentz requested changes to D1146: cli: add a --runs option to 'swh-scheduler task list' tool.
The new API endpoints don't have tests.
vlorentz added a comment to D1148: config: use already loaded swh config, if any, when instantiating an Indexer.
I don't see any variable named CONFIG in swh.scheduler outside of swh/scheduler/celery_backend/config.py.
vlorentz committed rDSTO152cb528234f: Move origin_get_range's right after origin_get. (authored by vlorentz).
Move origin_get_range's right after origin_get.
vlorentz committed rDCIDX064f1eb047c5: Add missing documentation of 'mappings' arguments in the in-mem storage. (authored by vlorentz).
Add missing documentation of 'mappings' arguments in the in-mem storage.
vlorentz updated the diff for D1143: Add missing documentation of 'mappings' arguments in the in-mem storage..
- Fix indent
- Squash
Herald added a reviewer for D1143: Add missing documentation of 'mappings' arguments in the in-mem storage.: Reviewers.
Thu, Feb 14
Thu, Feb 14
vlorentz committed rDCIDXd003f0b2a042: Don't send 'None' as a revision id to storage.revision_get. (authored by vlorentz).
Don't send 'None' as a revision id to storage.revision_get.
Herald added a reviewer for D1141: Don't send 'None' as a revision id to storage.revision_get.: Reviewers.
vlorentz committed rDCIDXa2da900a465e: Fix deduplication of origins when persisting origin intrinsic metadata. (authored by vlorentz).
Fix deduplication of origins when persisting origin intrinsic metadata.
vlorentz committed rDCIDXd4238d332f38: Fix duplication checking in the in-mem implementation of IndexerStorage. (authored by vlorentz).
Fix duplication checking in the in-mem implementation of IndexerStorage.
vlorentz updated the diff for D1138: Fix duplication checking in the in-mem implementation of IndexerStorage. origin_intrinsic_metadata_add..
- rebase
vlorentz committed rDCIDXeca69ce7543b: Fix mismatch between origins and head_revs. (authored by vlorentz).
Fix mismatch between origins and head_revs.
vlorentz updated the diff for D1139: Fix mismatch between origins and head_revs..
- rebase
vlorentz committed rDCIDX65a31e93fcc4: Remove files that weren't supposed to be committed yet. (authored by vlorentz).
Remove files that weren't supposed to be committed yet.
vlorentz added a comment to D1140: Remove files that weren't supposed to be committed yet..
Herald added a reviewer for D1140: Remove files that weren't supposed to be committed yet.: Reviewers.
vlorentz committed rDCIDX795bc1daca3e: Fix value of origin_id when more than one origin is indexed (authored by vlorentz).
Fix value of origin_id when more than one origin is indexed
vlorentz updated the diff for D1137: Fix value of origin_id when more than one origin is indexed.
- rebase
vlorentz committed rDCIDX2354d9bb313b: Fix crash when an origin has no HEAD. (authored by vlorentz).
Fix crash when an origin has no HEAD.
vlorentz updated the diff for D1138: Fix duplication checking in the in-mem implementation of IndexerStorage. origin_intrinsic_metadata_add..
- Fix deduplication of origins when persisting origin intrinsic metadata.
vlorentz updated the diff for D1137: Fix value of origin_id when more than one origin is indexed.
- Fix commit message
Herald added a reviewer for D1137: Fix value of origin_id when more than one origin is indexed: Reviewers.
vlorentz updated the diff for D1121: Generate pom.xml files ourselves instead of using xmltodict.unparse..
- Add test for tree_to_xml.
vlorentz added a comment to T1528: Efficient reindex when adding a metadata mapping.
Or, as the OriginMetadataIndexer already fetches this data anyway, it could write it to the indexer db when it's done.
vlorentz added a comment to D1121: Generate pom.xml files ourselves instead of using xmltodict.unparse..
It'd be good to have tests around the xml_document_strategy since it's used for tests though.
vlorentz added a comment to T1529: Efficient reindex when updating a metadata mapping.
Should be easy to do, we already have this info in the indexer db (in origin_intrinsic_metadata.mappings). Then it's just a matter of creating oneshot tasks.
vlorentz added a comment to T1528: Efficient reindex when adding a metadata mapping.
The naive solution to do this is adding a new indexer that pre-fetches snapshot+revision+root dir of an origin and writes its list of root files in the indexer db. Then we can read that to find which origins have a given file name pattern.
vlorentz committed rDCIDXb43f534ec9e3: Document the 'mappings' columns of revision_metadata and… (authored by vlorentz).
Document the 'mappings' columns of revision_metadata and…
vlorentz updated the diff for D1133: Document the 'mappings' columns of revision_metadata and origin_intrinsic_metadata..
- rebase
vlorentz added a comment to D1133: Document the 'mappings' columns of revision_metadata and origin_intrinsic_metadata..
vlorentz updated the diff for D1121: Generate pom.xml files ourselves instead of using xmltodict.unparse..
Reword commits:
vlorentz added a comment to D1122: Use xmlschema instead of xmltodict for parsing pom.xml..
Wed, Feb 13
Wed, Feb 13
vlorentz updated the summary of D1122: Use xmlschema instead of xmltodict for parsing pom.xml..
vlorentz added a child revision for D1123: Use schema validation for pom.xml: D1126: Catch exceptions raised by elementpath..
vlorentz retitled D1123: Use schema validation for pom.xml from Use schema validation. to Use schema validation for pom.xml.
Fix gemspec test.
vlorentz committed rDCIDX29e200839267: Break dependency of swh.indexer.storage on swh.indexer. (authored by vlorentz).
Break dependency of swh.indexer.storage on swh.indexer.
vlorentz requested changes to D1119: indexer_storage: Work around deployment issue.
Proper resolution: D1125
Herald added a reviewer for D1125: Break dependency of swh.indexer.storage on swh.indexer.: Reviewers.
Tue, Feb 12
Tue, Feb 12
vlorentz updated the diff for D1122: Use xmlschema instead of xmltodict for parsing pom.xml..
- Rebase
Duplicate of D1121.
vlorentz updated the diff for D1124: Add an hypothesis strategy to generate pom.xml documents..
- rebase
Herald added a reviewer for D1124: Add an hypothesis strategy to generate pom.xml documents.: Reviewers.
vlorentz updated the diff for D1122: Use xmlschema instead of xmltodict for parsing pom.xml..
- Fix base commit
vlorentz added a child revision for D1122: Use xmlschema instead of xmltodict for parsing pom.xml.: D1123: Use schema validation for pom.xml.
Herald added a reviewer for D1122: Use xmlschema instead of xmltodict for parsing pom.xml.: Reviewers.
vlorentz updated the diff for D1121: Generate pom.xml files ourselves instead of using xmltodict.unparse..
- More keys.
Herald added a reviewer for D1121: Generate pom.xml files ourselves instead of using xmltodict.unparse.: Reviewers.
vlorentz committed rDARCee85027276dd: Use the new BaseDb from swh.core, drop dependency on swh.storage. (authored by vlorentz).
Use the new BaseDb from swh.core, drop dependency on swh.storage.
vlorentz committed rDSTO1efbe5c16b27: Fix test to work with the latest version of swh.core. (authored by vlorentz).
Fix test to work with the latest version of swh.core.
Herald added a reviewer for D1118: Fix test to work with the latest version of swh.core.: Reviewers.
vlorentz added a comment to D1075: Storage: Add origin_count method.
Oh wait, my mistake. I tagged a new version of swh.core that broke that particular test.
vlorentz added a comment to D1075: Storage: Add origin_count method.
You need to rebase on master to fix the build failure.
Herald added a reviewer for D1116: Use the new BaseDb from swh.core, drop dependency on swh.storage.: Reviewers.
Fix rebase.
vlorentz committed rDCIDX9657abaf20a2: Prevent OriginMetadataIndexer from sending duplicate revisions to… (authored by vlorentz).
Prevent OriginMetadataIndexer from sending duplicate revisions to…
vlorentz updated the diff for D1081: Prevent OriginMetadataIndexer from sending duplicate revisions to revision_metadata_add..
- rebase
vlorentz committed rDCIDX0f75ae1e7346: Use hypothesis to generate adversarial inputs. (authored by vlorentz).
Use hypothesis to generate adversarial inputs.
Fix bugs found by hypothesis.
vlorentz committed rDCIDXd3a6ae1930ff: Add more type checks in metadata dictionary. (authored by vlorentz).
Add more type checks in metadata dictionary.
vlorentz updated the diff for D1077: Add more type checks in metadata dictionary..
- Rebase + squash
Add tests for swh.core.db.
Add test for BaseDb.connect.
vlorentz updated the diff for D1081: Prevent OriginMetadataIndexer from sending duplicate revisions to revision_metadata_add..
- rebase
vlorentz committed rDCIDXfd4c400d9299: Move boilerplate out of test_origin_metadata_indexer so it's reusable by other… (authored by vlorentz).
Move boilerplate out of test_origin_metadata_indexer so it's reusable by other…