Page MenuHomeSoftware Heritage
People vlorentz

vlorentz (Valentin Lorentz)
User

Projects

User Details

User Since
Oct 1 2018, 11:23 AM (45 w, 5 d)

Recent Activity
View All

Wed, Aug 14

vlorentz added a comment to D1720: Modify API output and test.

Keeping the expected results unchanged allows the build to pass, even though it is in the older format.

Wed, Aug 14, 10:23 AM

Tue, Aug 13

vlorentz updated the summary of D1848: Don't set $DJANGO_SETTINGS_MODULE in manage.py.
Tue, Aug 13, 4:00 PM
Herald added a reviewer for D1848: Don't set $DJANGO_SETTINGS_MODULE in manage.py: Reviewers.
Tue, Aug 13, 3:56 PM
vlorentz closed D1835: Remove concept of 'minimal set' of metadata..
Tue, Aug 13, 2:45 PM
vlorentz committed rDCIDX68db804cccae: Remove concept of 'minimal set' of metadata. (authored by vlorentz).
Remove concept of 'minimal set' of metadata.
Tue, Aug 13, 2:45 PM
vlorentz committed rCJSWH38a9fb2a970d: Make the cypress build fail if any of the commands fails. (authored by vlorentz).
Make the cypress build fail if any of the commands fails.
Tue, Aug 13, 2:09 PM
vlorentz closed D1843: Make the cypress build fail if any of the commands fails..
Tue, Aug 13, 2:09 PM
vlorentz accepted D1847: Refactor cypress tests.
Tue, Aug 13, 11:31 AM

Mon, Aug 12

vlorentz edited projects for T1947: Unsupported locale 'en_IN' in arrow lib, added: Scheduling utilities; removed Core & foundations.
Mon, Aug 12, 4:20 PM · Scheduling utilities
vlorentz edited projects for T1947: Unsupported locale 'en_IN' in arrow lib, added: Core & foundations; removed Lister.
Mon, Aug 12, 4:20 PM · Scheduling utilities
Herald added a reviewer for D1845: Escape $() in the 'cat << EOF' command.: Reviewers.
Mon, Aug 12, 4:10 PM
vlorentz added a comment to T1947: Unsupported locale 'en_IN' in arrow lib.

Although I feel this is more of arrow library issue rather than swh issue.

Mon, Aug 12, 4:08 PM · Scheduling utilities
vlorentz updated the diff for D1838: Drop content_metadata table and indexer..

fix base commit

Mon, Aug 12, 1:38 PM
vlorentz retitled D1838: Drop content_metadata table and indexer. from [WIP] Drop content_metadata table and indexer. to Drop content_metadata table and indexer..
Mon, Aug 12, 1:38 PM
vlorentz updated the diff for D1838: Drop content_metadata table and indexer..

remove WIP

Mon, Aug 12, 1:38 PM
vlorentz accepted D1841: stats_exporter: Refactor and add docstrings to graph data export script.
Mon, Aug 12, 1:25 PM
vlorentz accepted D1844: Add missing swh/foo/__init__.py.
Mon, Aug 12, 12:18 PM
vlorentz added a comment to D1844: Add missing swh/foo/__init__.py.

I don't think you should put yourself in the contributors of a template repo

Mon, Aug 12, 12:13 PM
vlorentz added a comment to D1720: Modify API output and test.
In D1720#42747, @twitu wrote:

How do I resolve this? Should I override the method in both classes?

Mon, Aug 12, 11:34 AM
Herald added a reviewer for D1843: Make the cypress build fail if any of the commands fails.: Reviewers.
Mon, Aug 12, 11:30 AM
vlorentz planned changes to D1838: Drop content_metadata table and indexer..
Mon, Aug 12, 10:11 AM

Fri, Aug 9

vlorentz updated the summary of D1836: [WIP] Refactor use of 'content_metadata' as cache..
Fri, Aug 9, 4:16 PM
vlorentz updated the summary of D1838: Drop content_metadata table and indexer..
Fri, Aug 9, 4:15 PM
Herald added a reviewer for D1838: Drop content_metadata table and indexer.: Reviewers.
Fri, Aug 9, 4:15 PM
vlorentz updated the summary of D1836: [WIP] Refactor use of 'content_metadata' as cache..
Fri, Aug 9, 3:13 PM
vlorentz planned changes to D1836: [WIP] Refactor use of 'content_metadata' as cache..
Fri, Aug 9, 3:05 PM
Herald added a reviewer for D1836: [WIP] Refactor use of 'content_metadata' as cache.: Reviewers.
Fri, Aug 9, 3:03 PM
Herald added a reviewer for D1835: Remove concept of 'minimal set' of metadata.: Reviewers.
Fri, Aug 9, 2:05 PM

Thu, Aug 8

vlorentz committed rDSTOC8569f689e8fb: Add a draft Cassandra backend. (authored by vlorentz).
Add a draft Cassandra backend.
Thu, Aug 8, 4:17 PM
vlorentz committed rDSTOCb58943f95e82: Store directory entries in a separate table to avoid huge records. (authored by vlorentz).
Store directory entries in a separate table to avoid huge records.
Thu, Aug 8, 4:17 PM
vlorentz committed rDSTOC3f888628c9fb: Remove config sanitization from api/server.py. (authored by vlorentz).
Remove config sanitization from api/server.py.
Thu, Aug 8, 4:17 PM
vlorentz committed rDSTOCbabded56a56a: Enforce log level for the werkzeug logger. (authored by vlorentz).
Enforce log level for the werkzeug logger.
Thu, Aug 8, 4:17 PM
vlorentz committed rDSTOC7053da801fb4: Make origin_get ignore the `type` argument (authored by vlorentz).
Make origin_get ignore the `type` argument
Thu, Aug 8, 4:17 PM
vlorentz edited P490 benchmark script cassandra vs postgresql.
Thu, Aug 8, 3:10 PM
vlorentz edited P491 cassandra vs postgresql read benchmark.
Thu, Aug 8, 3:05 PM
vlorentz edited P491 cassandra vs postgresql read benchmark.
Thu, Aug 8, 3:02 PM
vlorentz added a comment to P491 cassandra vs postgresql read benchmark.

Same comment as P489, except this time the cache is mostly cold

Thu, Aug 8, 1:48 PM
vlorentz created P491 cassandra vs postgresql read benchmark.
Thu, Aug 8, 1:47 PM
vlorentz created P490 benchmark script cassandra vs postgresql.
Thu, Aug 8, 12:21 PM
vlorentz added a comment to P489 warm cache cassandra vs postgresql read benchmark.

Rough test benchmark of read access from the cassandra test cluster (4 desktops) and the postgresql replica DB on Somerset.

Thu, Aug 8, 12:19 PM
vlorentz updated the title for P489 warm cache cassandra vs postgresql read benchmark from cassandra vs postgresql read benchmark to warm cache cassandra vs postgresql read benchmark.
Thu, Aug 8, 12:19 PM
vlorentz created P489 warm cache cassandra vs postgresql read benchmark.
Thu, Aug 8, 12:16 PM
vlorentz committed rDSTOCf78eb90ed488: Remove config sanitization from api/server.py. (authored by vlorentz).
Remove config sanitization from api/server.py.
Thu, Aug 8, 10:58 AM

Wed, Aug 7

vlorentz committed rDOBJS5b9a6e8454e9: Remove override of S3.namespace. (authored by vlorentz).
Remove override of S3.namespace.
Wed, Aug 7, 2:30 PM
vlorentz closed D1829: Remove override of S3.namespace..
Wed, Aug 7, 2:30 PM
vlorentz added a comment to D1829: Remove override of S3.namespace..

To be more specific, this code is only used for S3 and Swift, and I highly doubt @douardda tested against Swift (why did we even explicitly add support for Swift?)

Wed, Aug 7, 2:30 PM
vlorentz added a comment to D1829: Remove override of S3.namespace..

The seaweedfs objstorage backend does not use this code, it's in swh/objstorage/backends/seaweed.py.

Wed, Aug 7, 2:27 PM
vlorentz updated the diff for D1829: Remove override of S3.namespace..

rebase

Wed, Aug 7, 2:17 PM
vlorentz committed rDOBJScd4b21b9280a: Monkey-patch libcloud's signature of S3 requests. (authored by vlorentz).
Monkey-patch libcloud's signature of S3 requests.
Wed, Aug 7, 2:17 PM
vlorentz closed D1826: Monkey-patch libcloud's signature of S3 requests..
Wed, Aug 7, 2:17 PM
vlorentz committed rDJNL17a0c3412e8d: Remove concurrency and error-handling from the content replayer. (authored by vlorentz).
Remove concurrency and error-handling from the content replayer.
Wed, Aug 7, 2:17 PM
vlorentz closed D1825: Remove concurrency and error-handling from the content replayer..
Wed, Aug 7, 2:17 PM
Herald added a reviewer for D1829: Remove override of S3.namespace.: Reviewers.
Wed, Aug 7, 1:59 PM
Herald added a reviewer for D1826: Monkey-patch libcloud's signature of S3 requests.: Reviewers.
Wed, Aug 7, 1:44 PM
Herald added a reviewer for D1825: Remove concurrency and error-handling from the content replayer.: Reviewers.
Wed, Aug 7, 1:13 PM

Tue, Aug 6

vlorentz committed rDJNL80a939479e75: Fix typo in package name. (authored by vlorentz).
Fix typo in package name.
Tue, Aug 6, 5:20 PM
vlorentz committed rDJNLf2e6310b1de9: Limit replayer output to 1 message/min. (authored by vlorentz).
Limit replayer output to 1 message/min.
Tue, Aug 6, 3:35 PM
vlorentz closed D1777: Limit replayer output to 1 message/min..
Tue, Aug 6, 3:35 PM
vlorentz updated the diff for D1777: Limit replayer output to 1 message/min..

rebase

Tue, Aug 6, 3:35 PM
vlorentz committed rDJNLcc062eabc7ae: Exclude dates outside the range supported by our data model. (authored by vlorentz).
Exclude dates outside the range supported by our data model.
Tue, Aug 6, 3:34 PM
vlorentz closed D1775: Exclude dates outside the range supported by our data model..
Tue, Aug 6, 3:34 PM
vlorentz requested changes to D1503: celery: auto add tasks declared in the swh.workers entry point in task_modules.
Tue, Aug 6, 3:26 PM
vlorentz updated the diff for D1775: Exclude dates outside the range supported by our data model..
  • rebase
  • more doc
  • more tests
  • better warning
Tue, Aug 6, 3:22 PM
vlorentz closed D1773: Convert empty author/committer name/email strings to bytes..
Tue, Aug 6, 2:56 PM
vlorentz committed rDJNL4fbe6f6bb5d8: Convert empty author/committer name/email strings to bytes. (authored by vlorentz).
Convert empty author/committer name/email strings to bytes.
Tue, Aug 6, 2:56 PM
vlorentz updated the diff for D1773: Convert empty author/committer name/email strings to bytes..

rebase

Tue, Aug 6, 2:53 PM
vlorentz committed rDJNL3183a77771ec: Add option --exclude-sha1-file to content-replay. (authored by vlorentz).
Add option --exclude-sha1-file to content-replay.
Tue, Aug 6, 2:52 PM
vlorentz closed D1771: Add option --exclude-sha1-file to content-replay..
Tue, Aug 6, 2:52 PM
vlorentz updated the diff for D1771: Add option --exclude-sha1-file to content-replay..

Fix import path

Tue, Aug 6, 2:46 PM
vlorentz updated the diff for D1771: Add option --exclude-sha1-file to content-replay..

Use SHA1_SIZE constant from swh.model.

Tue, Aug 6, 2:37 PM
vlorentz closed D1816: Add a SHA1_SIZE constant for use by other packages..
Tue, Aug 6, 2:25 PM
vlorentz committed rDMOD56eb29f7addf: Add a SHA1_SIZE constant for use by other packages. (authored by vlorentz).
Add a SHA1_SIZE constant for use by other packages.
Tue, Aug 6, 2:25 PM

Mon, Aug 5

vlorentz updated the task description for T1892: Cassandra as a storage backend (meta-task).
Mon, Aug 5, 3:22 PM · Storage manager
vlorentz updated the task description for T1892: Cassandra as a storage backend (meta-task).
Mon, Aug 5, 3:21 PM · Storage manager
vlorentz committed rDCIDXbaf1fa7fe106: npm: Fix crash on invalid 'author' field. (authored by vlorentz).
npm: Fix crash on invalid 'author' field.
Mon, Aug 5, 3:17 PM
vlorentz closed D1818: npm: Fix crash on invalid 'author' field..
Mon, Aug 5, 3:17 PM
Herald added a reviewer for D1818: npm: Fix crash on invalid 'author' field.: Reviewers.
Mon, Aug 5, 3:15 PM
vlorentz requested changes to D1720: Modify API output and test.

Do you want help with your diff?

Mon, Aug 5, 1:49 PM
vlorentz committed rDJNLc93962e94df9: backfiller: include origin_visit's metadata (authored by douardda).
backfiller: include origin_visit's metadata
Mon, Aug 5, 12:25 PM
vlorentz closed D1788: backfiller: include origin_visit's metadata.
Mon, Aug 5, 12:25 PM
vlorentz commandeered D1788: backfiller: include origin_visit's metadata.
Mon, Aug 5, 12:24 PM
Herald added a reviewer for D1816: Add a SHA1_SIZE constant for use by other packages.: Reviewers.
Mon, Aug 5, 10:56 AM
vlorentz committed rDJNL11fe9d81a3fb: Add function is_hash_in_bytearray. (authored by vlorentz).
Add function is_hash_in_bytearray.
Mon, Aug 5, 10:53 AM
vlorentz closed D1770: Add function is_hash_in_bytearray..
Mon, Aug 5, 10:53 AM
vlorentz committed rDJNL2f09a51de6d2: Add test for the CLI endpoint content_replay. (authored by vlorentz).
Add test for the CLI endpoint content_replay.
Mon, Aug 5, 10:53 AM
vlorentz closed D1769: Add test for the CLI endpoint content_replay..
Mon, Aug 5, 10:53 AM
vlorentz updated subscribers of T1943: Publish swh-graph to PyPI.

ping @zack @haltode

Mon, Aug 5, 10:43 AM · Graph service
vlorentz triaged T1943: Publish swh-graph to PyPI as Unbreak Now! priority.
Mon, Aug 5, 10:42 AM · Graph service
vlorentz accepted D1809: proxmox/terraform: Avoid variables duplication.
Mon, Aug 5, 10:40 AM · System administration
vlorentz accepted D1783: sort requirements files for ease of inspection.
Mon, Aug 5, 10:33 AM
vlorentz accepted D1791: content-replayer: add a bit of resiliency when copying an object.
Mon, Aug 5, 10:33 AM
vlorentz accepted D1790: replayer: make the replayer handle kafka message without 'metadata' field.

My bad, it's in the grandparent diff.

Mon, Aug 5, 10:31 AM
vlorentz requested changes to D1790: replayer: make the replayer handle kafka message without 'metadata' field.

The backfiller should first be fixed to include this field.

Mon, Aug 5, 10:30 AM
vlorentz requested changes to D1789: replayer: ensure the 'type' field of the origin_visit exists.
Mon, Aug 5, 10:28 AM
vlorentz accepted D1672: Add end to end tests for content rendering.
Mon, Aug 5, 10:23 AM

Fri, Jul 26

Herald added a reviewer for D1777: Limit replayer output to 1 message/min.: Reviewers.
Fri, Jul 26, 4:47 PM
vlorentz updated the summary of D1775: Exclude dates outside the range supported by our data model..
Fri, Jul 26, 4:36 PM
vlorentz updated the diff for D1775: Exclude dates outside the range supported by our data model..

fix test data

Fri, Jul 26, 2:22 PM
Herald added a reviewer for D1775: Exclude dates outside the range supported by our data model.: Reviewers.
Fri, Jul 26, 2:00 PM
vlorentz committed rDJNLddc706869180: Run tests with origin ids disabled. (authored by vlorentz).
Run tests with origin ids disabled.
Fri, Jul 26, 1:54 PM
About · Developer information · Legal