- User Since
- Oct 1 2018, 11:23 AM (108 w, 4 d)
rebase (thx for the script)
Tue, Oct 27
Wouldn't it make sense to have this in swh.storage.algos instead?
undo changes to the API return format
Mon, Oct 26
Oh, I guess you meant replacing it to use writer = KafkaJournalWriter[BaseModel](, right?
Sat, Oct 24
Fri, Oct 23
oh yes, my bad. could you add a test for it?
Wouldn't it help the transition to also set an id attribute on instance? (You tell me, I don't know if it's actually used)
wait, what? It would be easier to just use POST everywhere, we just need to change the vault's protocol
Thu, Oct 22
fix pypi json format
or move it to a new file (eg. swh/core/db/db_testing.py), that doesn't get transitively imported by swh-web
Why don't you make the pytest_postgresql import optional in swh-core?
Mon, Oct 19
And it's confusing why compute_hash can't just return self.id; I think I liked it better as a staticmethod.
shouldn't you add -> bytes to all the compute_hash methods?
Are there tests for the backend_factory/backend_class stuff?
Fri, Oct 16
Thanks for the report and sorry for the delay.