Page MenuHomeSoftware Heritage

vlorentz (Valentin Lorentz)
User

Projects

User Details

User Since
Oct 1 2018, 11:23 AM (96 w, 2 d)

Recent Activity

Today

vlorentz accepted D3715: in_memory: Drop dead code.
Wed, Aug 5, 8:15 PM
vlorentz committed rDCORE9a903dc0a527: tarball: add test for permissions. (authored by vlorentz).
tarball: add test for permissions.
Wed, Aug 5, 8:15 PM
vlorentz closed D3714: tarball: add test for permissions..
Wed, Aug 5, 8:15 PM
vlorentz updated the diff for D3714: tarball: add test for permissions..

add comments

Wed, Aug 5, 8:15 PM
vlorentz committed rDSNIPd3760dc4ec64: reproduce-tarball: add support for pristine-zip (authored by vlorentz).
reproduce-tarball: add support for pristine-zip
Wed, Aug 5, 8:02 PM
vlorentz committed rDSNIP4ef44fcaa4d9: reproduce-tarball: add 'checkout' command, useful for debugging (authored by vlorentz).
reproduce-tarball: add 'checkout' command, useful for debugging
Wed, Aug 5, 8:02 PM
vlorentz committed rDSNIPe59e04e9ac8d: reproduce-tarball: don't count loading failures as irreproducibility (authored by vlorentz).
reproduce-tarball: don't count loading failures as irreproducibility
Wed, Aug 5, 8:02 PM
vlorentz committed rDSNIPa29d80c10e22: reproduce-tarball: add --fail-early option (authored by vlorentz).
reproduce-tarball: add --fail-early option
Wed, Aug 5, 8:02 PM
vlorentz created D3714: tarball: add test for permissions..
Wed, Aug 5, 7:49 PM
vlorentz created P736 shutil.unpack_archive drops executable bits.
Wed, Aug 5, 7:14 PM
vlorentz added inline comments to D3713: storage*: content_get_partition(...) -> PagedResult[Content].
Wed, Aug 5, 5:48 PM
vlorentz committed rDPRIZIP6bfa1c009b7a: Reset timestamps in the reference tarball. (authored by vlorentz).
Reset timestamps in the reference tarball.
Wed, Aug 5, 5:30 PM
vlorentz committed rDPRIZIP62bda3836b71: Remove output files instead of crashing when they already exist. (authored by vlorentz).
Remove output files instead of crashing when they already exist.
Wed, Aug 5, 5:29 PM
vlorentz committed rDPRIZIP1082d824c5e8: Rename 'compress' module to 'reference'. (authored by vlorentz).
Rename 'compress' module to 'reference'.
Wed, Aug 5, 5:29 PM
vlorentz committed rDPRIZIP78bbf12e56cb: Fix checksum checking. (authored by vlorentz).
Fix checksum checking.
Wed, Aug 5, 5:29 PM
vlorentz committed rDSNIP22bc8aaaac8d: reproduce-tarball: fix typo (authored by vlorentz).
reproduce-tarball: fix typo
Wed, Aug 5, 5:29 PM
vlorentz committed rDPRIZIP5865e93a4e10: Add support for multiple entries at root. (authored by vlorentz).
Add support for multiple entries at root.
Wed, Aug 5, 4:25 PM
vlorentz committed rDPRIZIP758e031a66d6: Add md5 checksum on the reference tarball. (authored by vlorentz).
Add md5 checksum on the reference tarball.
Wed, Aug 5, 4:25 PM
vlorentz committed rDPRIZIPc6af4a977ede: Initial implementation of pristine-zip. (authored by vlorentz).
Initial implementation of pristine-zip.
Wed, Aug 5, 3:55 PM
vlorentz accepted D3712: storage*: Drop deprecated content_get_range endpoint.
Wed, Aug 5, 3:32 PM
vlorentz accepted D3710: storage*: snapshot_*: Type remaining existing endpoints.
Wed, Aug 5, 2:39 PM
vlorentz accepted D3708: storage*: origin_get_by_sha1: Drop generator from pgstorage.
Wed, Aug 5, 12:47 PM
vlorentz accepted D3709: storage*: release_*: Type remaining existing endpoints.
Wed, Aug 5, 12:43 PM
vlorentz accepted D3707: storage*: revision_*: Type remaining existing endpoints.
Wed, Aug 5, 11:00 AM
vlorentz added inline comments to D3707: storage*: revision_*: Type remaining existing endpoints.
Wed, Aug 5, 10:39 AM
vlorentz accepted D3707: storage*: revision_*: Type remaining existing endpoints.
Wed, Aug 5, 10:24 AM
vlorentz accepted D3698: storage*: origin_get_by_sha1: Type remaining existing endpoints.
Wed, Aug 5, 10:22 AM
vlorentz added inline comments to D3707: storage*: revision_*: Type remaining existing endpoints.
Wed, Aug 5, 9:45 AM
vlorentz accepted D3697: storage*: check_config: Type remaining existing endpoints.
Wed, Aug 5, 9:07 AM
vlorentz requested changes to D3707: storage*: revision_*: Type remaining existing endpoints.
Wed, Aug 5, 9:07 AM
vlorentz added inline comments to D3707: storage*: revision_*: Type remaining existing endpoints.
Wed, Aug 5, 9:07 AM
vlorentz accepted D3706: storage*: directory_*: Type remaining existing endpoints.
Wed, Aug 5, 9:03 AM
vlorentz accepted D3705: storage*: skipped_content_missing: Type remaining existing endpoints.
Wed, Aug 5, 9:01 AM
vlorentz accepted D3704: storage*: content_missing_per_sha1(_git): Type remaining existing endpoints.
Wed, Aug 5, 9:01 AM
vlorentz accepted D3703: storage*: content_missing: Unify and type remaining existing endpoints.
Wed, Aug 5, 9:00 AM
vlorentz accepted D3702: storage*: content_get_partition: Type remaining existing endpoints.
Wed, Aug 5, 8:59 AM
vlorentz accepted D3701: storage*: content_get_range: Type remaining existing endpoints.
Wed, Aug 5, 8:58 AM
vlorentz added inline comments to D3698: storage*: origin_get_by_sha1: Type remaining existing endpoints.
Wed, Aug 5, 8:58 AM
vlorentz accepted D3700: storage*: content_get: Type remaining existing endpoints.

FYI, renaming from content to contents will break the RPC, so you'll have to update clients and server at the same time.

Wed, Aug 5, 8:56 AM
vlorentz accepted D3699: storage*: content_update: Type remaining existing endpoints.
Wed, Aug 5, 8:54 AM
vlorentz added inline comments to D3698: storage*: origin_get_by_sha1: Type remaining existing endpoints.
Wed, Aug 5, 8:53 AM
vlorentz added inline comments to D3693: service: Adapt according to the latest storage.content_find changes.
Wed, Aug 5, 8:47 AM

Yesterday

vlorentz added inline comments to D3693: service: Adapt according to the latest storage.content_find changes.
Tue, Aug 4, 2:47 PM
vlorentz accepted D3695: templates: Fix browsed object metadata availability from javascript.
Tue, Aug 4, 1:28 PM
vlorentz accepted D3694: tests: Improve coverage on `directory_ls` endpoints.

s/up to the contents/down to contents/ in your commit message

Tue, Aug 4, 1:26 PM
vlorentz committed rDSNIP02aaf68c8334: reproduce-tarball: improve readability (authored by vlorentz).
reproduce-tarball: improve readability
Tue, Aug 4, 12:09 PM
vlorentz committed rDSNIP5be0a7959261: reproduce-tarball: get rid of tarball headers, fully use pristine-tar. (authored by vlorentz).
reproduce-tarball: get rid of tarball headers, fully use pristine-tar.
Tue, Aug 4, 12:06 PM
vlorentz committed rDSNIP3a8baa2e0f7a: reproduce-tarball: attempt at reading and writing tarballs directly, without… (authored by vlorentz).
reproduce-tarball: attempt at reading and writing tarballs directly, without…
Tue, Aug 4, 11:09 AM

Mon, Aug 3

vlorentz committed rDSNIP0b7af7440bf2: reproduce-tarball: attempt at using pristine-gz. (authored by vlorentz).
reproduce-tarball: attempt at using pristine-gz.
Mon, Aug 3, 7:06 PM
vlorentz committed rDLDBASE9ee03fb539fc: archive: fix docstring (authored by vlorentz).
archive: fix docstring
Mon, Aug 3, 6:20 PM
vlorentz closed D3688: archive: fix docstring.
Mon, Aug 3, 6:20 PM
vlorentz updated the diff for D3688: archive: fix docstring.

rebase

Mon, Aug 3, 6:20 PM
vlorentz committed rDSNIPb8c348a0a922: reproduce-tarball: don't store files, it was the loader's job. (authored by vlorentz).
reproduce-tarball: don't store files, it was the loader's job.
Mon, Aug 3, 6:19 PM
vlorentz committed rDSNIPf46bc146dfc1: reproduce-tarball: pass magic number in metadata. (authored by vlorentz).
reproduce-tarball: pass magic number in metadata.
Mon, Aug 3, 6:19 PM
vlorentz committed rDSNIPdfb9edddd6af: reproduce-tarball: add warning about sparse files (authored by vlorentz).
reproduce-tarball: add warning about sparse files
Mon, Aug 3, 6:18 PM
vlorentz committed rDSNIP6addfa20c854: reproduce-tarball: fix --diffoscope (authored by vlorentz).
reproduce-tarball: fix --diffoscope
Mon, Aug 3, 6:18 PM
vlorentz accepted D3687: storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git.
Mon, Aug 3, 5:58 PM
vlorentz accepted D3689: nixguix: Fix format issue in error message.
Mon, Aug 3, 5:57 PM
vlorentz accepted D3690: nixguix: Align error message formatting using f-string.
Mon, Aug 3, 5:57 PM
vlorentz accepted D3691: nixguix: Fix docstring.
Mon, Aug 3, 5:57 PM
vlorentz committed rDSNIP74fe8a9981a1: reproduce-tarball: add 'many' subcommand (authored by vlorentz).
reproduce-tarball: add 'many' subcommand
Mon, Aug 3, 4:39 PM
vlorentz committed rDSNIP9a52fe141d23: reproduce-tarball: Switch to click (authored by vlorentz).
reproduce-tarball: Switch to click
Mon, Aug 3, 4:39 PM
vlorentz committed rDSNIP10ade7a47aa7: reproduce-tarball: Move file comparison to its own function. (authored by vlorentz).
reproduce-tarball: Move file comparison to its own function.
Mon, Aug 3, 4:30 PM
vlorentz committed rDSNIPd80ab8c9787d: reproduce-tarball: Always compare before running diffoscope. (authored by vlorentz).
reproduce-tarball: Always compare before running diffoscope.
Mon, Aug 3, 4:28 PM
vlorentz committed rDSNIPe407bd872f20: reproduce-tarball: Make the target file arg optional, run diffoscope if it's… (authored by vlorentz).
reproduce-tarball: Make the target file arg optional, run diffoscope if it's…
Mon, Aug 3, 4:25 PM
vlorentz committed rDSNIP89548c77e7d7: reproduce-tarball: break on success. (authored by vlorentz).
reproduce-tarball: break on success.
Mon, Aug 3, 4:25 PM
vlorentz committed rDSNIP2326c10567b5: reproduce-tarball: add BufPreservingTarInfo, which doesn't decode and reencode… (authored by vlorentz).
reproduce-tarball: add BufPreservingTarInfo, which doesn't decode and reencode…
Mon, Aug 3, 4:25 PM
vlorentz committed rDSNIPa4d4ab308f03: Start writing reproduce-tarball.py (authored by vlorentz).
Start writing reproduce-tarball.py
Mon, Aug 3, 3:47 PM
vlorentz added a comment to D3687: storage*: Type {cnt,dir,rev,rel,snp}_get_random(...) -> Sha1Git.

Could you return Sha1Git instead? (It's an alias of bytes for now, so it doesn't matter that much)

Mon, Aug 3, 2:40 PM
vlorentz created D3688: archive: fix docstring.
Mon, Aug 3, 2:08 PM
vlorentz accepted D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.
Mon, Aug 3, 12:24 PM
vlorentz added inline comments to D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.
Mon, Aug 3, 12:14 PM
vlorentz accepted D3681: storage*: Drop origin-get-range in favor of origin-list.
Mon, Aug 3, 11:47 AM
vlorentz added inline comments to D3681: storage*: Drop origin-get-range in favor of origin-list.
Mon, Aug 3, 11:47 AM
vlorentz committed rDSEAcd790375d893: Fix test_cli.invoke for old PyYAML versions (such as 3.13, in Debian 10). (authored by vlorentz).
Fix test_cli.invoke for old PyYAML versions (such as 3.13, in Debian 10).
Mon, Aug 3, 11:46 AM
vlorentz closed D3686: Fix test_cli.invoke for old PyYAML versions (such as 3.13, in Debian 10)..
Mon, Aug 3, 11:46 AM
vlorentz committed rDLDBASE614329b7ebaf: Convert the 'metadata' and 'info' cached-properties/lazy-attributes into… (authored by vlorentz).
Convert the 'metadata' and 'info' cached-properties/lazy-attributes into…
Mon, Aug 3, 11:44 AM
vlorentz closed D3679: Convert the 'metadata' and 'info' cached-properties/lazy-attributes into methods..
Mon, Aug 3, 11:44 AM
vlorentz created D3686: Fix test_cli.invoke for old PyYAML versions (such as 3.13, in Debian 10)..
Mon, Aug 3, 11:43 AM
vlorentz added inline comments to D3681: storage*: Drop origin-get-range in favor of origin-list.
Mon, Aug 3, 11:21 AM
vlorentz accepted D3684: swh.search.get_search: Simplify instantiation.
Mon, Aug 3, 10:35 AM
vlorentz accepted D3685: swh.search: Define an interface for search backends and use it.
Mon, Aug 3, 10:34 AM
vlorentz requested changes to D3684: swh.search.get_search: Simplify instantiation.
Mon, Aug 3, 10:09 AM
vlorentz added a revision to T2512: Make all loaders write their extrinsic metadata to the appropriate storage: D3677: pypi: Load the content of the API's response as extrinsic snapshot metadata..
Mon, Aug 3, 10:03 AM · Metadata workflow, Restricted Project
vlorentz added a task to D3677: pypi: Load the content of the API's response as extrinsic snapshot metadata.: T2512: Make all loaders write their extrinsic metadata to the appropriate storage.
Mon, Aug 3, 10:03 AM
vlorentz added a comment to D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.

I was thinking of print(), but that would work too

Mon, Aug 3, 9:56 AM
vlorentz requested changes to D3685: swh.search: Define an interface for search backends and use it.

You can remove docstrings from elasticsearch.py.

Mon, Aug 3, 9:17 AM
vlorentz accepted D3684: swh.search.get_search: Simplify instantiation.

great, thanks

Mon, Aug 3, 9:14 AM
vlorentz accepted D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.

It would be nice to print the token from time to time so the process can be resumed if interrupted, but that's good enough for now

Mon, Aug 3, 9:13 AM
vlorentz requested changes to D3681: storage*: Drop origin-get-range in favor of origin-list.
Mon, Aug 3, 9:11 AM
vlorentz added inline comments to D3681: storage*: Drop origin-get-range in favor of origin-list.
Mon, Aug 3, 9:10 AM
vlorentz accepted D3675: origin: Migrate use to storage.origin_list instead of origin_get_range.
Mon, Aug 3, 9:07 AM

Sat, Aug 1

vlorentz added a comment to D3683: storage.in_memory: Fix origin_list implementation.

then that's not a bug. The order of results of origin_list is not guaranteed to be the order of insertion. Providing this property is equivalent to having numeric origin ids.

Sat, Aug 1, 2:58 PM
vlorentz added a comment to D3683: storage.in_memory: Fix origin_list implementation.

I don't understand what the issue was. Could you add a test that triggers it?

Sat, Aug 1, 1:28 PM
vlorentz accepted D3680: storage*: Do not allow unknown visit status in origin_visit*_get_latest.
Sat, Aug 1, 1:25 PM
vlorentz added inline comments to D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.
Sat, Aug 1, 10:37 AM
vlorentz added inline comments to D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.
Sat, Aug 1, 10:33 AM
vlorentz added a comment to D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.

And if

Sat, Aug 1, 10:09 AM
vlorentz added inline comments to D3682: cli.task: Migrate scheduler cli to latest storage change on iter_origins.
Sat, Aug 1, 10:08 AM

Fri, Jul 31

vlorentz added inline comments to D3675: origin: Migrate use to storage.origin_list instead of origin_get_range.
Fri, Jul 31, 10:52 PM