Page MenuHomeSoftware Heritage

vlorentz (Valentin Lorentz)
User

User Details

User Since
Oct 1 2018, 11:23 AM (108 w, 4 d)

Recent Activity

Yesterday

vlorentz added inline comments to D4346: package loaders: write extrinsic metadata to directories instead of revisions..
Thu, Oct 29, 11:19 AM
vlorentz updated the diff for D4349: migrate_extrinsic_metadata: Write metadata on directories instead of revisions..

rebase (thx for the script)

Thu, Oct 29, 11:15 AM
vlorentz updated the diff for D4347: package loaders: write original_artifact metadata to directories instead of revisions..

rebase

Thu, Oct 29, 11:10 AM
vlorentz updated the diff for D4346: package loaders: write extrinsic metadata to directories instead of revisions..

rebase

Thu, Oct 29, 11:10 AM
vlorentz updated the diff for D4347: package loaders: write original_artifact metadata to directories instead of revisions..

rebase

Thu, Oct 29, 11:09 AM
vlorentz updated the diff for D4346: package loaders: write extrinsic metadata to directories instead of revisions..

fix names

Thu, Oct 29, 11:09 AM
vlorentz added inline comments to D4347: package loaders: write original_artifact metadata to directories instead of revisions..
Thu, Oct 29, 11:08 AM

Tue, Oct 27

vlorentz closed T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3 as Resolved.
Tue, Oct 27, 2:59 PM · Web app
vlorentz committed rDWAPPS3ffeb396fa10: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0. (authored by vlorentz).
lookup_content_license: Fix crash with swh.storage.indexer v0.3.0.
Tue, Oct 27, 2:59 PM
vlorentz closed D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..
Tue, Oct 27, 2:59 PM
vlorentz added a comment to D4356: common/archive: Avoid db timeouts in lookup_snapshot_sizes.

Wouldn't it make sense to have this in swh.storage.algos instead?

Tue, Oct 27, 11:09 AM
vlorentz updated the diff for D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..

undo changes to the API return format

Tue, Oct 27, 10:58 AM
vlorentz accepted D4348: Rename the RawExtrinsicMetadata id field to target.
Tue, Oct 27, 10:35 AM

Mon, Oct 26

vlorentz added a task to D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0.: T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3.
Mon, Oct 26, 4:49 PM
vlorentz added a revision to T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3: D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..
Mon, Oct 26, 4:49 PM · Web app
vlorentz edited reviewers for D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0., added: anlambert; removed: Reviewers.
Mon, Oct 26, 4:41 PM
vlorentz created D4355: lookup_content_license: Fix crash with swh.storage.indexer v0.3.0..
Mon, Oct 26, 4:40 PM
vlorentz claimed T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3.
Mon, Oct 26, 4:40 PM · Web app
vlorentz committed rDWAPPSd1643344e5e5: Remove requests to 'idx_storage.content_language_get'. (authored by vlorentz).
Remove requests to 'idx_storage.content_language_get'.
Mon, Oct 26, 4:27 PM
vlorentz closed D4353: Remove requests to 'idx_storage.content_language_get'..
Mon, Oct 26, 4:27 PM
vlorentz added a revision to T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3: D4353: Remove requests to 'idx_storage.content_language_get'..
Mon, Oct 26, 2:40 PM · Web app
vlorentz created D4353: Remove requests to 'idx_storage.content_language_get'..
Mon, Oct 26, 2:40 PM
vlorentz added a comment to D4082: Make the type of values of JournalWriter generic, so it works with types not from swh-model..

Oh, I guess you meant replacing it to use writer = KafkaJournalWriter[BaseModel](, right?

Mon, Oct 26, 12:37 PM
vlorentz added a comment to D4082: Make the type of values of JournalWriter generic, so it works with types not from swh-model..

Looks like the only user of the KafkaJournalWriter class outside the journal is swh.objstorage.replayer, which would be impacted by this diff (unless I'm mistaken) but this is indeed a minor issue.

Mon, Oct 26, 12:35 PM
vlorentz added a task to D4080: Make value_sanitizer an argument of JournalWriter.: T2651: Make the index-storage publish its rows to Kafka.
Mon, Oct 26, 9:31 AM
vlorentz added a task to D4082: Make the type of values of JournalWriter generic, so it works with types not from swh-model.: T2651: Make the index-storage publish its rows to Kafka.
Mon, Oct 26, 9:31 AM
vlorentz added revisions to T2651: Make the index-storage publish its rows to Kafka: D4080: Make value_sanitizer an argument of JournalWriter., D4082: Make the type of values of JournalWriter generic, so it works with types not from swh-model..
Mon, Oct 26, 9:31 AM · Indexer

Sat, Oct 24

vlorentz triaged T2729: lookup_content_license and lookup_content_language fail since swh.indexer.storage v0.3 as Unbreak Now! priority.
Sat, Oct 24, 1:14 PM · Web app

Fri, Oct 23

vlorentz added a comment to D4348: Rename the RawExtrinsicMetadata id field to target.

oh yes, my bad. could you add a test for it?

Fri, Oct 23, 6:23 PM
vlorentz added a comment to D4348: Rename the RawExtrinsicMetadata id field to target.

Wouldn't it help the transition to also set an id attribute on instance? (You tell me, I don't know if it's actually used)

Fri, Oct 23, 5:33 PM
vlorentz added a task to D4349: migrate_extrinsic_metadata: Write metadata on directories instead of revisions.: T2668: Package loaders should write extrinsic metadata on directories instead of revisions/releases.
Fri, Oct 23, 5:26 PM
vlorentz added a revision to T2668: Package loaders should write extrinsic metadata on directories instead of revisions/releases: D4349: migrate_extrinsic_metadata: Write metadata on directories instead of revisions..
Fri, Oct 23, 5:26 PM · Package Loader, Storage manager, Extrinsic metadata
vlorentz created D4349: migrate_extrinsic_metadata: Write metadata on directories instead of revisions..
Fri, Oct 23, 5:26 PM
vlorentz added a task to D4346: package loaders: write extrinsic metadata to directories instead of revisions.: T2668: Package loaders should write extrinsic metadata on directories instead of revisions/releases.
Fri, Oct 23, 5:01 PM
vlorentz added a task to D4347: package loaders: write original_artifact metadata to directories instead of revisions.: T2668: Package loaders should write extrinsic metadata on directories instead of revisions/releases.
Fri, Oct 23, 5:01 PM
vlorentz added revisions to T2668: Package loaders should write extrinsic metadata on directories instead of revisions/releases: D4346: package loaders: write extrinsic metadata to directories instead of revisions., D4347: package loaders: write original_artifact metadata to directories instead of revisions..
Fri, Oct 23, 5:01 PM · Package Loader, Storage manager, Extrinsic metadata
vlorentz created D4347: package loaders: write original_artifact metadata to directories instead of revisions..
Fri, Oct 23, 5:01 PM
vlorentz updated the summary of D4346: package loaders: write extrinsic metadata to directories instead of revisions..
Fri, Oct 23, 4:54 PM
vlorentz created D4346: package loaders: write extrinsic metadata to directories instead of revisions..
Fri, Oct 23, 4:53 PM
vlorentz added a comment to D4341: rpc_client: Allow http method declaration consistently with the rpc server.

wait, what? It would be easier to just use POST everywhere, we just need to change the vault's protocol

Fri, Oct 23, 12:24 PM
vlorentz accepted D4339: fuse: use debug level instead of error when returning ENOENT.
Fri, Oct 23, 11:56 AM
vlorentz added inline comments to D4330: Allow vault configuration without the args indirection.
Fri, Oct 23, 11:55 AM
vlorentz added inline comments to D4330: Allow vault configuration without the args indirection.
Fri, Oct 23, 11:54 AM
vlorentz committed rDSTO474ee72b070b: --amend (authored by vlorentz).
--amend
Fri, Oct 23, 11:11 AM
vlorentz closed D4335: migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API..
Fri, Oct 23, 11:11 AM
vlorentz committed rDSTOeb3952f3226b: migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names… (authored by vlorentz).
migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names…
Fri, Oct 23, 11:11 AM
vlorentz committed rDSTOb1a3b80f8eff: migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function. (authored by vlorentz).
migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function.
Fri, Oct 23, 11:11 AM
vlorentz closed D4334: migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function..
Fri, Oct 23, 11:11 AM
vlorentz added inline comments to D4335: migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API..
Fri, Oct 23, 11:11 AM

Thu, Oct 22

vlorentz updated the diff for D4335: migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API..

fix pypi json format

Thu, Oct 22, 10:35 PM
vlorentz added a comment to D4332: requirements-swh: Bump requirements to fix webapp build.

or move it to a new file (eg. swh/core/db/db_testing.py), that doesn't get transitively imported by swh-web

Thu, Oct 22, 4:28 PM
vlorentz added a comment to D4332: requirements-swh: Bump requirements to fix webapp build.

Why don't you make the pytest_postgresql import optional in swh-core?

Thu, Oct 22, 4:27 PM
vlorentz updated the diff for D4335: migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API..

rebase

Thu, Oct 22, 4:23 PM
vlorentz updated the diff for D4334: migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function..

fix type

Thu, Oct 22, 4:22 PM
vlorentz created D4335: migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API..
Thu, Oct 22, 4:20 PM
vlorentz created D4334: migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function..
Thu, Oct 22, 4:17 PM
vlorentz accepted D4295: Add types and tests on configuration checks.
Thu, Oct 22, 2:34 PM
vlorentz accepted D4329: vault.server: Introduce typed VaultInterface.
Thu, Oct 22, 2:20 PM
vlorentz added a comment to D4080: Make value_sanitizer an argument of JournalWriter..
In D4080#107053, @olasd wrote:

I'm not a fan of the sanitizer name (I know I probably introduced it :P). Something along the lines of object_filter may be more appropriate?

Thu, Oct 22, 1:21 PM
vlorentz added a comment to D4082: Make the type of values of JournalWriter generic, so it works with types not from swh-model..

Wouldn't it make a bit easier to name the generic version of the journal writer something like GenericKafkaJournalWriter and have KafkaJournalWriter = GenericKafkaJournalWriter[BaseModel] ? (for bw compat)

Thu, Oct 22, 1:14 PM
vlorentz committed rDSTOaeb72c71d007: migrate_extrinsic_metadata: add support for guix revisions (authored by vlorentz).
migrate_extrinsic_metadata: add support for guix revisions
Thu, Oct 22, 1:12 PM
vlorentz closed D4326: migrate_extrinsic_metadata: add support for guix revisions.
Thu, Oct 22, 1:12 PM
vlorentz committed rDSTO73dc5e32ed0d: migrate_extrinsic_metadata: allow deposits with 'id' missing from their… (authored by vlorentz).
migrate_extrinsic_metadata: allow deposits with 'id' missing from their…
Thu, Oct 22, 1:12 PM
vlorentz closed D4325: migrate_extrinsic_metadata: allow deposits with 'id' missing from their metadata..
Thu, Oct 22, 1:12 PM
vlorentz committed rDSTOc48306642bf1: migrate_extrinsic_metadata: add support for guessing the origin of more PyPI… (authored by vlorentz).
migrate_extrinsic_metadata: add support for guessing the origin of more PyPI…
Thu, Oct 22, 1:12 PM
vlorentz closed D4324: migrate_extrinsic_metadata: add support for guessing the origin of more PyPI packages from filenames..
Thu, Oct 22, 1:12 PM
vlorentz accepted D4299: asynchronous.RPCServerApp: Align implementation with api.RPCServerApp.
Thu, Oct 22, 1:12 PM
vlorentz created D4326: migrate_extrinsic_metadata: add support for guix revisions.
Thu, Oct 22, 12:33 PM
vlorentz created D4325: migrate_extrinsic_metadata: allow deposits with 'id' missing from their metadata..
Thu, Oct 22, 12:32 PM
vlorentz created D4324: migrate_extrinsic_metadata: add support for guessing the origin of more PyPI packages from filenames..
Thu, Oct 22, 12:27 PM
vlorentz accepted D4323: storage.pytest_plugin: Reuse swh.core.db.db_utils postgresql_fact.
Thu, Oct 22, 12:24 PM
vlorentz accepted D4322: scheduler.pytest_plugin: Make scheduler tests faster.
Thu, Oct 22, 12:23 PM
vlorentz accepted D4310: vault.tests: Make postgresql fixture faster.
Thu, Oct 22, 10:54 AM
vlorentz accepted D4300: Install postgresql_fact fixture for faster postgres tests.
Thu, Oct 22, 10:53 AM
vlorentz accepted D4307: Update the HashableObject interface to take the object itself.
Thu, Oct 22, 10:47 AM

Mon, Oct 19

vlorentz added a comment to D4307: Update the HashableObject interface to take the object itself.
In D4307#107125, @olasd wrote:

And it's confusing why compute_hash can't just return self.id; I think I liked it better as a staticmethod.

Is it? It's an initialization method that's mostly used when you don't have a self.id.

Mon, Oct 19, 5:51 PM
vlorentz added a comment to D4307: Update the HashableObject interface to take the object itself.

And it's confusing why compute_hash can't just return self.id; I think I liked it better as a staticmethod.

Mon, Oct 19, 5:40 PM
vlorentz added a comment to D4307: Update the HashableObject interface to take the object itself.

shouldn't you add -> bytes to all the compute_hash methods?

Mon, Oct 19, 5:39 PM
vlorentz accepted D4305: api.server: Drop the % in the error message.
Mon, Oct 19, 5:36 PM
vlorentz added inline comments to D4299: asynchronous.RPCServerApp: Align implementation with api.RPCServerApp.
Mon, Oct 19, 4:28 PM
vlorentz planned changes to D4083: [WIP] start writing to the journal from the idx-storage.
Mon, Oct 19, 2:34 PM
vlorentz updated the diff for D4083: [WIP] start writing to the journal from the idx-storage.

rebase

Mon, Oct 19, 2:34 PM
vlorentz retitled D4082: Make the type of values of JournalWriter generic, so it works with types not from swh-model. from [WIP] Make the type of values of JournalWriter generic, so it works with types not from swh-model. to Make the type of values of JournalWriter generic, so it works with types not from swh-model..
Mon, Oct 19, 2:02 PM
vlorentz retitled D4080: Make value_sanitizer an argument of JournalWriter. from [WIP] Make value_sanitizer an argument of JournalWriter. to Make value_sanitizer an argument of JournalWriter..
Mon, Oct 19, 2:02 PM
vlorentz updated the diff for D4082: Make the type of values of JournalWriter generic, so it works with types not from swh-model..

rebase

Mon, Oct 19, 2:02 PM
vlorentz updated the diff for D4080: Make value_sanitizer an argument of JournalWriter..

rebase

Mon, Oct 19, 2:01 PM
vlorentz added a comment to D4299: asynchronous.RPCServerApp: Align implementation with api.RPCServerApp.

Are there tests for the backend_factory/backend_class stuff?

Mon, Oct 19, 1:20 PM
vlorentz accepted D4298: api.tests.test_async: Simplify fixture setup.
Mon, Oct 19, 12:44 PM
vlorentz requested changes to D4295: Add types and tests on configuration checks.
Mon, Oct 19, 12:43 PM
vlorentz accepted D4294: swh.vault: Unify get_vault factory function with other factories.
Mon, Oct 19, 12:41 PM
vlorentz accepted D4290: docker/conf: Migrate configuration to the latest schema change.
Mon, Oct 19, 12:39 PM
vlorentz accepted D4288: storage.api.server: Add type to load_and_check_function and refactor tests.
Mon, Oct 19, 12:38 PM
vlorentz added inline comments to D4300: Install postgresql_fact fixture for faster postgres tests.
Mon, Oct 19, 12:36 PM

Fri, Oct 16

vlorentz committed rDDEP7cc8d3299e37: spec-technical: Add 'partial' self-loop + annotate transitions in the status… (authored by vlorentz).
spec-technical: Add 'partial' self-loop + annotate transitions in the status…
Fri, Oct 16, 6:21 PM
vlorentz closed D4283: spec-technical: Add 'partial' self-loop + annotate transitions in the status diagram.
Fri, Oct 16, 6:21 PM
vlorentz committed rDDEPefda75628fb1: spec-technical: Rewrite state diagram using Plantuml. (authored by vlorentz).
spec-technical: Rewrite state diagram using Plantuml.
Fri, Oct 16, 6:20 PM
vlorentz closed D4281: spec-technical: Rewrite state diagram using Plantuml..
Fri, Oct 16, 6:20 PM
vlorentz added projects to T2666: GitHub releases not available in record: Data Model, Git loader.
Fri, Oct 16, 2:28 PM · Git loader, Data Model
vlorentz added a comment to T2666: GitHub releases not available in record.

Thanks for the report and sorry for the delay.

Fri, Oct 16, 2:26 PM · Git loader, Data Model
vlorentz merged T2666: GitHub releases not available in record into T2059: Generate (swh) releases from all git tags.
Fri, Oct 16, 2:26 PM · Git loader