Page MenuHomeSoftware Heritage

vlorentz (Valentin Lorentz)
User

Projects

User Details

User Since
Oct 1 2018, 11:23 AM (55 w, 2 d)

Recent Activity

Sun, Oct 20

vlorentz accepted D2147: lister.gnu: Standardize arguments to pass to the loader tar.
Sun, Oct 20, 8:56 PM · Origin-GNU, Lister

Fri, Oct 18

vlorentz added a comment to D2147: lister.gnu: Standardize arguments to pass to the loader tar.

I don't think this regexp is the right solution, it's quite fragile in case a package name uses one of the keywords.

Yes, it's fragile and we don't see any better solution right now.
That's how we did it initially, we improved the current version to be a tad better though.
And also it's tested even if it's limited.

A possible solution is for get_version to only accept URLs, and split the path to find the package name.

I'm not getting the difference with the current implem.
filename is extracted from the uri in any case...

Fri, Oct 18, 3:01 PM · Origin-GNU, Lister
vlorentz added inline comments to D2147: lister.gnu: Standardize arguments to pass to the loader tar.
Fri, Oct 18, 2:45 PM · Origin-GNU, Lister
vlorentz requested changes to D2147: lister.gnu: Standardize arguments to pass to the loader tar.

I don't think this regexp is the right solution, it's quite fragile in case a package name uses one of the keywords. A possible solution is for get_version to only accept URLs, and split the path to find the package name.

Fri, Oct 18, 2:25 PM · Origin-GNU, Lister
vlorentz accepted D2160: Don't export origin_visit['origin']['type'].
Fri, Oct 18, 1:44 PM
vlorentz added a comment to D2159: model: Don't export origin['type'].

I'm not sure that's a good idea. What about this:

Fri, Oct 18, 1:17 PM
vlorentz updated the diff for D2157: Stop supporting origin ids in API (except in origin_get_range)..

fix argument names in API client.

Fri, Oct 18, 11:43 AM
vlorentz updated the diff for D2157: Stop supporting origin ids in API (except in origin_get_range)..
  • update docstrings as requested
  • add migration script
Fri, Oct 18, 11:31 AM
vlorentz added inline comments to D2157: Stop supporting origin ids in API (except in origin_get_range)..
Fri, Oct 18, 11:25 AM
vlorentz committed rDENV8c58590b65d1: Add swh-search to .mrconfig (authored by vlorentz).
Add swh-search to .mrconfig
Fri, Oct 18, 11:20 AM
vlorentz closed D2129: Add swh-search to .mrconfig.
Fri, Oct 18, 11:20 AM

Thu, Oct 17

vlorentz abandoned D2089: [WIP]Remove origin ids..

I forgot I made this diff... so I did a new one from scratch: D2157

Thu, Oct 17, 10:07 PM
vlorentz updated the diff for D2157: Stop supporting origin ids in API (except in origin_get_range)..

rebase

Thu, Oct 17, 7:05 PM
vlorentz created D2157: Stop supporting origin ids in API (except in origin_get_range)..
Thu, Oct 17, 7:04 PM
vlorentz abandoned D2154: Make the 'origin' key of visits a string instead of an object..
Thu, Oct 17, 4:54 PM
vlorentz updated the diff for D2154: Make the 'origin' key of visits a string instead of an object..

add missing changes

Thu, Oct 17, 4:37 PM
vlorentz accepted D2151: Remove useless origin visits from snapshot-only tests.
Thu, Oct 17, 4:14 PM
vlorentz created D2154: Make the 'origin' key of visits a string instead of an object..
Thu, Oct 17, 4:06 PM
vlorentz accepted D2153: Remove origin_visit_add fallback for type=None.
Thu, Oct 17, 3:50 PM
vlorentz added a comment to D2153: Remove origin_visit_add fallback for type=None.

👍

Thu, Oct 17, 3:50 PM
vlorentz accepted D2152: Always use explicit visit type in origin_visit_add.
Thu, Oct 17, 3:50 PM
vlorentz accepted D2150: Remove now-useless triggers.

I'm told these are already deleted in prod

Thu, Oct 17, 3:50 PM
vlorentz added a comment to D2150: Remove now-useless triggers.

and schema upgrade

Thu, Oct 17, 3:48 PM
vlorentz requested changes to D2150: Remove now-useless triggers.

Needs a migration script

Thu, Oct 17, 3:48 PM
vlorentz accepted D2149: Move systemd-python to an optional logging subpackage.
Thu, Oct 17, 3:47 PM
vlorentz accepted D2137: schemata: Send only origin url for scheduling debian loader tasks.
Thu, Oct 17, 3:29 PM
vlorentz accepted D2138: loader.debian: Send only the origin url instead of the origin dict.
Thu, Oct 17, 3:14 PM
vlorentz requested changes to D2137: schemata: Send only origin url for scheduling debian loader tasks.

Could you add a test?

Thu, Oct 17, 3:13 PM
vlorentz committed rDSTOfbdad1cabb9d: Remove fetch_history. (authored by vlorentz).
Remove fetch_history.
Thu, Oct 17, 3:02 PM
vlorentz closed D2148: Remove fetch_history..
Thu, Oct 17, 3:02 PM
vlorentz updated the diff for D2148: Remove fetch_history..

rebase

Thu, Oct 17, 3:01 PM
vlorentz updated the diff for D2148: Remove fetch_history..

add migration

Thu, Oct 17, 2:58 PM
vlorentz planned changes to D2148: Remove fetch_history..
Thu, Oct 17, 2:55 PM
vlorentz created D2148: Remove fetch_history..
Thu, Oct 17, 2:50 PM
vlorentz accepted D2134: debian.lister: Add integration test which checks scheduled tasks.
Thu, Oct 17, 2:12 PM

Tue, Oct 15

vlorentz committed rDCIDX1d625af0ba1e: Add a command-line tool to run metadata translation. (authored by vlorentz).
Add a command-line tool to run metadata translation.
Tue, Oct 15, 2:50 PM
vlorentz closed D2141: Add a command-line too to run metadata translation..
Tue, Oct 15, 2:50 PM
vlorentz created P549 Origins with a codemeta.json at root.
Tue, Oct 15, 2:49 PM
vlorentz added a comment to D2141: Add a command-line too to run metadata translation..

Because I messed up git. Removed

Tue, Oct 15, 2:33 PM
vlorentz updated the diff for D2141: Add a command-line too to run metadata translation..
  • remove print
  • remove stuff that wasn't supposed to be committed
Tue, Oct 15, 2:33 PM
vlorentz accepted D2143: base/Dockerfile: Add missing libffi-dev dependency for swh-indexer.
Tue, Oct 15, 2:19 PM
vlorentz created D2141: Add a command-line too to run metadata translation..
Tue, Oct 15, 1:37 PM

Mon, Oct 14

vlorentz accepted D2090: tests: refactor main storage tests.
Mon, Oct 14, 1:19 PM
vlorentz accepted D2119: test_api_client: refactor the code for new pytest based infra.
Mon, Oct 14, 1:18 PM
vlorentz added inline comments to D2119: test_api_client: refactor the code for new pytest based infra.
Mon, Oct 14, 12:26 PM
vlorentz added a comment to D2090: tests: refactor main storage tests.

also replace boolean hypothesis strategy by pytest.mark.parametrize, so we do
not need to reset the storage in these tests (since the test is truly
executed twice).

Mon, Oct 14, 12:16 PM

Fri, Oct 11

vlorentz requested changes to D2090: tests: refactor main storage tests.
Fri, Oct 11, 5:32 PM
vlorentz accepted D2128: phabricator.lister: Add integration test which checks scheduled tasks.
Fri, Oct 11, 5:19 PM
vlorentz added inline comments to D2090: tests: refactor main storage tests.
Fri, Oct 11, 5:07 PM
vlorentz accepted D2095: test_in_memory: adapt tests for the InMemoryStorage to new storage test infra.
Fri, Oct 11, 5:03 PM
vlorentz accepted D2091: test_storage: kill StorageTestDbFixture class.
Fri, Oct 11, 4:57 PM
vlorentz requested changes to D2119: test_api_client: refactor the code for new pytest based infra.
Fri, Oct 11, 4:56 PM
vlorentz accepted D2118: api: add (missing) refresh_stat_counters() endpoint.

meh.

Fri, Oct 11, 4:54 PM
vlorentz accepted D2117: tests/algos: rewrite test_snapshot with pytest.
Fri, Oct 11, 4:53 PM
vlorentz added a comment to D2095: test_in_memory: adapt tests for the InMemoryStorage to new storage test infra.

I wonder how you're going to mark these tests as skipped

Fri, Oct 11, 4:51 PM
vlorentz accepted D2092: test_storage: move db specific methods from main TestStorage to TestPgStorage.

Note that it implies they are no longer run on the remote api tests.

Fri, Oct 11, 4:50 PM
vlorentz requested changes to D2090: tests: refactor main storage tests.

I think the xfails should have a comment for future readers stumbling upon this commit.

Fri, Oct 11, 4:45 PM
vlorentz accepted D2127: packagist.lister: Add integration test which checks scheduled tasks.
Fri, Oct 11, 4:20 PM
vlorentz created D2129: Add swh-search to .mrconfig.
Fri, Oct 11, 4:19 PM
vlorentz committed rDSEA6c6772a5a7e8: Always use a free port for running ES's HTTP interface. (authored by vlorentz).
Always use a free port for running ES's HTTP interface.
Fri, Oct 11, 4:18 PM
vlorentz committed rDSEA7f1ce1d048ae: Add TODOs requested by @douardda. (authored by vlorentz).
Add TODOs requested by @douardda.
Fri, Oct 11, 4:18 PM
vlorentz committed rDSEA5d87738eea6b: Don't skip test_origin_url_paging on Elasticsearch tests. (authored by vlorentz).
Don't skip test_origin_url_paging on Elasticsearch tests.
Fri, Oct 11, 4:18 PM
vlorentz committed rDSEA6944ac1e197e: Add comments in ES backend. (authored by vlorentz).
Add comments in ES backend.
Fri, Oct 11, 4:18 PM
vlorentz committed rDSEA58834a44cd54: Remove dependency on pytest-elasticsearch. (authored by vlorentz).
Remove dependency on pytest-elasticsearch.
Fri, Oct 11, 4:18 PM
vlorentz committed rDSEA3a022a023845: Filter out origin type. (authored by vlorentz).
Filter out origin type.
Fri, Oct 11, 4:18 PM
vlorentz committed rDSEA13ed4d618118: Use pytest-style assertions. (authored by vlorentz).
Use pytest-style assertions.
Fri, Oct 11, 4:18 PM
vlorentz committed rDSEA702b7ef8debd: Remove check-manifest from tox.ini. (authored by vlorentz).
Remove check-manifest from tox.ini.
Fri, Oct 11, 4:18 PM
vlorentz updated the task description for T1912: Support origin pagination without origin ids.
Fri, Oct 11, 2:53 PM · Web app, Storage manager
vlorentz accepted D2122: npm.lister: Add integration test which checks the scheduled tasks.
Fri, Oct 11, 1:29 PM
vlorentz accepted D2121: pypi.lister: Add integration test which checks the scheduled tasks.
Fri, Oct 11, 1:28 PM
vlorentz accepted D2120: cran.lister: Fix cran lister and add proper integration test.
Fri, Oct 11, 1:28 PM
vlorentz accepted D2123: typing: minimal changes to make a no-op mypy run pass.

I also prefer the new line-breaking style, there's less space wasted by indentations

Fri, Oct 11, 10:36 AM
vlorentz accepted D2105: api: make backend_factory argument of RPCServerApp() optional.
Fri, Oct 11, 10:35 AM
vlorentz accepted D2096: in_memory: fix handling of 'hidden' content in InMemoryStorage.
Fri, Oct 11, 10:34 AM
vlorentz requested changes to D2121: pypi.lister: Add integration test which checks the scheduled tasks.

Same as D2120: what about mocking the scheduler?

Fri, Oct 11, 10:28 AM
vlorentz requested changes to D2120: cran.lister: Fix cran lister and add proper integration test.
Fri, Oct 11, 10:27 AM

Thu, Oct 10

vlorentz accepted D2115: tests: Explicit registering test tasks step for the swh_app.
Thu, Oct 10, 3:31 PM
vlorentz committed rDWCMcd1cc820f254: Add license import. (authored by vlorentz).
Add license import.
Thu, Oct 10, 3:23 PM
vlorentz accepted D2113: typing: minimal changes to make a no-op mypy run pass.
Thu, Oct 10, 3:11 PM
vlorentz accepted D2114: typing: minimal changes to make a no-op mypy run pass.
Thu, Oct 10, 2:38 PM
vlorentz added a project to T2035: Create codemeta generator tool for the FORCE19 Hackathon: CodeMeta Generator.
Thu, Oct 10, 2:38 PM · CodeMeta Generator, Metadata workflow
vlorentz added a project to T2038: [CodeMeta] Add a description to the README: CodeMeta Generator.
Thu, Oct 10, 2:38 PM · CodeMeta Generator, Metadata workflow
vlorentz added a project to T2036: [CodeMeta] Validate codemeta.json output: CodeMeta Generator.
Thu, Oct 10, 2:38 PM · CodeMeta Generator, Metadata workflow
vlorentz added a project to T2037: [CodeMeta] Add the possibility to add more terms from CodeMeta and schema.org: CodeMeta Generator.
Thu, Oct 10, 2:38 PM · CodeMeta Generator, Metadata workflow
vlorentz added a project to T2041: [CodeMeta] Add helpers to complete form: CodeMeta Generator.
Thu, Oct 10, 2:38 PM · CodeMeta Generator, Metadata workflow
vlorentz set the icon for CodeMeta Generator to Folder.
Thu, Oct 10, 2:37 PM
vlorentz created CodeMeta Generator.
Thu, Oct 10, 2:36 PM
vlorentz committed rDWAPPSe84547bd67dd: Add tests for the api-1-origin-search endpoint. (authored by vlorentz).
Add tests for the api-1-origin-search endpoint.
Thu, Oct 10, 2:35 PM
vlorentz closed D2111: Add tests for the api-1-origin-search endpoint..
Thu, Oct 10, 2:35 PM
vlorentz updated the diff for D2111: Add tests for the api-1-origin-search endpoint..

rebase

Thu, Oct 10, 2:35 PM
vlorentz added a comment to T2041: [CodeMeta] Add helpers to complete form.

I just added a list of licenses (cf515829580fe1f2e7dee65f4514c7505cf0cd84). It offers suggestions based on what is written in the box. I'm not very happy with the UI but I don't know how to improve it.

Thu, Oct 10, 2:29 PM · CodeMeta Generator, Metadata workflow
vlorentz added a comment to T2037: [CodeMeta] Add the possibility to add more terms from CodeMeta and schema.org.

Do you mean that users should be able to add arbitrary fields?

Thu, Oct 10, 2:28 PM · CodeMeta Generator, Metadata workflow
vlorentz closed T2039: [CodeMeta] Create a codemeta.json file for the CodeMeta generator , a subtask of T2038: [CodeMeta] Add a description to the README, as Resolved.
Thu, Oct 10, 2:27 PM · CodeMeta Generator, Metadata workflow
vlorentz closed T2039: [CodeMeta] Create a codemeta.json file for the CodeMeta generator as Resolved.

Resolved by 6259775.

Thu, Oct 10, 2:27 PM · Metadata workflow
vlorentz committed rDWCM625977521726: Add codemeta.json. (authored by vlorentz).
Add codemeta.json.
Thu, Oct 10, 2:27 PM
vlorentz added a comment to T2036: [CodeMeta] Validate codemeta.json output.

Oh, you want to generate codemeta text even if it's invalid, then show an error?

Thu, Oct 10, 2:26 PM · CodeMeta Generator, Metadata workflow
vlorentz added a comment to T2036: [CodeMeta] Validate codemeta.json output.

The output is already always validated (before being generated)

Thu, Oct 10, 2:25 PM · CodeMeta Generator, Metadata workflow
vlorentz closed T2040: [CodeMeta] Add AUTHORS file as Resolved.

Resolved by c566b37.

Thu, Oct 10, 2:22 PM · Metadata workflow
vlorentz closed T2040: [CodeMeta] Add AUTHORS file, a subtask of T2039: [CodeMeta] Create a codemeta.json file for the CodeMeta generator , as Resolved.
Thu, Oct 10, 2:22 PM · Metadata workflow
vlorentz committed rDWCMc566b3759ffc: Add AUTHORS file. (authored by vlorentz).
Add AUTHORS file.
Thu, Oct 10, 2:22 PM