- User Since
- Oct 1 2018, 11:23 AM (86 w, 4 d)
This also kills test_write_replay.py file since it does not test anything
more than what is currently tested in test_replay.py.
Or you could just use a random value every time.
The proposal is good imo. Maybe add milliseconds just to be sure though, in case the client is scripting multiple uploads at the same time
I think you should change check_archive to detect Django's name changes (see D3192)
I wonder if there should be a test checking the snapshot isn't referenced if Storage.snapshot_add errors
this should be two commits, though
Thu, May 28
It should be easy to fix
Upping priority, as we are hitting this issue in production
LGTM, but I think it's missing some tests:
fix migration, it was dropping a function that is still in use.
Wed, May 27
Tue, May 26
- fix typo
Mon, May 25
We wouldn't need that if pytest had an equivalent for assertCountEqual :/
What is the motivation for this?
Wed, May 20
fix typo + use SWHID as first argument
Shouldn't we make anonymized objects error when their compute_hash() method is called?
Tue, May 19
Mon, May 18
fixup of the rebase: alter index metadata_provider_type_url to change its name, instead of creating metadata_authority_type_url which is a duplicate.
Make 'visit' depend on 'origin' being provided.
apply @ardumont's changes to the migration.
I applied most of your comments, except:
apply most comments
undo push on the wrong diff (for real this time)
undo push on the wrong diff
Sat, May 16
for the context, we need to use the SHWIDs themselves, not the sha1_git that is bound to version 1 of SWHIDS
Fri, May 15
I don't think it makes sense to make this difference, because if a metadata only has origin in its context, it means it's context-free on all "axis" but the origin already. Having also no origin context is just one more axis it would be context-free on.
Thu, May 14
Hmm actually, "artifact" isn't great either, because we'll want to use it to mean extrinsic metadata , which aren't artifacts. Ugh...