Page MenuHomeSoftware Heritage

vlorentz (Valentin Lorentz)
User

User Details

User Since
Oct 1 2018, 11:23 AM (195 w, 3 d)

Recent Activity

Yesterday

vlorentz added inline comments to D8047: Indexer for Packagist(composer.json).
Thu, Jun 30, 10:31 PM
vlorentz added inline comments to D8047: Indexer for Packagist(composer.json).
Thu, Jun 30, 9:38 PM
vlorentz requested changes to D8047: Indexer for Packagist(composer.json).
Thu, Jun 30, 7:43 PM
vlorentz updated the summary of D8058: Add support for origin_extrinsic_metadata to the storage.
Thu, Jun 30, 3:39 PM
vlorentz requested review of D8060: Add extrinsic metadata indexer.
Thu, Jun 30, 3:37 PM
vlorentz requested review of D8058: Add support for origin_extrinsic_metadata to the storage.
Thu, Jun 30, 3:35 PM
vlorentz added a task to D8046: Remove SingleFileMapping from JsonMapping's base classes: T2073: Index extrinsic metadata from the journal in swh-search/Elasticsearch.
Thu, Jun 30, 3:31 PM
vlorentz added a task to D8053: Add minimal GitHub metadata mapping: T2073: Index extrinsic metadata from the journal in swh-search/Elasticsearch.
Thu, Jun 30, 3:31 PM
vlorentz added a task to D8054: github mapping: Add support for terms outside the codemeta context: T2073: Index extrinsic metadata from the journal in swh-search/Elasticsearch.
Thu, Jun 30, 3:31 PM
vlorentz added a task to D8055: github mapping: Add support for more terms from the Codemeta crosswalk: T2073: Index extrinsic metadata from the journal in swh-search/Elasticsearch.
Thu, Jun 30, 3:31 PM
vlorentz added revisions to T2073: Index extrinsic metadata from the journal in swh-search/Elasticsearch: D8060: Add extrinsic metadata indexer, D8058: Add support for origin_extrinsic_metadata to the storage, D8055: github mapping: Add support for more terms from the Codemeta crosswalk, D8054: github mapping: Add support for terms outside the codemeta context, D8053: Add minimal GitHub metadata mapping, D8046: Remove SingleFileMapping from JsonMapping's base classes.
Thu, Jun 30, 3:31 PM · Archive search, Metadata workflow
vlorentz requested review of D8055: github mapping: Add support for more terms from the Codemeta crosswalk.
Thu, Jun 30, 11:08 AM
vlorentz added inline comments to D8023: Install `swh provenance origin from-journal` cli and tests.
Thu, Jun 30, 11:08 AM
vlorentz accepted D7258: Update the mirror operation docker manual.
Thu, Jun 30, 11:04 AM
vlorentz accepted D7988: api/origin: Do not attempt to lookup similar origin URLs.
Thu, Jun 30, 11:03 AM
vlorentz updated the diff for D8054: github mapping: Add support for terms outside the codemeta context.

fix cli test

Thu, Jun 30, 11:01 AM
vlorentz updated the diff for D8053: Add minimal GitHub metadata mapping.

fix cli test

Thu, Jun 30, 11:01 AM
vlorentz updated subscribers of T4296: Pagination does not work when using sort_by in search query language.
Thu, Jun 30, 10:38 AM · Archive search
vlorentz merged task T4364: "sort_by" in the search QL does not support pagination into T4296: Pagination does not work when using sort_by in search query language.
Thu, Jun 30, 10:38 AM · Archive search
vlorentz merged T4364: "sort_by" in the search QL does not support pagination into T4296: Pagination does not work when using sort_by in search query language.
Thu, Jun 30, 10:38 AM · Archive search
vlorentz triaged T4364: "sort_by" in the search QL does not support pagination as Normal priority.
Thu, Jun 30, 10:36 AM · Archive search
vlorentz created T4364: "sort_by" in the search QL does not support pagination.
Thu, Jun 30, 10:36 AM · Archive search
vlorentz added inline comments to D6138: package/utils: Handle downloads for urls with missing schema.
Thu, Jun 30, 9:19 AM

Wed, Jun 29

vlorentz requested review of D8054: github mapping: Add support for terms outside the codemeta context.
Wed, Jun 29, 7:59 PM
vlorentz requested review of D8053: Add minimal GitHub metadata mapping.
Wed, Jun 29, 7:58 PM
vlorentz accepted D8023: Install `swh provenance origin from-journal` cli and tests.
Wed, Jun 29, 4:42 PM
vlorentz closed D8052: crates: Remove redundant 'max_content_length' argument.
Wed, Jun 29, 4:33 PM
vlorentz committed rDLDBASEb0e3335df76c: crates: Remove redundant 'max_content_length' argument (authored by vlorentz).
crates: Remove redundant 'max_content_length' argument
Wed, Jun 29, 4:33 PM
vlorentz requested review of D8052: crates: Remove redundant 'max_content_length' argument.
Wed, Jun 29, 4:08 PM
vlorentz accepted D8051: Arch, use **kwargs on task initialisation instead of named args..
Wed, Jun 29, 4:06 PM
vlorentz requested review of D8048: Move mapping-specific tests to a new directory.
Wed, Jun 29, 1:54 PM
vlorentz requested review of D8046: Remove SingleFileMapping from JsonMapping's base classes.
Wed, Jun 29, 12:31 PM
vlorentz updated the diff for D8045: Add typing to detect_metadata() and related functions.

remove dead, broken code

Wed, Jun 29, 11:41 AM
vlorentz requested review of D8045: Add typing to detect_metadata() and related functions.
Wed, Jun 29, 11:07 AM
vlorentz accepted D8036: Check CFF Value Types.
Wed, Jun 29, 11:00 AM
vlorentz closed D8044: tests: Update mock to work with objstorage >= v2.0.0.
Wed, Jun 29, 10:25 AM
vlorentz committed rDCIDX70c7e91fa894: tests: Update mock to work with objstorage >= v2.0.0 (authored by vlorentz).
tests: Update mock to work with objstorage >= v2.0.0
Wed, Jun 29, 10:25 AM
vlorentz closed D8043: DirectoryIndexer: Remove incorrect assumption on object types.
Wed, Jun 29, 10:25 AM
vlorentz committed rDCIDX3394dca40599: DirectoryIndexer: Remove incorrect assumption on object types (authored by vlorentz).
DirectoryIndexer: Remove incorrect assumption on object types
Wed, Jun 29, 10:25 AM
vlorentz accepted D8036: Check CFF Value Types.

thanks!

Wed, Jun 29, 10:23 AM

Tue, Jun 28

vlorentz requested review of D8044: tests: Update mock to work with objstorage >= v2.0.0.
Tue, Jun 28, 5:31 PM
vlorentz triaged T4357: Metadata Indexer for Composer as Normal priority.
Tue, Jun 28, 5:03 PM · Indexer
vlorentz added a comment to D8033: Arch User Repository (AUR) lister.

but got the bug while testing runner on docker

Tue, Jun 28, 1:17 PM
vlorentz updated the diff for D8043: DirectoryIndexer: Remove incorrect assumption on object types.

update docstring

Tue, Jun 28, 1:10 PM
vlorentz requested review of D8043: DirectoryIndexer: Remove incorrect assumption on object types.
Tue, Jun 28, 12:37 PM
vlorentz updated the task description for T4354: Contribute terms to ForgeFed.
Tue, Jun 28, 12:11 PM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Tue, Jun 28, 11:45 AM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Tue, Jun 28, 11:45 AM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Tue, Jun 28, 11:22 AM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Tue, Jun 28, 10:42 AM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Tue, Jun 28, 10:08 AM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Tue, Jun 28, 9:08 AM · Archive search, Metadata workflow

Mon, Jun 27

vlorentz accepted D8041: scrubber: Deactivate the unneeded objstorage configuration part.
Mon, Jun 27, 4:57 PM
vlorentz added inline comments to D8040: Limit the number of entries in the cache.
Mon, Jun 27, 4:16 PM
vlorentz added inline comments to D8040: Limit the number of entries in the cache.
Mon, Jun 27, 4:15 PM
vlorentz added a comment to D8033: Arch User Repository (AUR) lister.

There is no real direct way for the lister to discover where to download oldest versions of a package. There is a canonical url for each package in its page description but its the latest snapshot url, no way to know which version it is when downloading from this link.

Mon, Jun 27, 4:03 PM
vlorentz closed T4345: get_filtered_files_content fails with "unexpected status None for content" as Resolved.
Mon, Jun 27, 3:12 PM · Vault
vlorentz closed D8031: Add test for DirectoryBuilder on missing directories.
Mon, Jun 27, 3:12 PM
vlorentz committed rDVAUc07d934aeff6: Add test for DirectoryBuilder on missing directories (authored by vlorentz).
Add test for DirectoryBuilder on missing directories
Mon, Jun 27, 3:12 PM
vlorentz closed D8030: Fix crash on directories pointing to missing contents.
Mon, Jun 27, 3:12 PM
vlorentz committed rDVAU141b4531b1a6: Fix crash on directories pointing to missing contents (authored by vlorentz).
Fix crash on directories pointing to missing contents
Mon, Jun 27, 3:12 PM
vlorentz added inline comments to D8029: Start introducing composite ObjId in the interface.
Mon, Jun 27, 3:11 PM
vlorentz updated the diff for D8029: Start introducing composite ObjId in the interface.

apply comments

Mon, Jun 27, 3:09 PM
vlorentz accepted D8035: sysadm: Reference the production swh-scrubber db access.
Mon, Jun 27, 2:27 PM
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Mon, Jun 27, 1:17 PM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Mon, Jun 27, 1:17 PM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Mon, Jun 27, 1:04 PM · Archive search, Metadata workflow
vlorentz updated the task description for T4354: Contribute terms to ForgeFed.
Mon, Jun 27, 11:12 AM · Archive search, Metadata workflow
vlorentz updated the task description for T4354: Contribute terms to ForgeFed.
Mon, Jun 27, 11:12 AM · Archive search, Metadata workflow
vlorentz triaged T4354: Contribute terms to ForgeFed as Normal priority.
Mon, Jun 27, 11:11 AM · Archive search, Metadata workflow

Sat, Jun 25

vlorentz added inline comments to D8036: Check CFF Value Types.
Sat, Jun 25, 7:21 AM
vlorentz requested changes to D8036: Check CFF Value Types.

you can move the inner for loop in normalize_authors and combine the conditionals with the existing ones. This will considerably simplify your code

Sat, Jun 25, 7:18 AM

Thu, Jun 23

vlorentz added a comment to T4350: Search in web UI using metadata is throwing an error.

could you link to the sentry issue? (sorry, I don't have access to sentry right now)

Thu, Jun 23, 8:16 PM · Web app
vlorentz added inline comments to D8029: Start introducing composite ObjId in the interface.
Thu, Jun 23, 3:23 PM
vlorentz closed D8028: Make WineryWriter.add return None.
Thu, Jun 23, 3:17 PM
vlorentz committed rDOBJSe712f28684a1: Make WineryWriter.add return None (authored by vlorentz).
Make WineryWriter.add return None
Thu, Jun 23, 3:17 PM
vlorentz closed D8026: Remove get_random().
Thu, Jun 23, 3:17 PM
vlorentz committed rDOBJS2caa05e869c9: Remove get_random() (authored by vlorentz).
Remove get_random()
Thu, Jun 23, 3:17 PM
vlorentz requested review of D8029: Start introducing composite ObjId in the interface.
Thu, Jun 23, 3:16 PM
vlorentz updated the diff for D8028: Make WineryWriter.add return None.

rebase

Thu, Jun 23, 3:12 PM
vlorentz updated the diff for D8026: Remove get_random().

rebase

Thu, Jun 23, 3:12 PM
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Thu, Jun 23, 2:30 PM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Thu, Jun 23, 1:54 PM · Archive search, Metadata workflow
vlorentz updated the task description for T4249: Choose/define an ontology to use for indexed extrinsic origin metadata.
Thu, Jun 23, 1:53 PM · Archive search, Metadata workflow
vlorentz updated the task description for T1408: More/better Metrics.
Thu, Jun 23, 11:06 AM · Metrics/monitoring, Sprint 2018 12
vlorentz closed T1461: Add loader-related metrics to swh-loader-core, a subtask of T1408: More/better Metrics, as Resolved.
Thu, Jun 23, 10:59 AM · Metrics/monitoring, Sprint 2018 12
vlorentz closed T1461: Add loader-related metrics to swh-loader-core, a subtask of T1535: Deploy prometheus-statsd-exporter to gather per-worker metrics, as Resolved.
Thu, Jun 23, 10:59 AM · System administration, Metrics/monitoring
vlorentz closed T1461: Add loader-related metrics to swh-loader-core as Resolved.

Closing this, as these metrics are now visible on https://grafana.softwareheritage.org/d/FqGC4zu7z/vlorentz-loader-metrics

Thu, Jun 23, 10:59 AM · Core Loader, Metrics/monitoring
vlorentz added a comment to T4185: Loader profiling : Add Measure of ignored objects .

FTR, the Git loader now exports a swh_loader_filtered_objects_total metric. We should generalize this to other loaders eventually

Thu, Jun 23, 10:40 AM · Storage manager
vlorentz requested review of D8031: Add test for DirectoryBuilder on missing directories.
Thu, Jun 23, 10:22 AM
vlorentz requested review of D8030: Fix crash on directories pointing to missing contents.
Thu, Jun 23, 10:07 AM
vlorentz added a revision to T4345: get_filtered_files_content fails with "unexpected status None for content": D8030: Fix crash on directories pointing to missing contents.
Thu, Jun 23, 10:04 AM · Vault
vlorentz added a revision to T4345: get_filtered_files_content fails with "unexpected status None for content": D8021: to_disk: Add type annotations + a simple test for DirectoryBuilder.
Thu, Jun 23, 9:47 AM · Vault
vlorentz added a task to D8021: to_disk: Add type annotations + a simple test for DirectoryBuilder: T4345: get_filtered_files_content fails with "unexpected status None for content".
Thu, Jun 23, 9:47 AM
vlorentz closed D8021: to_disk: Add type annotations + a simple test for DirectoryBuilder.
Thu, Jun 23, 9:46 AM
vlorentz committed rDVAU6da99426e215: to_disk: Add type annotations + a simple test for DirectoryBuilder (authored by vlorentz).
to_disk: Add type annotations + a simple test for DirectoryBuilder
Thu, Jun 23, 9:46 AM
vlorentz closed D8025: Remove deprecated 'args' argument of get_objstorage.
Thu, Jun 23, 9:46 AM
vlorentz committed rDOBJSd7f4daa242a5: Remove deprecated 'args' argument of get_objstorage (authored by vlorentz).
Remove deprecated 'args' argument of get_objstorage
Thu, Jun 23, 9:46 AM
vlorentz closed D8010: Make obj_id argument of ObjStorage.restore() required.

6cdfe555fab7f75423bae7d820b2cd25ef4f4530

Thu, Jun 23, 9:45 AM
vlorentz closed D8009: Make obj_id argument of ObjStorage.add() required.

99e0d40bb0d2f30dc071ad23692a661b348171fc

Thu, Jun 23, 9:44 AM