Differential D6909

tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
AbandonedPublic
Actions

Authored by vlorentz on Jan 11 2022, 12:15 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T3752: Store/represent time offsets as strings

Summary

A future release of swh-model will change its constructor's signature (replace 'offset'
and 'negative_utc_offset' with 'offset_bytes).

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25917
Build 40505: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40504: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 11 2022, 12:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2022, 12:15 PM

Build is green

Patch application report for D6909 (id=25047)

Rebasing onto 9777195fdb...

First, rewinding head to replay your work on top of it...
Applying: tests: Use TimestampWithTimezone.from_datetime() instead of the constructor

Changes applied before test

commit 4667e67977b873c337c0477da3fd60a034b86ec9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 12:15:31 2022 +0100

    tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
    
    A future release of swh-model will change its constructor's signature (replace 'offset'
    and 'negative_utc_offset' with 'offset_bytes).

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/187/ for more details.

Harbormaster completed remote builds in B25917: Diff 25047.Jan 11 2022, 12:18 PM

vlorentz requested review of this revision.Jan 11 2022, 12:18 PM

vlorentz added a task: T3752: Store/represent time offsets as strings.Jan 11 2022, 2:15 PM

vlorentz removed a reviewer: Reviewers.Jan 11 2022, 3:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2022, 3:30 PM

Landed as 1e802dea6e5ebd4ebc2cf1dfca757b3b87bd29e7