Page MenuHomeSoftware Heritage

git_objects: Use raw offset_bytes to format dates, and remove format_offset()
ClosedPublic

Authored by vlorentz on Fri, Jan 7, 1:53 PM.

Details

Summary

This is needed when recomputing the manifest of git objects with weird offsets.

Part of T3752.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6890 (id=24993)

Rebasing onto c6ec4d87c5...

Current branch diff-target is up to date.
Changes applied before test
commit d862fb745ae47ead42ceb4b2fd99f5eccb34067d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jan 7 13:51:05 2022 +0100

    git_objects: Use raw offset_bytes to format dates, and remove format_offset()
    
    This is needed when recomputing the manifest of git objects with weird offsets.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/440/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/440/console

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 7, 1:54 PM
Harbormaster failed remote builds in B25863: Diff 24993!

Build is green

Patch application report for D6890 (id=24994)

Rebasing onto c6ec4d87c5...

Current branch diff-target is up to date.
Changes applied before test
commit 56460e1d4a58a4b2bb5697a02e8154e3f37767dc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jan 7 13:51:05 2022 +0100

    git_objects: Use raw offset_bytes to format dates, and remove format_offset()
    
    This is needed when recomputing the manifest of git objects with weird offsets.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/441/ for more details.

olasd added a subscriber: olasd.

Thanks!

This revision is now accepted and ready to land.Mon, Jan 10, 2:38 PM