Page MenuHomeSoftware Heritage

Remove special handling of negative_utc
ClosedPublic

Authored by vlorentz on Wed, Jan 12, 3:24 PM.

Details

Summary

The next release of swh-model will remove this attribute, because it was
only a special case, and we will replace it with the generalized 'offset_bytes'.

Step 5 of T3752.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6927 (id=25105)

Rebasing onto e870ec2b9a...

Current branch diff-target is up to date.
Changes applied before test
commit b3d7c69bec6372e263516f3801a1cc94d7929d58
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jan 12 15:23:53 2022 +0100

    Remove special handling of negative_utc
    
    The next release of swh-model will remove this attribute, because it was
    only a special case, and we will replace it with the generalized 'offset_bytes'.

commit 9cfc70630b414b69f8e05cbe57922f3c57a8fb18
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 15:25:25 2022 +0100

    tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
    
    A future release of swh-model will change its constructor's signature (replace 'offset'
    and 'negative_utc_offset' with 'offset_bytes).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1296/ for more details.

vlorentz retitled this revision from tests: Use TimestampWithTimezone.from_datetime() instead of the constructor to Remove special handling of negative_utc.Wed, Jan 12, 3:41 PM
vlorentz edited the summary of this revision. (Show Details)

Build is green

Patch application report for D6927 (id=25106)

Could not rebase; Attempt merge onto e870ec2b9a...

Updating e870ec2b..45429e8d
Fast-forward
 swh/web/common/converters.py            | 28 +++++++++++-----------------
 swh/web/tests/api/views/test_release.py | 18 +++---------------
 swh/web/tests/common/test_converters.py | 30 ++++++------------------------
 3 files changed, 20 insertions(+), 56 deletions(-)
Changes applied before test
commit 45429e8d5ca813fe2789c46e64bbed44d71ceb72
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jan 12 15:23:53 2022 +0100

    Remove special handling of negative_utc
    
    The next release of swh-model will remove this attribute, because it was
    only a special case, and we will replace it with the generalized 'offset_bytes'.

commit 9cfc70630b414b69f8e05cbe57922f3c57a8fb18
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 15:25:25 2022 +0100

    tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
    
    A future release of swh-model will change its constructor's signature (replace 'offset'
    and 'negative_utc_offset' with 'offset_bytes).

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1297/ for more details.

This revision is now accepted and ready to land.Wed, Jan 12, 5:18 PM