Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3752: Store/represent time offsets as strings
- Commits
- rDMOD5359c434e16e: Remove deprecated property 'TimestampWithTimezone.offset'
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7012 (id=25416)
Could not rebase; Attempt merge onto a654060bf2...
Updating a654060..9c474d0 Fast-forward requirements.txt | 2 +- swh/model/model.py | 191 +++++++++++------------------------- swh/model/tests/test_identifiers.py | 142 ++++----------------------- swh/model/tests/test_model.py | 20 ++-- 4 files changed, 89 insertions(+), 266 deletions(-)
Changes applied before test
commit 9c474d0784ad580ff337e956615dbbd4bbea60b6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 14:57:22 2022 +0100
Remove deprecated property 'TimestampWithTimezone.offset'
commit e3b5349bbd685d364a2f62f627ff53b5fb9a943b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 14:51:18 2022 +0100
Revert "Restore 'offset' and 'negative_utc' arguments and make them optional"
This reverts commit a0f5436273ef6f5b62a388ae131ed5afa7287d00.
This means this commit removes the 'offset' and 'negative_utc'
arguments.
It also removes the 'negative_utc' attribute (which is not used
anymore), but keeps an 'offset' property, which is an alias to
'offset_minutes()'. This is only to keep this commit readable;
the next commit will remove this alias.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/455/ for more details.
Comment Actions
Build is green
Patch application report for D7012 (id=26583)
Could not rebase; Attempt merge onto 118c8a44d7...
Updating 118c8a4..5359c43 Fast-forward requirements.txt | 2 +- swh/model/model.py | 191 +++++++++++------------------------- swh/model/tests/test_identifiers.py | 142 ++++----------------------- swh/model/tests/test_model.py | 20 ++-- 4 files changed, 89 insertions(+), 266 deletions(-)
Changes applied before test
commit 5359c434e16ef2c04b69198ecda35dd370d40bf5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 14:57:22 2022 +0100
Remove deprecated property 'TimestampWithTimezone.offset'
commit 07c7b4f151022f8ecdbaff6013cc71e36340d155
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jan 21 14:51:18 2022 +0100
Revert "Restore 'offset' and 'negative_utc' arguments and make them optional"
This reverts commit a0f5436273ef6f5b62a388ae131ed5afa7287d00.
This means this commit removes the 'offset' and 'negative_utc'
arguments.
It also removes the 'negative_utc' attribute (which is not used
anymore), but keeps an 'offset' property, which is an alias to
'offset_minutes()'. This is only to keep this commit readable;
the next commit will remove this alias.See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/460/ for more details.