Page MenuHomeSoftware Heritage

tests: Replace 'offset' and 'negative_utc' with 'offset_bytes'
ClosedPublic

Authored by vlorentz on Thu, Jan 13, 12:21 PM.

Details

Summary

Required by swh-model v5.0.0

Depends on D6935

Test Plan

Will fail because this depends on D6936, which isn't released yet.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6938 (id=25128)

Could not rebase; Attempt merge onto e3d793dec5...

Updating e3d793d..0a68312
Fast-forward
 requirements-swh.txt                                     |  2 +-
 .../https_deposit.softwareheritage.org/hello_2.10.json   |  6 ++----
 .../https_deposit.softwareheritage.org/hello_2.11.json   |  6 ++----
 .../https_deposit.softwareheritage.org/hello_2.12.json   |  6 ++----
 .../https_deposit.softwareheritage.org/hello_2.13.json   |  6 ++----
 swh/loader/package/deposit/tests/test_deposit.py         | 12 ++++++------
 swh/loader/tests/test_init.py                            | 16 ++--------------
 7 files changed, 17 insertions(+), 37 deletions(-)
Changes applied before test
commit 0a68312759526b8f2a883f10dc6054c9019adcfa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 13 12:21:07 2022 +0100

    tests: Replace 'offset' and 'negative_utc' with 'offset_bytes'
    
    Required by swh-model v5.0.0

commit c2d96ed3e4613433171895624acbd54b9be5cb99
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 13 11:50:19 2022 +0100

    deposit: Remove 'negative_utc' from test data
    
    swh-deposit v0.17.0 removes it, to match the removal from swh-model v5.0.0

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/675/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/675/console

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Jan 13, 12:22 PM
Harbormaster failed remote builds in B25998: Diff 25128!

Build has FAILED

Patch application report for D6938 (id=25128)

Rebasing onto c2d96ed3e4...

Current branch diff-target is up to date.
Changes applied before test
commit 0a68312759526b8f2a883f10dc6054c9019adcfa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 13 12:21:07 2022 +0100

    tests: Replace 'offset' and 'negative_utc' with 'offset_bytes'
    
    Required by swh-model v5.0.0

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/676/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/676/console

lower swh-model version requirement

Build is green

Patch application report for D6938 (id=25186)

Rebasing onto c2d96ed3e4...

Current branch diff-target is up to date.
Changes applied before test
commit 2413cb9ff9a7c784277d35355ac750206e84253c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jan 13 12:21:07 2022 +0100

    tests: Replace 'offset' and 'negative_utc' with 'offset_bytes'
    
    Will be required by swh-model v5.0.0

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/677/ for more details.

olasd added a subscriber: olasd.

Cool, thanks!

This revision is now accepted and ready to land.Fri, Jan 14, 5:48 PM