• swh identify -t snapshot: add support for symbolic refs
• test_cli.py: drop unused NoQA marker
• test_cli.py: fill in valid snapshot ID

In D2078#49823, @olasd wrote:

In D2078#48207, @zack wrote:

Then I've dumped the branch list just before it's hashed (with P542 in swh.model.identifiers) and what I get is this:

alias HEAD 726566732f68656164732f6d6173746572
revision refs/heads/master 9768d0b576dbaaecd80abedad6dfd0d72f1476da
revision refs/remotes/origin/master c3c588713233609f5bbbb2d9e7f3fb4a660f3f72

where HEAD is an alias, but it's pointing to an object ID (this is on the sample git repo used for tests on swh-load-git, but I obtain similar results on any other repo I've tried).
What am I missing here?

That's not an object id, that's a branch name (refs/heads/master, in ASCII).

• test_cli.py: drop unused NoQA marker
• test_cli.py: fill in valid snapshot ID

• storage/db.py: drop unused format arg regconfig from query

Updating D2144: [WIP] typing: minimal changes to make a no-op mypy run pass

• CRAN lister: fix compute_package_url interpolation

• typing: minimal changes to make a no-op mypy run pass
• CRAN lister: make shelling out decoding compatible with Python 3.5
• mypy: add typing annotations for novel lister abstractions

doesn't actually pass mypy yet, will update

• typing: minimal changes to make a no-op mypy run pass
• CRAN lister: make shelling out decoding compatible with Python 3.5

updating D2123

In D2123#49304, @vlorentz wrote:

I also prefer the new line-breaking style, there's less space wasted by indentations

I've marked this as depending on D2120, as the encoding fix for the CRAN lister (formerly known as D2125) has been integrated there.

In D2125#49275, @ardumont wrote:

This is now obsolete as that was merged within the D2120 diff which add integration test and fixes the cran lister behavior.

• typing: minimal changes to make a no-op mypy run pass
• mypy: use sqlalchemy plugin

• mypy: use sqlalchemy plugin

In D2088#48849, @ardumont wrote:

Needs a rebase (as i modified slightly the tox.ini today).

Looks good, but I'm puzzled by some testing results.

In a subsequent commit please update also docs/api.rst to document the new methods (a catch-all thing to document all of them at once would do too).

btw, I've tested this diff manually in tox and it does build find

thanks a lot @DanSeraf!, this has now been accepted, landed to master, and you've been added to the CONTRIBUTORS file :-)

oh, and remember to add a "Closes: T1986" line to the diff description (and commit), so that there is a link with the corresponding issue

In D2070#47879, @anlambert wrote:

To install mypy in the docker image used to run the tests, you have to modify that Dockerfile.
You will have to land the dockerfile change prior to that diff of course.

In D2032#47733, @douardda wrote:

where should the mypy_django_plugin dependency be? looks like this is required.

Hheya, thanks a lot for this contribution !

nice catch!

not sure where I saw that kwd argument…