- User Since
- Sep 7 2015, 3:43 PM (319 w, 22 h)
Fri, Oct 15
Thu, Oct 14
Wed, Oct 13
+1 on dropping the / -> /devel/ redirect and have at / a landing page allowing to choose between the 3 bodies of documentation.
Tue, Oct 12
Mon, Oct 11
Aside from the specific needs of the mirroring stack, the question at hand is whether the read-only object storage should be by default open to the public or not.
Sat, Oct 9
Fri, Oct 8
Thu, Oct 7
This should stay pending until we resolve the archiving policy discussion in T3627, so I'm marking it as such.
Thanks for your feedback @olasd. I see three main arguments raised there: (1) the raciness of archiving those data via other means (= related forks), (2) the completeness of our canvassing of synthetic refs, (3) annotating rather than not archiving "synthetic" refs.
Wed, Oct 6
Mon, Oct 4
According to the snippet referenced by @ardumont, all branch names starting with refs/pull/ should be filtered out.
But in the recent snapshot of torvalds/linux there are a lot of branch names like that.
Sat, Oct 2
Fri, Oct 1
Thu, Sep 30
Mon, Sep 27
Fri, Sep 24
Thu, Sep 23
Wed, Sep 22
Approved, but please fix the minutia I'm mentioning in the above comment before landing.
Sep 18 2021
Sep 1 2021
Aug 31 2021
Here's an opinionated and prioritized list.
quick comment on the "Miscellaneous" category:
- it's not a great name, and it really feels they are "less important" than the others even if we say explicitly they aren't (or maybe because we say so :-))
- and shouldn't the two items in there (nix, guix) go under "regular crawling" anyway? (that would trivially solve the previous point)
Aug 24 2021
LGTM, thanks! But please note that remaining "-a/--add" reference in the new docstring, which should be changed to "-e/..." for consistency. Please fix that before landing this change.
Aug 23 2021
Nice! And I also like the refactoring out of client.py.
Aug 19 2021
Aug 17 2021
Thanks for this, and for the screenshots, they look gorgeous!
Aug 10 2021
Aug 9 2021
I'm approving this, but please fix the remaining occurrence of 1000 before landing, as per comment above.
Jul 29 2021
Jul 28 2021
I'm requesting some minor changes (+ some other changes to be submitted in a separate diff which I've noticed only now, sorry!).
Jul 23 2021
Jul 22 2021
I'm accepting this diff, but note that I've added a few suggestions for improved language above. Please integrate them before this is final.
Jul 21 2021
Wonderful, thanks for adding the order tests! LGTM.
Jul 19 2021
thanks @KShivendu, this is a great start!
Jul 17 2021
It is okay with you if I add it in the next diff? This one has become extremely long because of lots of build failures.
Jul 16 2021
Can we have some documentation of the query language, included in this diff?
E.g., a file under docs/ which will then be rendered on docs.s.o as user documentation for how to use the query language.
Thanks for this update, great work!
Looks great! I've noted down only some nits.
Jul 15 2021
Jul 8 2021
Please note down on the sides two remaining TODOs about all this:
- adding a test case with a deduplicated source tree, to make sure nodes that are deduplicated at the Merkle DAG level are present multiple times in the output
- adding a test case for a path that is not decodable in utf-8, to make sure it can be handled propertly
Jul 7 2021
Jul 6 2021
Thanks, both the general structure and implementation look OK.
I'm requesting changes to address two main issues: