Page MenuHomeSoftware Heritage

zack (Stefano Zacchiroli)
UserAdministrator

User Details

User Since
Sep 7 2015, 3:43 PM (215 w, 2 d)
Roles
Administrator

Recent Activity

Sun, Oct 20

zack committed rDMOD2e4558c0d2d5: test_cli.py: fill in valid snapshot ID (authored by zack).
test_cli.py: fill in valid snapshot ID
Sun, Oct 20, 9:26 PM
zack committed rDMOD8e3ee395d3c7: test_cli.py: drop unused NoQA marker (authored by zack).
test_cli.py: drop unused NoQA marker
Sun, Oct 20, 9:26 PM
zack committed rDMOD4a742055c299: swh identify -t snapshot: add support for symbolic refs (authored by zack).
swh identify -t snapshot: add support for symbolic refs
Sun, Oct 20, 9:26 PM
zack closed D2081: swh identify -t snapshot: add support for symbolic refs.
Sun, Oct 20, 9:26 PM
zack updated the diff for D2081: swh identify -t snapshot: add support for symbolic refs.
  • swh identify -t snapshot: add support for symbolic refs
  • test_cli.py: drop unused NoQA marker
  • test_cli.py: fill in valid snapshot ID
Sun, Oct 20, 9:24 PM
zack added a comment to D2078: Add support for symbolic references.
In D2078#49823, @olasd wrote:
In D2078#48207, @zack wrote:

Then I've dumped the branch list just before it's hashed (with P542 in swh.model.identifiers) and what I get is this:

alias HEAD 726566732f68656164732f6d6173746572
revision refs/heads/master 9768d0b576dbaaecd80abedad6dfd0d72f1476da
revision refs/remotes/origin/master c3c588713233609f5bbbb2d9e7f3fb4a660f3f72

where HEAD is an alias, but it's pointing to an object ID (this is on the sample git repo used for tests on swh-load-git, but I obtain similar results on any other repo I've tried).
What am I missing here?

That's not an object id, that's a branch name (refs/heads/master, in ASCII).

Sun, Oct 20, 9:23 PM
zack committed rDGRPH5230e55c0312: git2graph: fix snapshot ID computation, now compatible with swh identify (authored by zack).
git2graph: fix snapshot ID computation, now compatible with swh identify
Sun, Oct 20, 9:21 PM
zack committed rDGRPHd93aeaf2a085: git2graph: remove left over, comment out debug prints (authored by zack).
git2graph: remove left over, comment out debug prints
Sun, Oct 20, 9:21 PM
zack committed rDGRPH0c9a71a667d7: ParallelBFS benchmark: add support to optionally use transposed graph (authored by zack).
ParallelBFS benchmark: add support to optionally use transposed graph
Sun, Oct 20, 2:15 PM
zack committed rDGRPH132e528ee737: benchmark.ParallelBFS: new class to time parallel BFS on the full graph (authored by zack).
benchmark.ParallelBFS: new class to time parallel BFS on the full graph
Sun, Oct 20, 2:02 PM
zack committed rDGRPH7fcf2f1d0a49: Graph: add getBVGraph getter for underlying BVgraph(s) (authored by zack).
Graph: add getBVGraph getter for underlying BVgraph(s)
Sun, Oct 20, 2:02 PM
zack updated the diff for D2081: swh identify -t snapshot: add support for symbolic refs.
  • test_cli.py: drop unused NoQA marker
  • test_cli.py: fill in valid snapshot ID
Sun, Oct 20, 9:39 AM
zack updated the diff for D2144: typing: minimal changes to make a no-op mypy run pass.
  • storage/db.py: drop unused format arg regconfig from query
Sun, Oct 20, 9:15 AM
zack added a reviewer for D2032: typing: minimal changes to make a no-op mypy run pass: ardumont.
Sun, Oct 20, 9:09 AM
zack added a reviewer for D2144: typing: minimal changes to make a no-op mypy run pass: vlorentz.
Sun, Oct 20, 9:08 AM
zack retitled D2144: typing: minimal changes to make a no-op mypy run pass from [WIP] typing: minimal changes to make a no-op mypy run pass to typing: minimal changes to make a no-op mypy run pass.
Sun, Oct 20, 9:08 AM
zack updated the diff for D2144: typing: minimal changes to make a no-op mypy run pass.

Updating D2144: [WIP] typing: minimal changes to make a no-op mypy run pass

Sun, Oct 20, 9:08 AM

Sat, Oct 19

zack triaged T2045: add support for reverse lookup from swh:1:ori:... PIDs to origin URLs as Normal priority.
Sat, Oct 19, 2:45 PM · Storage manager

Fri, Oct 18

zack updated the diff for D2123: typing: minimal changes to make a no-op mypy run pass.
  • CRAN lister: fix compute_package_url interpolation
Fri, Oct 18, 5:40 PM
zack updated the diff for D2123: typing: minimal changes to make a no-op mypy run pass.
  • typing: minimal changes to make a no-op mypy run pass
  • CRAN lister: make shelling out decoding compatible with Python 3.5
  • mypy: add typing annotations for novel lister abstractions
Fri, Oct 18, 5:33 PM

Tue, Oct 15

zack planned changes to D2144: typing: minimal changes to make a no-op mypy run pass.

doesn't actually pass mypy yet, will update

Tue, Oct 15, 3:59 PM
zack created D2144: typing: minimal changes to make a no-op mypy run pass.
Tue, Oct 15, 3:59 PM

Fri, Oct 11

zack updated the diff for D2123: typing: minimal changes to make a no-op mypy run pass.
  • typing: minimal changes to make a no-op mypy run pass
  • CRAN lister: make shelling out decoding compatible with Python 3.5
Fri, Oct 11, 3:28 PM
zack updated the diff for D2123: typing: minimal changes to make a no-op mypy run pass.

updating D2123

Fri, Oct 11, 3:15 PM
zack added a comment to D2123: typing: minimal changes to make a no-op mypy run pass.

I also prefer the new line-breaking style, there's less space wasted by indentations

Fri, Oct 11, 10:39 AM
zack resigned from D2120: cran.lister: Fix cran lister and add proper integration test.
Fri, Oct 11, 10:35 AM
zack requested changes to D2120: cran.lister: Fix cran lister and add proper integration test.
Fri, Oct 11, 10:35 AM
zack added a comment to D2123: typing: minimal changes to make a no-op mypy run pass.

I've marked this as depending on D2120, as the encoding fix for the CRAN lister (formerly known as D2125) has been integrated there.

Fri, Oct 11, 10:26 AM
zack abandoned D2125: CRAN lister: decode R lister output before JSON loading.

This is now obsolete as that was merged within the D2120 diff which add integration test and fixes the cran lister behavior.

Fri, Oct 11, 10:25 AM
zack created D2125: CRAN lister: decode R lister output before JSON loading.
Fri, Oct 11, 8:55 AM
zack abandoned D2124: CRAN lister: decode R lister output before JSON loading.
Fri, Oct 11, 8:55 AM
zack updated the diff for D2124: CRAN lister: decode R lister output before JSON loading.
  • typing: minimal changes to make a no-op mypy run pass
  • mypy: use sqlalchemy plugin
Fri, Oct 11, 8:50 AM
zack created D2124: CRAN lister: decode R lister output before JSON loading.
Fri, Oct 11, 8:49 AM
zack updated the diff for D2123: typing: minimal changes to make a no-op mypy run pass.
  • mypy: use sqlalchemy plugin
Fri, Oct 11, 8:26 AM
zack created D2123: typing: minimal changes to make a no-op mypy run pass.
Fri, Oct 11, 8:15 AM

Thu, Oct 10

zack committed rDVAU5acd37a6a95e: typing: minimal changes to make a no-op mypy run pass (authored by zack).
typing: minimal changes to make a no-op mypy run pass
Thu, Oct 10, 3:18 PM
zack closed D2113: typing: minimal changes to make a no-op mypy run pass.
Thu, Oct 10, 3:18 PM
zack committed rDLDSVNe28a8b849c28: typing: minimal changes to make a no-op mypy run pass (authored by zack).
typing: minimal changes to make a no-op mypy run pass
Thu, Oct 10, 2:39 PM
zack closed D2114: typing: minimal changes to make a no-op mypy run pass.
Thu, Oct 10, 2:39 PM
zack created D2114: typing: minimal changes to make a no-op mypy run pass.
Thu, Oct 10, 2:37 PM
zack created D2113: typing: minimal changes to make a no-op mypy run pass.
Thu, Oct 10, 12:15 PM
zack committed rDLDG8f3803991522: MANIFEST.in: ship py.typed (authored by zack).
MANIFEST.in: ship py.typed
Thu, Oct 10, 12:07 PM
zack added a comment to D2088: typing: minimal changes to make a no-op mypy run pass.

Needs a rebase (as i modified slightly the tox.ini today).

Thu, Oct 10, 10:11 AM
zack committed rDLDTAR1e937ff7a40b: Merge branch 'feature/typing' (authored by zack).
Merge branch 'feature/typing'
Thu, Oct 10, 10:11 AM
zack committed rDLDTARda20d00b68b5: typing: minimal changes to make a no-op mypy run pass (authored by zack).
typing: minimal changes to make a no-op mypy run pass
Thu, Oct 10, 10:11 AM
zack closed D2088: typing: minimal changes to make a no-op mypy run pass.
Thu, Oct 10, 10:11 AM
zack committed rMSLDb4a0bb2cabd5: JCAD 2019 talk: review and update (authored by zack).
JCAD 2019 talk: review and update
Thu, Oct 10, 9:54 AM

Wed, Oct 9

zack committed rMSLD5a071ab6dcd2: JCAD 2019 talk: first draft (authored by zack).
JCAD 2019 talk: first draft
Wed, Oct 9, 10:00 AM

Tue, Oct 8

zack committed rDLDDIR5b75b8d06ab9: typing: minimal changes to make a no-op mypy run pass (authored by zack).
typing: minimal changes to make a no-op mypy run pass
Tue, Oct 8, 4:54 PM
zack closed D2087: typing: minimal changes to make a no-op mypy run pass.
Tue, Oct 8, 4:54 PM
zack created D2088: typing: minimal changes to make a no-op mypy run pass.
Tue, Oct 8, 3:53 PM
zack created D2087: typing: minimal changes to make a no-op mypy run pass.
Tue, Oct 8, 3:50 PM
zack created D2081: swh identify -t snapshot: add support for symbolic refs.
Tue, Oct 8, 9:53 AM
zack added a comment to D2078: Add support for symbolic references.

Looks good, but I'm puzzled by some testing results.

Tue, Oct 8, 9:51 AM

Mon, Oct 7

zack committed rDGRPH8c1c7cd5fa0b: git2graph: add support for origins & snapshots (authored by zack).
git2graph: add support for origins & snapshots
Mon, Oct 7, 10:34 PM
zack committed rDGRPH11507e8aa8f7: git2graph: sanitize struct names (refactoring) (authored by zack).
git2graph: sanitize struct names (refactoring)
Mon, Oct 7, 10:34 PM
zack accepted D2080: Add count() methods.

In a subsequent commit please update also docs/api.rst to document the new methods (a catch-all thing to document all of them at once would do too).

Mon, Oct 7, 9:01 PM
zack accepted D2069: Add low level API (WIP).
Mon, Oct 7, 8:25 PM

Sun, Oct 6

zack committed rDMOD131298ca4571: swh.model: document how origin PIDs are computed (authored by zack).
swh.model: document how origin PIDs are computed
Sun, Oct 6, 8:10 PM
zack committed rDGRPH05e9f0b1d8fa: git2graph: add support for (explicitly passed) origin nodes (authored by zack).
git2graph: add support for (explicitly passed) origin nodes
Sun, Oct 6, 8:07 PM
zack committed rDGRPHa5caf475863b: git2graph: implement user-customizable graph filtering (authored by zack).
git2graph: implement user-customizable graph filtering
Sun, Oct 6, 7:43 PM
zack added a reverting change for rDGRPHd2ff3227a240: git2graph: drop node filtering and output, it has no sane semantics: rDGRPH303d017350c3: git2graph: add back node output support, with simpler/saner semantics.
Sun, Oct 6, 7:43 PM
zack committed rDGRPH303d017350c3: git2graph: add back node output support, with simpler/saner semantics (authored by zack).
git2graph: add back node output support, with simpler/saner semantics
Sun, Oct 6, 7:43 PM
zack committed rDGRPHa3aeaed4e5ca: git2graph: update benchmark figures in README (authored by zack).
git2graph: update benchmark figures in README
Sun, Oct 6, 7:43 PM
zack committed rDGRPHd2ff3227a240: git2graph: drop node filtering and output, it has no sane semantics (authored by zack).
git2graph: drop node filtering and output, it has no sane semantics
Sun, Oct 6, 7:43 PM
zack committed rDGRPH81af49b8d359: git2graph: add test suite (authored by zack).
git2graph: add test suite
Sun, Oct 6, 7:43 PM
zack committed rDGRPH8e47b6a15f70: git2graph: add real CLI parsing and make both nodes/edges files optional (authored by zack).
git2graph: add real CLI parsing and make both nodes/edges files optional
Sun, Oct 6, 7:43 PM
zack committed rDGRPHfc8c19bdfc9c: git2graph Makefile: factor out definition of wanted libs (authored by zack).
git2graph Makefile: factor out definition of wanted libs
Sun, Oct 6, 7:43 PM
zack committed rDGRPH112c87f448cb: git2graph: add (static) support for filtering desired nodes & edges (authored by zack).
git2graph: add (static) support for filtering desired nodes & edges
Sun, Oct 6, 7:43 PM
zack added a comment to D2069: Add low level API (WIP).

btw, I've tested this diff manually in tox and it does build find

Sun, Oct 6, 11:42 AM
zack requested changes to D2069: Add low level API (WIP).
Sun, Oct 6, 11:41 AM

Fri, Oct 4

zack added a comment to D2058: PersistentId constructor parameters validation.

thanks a lot @DanSeraf!, this has now been accepted, landed to master, and you've been added to the CONTRIBUTORS file :-)

Fri, Oct 4, 7:13 PM
zack committed rDMOD298c9429c9f1: CONTRIBUTORS: add @DanSeraf (authored by zack).
CONTRIBUTORS: add @DanSeraf
Fri, Oct 4, 7:13 PM
zack committed rDMODe7cf550ac3f3: Merge branch 'arcpatch-D2058' (authored by zack).
Merge branch 'arcpatch-D2058'
Fri, Oct 4, 7:11 PM
zack committed rDMOD375832f51bf5: PID: move validation checks to PersistentId constructor (authored by DanSeraf).
PID: move validation checks to PersistentId constructor
Fri, Oct 4, 7:11 PM
zack closed T1986: swh.model.identifiers: move validation from parsing_persistent_identifier to PersistentId constructor as Resolved by committing rDMOD375832f51bf5: PID: move validation checks to PersistentId constructor.
Fri, Oct 4, 7:11 PM · Easy hack, Data Model
zack closed D2058: PersistentId constructor parameters validation.
Fri, Oct 4, 7:11 PM
zack accepted D2058: PersistentId constructor parameters validation.
Fri, Oct 4, 7:06 PM
zack added a member for Paper authors: seirl.
Fri, Oct 4, 9:22 AM
zack committed R183:bd1cc6376583: add bibtex entries about forking on github (authored by zack).
add bibtex entries about forking on github
Fri, Oct 4, 9:18 AM
zack added a comment to D2058: PersistentId constructor parameters validation.

oh, and remember to add a "Closes: T1986" line to the diff description (and commit), so that there is a link with the corresponding issue

Fri, Oct 4, 8:30 AM
zack requested changes to D2058: PersistentId constructor parameters validation.
Fri, Oct 4, 8:29 AM

Thu, Oct 3

zack committed rDGRPHb3766062881c: pom.xml: reindent to 2-space per TAB (Maven convention) (authored by zack).
pom.xml: reindent to 2-space per TAB (Maven convention)
Thu, Oct 3, 4:02 PM
zack committed rDGRPHd46b451d54ae: java toolchain: sanitize (fat) jar naming to swh-graph-X.Y.Z.jar (authored by zack).
java toolchain: sanitize (fat) jar naming to swh-graph-X.Y.Z.jar
Thu, Oct 3, 4:02 PM
zack committed rDGRPH39913d016403: Dockerfile: tigthening, joining RUN runs together and rm temp stuff (authored by zack).
Dockerfile: tigthening, joining RUN runs together and rm temp stuff
Thu, Oct 3, 3:43 PM
zack committed rDGRPH1fd72529340b: java toolchain: sanitize build toolchain (authored by zack).
java toolchain: sanitize build toolchain
Thu, Oct 3, 3:06 PM
zack committed rCJSWH6e46253416fd: add optional mypy invocation to the CI pipeline (swh-pipeline) (authored by zack).
add optional mypy invocation to the CI pipeline (swh-pipeline)
Thu, Oct 3, 10:39 AM
zack closed D2070: add optional mypy invocation to the CI pipeline (swh-pipeline).
Thu, Oct 3, 10:39 AM
zack added a comment to D2070: add optional mypy invocation to the CI pipeline (swh-pipeline).

To install mypy in the docker image used to run the tests, you have to modify that Dockerfile.
You will have to land the dockerfile change prior to that diff of course.

Thu, Oct 3, 10:38 AM
zack created D2070: add optional mypy invocation to the CI pipeline (swh-pipeline).
Thu, Oct 3, 8:46 AM

Wed, Oct 2

zack committed rDLDG243310459653: typing: minimal changes to make a no-op mypy run pass (authored by zack).
typing: minimal changes to make a no-op mypy run pass
Wed, Oct 2, 11:50 AM
zack closed D2055: typing: minimal changes to make a no-op mypy run pass.
Wed, Oct 2, 11:50 AM
zack added a comment to D2032: typing: minimal changes to make a no-op mypy run pass.

where should the mypy_django_plugin dependency be? looks like this is required.

Wed, Oct 2, 11:46 AM
zack requested changes to D2058: PersistentId constructor parameters validation.

Hheya, thanks a lot for this contribution !

Wed, Oct 2, 10:14 AM
zack accepted D2060: docker-compose: Fix missing `start-` prefix on scheduler cli.

nice catch!

Wed, Oct 2, 8:19 AM
zack accepted D2059: Dict's get method does not take keyword argument.

not sure where I saw that kwd argument…

Wed, Oct 2, 8:18 AM

Tue, Oct 1

zack committed rDMOD6e7c3dac3c6c: mypi.ini: remove left-over "false positive" comment from dulwich exclude (authored by zack).
mypi.ini: remove left-over "false positive" comment from dulwich exclude
Tue, Oct 1, 6:03 PM
zack committed rDMODa9af3e7c66c0: swh identify: add support to compute snapshot PIDs of on-disk git repo (authored by zack).
swh identify: add support to compute snapshot PIDs of on-disk git repo
Tue, Oct 1, 6:02 PM
zack committed rDMODb2d8bbf56923: setup.py: move CLI dependencies to a dedicated swh-model[cli] subpackage (authored by zack).
setup.py: move CLI dependencies to a dedicated swh-model[cli] subpackage
Tue, Oct 1, 6:02 PM
zack closed D2056: swh identify: add support to compute snapshot PIDs of on-disk git repo.
Tue, Oct 1, 6:02 PM