Note that this Diff require also D2116

rebase

Update the code, tests in test_in_memory should now pass

In D2096#48894, @vlorentz wrote:

Eh, it needs a test ^^

rebased

rebased, get rid of pytest-flask and move some code in pytest_plugin.py

rebase

Update the docstring

In D2082#48580, @douardda wrote:

In D2082#48297, @olasd wrote:

From my tests and reading documentation further (pytest, tox), the issue really is a limitation of the way we're using the tox + pytest combination: we're running the tests on the checked out version of the module, instead of the version that's installed by tox (which is what pytest expects). If we adapt tox.ini to run tests on the installed version of the module (by running pytest [...] {envsitepackagesdir}/swh/core/..., then we can ship the pytest plugin wherever we want without triggering the dreaded ImportMismatchError.

well this is the default behavior of tox: execute tests from local working directory against installed python package. However if this default makes sense for project which tests are not part of the package itself, we may indeed consider executing tests that are installed with the package. It would probably be a sensible choice.

I am inclined to give this a try before landing this diff. Thanks for pointing this out.

In D2082#48297, @olasd wrote:

From my tests and reading documentation further (pytest, tox), the issue really is a limitation of the way we're using the tox + pytest combination: we're running the tests on the checked out version of the module, instead of the version that's installed by tox (which is what pytest expects). If we adapt tox.ini to run tests on the installed version of the module (by running pytest [...] {envsitepackagesdir}/swh/core/..., then we can ship the pytest plugin wherever we want without triggering the dreaded ImportMismatchError.

apply TestStorageCommonProp renaming

where should the mypy_django_plugin dependency be? looks like this is required.

See my comment, just in case.

Gheez

Adding tests 2 or 3 diffs after is a bold move... UNFAIR :-)

Oh! They are here. Ok then.

Ok but also lacks a test case for trailing garbage generated Error(), I'm afraid.

I would expect a (series of) test(s) with statements like with pytest.raises(Error, match='Corrupt object') somewhere in this diff.

remove journal_writer.py

closed by 1144f7dd1552

Ok but a comment would be welcome

also update test_api_client.py

writer: rename writer.direct.DirectKafkaWriter as writer.kafka.KafkaJournalWriter

My guts on this task tell me that what we need (what we really really need) is a 3rd solution:

In T1389#27957, @anlambert wrote:

Package manager	Packages listing url	Package metadata url	Package source tarball url
Rubygems	No public api endpoint available	https://rubygems.org/api/v2/rubygems/[package]/versions/[version].json	available in the medata

Looks globally ok to me, so feel free to ignore my comments.