Details

note that there is a dependency loop between this diff and D2024, because we do have an import loop between swh-storage and swh-journal (even after D1993)

zack added a parent revision: D2024: typing: minimal changes to make a no-op mypy run pass.Sep 22 2019, 4:50 PM

zack mentioned this in D2024: typing: minimal changes to make a no-op mypy run pass.

vlorentz added a subscriber: vlorentz.Sep 23 2019, 12:30 PM

vlorentz added inline comments.

swh/storage/tests/test_storage.py
47–49	why?

zack marked an inline comment as done.Sep 23 2019, 1:24 PM

zack added inline comments.

swh/storage/tests/test_storage.py
47–49	because without it: swh/storage/tests/test_storage.py:3926: error: Definition of "setUp" in base class "TestStorageData" is incompatible with definition in base class "SingleDbTestFixture" swh/storage/tests/test_storage.py:3926: error: Definition of "setUp" in base class "TestStorageData" is incompatible with definition in base class "DbTestFixture" swh/storage/tests/test_storage.py:3983: error: Definition of "setUp" in base class "TestStorageData" is incompatible with definition in base class "SingleDbTestFixture" swh/storage/tests/test_storage.py:3983: error: Definition of "setUp" in base class "TestStorageData" is incompatible with definition in base class "DbTestFixture" swh/storage/tests/test_api_client.py:133: error: Definition of "setUp" in base class "TestStorageData" is incompatible with definition in base class "SingleDbTestFixture" swh/storage/tests/test_api_client.py:133: error: Definition of "setUp" in base class "TestStorageData" is incompatible with definition in base class "DbTestFixture" and mypy is right, as the base class and the original fixture from `s.s.t.storage_testing` are used together, they should have compatible signatures

zack marked an inline comment as done.Sep 23 2019, 1:24 PM

vlorentz added inline comments.Sep 23 2019, 1:38 PM

swh/storage/tests/test_storage.py
47–49	You should remove these arguments to `setUp` from the parent classes then. I don't think we need it since douardda's refactoring of test classes months ago

zack added a subscriber: douardda.Sep 23 2019, 1:49 PM

zack added inline comments.

swh/storage/tests/test_storage.py
47–49	Actually, wrong reference in mu previous message, the `args/*kwargs` come from the `DbTestFixture` class in swh-core, not from swh-storage. I don't mind removing those args from there, but: (1) I cannot do that in this diff; (2) can @douardda confirm they should go?

zack edited parent revisions, added: D1993: journal_writer: use journal writer from swh.journal; removed: D2024: typing: minimal changes to make a no-op mypy run pass.Sep 24 2019, 1:27 PM

zack added a child revision: D2024: typing: minimal changes to make a no-op mypy run pass.

zack added a child revision: D2033: typing: minimal changes to make a no-op mypy run pass.Sep 24 2019, 1:48 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/642/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/642/console

init.py: switch to documented way of extending path

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/643/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/643/console

Harbormaster failed remote builds in B7957: Diff 6835!Sep 27 2019, 10:42 AM

mypy: ignore swh.journal to work-around dependency loop

Harbormaster failed remote builds in B7963: Diff 6842!Sep 27 2019, 3:32 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/646/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/646/console

typing: minimal changes to make a no-op mypy run pass
init.py: switch to documented way of extending path
mypy: ignore swh.journal to work-around dependency loop
storage.py: ignore typing of optional get_journal_writer import

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/648/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/648/console

Harbormaster failed remote builds in B7989: Diff 6853!Sep 28 2019, 12:50 PM

mypy.ini: be less flaky w.r.t. the packages installed in tox

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/649/ for more details.

Harbormaster completed remote builds in B7990: Diff 6854.Sep 28 2019, 1:26 PM

tox: anticipate mypy run to just after flake8

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/650/ for more details.

Harbormaster completed remote builds in B7991: Diff 6855.Sep 28 2019, 1:32 PM

douardda added inline comments.Sep 30 2019, 1:20 PM

swh/storage/tests/test_storage.py
47–49	I'm ok with adding these generic args here. In fact, I have a WIP to simply remove this 'data class' from the tests, but it's not ready for review yet. So meanwhile, the path of least work is just fine.