Page MenuHomeSoftware Heritage

Make the null compression use the "none" identifier instead of None
ClosedPublic

Authored by olasd on Mon, Sep 30, 10:37 PM.

Details

Summary

This is friendlier to configuration files

Depends on D2049
Depends on D2050

Test Plan

tox

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mon, Sep 30, 10:37 PM
douardda accepted this revision.Tue, Oct 1, 9:44 AM

See my comment, just in case.

swh/objstorage/tests/test_objstorage_azure.py
112

I tend to prefer the if a == b when both the if and else blocks are there.

This revision is now accepted and ready to land.Tue, Oct 1, 9:44 AM
olasd updated this revision to Diff 6901.Tue, Oct 1, 11:40 AM

Switch conditions to get a ==

olasd marked an inline comment as done.Tue, Oct 1, 11:40 AM