Page MenuHomeSoftware Heritage
Differential D2032

typing: minimal changes to make a no-op mypy run pass
ClosedPublic
Actions

Authored by zack on Sep 24 2019, 11:05 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEP39d124190019: mypy: properly type get/put methods, as well deposit_requests_types dict
rDDEPdd06930548f3: tox.ini: pass DJANGO_SETTINGS_MODULE to mypy environment
rDDEP4bb1de4415b0: Makefile.local: sync typecheck target with global Makefile.python
rDDEP17b3ee474e11: mypy: ignore psycopg2
rDDEP00440eb99622: requirements-test.txt: add back deps from master
rDDEP34153ef59b77: tox: add mypy environment
rDDEP422b92fc1910: init.py: switch to documented way of extending path
rDDEP0b3d526e956a: typing: convert leftover variable annotation to comments
rDDEPfd8db57691c3: typing: minimal changes to make a no-op mypy run pass
rDDEP2499370d740e: models: add migration to on_delete=protect

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Sep 24 2019, 11:05 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2019, 11:05 AM
zack added a parent revision: D2031: models: add required on_delete kwarg to ForeignKey.Sep 24 2019, 11:06 AM
swh-public-ci added a comment.Sep 24 2019, 11:08 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/179/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/179/console

Harbormaster failed remote builds in B7931: Diff 6817!Sep 24 2019, 11:08 AM
zack updated this revision to Diff 6828.Sep 25 2019, 11:08 AM
  • models: add required on_delete kwarg to ForeignKey
  • models: add migration to on_delete=protect
  • typing: minimal changes to make a no-op mypy run pass
swh-public-ci added a comment.Sep 25 2019, 11:10 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/181/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/181/console

Harbormaster failed remote builds in B7939: Diff 6828!Sep 25 2019, 11:10 AM
zack updated this revision to Diff 6829.Sep 25 2019, 11:41 AM
  • typing: convert leftover variable annotation to comments
swh-public-ci added a comment.Sep 25 2019, 11:43 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/182/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/182/console

Harbormaster failed remote builds in B7940: Diff 6829!Sep 25 2019, 11:43 AM
ardumont added a subscriber: ardumont.Sep 25 2019, 6:17 PM
ardumont added inline comments.
swh/deposit/migrations/0017_auto_20190925_0906.py
21 ↗(On Diff #6829)

This is out of scope for this diff, this is D2031's
You need to arc diff HEAD~3 --update D2032 (3 commits you made for this diff).

As the diff is stacked (i don't see the Depends on D2031 in the diff description but you probably added the diff's dependency yourself), the build should be ok.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 26 2019, 3:49 PM
This revision was landed with ongoing or failed builds.
Closed by commit rDDEP2499370d740e: models: add migration to on_delete=protect (authored by zack). · Explain Why
This revision was automatically updated to reflect the committed changes.
zack added a commit: rDDEP2499370d740e: models: add migration to on_delete=protect.
zack reopened this revision.Sep 27 2019, 10:34 AM
zack updated this revision to Diff 6834.Sep 27 2019, 10:35 AM
  • typing: minimal changes to make a no-op mypy run pass
  • typing: convert leftover variable annotation to comments
  • init.py: switch to documented way of extending path
zack added a comment.Sep 27 2019, 10:36 AM

this is now (also) waiting for an upstream release of django-stubs compatible with mypy >= 0.730

swh-public-ci added a comment.Sep 27 2019, 10:38 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/183/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/183/console

Harbormaster failed remote builds in B7956: Diff 6834!Sep 27 2019, 10:38 AM
zack updated this revision to Diff 6903.Oct 1 2019, 12:28 PM
  • tox: add mypy environment
swh-public-ci added a comment.Oct 1 2019, 12:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/184/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/184/console

Harbormaster failed remote builds in B8047: Diff 6903!Oct 1 2019, 12:30 PM
douardda added a subscriber: douardda.Oct 2 2019, 10:49 AM

where should the mypy_django_plugin dependency be? looks like this is required.

zack added a comment.Oct 2 2019, 11:46 AM
In D2032#47733, @douardda wrote:

where should the mypy_django_plugin dependency be? looks like this is required.

It comes from the django-stubs PyPI package, which is added by this diff to requirements-test.txt. But. The most recent release of django-stubs is incompatible (and declared as such in its dependencies) with the most recent release of mypy (0.730). I'm waiting for a new release of django-stubs to be made by upstream. See discussion here: https://github.com/typeddjango/django-stubs/issues/160

swh-public-ci added a comment.Oct 8 2019, 4:51 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/187/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/187/console

zack added a reviewer: ardumont.Oct 20 2019, 9:09 AM
zack planned changes to this revision.Nov 1 2019, 12:26 PM

removing this form the review queue for now, as it will need py3.7 in the CI to pass tests anyway

zack updated this revision to Diff 7601.Nov 1 2019, 3:36 PM
  • typing: minimal changes to make a no-op mypy run pass
  • typing: convert leftover variable annotation to comments
  • init.py: switch to documented way of extending path
  • tox: add mypy environment
  • requirements-test.txt: add back deps from master
  • Makefile.local: sync typecheck target with global Makefile.python
  • mypy: ignore psycopg2
zack planned changes to this revision.Nov 1 2019, 3:36 PM
swh-public-ci added a comment.Nov 1 2019, 3:38 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/193/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/193/console

Harbormaster failed remote builds in B8754: Diff 7601!Nov 1 2019, 3:38 PM
swh-public-ci added a comment.Nov 6 2019, 5:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/194/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/194/console

anlambert added a subscriber: anlambert.Nov 6 2019, 5:51 PM
anlambert added inline comments.
tox.ini
37 ↗(On Diff #7601)

Adding setenv = DJANGO_SETTINGS_MODULE = swh.deposit.settings.testing here will fix the mypy execution with tox

zack updated this revision to Diff 7684.Nov 7 2019, 9:25 AM
  • tox.ini: pass DJANGO_SETTINGS_MODULE to mypy environment
swh-public-ci added a comment.Nov 7 2019, 9:27 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/195/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/195/console

Harbormaster failed remote builds in B8852: Diff 7684!Nov 7 2019, 9:27 AM
zack updated this revision to Diff 7685.Nov 7 2019, 9:31 AM
  • mypy: properly type get/put methods, as well deposit_requests_types dict
swh-public-ci added a comment.Nov 7 2019, 9:34 AM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/196/ for more details.

Harbormaster completed remote builds in B8853: Diff 7685.Nov 7 2019, 9:34 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2019, 9:39 AM
Closed by commit rDDEPfd8db57691c3: typing: minimal changes to make a no-op mypy run pass (authored by zack). · Explain Why
This revision was automatically updated to reflect the committed changes.
zack added a commit: rDDEPfd8db57691c3: typing: minimal changes to make a no-op mypy run pass.
zack added a commit: rDDEP0b3d526e956a: typing: convert leftover variable annotation to comments.
zack added a commit: rDDEP422b92fc1910: init.py: switch to documented way of extending path.
zack added a commit: rDDEP34153ef59b77: tox: add mypy environment.
zack added a commit: rDDEP00440eb99622: requirements-test.txt: add back deps from master.
zack added a commit: rDDEP4bb1de4415b0: Makefile.local: sync typecheck target with global Makefile.python.
zack added a commit: rDDEP17b3ee474e11: mypy: ignore psycopg2.
zack added a commit: rDDEPdd06930548f3: tox.ini: pass DJANGO_SETTINGS_MODULE to mypy environment.
zack added a commit: rDDEP39d124190019: mypy: properly type get/put methods, as well deposit_requests_types dict.

Revision Contents
Changeset List

PathSize
1 line
1 line
7 lines
31 lines
3 lines
swh/
deposit/
api/
4 lines
4 lines
5 lines
1 line
tests/
4 lines
loader/
2 lines

Diff 7686

View Options

.gitignore

Loading...
View Options

MANIFEST.in

Loading...
View Options

Makefile.local

Loading...
View Options

mypy.ini

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/deposit/api/common.py

Loading...
View Options

swh/deposit/config.py

Loading...
View Options

swh/deposit/models.py

Loading...
View Options

swh/deposit/py.typed

Loading...
View Options

swh/deposit/tests/__init__.py

Loading...
View Options

swh/deposit/tests/loader/conftest.py

Loading...
About · Developer information · Legal