Page MenuHomeSoftware Heritage
Differential D2117

tests/algos: rewrite test_snapshot with pytest
ClosedPublic
Actions

Authored by douardda on Oct 10 2019, 5:49 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC8a9cfebb5ccf: tests/algos: rewrite test_snapshot with pytest
rDSTO8a9cfebb5ccf: tests/algos: rewrite test_snapshot with pytest

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 10 2019, 5:49 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 10 2019, 5:49 PM
douardda added a child revision: D2118: api: add (missing) refresh_stat_counters() endpoint.Oct 10 2019, 5:50 PM
swh-public-ci added a comment.Oct 10 2019, 5:56 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/692/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/692/console

Harbormaster failed remote builds in B8304: Diff 7102!Oct 10 2019, 5:56 PM
douardda mentioned this in D2090: tests: refactor main storage tests.Oct 11 2019, 3:56 PM
douardda updated this revision to Diff 7148.Oct 11 2019, 4:10 PM

rebased

swh-public-ci added a comment.Oct 11 2019, 4:22 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/704/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/704/console

Harbormaster failed remote builds in B8350: Diff 7148!Oct 11 2019, 4:22 PM
vlorentz accepted this revision.Oct 11 2019, 4:53 PM
This revision is now accepted and ready to land.Oct 11 2019, 4:53 PM
ardumont requested changes to this revision.Oct 11 2019, 6:57 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/storage/tests/algos/test_snapshot.py
42

either remove or use a logger.debug statement ;)

This revision now requires changes to proceed.Oct 11 2019, 6:57 PM
ardumont accepted this revision.Oct 12 2019, 7:51 AM
ardumont added inline comments.
swh/storage/tests/algos/test_snapshot.py
42

meh, I'm also fine if you fix that later...

This revision is now accepted and ready to land.Oct 12 2019, 7:51 AM
douardda updated this revision to Diff 7180.Oct 14 2019, 10:55 AM

rebae + kill print statement

swh-public-ci added a comment.Oct 14 2019, 11:10 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/714/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/714/console

Harbormaster failed remote builds in B8394: Diff 7180!Oct 14 2019, 11:10 AM
ardumont accepted this revision.Oct 14 2019, 11:11 AM
douardda edited the summary of this revision. (Show Details)Oct 14 2019, 1:09 PM
douardda updated this revision to Diff 7194.Oct 14 2019, 1:13 PM

rebased

swh-public-ci added a comment.Oct 14 2019, 1:28 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/724/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/724/console

Harbormaster failed remote builds in B8408: Diff 7194!Oct 14 2019, 1:28 PM
douardda edited parent revisions, added: D2095: test_in_memory: adapt tests for the InMemoryStorage to new storage test infra; removed: D2096: in_memory: fix handling of 'hidden' content in InMemoryStorage.Oct 14 2019, 2:37 PM
douardda updated this revision to Diff 7209.Oct 14 2019, 2:46 PM

rebased

swh-public-ci added a comment.Oct 14 2019, 2:50 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/733/ for more details.

Harbormaster completed remote builds in B8423: Diff 7209.Oct 14 2019, 2:50 PM
Closed by commit rDSTO8a9cfebb5ccf: tests/algos: rewrite test_snapshot with pytest (authored by douardda). · Explain WhyOct 14 2019, 3:11 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDSTO8a9cfebb5ccf: tests/algos: rewrite test_snapshot with pytest.
douardda added a commit: rDSTOC8a9cfebb5ccf: tests/algos: rewrite test_snapshot with pytest.Oct 30 2019, 5:22 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
tests/
algos/
64 lines

Diff 7222

View Options

swh/storage/tests/algos/test_snapshot.py

Loading...
About · Developer information · Legal