Page MenuHomeSoftware Heritage
Differential D2096

in_memory: fix handling of 'hidden' content in InMemoryStorage
AbandonedPublic
Actions

Authored by douardda on Oct 8 2019, 5:06 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Test Plan

test_in_memory.py should now pass

Diff Detail

Repository
rDSTO Storage manager
Branch
tests-refactorings
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 8407
Build 12182: tox-on-jenkinsJenkins
Build 12181: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 8 2019, 5:06 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 8 2019, 5:06 PM
swh-public-ci added a comment.Oct 8 2019, 5:09 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/689/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/689/console

Harbormaster failed remote builds in B8199: Diff 7029!Oct 8 2019, 5:09 PM
vlorentz accepted this revision.Oct 10 2019, 10:41 AM
This revision is now accepted and ready to land.Oct 10 2019, 10:41 AM
vlorentz requested changes to this revision.Oct 10 2019, 10:42 AM

Eh, it needs a test ^^

This revision now requires changes to proceed.Oct 10 2019, 10:42 AM
douardda added a comment.Oct 10 2019, 5:42 PM
In D2096#48894, @vlorentz wrote:

Eh, it needs a test ^^

In fact I had to fix this for the (new) tests to pass, so let's consider there are such tests, shall we? I should have mentioned this in the message of this Diff.

douardda updated this revision to Diff 7101.Oct 10 2019, 5:48 PM

rebase

douardda added a child revision: D2117: tests/algos: rewrite test_snapshot with pytest.Oct 10 2019, 5:49 PM
swh-public-ci added a comment.Oct 10 2019, 5:53 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/691/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/691/console

Harbormaster failed remote builds in B8303: Diff 7101!Oct 10 2019, 5:53 PM
vlorentz accepted this revision.Oct 11 2019, 10:34 AM
This revision is now accepted and ready to land.Oct 11 2019, 10:34 AM
douardda updated this revision to Diff 7147.Oct 11 2019, 4:09 PM

rebased

swh-public-ci added a comment.Oct 11 2019, 4:20 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/703/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/703/console

Harbormaster failed remote builds in B8349: Diff 7147!Oct 11 2019, 4:20 PM
ardumont accepted this revision.Oct 11 2019, 6:51 PM
douardda updated this revision to Diff 7179.Oct 14 2019, 10:54 AM

rebase

swh-public-ci added a comment.Oct 14 2019, 11:07 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/713/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/713/console

Harbormaster failed remote builds in B8393: Diff 7179!Oct 14 2019, 11:07 AM
douardda edited the summary of this revision. (Show Details)Oct 14 2019, 1:09 PM
douardda updated this revision to Diff 7193.Oct 14 2019, 1:12 PM

rebased

swh-public-ci added a comment.Oct 14 2019, 1:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/723/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/723/console

Harbormaster failed remote builds in B8407: Diff 7193!Oct 14 2019, 1:25 PM
douardda abandoned this revision.EditedOct 14 2019, 2:34 PM

merged in D2095

douardda mentioned this in D2095: test_in_memory: adapt tests for the InMemoryStorage to new storage test infra.Oct 14 2019, 2:36 PM
douardda removed a child revision: D2117: tests/algos: rewrite test_snapshot with pytest.Oct 14 2019, 2:37 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
4 lines

Diff 7193

View Options

swh/storage/in_memory.py

Loading...
About · Developer information · Legal