Differential D2004

Mock more things in MockedKafkaConsumer
ClosedPublic
Actions

Authored by olasd on Sep 18 2019, 5:45 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDJNL5c68ff1d35b2: Mock more things in MockedKafkaConsumer

Summary

This will allow reusing this mock in swh.indexer's cli tests.

Test Plan

tox is happy

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Sep 18 2019, 5:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 18 2019, 5:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/262/ for more details.

Harbormaster completed remote builds in B7848: Diff 6740.Sep 18 2019, 5:49 PM

Ok but a comment would be welcome

This revision is now accepted and ready to land.Sep 18 2019, 5:56 PM

Rebase and add comment

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/264/ for more details.

Harbormaster completed remote builds in B7852: Diff 6744.Sep 18 2019, 6:03 PM

Closed by commit rDJNL5c68ff1d35b2: Mock more things in MockedKafkaConsumer (authored by olasd). · Explain WhySep 18 2019, 6:04 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDJNL5c68ff1d35b2: Mock more things in MockedKafkaConsumer.

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

utils.py

14 lines

Diff 6745

View Options

swh/journal/tests/utils.py

Mock more things in MockedKafkaConsumerClosedPublicActions