Page MenuHomeSoftware Heritage

gnu.tests: Check gnu lister
ClosedPublic

Authored by ardumont on Fri, Oct 4, 6:30 PM.

Details

Summary

This triggers a gnu listing and checks the output from the scheduler.

For this, a new swh-listers fixture got added.
This allows to retrieve a test ready lister from its name (e.g gnu).
Those listers have then access to a scheduler fixture to be able to
check the lister's output in the scheduler backend.

Related T2023

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Oct 4, 6:30 PM
ardumont updated this revision to Diff 6972.Sat, Oct 5, 12:50 PM
  • gnu.tests: Checks lister output from scheduler
  • core.models: Fix typo
ardumont retitled this revision from gnu.tests: Add basic listing check from a tree.json.gz to gnu.tests: Check gnu listing.Sat, Oct 5, 12:56 PM
ardumont edited the summary of this revision. (Show Details)
ardumont added projects: Lister, Origin-GNU.
ardumont retitled this revision from gnu.tests: Check gnu listing to gnu.tests: Check gnu lister.
ardumont edited the summary of this revision. (Show Details)Sat, Oct 5, 2:25 PM
douardda requested changes to this revision.Mon, Oct 7, 10:24 AM
douardda added inline comments.
swh/lister/gnu/tests/test_lister.py
19–26 ↗(On Diff #6972)

wouldn't it be the right moment to (at least) move this in swh/lister/core/tests/conftest.py (or so)?

This revision now requires changes to proceed.Mon, Oct 7, 10:24 AM
ardumont added inline comments.Mon, Oct 7, 10:33 AM
swh/lister/gnu/tests/test_lister.py
19–26 ↗(On Diff #6972)

I entertained the idea then i did not really know how to "properly" handle the DATADIR which is different between listers.

ardumont added inline comments.Mon, Oct 7, 2:28 PM
swh/lister/gnu/tests/test_lister.py
19–26 ↗(On Diff #6972)

wip in swh-core

ardumont added inline comments.Tue, Oct 8, 11:08 AM
swh/lister/gnu/tests/test_lister.py
19–26 ↗(On Diff #6972)

no longer wip, it's happening -> D2082

douardda accepted this revision.Tue, Oct 8, 1:39 PM
This revision is now accepted and ready to land.Tue, Oct 8, 1:39 PM
ardumont updated this revision to Diff 7040.Wed, Oct 9, 2:46 PM

Update diff?

ardumont updated this revision to Diff 7041.Wed, Oct 9, 2:47 PM

Include the tox.ini fix.

  • tox.ini: Use tests installed files instead of working directory
This revision was landed with ongoing or failed builds.Wed, Oct 9, 5:39 PM
This revision was automatically updated to reflect the committed changes.