Page MenuHomeSoftware Heritage

api: make backend_factory argument of RPCServerApp() optional
ClosedPublic

Authored by douardda on Oct 9 2019, 5:39 PM.

Details

Summary

defaults to calling the backend_class constructor.

Depends on D2104

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 9 2019, 5:39 PM
vlorentz requested changes to this revision.Oct 9 2019, 5:49 PM
vlorentz added a subscriber: vlorentz.

Should be documented

This revision now requires changes to proceed.Oct 9 2019, 5:49 PM

and the type in the doc of backend_class should use Optional[] too

douardda updated this revision to Diff 7092.Oct 10 2019, 4:21 PM

Update the docstring

vlorentz accepted this revision.Oct 11 2019, 10:35 AM
This revision is now accepted and ready to land.Oct 11 2019, 10:35 AM