Page MenuHomeSoftware Heritage
Differential D2107

api/tests: split test_api.py in 2 files and rewrite tests using pytest
ClosedPublic
Actions

Authored by douardda on Oct 9 2019, 5:40 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDCOREf85802049637: api/tests: split test_api.py in 2 files and rewrite tests using pytest
Summary

using pytest-flask for test_rpc_server.py

Depends on D2106

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 9 2019, 5:40 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 9 2019, 5:40 PM
swh-public-ci added a comment.Oct 9 2019, 5:50 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/309/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/309/console

Harbormaster failed remote builds in B8247: Diff 7054!Oct 9 2019, 5:50 PM
vlorentz accepted this revision.Oct 9 2019, 5:53 PM
vlorentz added a subscriber: vlorentz.

I really don't like how app gets implicitly/indirectly used by the tests...

This revision is now accepted and ready to land.Oct 9 2019, 5:53 PM
vlorentz added a comment.Oct 9 2019, 5:54 PM

Please add a comment on the app fixture to explain what is going on.

douardda updated this revision to Diff 7094.Oct 10 2019, 4:29 PM

rebased, get rid of pytest-flask and move some code in pytest_plugin.py

pytest-flask has some side effects not easily fixed, so we just embed in our
pytest_plugin the required code, aka a flask_app_cliant fixture (same as
pytest-flask's client fixture), and a fixture hook to be executed each time
to ensure flake's test context is properly set.

Harbormaster failed remote builds in B8295: Diff 7094!Oct 10 2019, 4:29 PM
swh-public-ci added a comment.Oct 10 2019, 4:29 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/313/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/313/console

This revision was landed with ongoing or failed builds.Oct 11 2019, 10:42 AM
Closed by commit rDCOREf85802049637: api/tests: split test_api.py in 2 files and rewrite tests using pytest (authored by douardda). · Explain Why
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDCOREf85802049637: api/tests: split test_api.py in 2 files and rewrite tests using pytest.

Revision Contents
Changeset List

PathSize
swh/
core/
api/
tests/
56 lines
73 lines
31 lines

Diff 7118

View Options

swh/core/api/tests/test_api.py

Loading...
View Options

swh/core/api/tests/test_rpc_client.py

Loading...
View Options

swh/core/api/tests/test_rpc_server.py

Loading...
View Options

swh/core/pytest_plugin.py

Loading...
About · Developer information · Legal