Page MenuHomeSoftware Heritage

Move to streaming decompression API
ClosedPublic

Authored by olasd on Mon, Sep 30, 10:30 PM.

Details

Summary

This allows us to detect whether the (compressed) object got corrupted with
trailing data, which the plain decompress() api doesn't allow.

This will be useful in further diffs

Depends on D2044

Test Plan

tox

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda requested changes to this revision.Tue, Oct 1, 9:32 AM

I would expect a (series of) test(s) with statements like with pytest.raises(Error, match='Corrupt object') somewhere in this diff.

This revision now requires changes to proceed.Tue, Oct 1, 9:32 AM
douardda accepted this revision.Tue, Oct 1, 9:38 AM

Adding tests 2 or 3 diffs after is a bold move... UNFAIR :-)

This revision is now accepted and ready to land.Tue, Oct 1, 9:38 AM
This revision was automatically updated to reflect the committed changes.