Page MenuHomeSoftware Heritage
Differential D2055

typing: minimal changes to make a no-op mypy run pass
ClosedPublic
Actions

Authored by zack on Oct 1 2019, 2:43 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDLDG243310459653: typing: minimal changes to make a no-op mypy run pass
Test Plan

tox -e mypy

Diff Detail

Repository
rDLDG Git loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Oct 1 2019, 2:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 1 2019, 2:43 PM
zack added a parent revision: D2054: typing: minimal changes to make a no-op mypy run pass.Oct 1 2019, 2:44 PM
swh-public-ci added a comment.Oct 1 2019, 2:45 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/99/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/99/console

Harbormaster failed remote builds in B8056: Diff 6912!Oct 1 2019, 2:45 PM
swh-public-ci added a comment.Oct 1 2019, 4:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tox/100/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tox/100/console

swh-public-ci added a comment.Oct 1 2019, 4:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/101/ for more details.

Harbormaster completed remote builds in B8056: Diff 6912.Oct 1 2019, 4:57 PM
douardda accepted this revision.Oct 2 2019, 10:51 AM
This revision is now accepted and ready to land.Oct 2 2019, 10:51 AM
Closed by commit rDLDG243310459653: typing: minimal changes to make a no-op mypy run pass (authored by zack). · Explain WhyOct 2 2019, 11:50 AM
This revision was automatically updated to reflect the committed changes.
zack added a commit: rDLDG243310459653: typing: minimal changes to make a no-op mypy run pass.

Revision Contents
Changeset List

PathSize
1 line
18 lines
swh/
5 lines
loader/
5 lines
git/
1 line
tests/
2 lines
10 lines

Diff 6936

View Options

.gitignore

Loading...
View Options

mypy.ini

Loading...
View Options

swh/__init__.py

Loading...
View Options

swh/loader/__init__.py

Loading...
View Options

swh/loader/git/py.typed

Loading...
View Options

swh/loader/git/tests/conftest.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal