Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

rDSTOCdbea02c5f1c5: test_api_client: refactor the code for new pytest based infra
rDSTOdbea02c5f1c5: test_api_client: refactor the code for new pytest based infra

Summary

This uses the latest pytest fixtures added in swh.core to define a
swh_storage fixture that setup a RPC client/server stack to execute
tests defined in classes TestStorage and TestStorageGeneratedData
(from swh.storage.tests.test_storage).

Test Plan

all tests should now pass using pytest

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Oct 10 2019, 5:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 10 2019, 5:50 PM

Note that this Diff require also D2116

douardda added a parent revision: D2116: api/tests: add a few test for the whole rpc client/server stack.Oct 10 2019, 5:52 PM

Harbormaster failed remote builds in B8306: Diff 7104!Oct 10 2019, 5:58 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/694/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/694/console

douardda mentioned this in D2090: tests: refactor main storage tests.Oct 11 2019, 3:16 PM

rebased

douardda added a child revision: D2091: test_storage: kill StorageTestDbFixture class.Oct 11 2019, 4:31 PM

vlorentz requested changes to this revision.Oct 11 2019, 4:56 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/storage/tests/test_api_client.py
34	Let's use a better name; there are already too many `app` variables in our code
47	it should be un-monkeypatched at the end of the fixture.
59	Should be un-patched at end too

This revision now requires changes to proceed.Oct 11 2019, 4:56 PM

olasd removed a parent revision: D2116: api/tests: add a few test for the whole rpc client/server stack.Oct 11 2019, 5:02 PM

douardda added inline comments.Oct 11 2019, 5:31 PM

swh/storage/tests/test_api_client.py
34	I've stick to the fixture name used in pytest-flask (even if I do not use this package, in the end).
34	And more importantly, it's what is expected by the rpc client/server fixture stuff in swh.core.pytest_plugin...

ardumont accepted this revision.Oct 11 2019, 7:03 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/storage/tests/test_api_client.py
47	can you enlighten me as to why? And also how to do that?

rebase

douardda added inline comments.Oct 14 2019, 10:57 AM

swh/storage/tests/test_api_client.py
47	it should be un-monkeypatched at the end of the fixture. I don't think it's useful in any case, but meh.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/716/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/716/console

Harbormaster failed remote builds in B8396: Diff 7182!Oct 14 2019, 11:16 AM

vlorentz added inline comments.Oct 14 2019, 12:26 PM

swh/storage/tests/test_api_client.py
34	Ok for `app`
47	I don't think it's useful in any case, but meh. I don't want to waste time debugging when we'll write a test that expects the un-patched version .