I trust the tests to validate the "GraphServerApp does not use any of the features added by RPCServerApp" assertion :-)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 3 2023
Jan 3 2023
Dec 16 2022
Dec 16 2022
douardda committed rDOBJSRPL2f297a695943: Add a --size-limit cli option to the replay command (authored by douardda).
Add a --size-limit cli option to the replay command
Dec 15 2022
Dec 15 2022
douardda committed rDOBJSRPL11b1b233e2b1: Add tests for replay scenarios with add errors (authored by douardda).
Add tests for replay scenarios with add errors
Improve logging in replay.py
douardda committed rDOBJSRPLa3e366823d81: Rework the replaying exception handling (authored by douardda).
Rework the replaying exception handling
Dec 9 2022
Dec 9 2022
Bump copyright dates
In D8939#232688, @douardda wrote:In D8939#232687, @douardda wrote:In D8939#232508, @vlorentz wrote:Could you use a logger instance,
what do you mean by "use a logger instance"?
and add if logger.isEnabledFor(logging.DEBUG): before logger.debug statements that use hash_to_hex?
sure
Actually, why would this be needed? I mean I don't expect has_to_hex() to be a fat cpu burner, do I?
In D8939#232687, @douardda wrote:In D8939#232508, @vlorentz wrote:Could you use a logger instance,
what do you mean by "use a logger instance"?
and add if logger.isEnabledFor(logging.DEBUG): before logger.debug statements that use hash_to_hex?
sure
In D8939#232508, @vlorentz wrote:Could you use a logger instance,
Dec 8 2022
Dec 8 2022
douardda added inline comments to D8940: cli.add_forge_now: Open `register-lister` with sensible defaults.
Dec 7 2022
Dec 7 2022
(no test? worth it?)
Nov 28 2022
Nov 28 2022
douardda triaged T4704: Publish objects that has been subject to a TDN in a (series of) kafka topic as High priority.
In T4657#98361, @lunar wrote:[...]
@douardda: would you agree?
Nov 23 2022
Nov 23 2022
douardda committed rDPROV869f9f168255: kafka: improve the message schema for the journal writer (authored by douardda).
kafka: improve the message schema for the journal writer
Fix typo (orign -> origin)
Nov 22 2022
Nov 22 2022
Nov 2 2022
Nov 2 2022
douardda committed rDPROVe4795882d3aa: sql: only insert entities that we really need to insert in relation_add (authored by douardda).
sql: only insert entities that we really need to insert in relation_add
douardda committed rDPROVc89763f01c8d: tests: set journal writer auto_flush to False (authored by douardda).
tests: set journal writer auto_flush to False
douardda committed rDPROV90a4250a2c57: tests: simplify and (possibly) fix the grpc_server helper context manager (authored by douardda).
tests: simplify and (possibly) fix the grpc_server helper context manager
douardda updated the diff for D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.
also add rabbitmq marker in pytest.ini
Oct 21 2022
Oct 21 2022
douardda committed rDSTO0e8da810ac96: tests: only flush() the kafka journal writer once per test (authored by douardda).
tests: only flush() the kafka journal writer once per test
On the outstanding sample of one execution on jenkins: 11min 44s vs 13min 39s (previous execution, before this diff)
douardda committed rDSTOfe0eaee8718b: Make the replayer not crash on kafka messages that fail to be converted as… (authored by douardda).
Make the replayer not crash on kafka messages that fail to be converted as…
douardda committed rDSTO242e37a7be35: Add a comment that should have been "kept" from 850a7553b (authored by douardda).
Add a comment that should have been "kept" from 850a7553b
douardda updated the diff for D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.
rebase
douardda committed rDJNL7c83ee11ecab: writer: make calling flush() in write_addition(s)() optional (authored by douardda).
writer: make calling flush() in write_addition(s)() optional
douardda committed rDJNL04a84dba6a17: tests: make the kafka_server_base fixture a function scoped one (authored by douardda).
tests: make the kafka_server_base fixture a function scoped one
typos
douardda updated the diff for D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.
fix typos as reported by anlambert
Add the missing docstring entry
douardda added a comment to D8751: Make the replayer not crash on kafka messages that fail to be converted as model objects.
In D8751#227397, @anlambert wrote:Looks good to me , just noticed some remaining typos: one in code and another in commit message (s/sctructure/structure).
Oct 20 2022
Oct 20 2022
In D8697#227324, @ardumont wrote:I don't see the difference comparing the master build or the diff build times but wny not ;)
douardda added a comment to D8747: conda: Yield listed origins after all artifacts in a page are processed.
shouldn't this fix come with a test of some sort?
In D8748#227318, @douardda wrote:it's unclear to me whether this actually implements the iteration protocol described in the API doc (https://learn.microsoft.com/en-us/nuget/api/catalog-resource#iterating-over-catalog-items) or not.
douardda added a comment to D8747: conda: Yield listed origins after all artifacts in a page are processed.
I believe the commit title lacks a verb, doesn't it? ("conda: Yield listed origins after all artifacts in a page are processed" or something similar?)
it's unclear to me whether this actually implements the iteration protocol described in the API doc (https://learn.microsoft.com/en-us/nuget/api/catalog-resource#iterating-over-catalog-items) or not.
Oct 19 2022
Oct 19 2022
with the same idea as the inline comment, it would be better to rename the network like 'swh-mirror' rather than 'swhtest-mirror'.
douardda committed rDWAPPS176799962e82: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDPROV4ed652e03d12: Move all non pytest-related functions from conftest to utils.py (authored by douardda).
Move all non pytest-related functions from conftest to utils.py
douardda committed rDPROVb686e9a516e0: tests: small fixes in test_journal_client.py (authored by douardda).
tests: small fixes in test_journal_client.py
Oct 18 2022
Oct 18 2022
douardda requested review of D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.
closed by da5c23bdbdd06e919e9b45576c378623990b8b57
douardda updated the diff for D8695: Move all non pytest-related functions from conftest to utils.py.
rebase (+ a small fix)
douardda requested review of D8697: tests: make the kafka_server_base fixture a function scoped one.
douardda committed rDPROV60c5a5c463ec: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDJNL2c6d9e05eca6: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDVAUb033a2e19ede: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDSTOc1c2dbf01bce: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDSEA2912b17c611b: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDSCHaeb870a7009a: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDSCRUBafacc488cd3d: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
rebase
douardda committed rDTSCN8c6974fa8069: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDTPLd6d658a078f1: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDOPH8142df4b7b49: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDOBJSRPL5461a1f7c2b9: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDOBJSc97160b5b1bc: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDMODfe8d55588a9b: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDLDSVN8e38d524c0a6: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDLDMD3246b8d6b955: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDLDHG856dbe83f04f: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8
douardda committed rDLDGfc0c81305fbb: pre-commit, tox: Bump pre-commit, codespell, black and flake8 (authored by douardda).
pre-commit, tox: Bump pre-commit, codespell, black and flake8