First version of guided tour has been deployed to production for ambassador and staff users.

I think we could also get an accurate count of deposit origins (HAL, IPOL) using swh-deposit API

Fix a guided tour step, element id was removed after a rebase.

Rebase

Remove added empty line

Update:

• install as root and in /opt
• update commit message

Only one nit about the display. Using modal windows/popover will mean that there will be no easy way to have, as a user, the full list: one will have to click on each logo one by one, which could be quite annoying. Would it be possible to have a page with a rendering of the table above? (not sure if we want all columns, but at least the last update time and the number of origins per forge instance looks relevant and interesting to me). It coule be either in addition of what you propose (e.g., as a "coverage details" link, leading to the full page), or as a replacement of it (e.g., by making each forge icon just a link to the relevant anchor within the table on the "coverage details" page).

Yes, that's a good point.
On the other hand, not including it means we install-depend on nodejs+yarn and a C compiler...

I added a couple of inline comments for some issues to fix and some improvements to add.

@anlambert We are going to need to precompile some assets in swh-search using JS dependencies. We define the grammar in JS, which can then be compile into a big JSON file, that will be read from Python; see swh/search/parser/package.json. Do you have some advice to make this work nicely?

Some reports of what have been done so far and some future directions regarding the display of those data in swh-web.

It seems the remaining lister instances to process are the phabricator ones that also need credentials.
This is what we currently have in the listers table in scheduler database.

In D5819#154171, @swh-public-ci wrote:

Build has FAILED

Patch application report for D5819 (id=21588)

Rebasing onto 3bfc6942fe...

Current branch diff-target is up to date.

Changes applied before test

commit c8e32e745aa3e76fc8d972cc89f6d01757e34e73
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed May 12 11:42:40 2021 +0200

    assets/webapp: Add UI guided tour to help users discover features
    
    Add a Web UI guided tour implemented using the intro.js library.
    
    The tour showcases the main browsing features offered by Software
    Heritage web application by highlighting the relevant DOM elements
    and displaying help texts in tooltips.
    
    The tour can span multiple web pages and steps are configured in
    a YAML file for help texts writing commodity.
    
    Currently, the homepage, the main origin browsing view and content
    browsing view are covered by the tour.
    
    Related to T3202

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/962/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/962/console

Rebase

Precise metrics about listed origins and their counts will be retrieved from the scheduler database, no need to backfill origins with swh-counters then, closing this.

Better indeed, thanks !

Looks good to me !

Rebase on top of D5982 fixing flaky cypress test

highlight.js 11.1.0 has been released fixing numerous regressions since the 11.0 release, so it is time to perform the upgrade.

Update:

• Rebase
• Open origin in browser tab in save code now UI too

In D5978#153850, @ardumont wrote:

I got the idea but I am wondering if it would not be simpler to store the list of visit statuses directly in the model ?

It's in the model ;) (but not in ListedOrigin if that's what you meant ;)

This would allow finer processing for the scheduling policies, but this will be more costly to store.

Hum, yes, i think that will be too much to store and i'm not sure what the other benefits would be
aside from the current need [1]. Also, that duplicates the information we already have in the archive?

[1] Right now, the need is a simple one, a counter to ease determine if too many failed
attempts occurred or not. If so, disable the origin in the model here (it will come during the week

I got the idea but I am wondering if it would not be simpler to store the list of visit statuses directly in the model ?
This would allow finer processing for the scheduling policies, but this will be more costly to store.

Nice, that lister should perform better once that feature deployed to production. I added a first batch of inline comments.

Fix cypress test

After some hacks on the current Jenkins pipeline for swh-web to test if it was feasible, I managed to setup the use of sorry-cypress but could not run multiple cypress in parallel as Jenkins pipelines forbid nested parallel stages.
So this would require setting up a dedicated pipeline build job for cypress tests as currently Python and cypress tests are executed in parallel in a single job.

I still find docutils warnings after last diff update in those pages (sorry):

• http://localhost:5004/api/1/resolve/doc/
• http://localhost:5004/api/1/raw-extrinsic-metadata/swhid/doc/

In D5971#153603, @vlorentz wrote:

indeed, it was a little tricky to get it right

Update:

• add more steps to origin browse view
• add more steps to content browse view and use more relevant source code file as example
• polish js code
• fix some spotted issues while testing the tour
• improve interactive part of the tour regarding source code lines selection
• update cypress tests

Nice ! I guess the remaining docutils error in http://localhost:5004/api/1/raw-extrinsic-metadata/swhid/doc/ is due to the missing target node handling ?

Update:

• Add more steps to origin browse view tour (notably for the SWHIDs tab)
• Fix bugs spotted by @vlorentz

I'm now at the "Highlight a source code line" step, the "Back" button is disabled, and the "Next" button doesn't do anything. Is this a WIP?

In D5819#153337, @vlorentz wrote:

Two other bugs at once:

• while on the "Search archived software origins" modal, make sure the "Next" button is selected
• Press space -> bug #2: it makes the page scroll instead of having the same action as pressing Enter or clicking the button
• Actually click the button
• bug #3: Because the page scrolled at the previous step, it highlights the wrong part of the page as the "Save Code Now" button:

In D5819#153336, @vlorentz wrote:

I found a bug:

• click "Help"
• wait for the popup to appear
• click anywhere outside the popup (could happen by accident)
• click "Help" again, directs me to /?guided_tour=0&guided_tour_next=http://127.0.0.1:5004/# but does not start a tour
• clicking "Help" again does nothing

@vsellier, could you also open a read access to the scheduler service ? I will need it to work on T3127.

Almost there, a couple more steps to add in the tour and some polishing to do before landing this.

Update:

• rebase
• improve guided tour steps (thanks @moranegg !)

In D5819#152907, @moranegg wrote:

Great work!

I just suggested some UX changes to make it more fun, but the tour sounds really great.

What's the ETA on this? (not for urgency, just to know when to expect this for the ambassadors...)

Still WIP

Update:

• rebase
• improve CSS
• add more steps to orgin browse view guided tour