Page MenuHomeSoftware Heritage

apidoc: Remove explicit recursion used in visit_field_list
ClosedPublic

Authored by vlorentz on Fri, Jul 9, 1:18 PM.

Details

Summary

The visit is already recursive, we don't need to add this explicit
recursion.

Children nodes can be dispatched to visit_field_name and
visit_field_body instead.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5984 (id=21578)

Rebasing onto dd2e5e261b...

Current branch diff-target is up to date.
Changes applied before test
commit 3bfc6942fe497ff28eed722ab7f208cdd1b81110
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jul 9 13:18:12 2021 +0200

    apidoc: Remove explicit recursion used in visit_field_list
    
    The visit is already recursive, we don't need to add this explicit
    recursion.
    
    Children nodes can be dispatched to visit_field_name and
    visit_field_body instead.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/961/ for more details.

anlambert added a subscriber: anlambert.

Better indeed, thanks !

This revision is now accepted and ready to land.Fri, Jul 9, 1:54 PM