Page MenuHomeSoftware Heritage

pattern: Use URL network location as instance name when not provided
ClosedPublic

Authored by anlambert on Tue, Jul 13, 12:40 PM.

Details

Summary

Make the instance parameter of the base pattern lister optional and set
lister name to URL network location when not provided.

It simplifies lister creation when associated forge type have a lot of
instances in the wild (e.g. gitlab or cgit) while giving more details
about the listed forge instance.

Also process listers for forge with multiple instances (cgit, gitea,
gitlab, phabricator and tuleap) to ensure URL network location will be
used when instance parameter is not provided.

Related to T3403

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5989 (id=21615)

Rebasing onto df46b22098...

Current branch diff-target is up to date.
Changes applied before test
commit 6c123508634c6467b2fb9be83de69e6a5e77363a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 13 12:33:41 2021 +0200

    pattern: Use URL network location as instance name when not provided
    
    Make the instance parameter of the base pattern lister optional and set
    lister name to URL network location when not provided.
    
    It simplifies lister creation when associated forge type have a lot of
    instances in the wild (e.g. gitlab or cgit) while giving more details
    about the listed forge instance.
    
    Also process listers for forge with multiple instances (cgit, gitea,
    gitlab, phabricator and tuleap) to ensure URL network location will be
    used when instance parameter is not provided.
    
    Related to T3403

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/331/ for more details.

olasd added a subscriber: olasd.

Thanks!

This revision is now accepted and ready to land.Tue, Jul 13, 1:09 PM