Page MenuHomeSoftware Heritage

moranegg (Morane Otilia Gruenpeter)
User

Projects

User Details

User Since
Feb 14 2017, 10:57 AM (94 w, 6 d)

Recent Activity

Wed, Nov 21

moranegg added a comment to T1298: Review Wikidata property proposal for swh-id release.

Here is the approved property on Wikidata:
https://www.wikidata.org/wiki/Property:P6138

Wed, Nov 21, 2:25 PM · Wikidata, Metadata workflow

Wed, Nov 14

moranegg added a comment to T1346: Define persistent URL to be used as archive url property in Wikidata.

This will also be useful for:

  • ASCL
  • swMath
  • OpenAire
Wed, Nov 14, 4:48 PM · Web app, Wikidata
moranegg triaged T1346: Define persistent URL to be used as archive url property in Wikidata as Normal priority.
Wed, Nov 14, 4:42 PM · Web app, Wikidata
moranegg triaged T1345: Add HAL-deposit to CodeMeta mapping in deposit/docs as Low priority.
Wed, Nov 14, 4:30 PM · SWORD deposit, Metadata workflow
moranegg added a comment to T1344: Write specs about metadata workflow .

Where would you put this type of specs?

Wed, Nov 14, 4:29 PM · Metadata workflow
moranegg accepted D637: Document metadata providers..

I think that @douardda's comments should be resolved in a specs document and not in the current docs.
So I'm opening a task about that, referring to the discussion here [T1344]

Wed, Nov 14, 4:03 PM
moranegg triaged T1344: Write specs about metadata workflow as Normal priority.
Wed, Nov 14, 4:03 PM · Metadata workflow
moranegg closed T1298: Review Wikidata property proposal for swh-id release as Resolved.
Wed, Nov 14, 2:45 PM · Wikidata, Metadata workflow
moranegg added a comment to D637: Document metadata providers..

Also, I'm not sure why the build is failing.
Can I relaunch a build as a reviewer, or only by changing the diff will the build be relaunched?

Wed, Nov 14, 2:27 PM

Mon, Nov 12

moranegg added a project to P332 Metadata files count 22.5.2017: Metadata workflow.
Mon, Nov 12, 5:12 PM · Metadata workflow
moranegg changed the edit policy for P332 Metadata files count 22.5.2017.
Mon, Nov 12, 5:11 PM · Metadata workflow
moranegg added a comment to T1298: Review Wikidata property proposal for swh-id release.

Here is the property proposal under discussion: https://www.wikidata.org/wiki/Wikidata:Property_proposal/SWH_Release_ID

Mon, Nov 12, 2:37 PM · Wikidata, Metadata workflow

Nov 9 2018

moranegg added inline comments to D637: Document metadata providers..
Nov 9 2018, 11:26 AM

Nov 8 2018

moranegg added a comment to T1298: Review Wikidata property proposal for swh-id release.

Questions and Answers with the WikiDigi WG (from Toto256):

  1. Even thought we identified the release ID to be the most appropriate ID to use in Wikidata, should the property specify it is a release instead of being a generic SWH ID?

As we discussed, it's easier to have a limited scope for a property : it allows for defining constraints, building bots and explaining the purpose.
This doesn't mean we can later add other properties for others ids.

Nov 8 2018, 11:49 AM · Wikidata, Metadata workflow

Nov 7 2018

moranegg added a watcher for Wikidata: moranegg.
Nov 7 2018, 4:25 PM
moranegg shifted T1298: Review Wikidata property proposal for swh-id release from the Restricted Space space to the S1 Public space.
Nov 7 2018, 4:22 PM · Wikidata, Metadata workflow
moranegg added a project to T1298: Review Wikidata property proposal for swh-id release: Wikidata.
Nov 7 2018, 4:22 PM · Wikidata, Metadata workflow
moranegg created Wikidata.
Nov 7 2018, 4:21 PM

Nov 5 2018

moranegg accepted D619: Translate authors from package.json.

Accepting because I accepted D620

Nov 5 2018, 5:31 PM
moranegg accepted D617: Always output valid JSON-LD..

Accepting because I accepted D620

Nov 5 2018, 5:31 PM
moranegg accepted D620: Translate from pom.xml and codemeta.json..
Nov 5 2018, 5:30 PM
moranegg requested changes to D620: Translate from pom.xml and codemeta.json..

There is no test a case of a revision with multiple 'metadata files' which is an intriguing case - this should be tested before accepting this diff.

Nov 5 2018, 1:16 PM

Oct 31 2018

moranegg added a comment to D620: Translate from pom.xml and codemeta.json..

Add README or CITATION to data directory with the following:
Matthew B. Jones, Carl Boettiger, Abby Cabunoc Mayes, Arfon Smith, Peter Slaughter, Kyle Niemeyer, Yolanda Gil, Martin Fenner, Krzysztof Nowak, Mark Hahnel, Luke Coy, Alice Allen, Mercè Crosas, Ashley Sands, Neil Chue Hong, Patricia Cruse, Daniel S. Katz, Carole Goble. 2017. CodeMeta: an exchange schema for software metadata. Version 2.0. KNB Data Repository. doi:10.5063/schema/codemeta-2.0
swh:1:dir:39c509fd2002f9e531fb4b3a321ceb5e6994e54a;origin=https://github.com/codemeta/codemeta

Oct 31 2018, 4:00 PM
moranegg added a comment to T1110: document GitHub caseness caveats.

When using the save code now feature with https://github.com/codemeta/codemeta.git the origin created was exactly as requested.
Now there are 2 different origins:

Oct 31 2018, 11:03 AM · GitHub lister, Development documentation

Oct 30 2018

moranegg triaged T1299: Configuration file when empty returns AttributeError: 'NoneType' object has no attribute 'get' as Low priority.
Oct 30 2018, 5:00 PM · Core & foundations
moranegg created P328 swh-indexer test fails with tox -r.
Oct 30 2018, 4:31 PM
moranegg edited P169 One year plan.
Oct 30 2018, 12:30 PM · Metadata workflow
moranegg renamed T1298: Review Wikidata property proposal for swh-id release from Review Wikidata property for swh-id release to Review Wikidata property proposal for swh-id release.
Oct 30 2018, 11:43 AM · Wikidata, Metadata workflow
moranegg triaged T1298: Review Wikidata property proposal for swh-id release as Normal priority.
Oct 30 2018, 11:41 AM · Wikidata, Metadata workflow

Oct 25 2018

moranegg created P324 ghost error with Meatadata Indexer.
Oct 25 2018, 2:47 PM
moranegg added a comment to T1237: Update mappings to CodeMeta crosswalk table .

Noted Invalid because D591 by @vlorentz uses the most up-to-date mappings with the CodeMeta crosswalk table.

Oct 25 2018, 1:55 PM · Metadata workflow, Indexer
moranegg closed T1237: Update mappings to CodeMeta crosswalk table , a subtask of T1236: Refactor metadata translator to parse different types of files, as Invalid.
Oct 25 2018, 1:52 PM · Metadata workflow, Indexer
moranegg closed T1237: Update mappings to CodeMeta crosswalk table as Invalid.
Oct 25 2018, 1:52 PM · Metadata workflow, Indexer
moranegg accepted D591: Make mappings into a hierarchy of classes that can be easily extended..

I'm accepting this diff- it looks great.
Nevertheless, I think there should be at least one test for CodeMeta (even without the json-ld resolution)
and I added a comment about the tool version.

Oct 25 2018, 1:51 PM
moranegg added a comment to T1288: Web-app: Improve visibility of an accepted "save code now request" on submission.

I think that an alert would work in this case, just need to see when it appears.
This is also to prevent re-submission by mistake.

Oct 25 2018, 12:27 PM · Web app
moranegg added a comment to P323 Codemeta test.

This test doesn"t pass but it's normal.
We should see how do we want to address this.
The CodeMeta file is a json-ld file and contains keys that are not detailed in the codemeta.csv table.

Oct 25 2018, 12:10 PM · Metadata workflow
moranegg created P323 Codemeta test.
Oct 25 2018, 12:06 PM · Metadata workflow
moranegg added a comment to D591: Make mappings into a hierarchy of classes that can be easily extended..

I need some more time to play with this diff before accepting it

Oct 25 2018, 11:44 AM
moranegg accepted D587: Include and load codemeta's crosswalk table..
Oct 25 2018, 11:43 AM
moranegg triaged T1288: Web-app: Improve visibility of an accepted "save code now request" on submission as Normal priority.
Oct 25 2018, 11:06 AM · Web app

Oct 24 2018

moranegg added a comment to P321 Error with D558.

Now that D558 and D557 have landed this error is no longer happening

Oct 24 2018, 3:12 PM
moranegg closed T1019: Prepare Crossminer dataset as Resolved.
Oct 24 2018, 9:40 AM · Metadata workflow

Oct 23 2018

moranegg added a comment to D558: Add the origin intrinsic metadata indexer.

I have the following error: P321
Don't know if this is due to local configuration or about the other unlanded diff.

Oct 23 2018, 5:03 PM
moranegg created P321 Error with D558.
Oct 23 2018, 5:01 PM
moranegg added a comment to T1237: Update mappings to CodeMeta crosswalk table .

This task was a temporary task to manually review the CodeMeta mapping, which I forgot to do but I can do it rapidly.
I think we should open a new task for you or use T1236 which have a more technical aspect of how to use the CodeMeta crosswalk table.

Oct 23 2018, 11:46 AM · Metadata workflow, Indexer

Oct 22 2018

moranegg added inline comments to D557: Add the origin intrinsic metadata storage database..
Oct 22 2018, 2:31 PM
moranegg added inline comments to D557: Add the origin intrinsic metadata storage database..
Oct 22 2018, 11:48 AM

Oct 19 2018

moranegg accepted D536: doc: document PID resolution possibilities other than Web UI /.
Oct 19 2018, 3:06 PM
moranegg added inline comments to D537: Origin metadata pipeline..
Oct 19 2018, 3:04 PM
moranegg added inline comments to D537: Origin metadata pipeline..
Oct 19 2018, 2:42 PM
moranegg updated subscribers of D537: Origin metadata pipeline..

Did you change the swh-schema.sql, I can't see it in this diff..?

I didn't have to, there's already a origin_metadata_translation table. Looks like @ardumont foresaw our need ^^

Oct 19 2018, 12:26 PM
moranegg added a comment to D537: Origin metadata pipeline..

Another question, did we choose to have the revision_id as a column of the origin_intrinsic_metadata table? or is it in the translated_metadata?

Oct 19 2018, 11:12 AM
moranegg requested changes to D537: Origin metadata pipeline..

The last comment was submitted rapidly, sorry..
It looks good, but I can't review tasks.py and other technical changes to the content indexers, so i'm pinging @ardumont to do a review as well.

Oct 19 2018, 11:06 AM
moranegg added a comment to D537: Origin metadata pipeline..

Did you change the swh-schema.sql, I can't see it in this diff..?

Oct 19 2018, 10:52 AM

Oct 18 2018

moranegg triaged T1274: Web-app: deposit moderation view- use origin url for external-id as Low priority.
Oct 18 2018, 3:13 PM · Web app, SWORD deposit

Oct 16 2018

moranegg updated the task description for T1262: wiki: Update suggestion box if `all Debian derivatives` can be noted as ingested.
Oct 16 2018, 11:55 AM · Archive coverage
moranegg renamed T1262: wiki: Update suggestion box if `all Debian derivatives` can be noted as ingested from wiki: Update suggestion box to wiki: Update suggestion box if `all Debian derivatives` can be noted as ingested.
Oct 16 2018, 11:54 AM · Archive coverage
moranegg added a comment to T1223: identifiers.org URL resolution should support swh:id contextual parameters.

I did open a ticket on identifiers.org to ask for a contextual identifier resolution:
ticket number: [Support #303235]

Oct 16 2018, 11:49 AM · Metadata workflow
moranegg added a comment to D536: doc: document PID resolution possibilities other than Web UI /.

I don't know if this is important information for the documentation but the identifier is also resolvable in the web-ui search box (https://archive.softwareheritage.org/browse/search/)

Oct 16 2018, 11:39 AM

Oct 15 2018

moranegg added a comment to T795: create origin_metadata_translation.

This task is now not compatible with the new indexer db.
Also, this table might be divided into origin_intrinsic_metadata for the perstitent copy of T1232
and origin_extrinsic_metadata for metadata translated from the origin_metadata table.

Oct 15 2018, 12:21 PM · Metadata workflow
moranegg closed T795: create origin_metadata_translation, a subtask of T737: create origin_metadata table , as Wontfix.
Oct 15 2018, 12:17 PM · Metadata implementation
moranegg closed T795: create origin_metadata_translation as Wontfix.
Oct 15 2018, 12:17 PM · Metadata workflow
moranegg added a comment to T834: deploy revision_indexer (at least for codemeta.json).

The deployment of the RevisionMetadataIndexer will be correlated with the deployment of the OriginMetadataIndexer when the workflow is ready on a new separated task.

Oct 15 2018, 12:16 PM · Indexer, Metadata workflow
moranegg closed T834: deploy revision_indexer (at least for codemeta.json) as Wontfix.
Oct 15 2018, 12:15 PM · Indexer, Metadata workflow

Oct 12 2018

moranegg added a comment to T1262: wiki: Update suggestion box if `all Debian derivatives` can be noted as ingested.

I suggested this task instead of editing because I wasn't sure about item no° 3 (Debian).
And I didn't know if entries should be dropped or do we want to keep all items in the list and have a checkbox when we get to them.

Oct 12 2018, 11:09 AM · Archive coverage

Oct 11 2018

moranegg added a comment to T1251: archive page: visually show archive coverage.

thanks ! good idea.

Oct 11 2018, 5:04 PM · Web app, Website
moranegg added a comment to T1251: archive page: visually show archive coverage.

Can you keep the texts in the boxes you had with F3322096 ?
I find it clearer than just the logo.
Also, it helps to distinguish gitlab-Inria and hal, because hal has an hal-inria instance.

Oct 11 2018, 4:54 PM · Web app, Website
moranegg triaged T1262: wiki: Update suggestion box if `all Debian derivatives` can be noted as ingested as Low priority.
Oct 11 2018, 2:41 PM · Archive coverage
moranegg added a comment to T1251: archive page: visually show archive coverage.

Looks great !

Oct 11 2018, 12:09 PM · Web app, Website

Oct 9 2018

moranegg accepted D490: Add OriginIndexer + OriginHeadIndexer..
Oct 9 2018, 10:42 AM

Oct 8 2018

moranegg accepted D490: Add OriginIndexer + OriginHeadIndexer..

This looks good to me. Testing is also great for later iterations.

Oct 8 2018, 4:22 PM

Oct 5 2018

moranegg updated the title for P309 OriginHead click error from OriginHead error to OriginHead click error.
Oct 5 2018, 2:59 PM
moranegg updated subscribers of P309 OriginHead click error.

thanks to @vlorentz, this command solves the error:

Oct 5 2018, 2:58 PM
moranegg created P309 OriginHead click error.
Oct 5 2018, 2:51 PM
moranegg accepted D482: Remove prepare() method from MetadataIndexer, it's inherited from BaseIndexer..
Oct 5 2018, 2:44 PM
moranegg added inline comments to D490: Add OriginIndexer + OriginHeadIndexer..
Oct 5 2018, 2:41 PM
moranegg accepted D482: Remove prepare() method from MetadataIndexer, it's inherited from BaseIndexer..

The test passes and the duplicated code is gone, very nice.
But I should really write more tests, there are so many scenarios that aren't tested.

Oct 5 2018, 1:51 PM
moranegg added a comment to D482: Remove prepare() method from MetadataIndexer, it's inherited from BaseIndexer..

I have the same error with make test.
Maybe it's due to the initialization of the ContentIndexer during the RevisionIndexer.

Oct 5 2018, 8:28 AM

Oct 4 2018

moranegg committed rDCIDX7c4ef437a68a: Metadata detector: update minimal dict and test (authored by moranegg).
Metadata detector: update minimal dict and test
Oct 4 2018, 4:56 PM
moranegg committed rDCIDX68593287782c: docs: refix README path (authored by moranegg).
docs: refix README path
Oct 4 2018, 3:58 PM
moranegg closed T1230: Indexers: Improve readme to be more explicit on how to run locally as Resolved by committing rDCIDX68593287782c: docs: refix README path.
Oct 4 2018, 3:58 PM · Indexer, Scheduling utilities
moranegg closed T1230: Indexers: Improve readme to be more explicit on how to run locally, a subtask of T1227: General improvments of the indexer: Schedule indexer tasks, as Resolved.
Oct 4 2018, 3:58 PM · Indexer, Scheduling utilities
moranegg committed rDCIDX3288593ea480: docs: fix README path instead of duplication and fix headers (authored by moranegg).
docs: fix README path instead of duplication and fix headers
Oct 4 2018, 3:27 PM
moranegg committed rDCIDX528980f7cd81: docs: update index.rst and added dev-info.rst (authored by moranegg).
docs: update index.rst and added dev-info.rst
Oct 4 2018, 3:00 PM
moranegg claimed T1230: Indexers: Improve readme to be more explicit on how to run locally.
Oct 4 2018, 12:11 PM · Indexer, Scheduling utilities

Oct 3 2018

moranegg added a parent task for T1228: Create a component that sends a list of revision sha1 to the metadataRevisionIndexer: T1232: Search over intrinsic metadata associated to an origin.
Oct 3 2018, 3:56 PM · Indexer, Metadata workflow
moranegg added a subtask for T1232: Search over intrinsic metadata associated to an origin: T1228: Create a component that sends a list of revision sha1 to the metadataRevisionIndexer.
Oct 3 2018, 3:56 PM · Metadata workflow
moranegg added a subtask for T1236: Refactor metadata translator to parse different types of files: T1237: Update mappings to CodeMeta crosswalk table .
Oct 3 2018, 3:55 PM · Metadata workflow, Indexer
moranegg added a parent task for T1237: Update mappings to CodeMeta crosswalk table : T1236: Refactor metadata translator to parse different types of files.
Oct 3 2018, 3:55 PM · Metadata workflow, Indexer
moranegg triaged T1237: Update mappings to CodeMeta crosswalk table as Normal priority.
Oct 3 2018, 3:53 PM · Metadata workflow, Indexer
moranegg created T1237: Update mappings to CodeMeta crosswalk table .
Oct 3 2018, 3:53 PM · Metadata workflow, Indexer
moranegg added a parent task for T1236: Refactor metadata translator to parse different types of files: T1235: Refactor metadata detector tool to add easily new file names to detect.
Oct 3 2018, 3:48 PM · Metadata workflow, Indexer
moranegg added a subtask for T1235: Refactor metadata detector tool to add easily new file names to detect: T1236: Refactor metadata translator to parse different types of files.
Oct 3 2018, 3:48 PM · Metadata workflow, Indexer
moranegg triaged T1236: Refactor metadata translator to parse different types of files as Normal priority.
Oct 3 2018, 3:47 PM · Metadata workflow, Indexer
moranegg added a subtask for T1232: Search over intrinsic metadata associated to an origin: T1235: Refactor metadata detector tool to add easily new file names to detect.
Oct 3 2018, 3:43 PM · Metadata workflow
moranegg added a parent task for T1235: Refactor metadata detector tool to add easily new file names to detect: T1232: Search over intrinsic metadata associated to an origin.
Oct 3 2018, 3:43 PM · Metadata workflow, Indexer
moranegg triaged T1235: Refactor metadata detector tool to add easily new file names to detect as Normal priority.
Oct 3 2018, 3:42 PM · Metadata workflow, Indexer
moranegg added a parent task for T1231: Create an origin indexer that lists the most recent revision in HEAD branch: T1232: Search over intrinsic metadata associated to an origin.
Oct 3 2018, 3:20 PM · Indexer, Metadata workflow
moranegg added a subtask for T1232: Search over intrinsic metadata associated to an origin: T1231: Create an origin indexer that lists the most recent revision in HEAD branch.
Oct 3 2018, 3:20 PM · Metadata workflow
moranegg triaged T1232: Search over intrinsic metadata associated to an origin as Normal priority.
Oct 3 2018, 3:20 PM · Metadata workflow