Page MenuHomeSoftware Heritage

moranegg (Morane Otilia Gruenpeter)
User

Projects

User Details

User Since
Feb 14 2017, 10:57 AM (114 w, 2 d)

Recent Activity

Yesterday

moranegg added a comment to T1683: Decide where should be gathered specs.
In T1683#31104, @zack wrote:

That was my point about "swh-docs as a fallback".

Wed, Apr 24, 3:05 PM · Development documentation
moranegg added a comment to T1683: Decide where should be gathered specs.

@zack Thanks for the answer.
It's not a blocker per se but I prefer to have a long term decision before moving the specs from different spaces, so for me it's a high priority.
It wasn't clear to me that it should be in the docs and that this is the long term decision.

Wed, Apr 24, 11:42 AM · Development documentation

Tue, Apr 23

moranegg added a comment to T1683: Decide where should be gathered specs.

I need this decision for different specs, for example:

  • Legacy software deposit
  • Sparse / Metadata deposit (now in docs)
  • Metadata workflow- How do we dill with software metadata (T1344)
Tue, Apr 23, 11:54 AM · Development documentation

Mon, Apr 22

moranegg updated the task description for T1683: Decide where should be gathered specs.
Mon, Apr 22, 11:11 AM · Development documentation
moranegg triaged T1683: Decide where should be gathered specs as High priority.
Mon, Apr 22, 11:11 AM · Development documentation

Fri, Apr 19

moranegg closed T1636: Notify and follow up dateCreated bug on HAL as Resolved.
Fri, Apr 19, 11:53 AM · SWORD deposit
moranegg added a comment to T1636: Notify and follow up dateCreated bug on HAL.

Resolved with last deployment on HAL

Fri, Apr 19, 11:53 AM · SWORD deposit
moranegg added a comment to T1676: Bug: the deposit metadata is not added to the revision while those are present.

Thank you both for dealing with this bug quickly!

Fri, Apr 19, 11:52 AM · SWORD deposit

Thu, Apr 18

moranegg renamed T1676: Bug: the deposit metadata is not added to the revision while those are present from The deposit metadata is not added to the revision (it is recieved) to Bug: the deposit metadata is not added to the revision (it is recieved).
Thu, Apr 18, 4:04 PM · SWORD deposit
moranegg triaged T1676: Bug: the deposit metadata is not added to the revision while those are present as Unbreak Now! priority.
Thu, Apr 18, 4:03 PM · SWORD deposit
moranegg triaged T1675: Fix message and error for artifact history view bug as Normal priority.
Thu, Apr 18, 3:31 PM · Storage manager, Web app

Wed, Apr 17

moranegg accepted D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

After pairing with Ardumont, the updates are validated!

Wed, Apr 17, 3:28 PM
moranegg accepted D1422: deposit: Wrongly formatted xml should return a 400 bad request.

Validating this but we have some changes to do on the added test to follow a more restrictive grammar.

Wed, Apr 17, 2:51 PM · SWORD deposit
moranegg accepted D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

Blocked because I thought I can call swh-deposit like old times:-)
Now it is good for me (saw the slug changes live).

Wed, Apr 17, 2:40 PM
moranegg added a comment to D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

I'm going to try and run it, but am a bit blocked with swh-deposit command................
Maybe @douardda could validate he can do a deposit?

Wed, Apr 17, 1:50 PM

Tue, Apr 16

moranegg added a comment to D1416: deposit: Adapt revision dates setting according to new rules.
======================= 112 passed, 1 warnings in 16.33 seconds ========================
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7ff254794840>
Traceback (most recent call last):
  File "/home/morane/Documents/code/swh-environment/swh-deposit/.tox/py3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
Exception ignored in: <function WeakValueDictionary.__init__.<locals>.remove at 0x7ff254794840>
Traceback (most recent call last):
  File "/home/morane/Documents/code/swh-environment/swh-deposit/.tox/py3/lib/python3.5/weakref.py", line 117, in remove
TypeError: 'NoneType' object is not callable
WARNING [pifpaf.drivers] `psutil.Popen(pid=5224, status='terminated')` is already gone, sending SIGKILL to its process group
WARNING [pifpaf.drivers] `psutil.Popen(pid=5207, status='terminated')` is already gone, sending SIGKILL to its process group
WARNING [pifpaf.drivers] `psutil.Popen(pid=5202, status='terminated')` is already gone, sending SIGKILL to its process group
_______________________________________ summary ________________________________________
  flake8: commands succeeded
  py3: commands succeeded
  congratulations :)
Tue, Apr 16, 3:21 PM · SWORD deposit
moranegg added a comment to D1416: deposit: Adapt revision dates setting according to new rules.

Seems great!
tox passes locally.
I would add/change the date formats in tests (because we can recieve dates in different styles)
and/or test only the _parse_date and compute_date functions.
Here some examples:

Tue, Apr 16, 12:28 PM · SWORD deposit

Mon, Apr 15

moranegg moved T1638: Deposit: error when submitting through cli from Backlog to High priority on the SWORD deposit board.
Mon, Apr 15, 3:07 PM · SWORD deposit
moranegg moved T1648: Change `url` and `external-id` from mandatory to optional metadata from Backlog to High priority on the SWORD deposit board.
Mon, Apr 15, 3:07 PM · SWORD deposit
moranegg moved T1637: Adapt deposit's creation/publication date to the SWH data-structure from High priority to In progress on the SWORD deposit board.
Mon, Apr 15, 3:07 PM · SWORD deposit
moranegg moved T1636: Notify and follow up dateCreated bug on HAL from High priority to In progress on the SWORD deposit board.
Mon, Apr 15, 3:07 PM · SWORD deposit
moranegg archived SWORD deposit (2018-09-25-HAL-opening).
Mon, Apr 15, 3:05 PM
moranegg moved T1646: Enable compliance scenario for deposits from Backlog to High priority on the SWORD deposit board.
Mon, Apr 15, 3:05 PM · SWORD deposit
moranegg triaged T1651: Create a separate project for deposit-client as Low priority.
Mon, Apr 15, 3:00 PM · SWH command line interface, SWORD deposit
moranegg added a parent task for T1345: Update metadata docs about using CodeMeta vocabulary: T1649: Update documentation with compliance scenario changes.
Mon, Apr 15, 2:56 PM · SWORD deposit, Metadata workflow
moranegg added a subtask for T1649: Update documentation with compliance scenario changes: T1345: Update metadata docs about using CodeMeta vocabulary.
Mon, Apr 15, 2:56 PM · SWORD deposit
moranegg removed a parent task for T1648: Change `url` and `external-id` from mandatory to optional metadata: T1650: Generate xml for SWORD protocol with deposit client.
Mon, Apr 15, 2:55 PM · SWORD deposit
moranegg removed a subtask for T1650: Generate xml for SWORD protocol with deposit client: T1648: Change `url` and `external-id` from mandatory to optional metadata.
Mon, Apr 15, 2:55 PM · SWORD deposit
moranegg added a parent task for T1648: Change `url` and `external-id` from mandatory to optional metadata: T1650: Generate xml for SWORD protocol with deposit client.
Mon, Apr 15, 2:55 PM · SWORD deposit
moranegg added a subtask for T1650: Generate xml for SWORD protocol with deposit client: T1648: Change `url` and `external-id` from mandatory to optional metadata.
Mon, Apr 15, 2:55 PM · SWORD deposit
moranegg triaged T1650: Generate xml for SWORD protocol with deposit client as Normal priority.
Mon, Apr 15, 2:54 PM · SWORD deposit
moranegg added a parent task for T1648: Change `url` and `external-id` from mandatory to optional metadata: T1649: Update documentation with compliance scenario changes.
Mon, Apr 15, 2:51 PM · SWORD deposit
moranegg added a subtask for T1649: Update documentation with compliance scenario changes: T1648: Change `url` and `external-id` from mandatory to optional metadata.
Mon, Apr 15, 2:51 PM · SWORD deposit
moranegg added a parent task for T1649: Update documentation with compliance scenario changes: T1646: Enable compliance scenario for deposits.
Mon, Apr 15, 2:51 PM · SWORD deposit
moranegg added a subtask for T1646: Enable compliance scenario for deposits: T1649: Update documentation with compliance scenario changes.
Mon, Apr 15, 2:51 PM · SWORD deposit
moranegg triaged T1649: Update documentation with compliance scenario changes as Normal priority.
Mon, Apr 15, 2:50 PM · SWORD deposit
moranegg added a parent task for T1637: Adapt deposit's creation/publication date to the SWH data-structure: T1646: Enable compliance scenario for deposits.
Mon, Apr 15, 2:46 PM · SWORD deposit
moranegg added a subtask for T1646: Enable compliance scenario for deposits: T1637: Adapt deposit's creation/publication date to the SWH data-structure.
Mon, Apr 15, 2:46 PM · SWORD deposit
moranegg renamed T1637: Adapt deposit's creation/publication date to the SWH data-structure from deposit: Change commit date to the date of software creation (instead of the deposit's completed date) to Adapt deposit's creation/publication date to the SWH data-structure.
Mon, Apr 15, 2:45 PM · SWORD deposit
moranegg triaged T1648: Change `url` and `external-id` from mandatory to optional metadata as High priority.
Mon, Apr 15, 2:44 PM · SWORD deposit
moranegg triaged T1647: separate clients for each HAL instance as Normal priority.
Mon, Apr 15, 2:39 PM · SWORD deposit
moranegg triaged T1646: Enable compliance scenario for deposits as Normal priority.
Mon, Apr 15, 2:30 PM · SWORD deposit
moranegg updated subscribers of T1033: Review url schema to follow the 'with what tool' pattern for deposits.
Mon, Apr 15, 2:26 PM · SWORD deposit
moranegg updated subscribers of T1033: Review url schema to follow the 'with what tool' pattern for deposits.

@zack this was open last year but we never got to that.
Is this still our goal?

Mon, Apr 15, 2:26 PM · SWORD deposit
moranegg renamed T1345: Update metadata docs about using CodeMeta vocabulary from Add HAL-deposit to CodeMeta mapping in deposit/docs to Update metadata docs about using CodeMeta vocabulary.
Mon, Apr 15, 2:24 PM · SWORD deposit, Metadata workflow
moranegg moved T1636: Notify and follow up dateCreated bug on HAL from Backlog to High priority on the SWORD deposit board.
Mon, Apr 15, 2:21 PM · SWORD deposit
moranegg assigned T1637: Adapt deposit's creation/publication date to the SWH data-structure to ardumont.
Mon, Apr 15, 2:21 PM · SWORD deposit
moranegg moved T1637: Adapt deposit's creation/publication date to the SWH data-structure from Backlog to High priority on the SWORD deposit board.
Mon, Apr 15, 2:21 PM · SWORD deposit
moranegg added a comment to T1637: Adapt deposit's creation/publication date to the SWH data-structure.
SWHHALSWORD workflow
visit datewhen HAL sent deposit to SWH after moderationtime-stamp of received deposit
author datedate de créationdateCreated
commit datewhen deposit was received on HALdatePublished
Mon, Apr 15, 2:20 PM · SWORD deposit
moranegg added a comment to T912: integration with HAL for SWORD-based deposit (meta task).

I think we can close this one :-)

Mon, Apr 15, 2:10 PM · SWORD deposit (2018-09-25-HAL-opening)
moranegg added a comment to D1416: deposit: Adapt revision dates setting according to new rules.

I started reviewing but the question is more complex than I first stated
I asked HAL to fix dateCreated to their real metadata 'date de création/écriture'
and to add datePublished as the deposit date
While dateCreated isn't mandatory on HAL, datePublished is implicitly mandatory
And the date of arrival to SWH isn't the same of datePublished, because of the moderation process on HAL side
It can differ by hours, days or even weeks

Mon, Apr 15, 10:55 AM · SWORD deposit
moranegg added a comment to T1636: Notify and follow up dateCreated bug on HAL.

And add datePublished for the deposit date

Mon, Apr 15, 10:48 AM · SWORD deposit

Wed, Apr 10

moranegg edited projects for T1638: Deposit: error when submitting through cli, added: SWORD deposit; removed Deposit.
Wed, Apr 10, 1:36 PM · SWORD deposit
moranegg triaged T1637: Adapt deposit's creation/publication date to the SWH data-structure as High priority.
Wed, Apr 10, 12:30 PM · SWORD deposit
moranegg triaged T1636: Notify and follow up dateCreated bug on HAL as High priority.
Wed, Apr 10, 12:29 PM · SWORD deposit

Tue, Apr 2

moranegg committed rMSLD4a57562a45e9: small changes to RDA WG slides (authored by moranegg).
small changes to RDA WG slides
Tue, Apr 2, 2:08 PM

Thu, Mar 28

moranegg committed rMSLD4c68873af6e2: IG activity added to RDA-P13 (authored by moranegg).
IG activity added to RDA-P13
Thu, Mar 28, 3:34 PM

Jan 22 2019

moranegg triaged T1490: Use origin url on external-id attribute on deposit admin page as Low priority.
Jan 22 2019, 3:03 PM · Metrics/monitoring, SWORD deposit

Nov 21 2018

moranegg added a comment to T1298: Review Wikidata property proposal for swh-id release.

Here is the approved property on Wikidata:
https://www.wikidata.org/wiki/Property:P6138

Nov 21 2018, 2:25 PM · Wikidata, Metadata workflow

Nov 14 2018

moranegg added a comment to T1346: Define persistent URL to be used as archive url property in Wikidata.

This will also be useful for:

  • ASCL
  • swMath
  • OpenAire
Nov 14 2018, 4:48 PM · Web app, Wikidata
moranegg triaged T1346: Define persistent URL to be used as archive url property in Wikidata as Normal priority.
Nov 14 2018, 4:42 PM · Web app, Wikidata
moranegg triaged T1345: Update metadata docs about using CodeMeta vocabulary as Low priority.
Nov 14 2018, 4:30 PM · SWORD deposit, Metadata workflow
moranegg added a comment to T1344: Write specs about metadata workflow .

Where would you put this type of specs?

Nov 14 2018, 4:29 PM · Metadata workflow
moranegg accepted D637: Document metadata providers..

I think that @douardda's comments should be resolved in a specs document and not in the current docs.
So I'm opening a task about that, referring to the discussion here [T1344]

Nov 14 2018, 4:03 PM
moranegg triaged T1344: Write specs about metadata workflow as Normal priority.
Nov 14 2018, 4:03 PM · Metadata workflow
moranegg closed T1298: Review Wikidata property proposal for swh-id release as Resolved.
Nov 14 2018, 2:45 PM · Wikidata, Metadata workflow
moranegg added a comment to D637: Document metadata providers..

I'm not sure why the build is failing.
Can I relaunch a build as a reviewer, or only by changing the diff will the build be relaunched?

Nov 14 2018, 2:27 PM

Nov 12 2018

moranegg added a project to P332 Metadata files count 22.5.2017: Metadata workflow.
Nov 12 2018, 5:12 PM · Metadata workflow
moranegg changed the edit policy for P332 Metadata files count 22.5.2017.
Nov 12 2018, 5:11 PM · Metadata workflow
moranegg added a comment to T1298: Review Wikidata property proposal for swh-id release.

Here is the property proposal under discussion: https://www.wikidata.org/wiki/Wikidata:Property_proposal/SWH_Release_ID

Nov 12 2018, 2:37 PM · Wikidata, Metadata workflow

Nov 9 2018

moranegg added inline comments to D637: Document metadata providers..
Nov 9 2018, 11:26 AM

Nov 8 2018

moranegg added a comment to T1298: Review Wikidata property proposal for swh-id release.

Questions and Answers with the WikiDigi WG (from Toto256):

  1. Even thought we identified the release ID to be the most appropriate ID to use in Wikidata, should the property specify it is a release instead of being a generic SWH ID?

As we discussed, it's easier to have a limited scope for a property : it allows for defining constraints, building bots and explaining the purpose.
This doesn't mean we can later add other properties for others ids.

Nov 8 2018, 11:49 AM · Wikidata, Metadata workflow

Nov 7 2018

moranegg added a watcher for Wikidata: moranegg.
Nov 7 2018, 4:25 PM
moranegg shifted T1298: Review Wikidata property proposal for swh-id release from the Restricted Space space to the S1 Public space.
Nov 7 2018, 4:22 PM · Wikidata, Metadata workflow
moranegg added a project to T1298: Review Wikidata property proposal for swh-id release: Wikidata.
Nov 7 2018, 4:22 PM · Wikidata, Metadata workflow
moranegg created Wikidata.
Nov 7 2018, 4:21 PM

Nov 5 2018

moranegg accepted D619: Translate authors from package.json.

Accepting because I accepted D620

Nov 5 2018, 5:31 PM
moranegg accepted D617: Always output valid JSON-LD..

Accepting because I accepted D620

Nov 5 2018, 5:31 PM
moranegg accepted D620: Translate from pom.xml and codemeta.json..
Nov 5 2018, 5:30 PM
moranegg requested changes to D620: Translate from pom.xml and codemeta.json..

There is no test a case of a revision with multiple 'metadata files' which is an intriguing case - this should be tested before accepting this diff.

Nov 5 2018, 1:16 PM

Oct 31 2018

moranegg added a comment to D620: Translate from pom.xml and codemeta.json..

Add README or CITATION to data directory with the following:
Matthew B. Jones, Carl Boettiger, Abby Cabunoc Mayes, Arfon Smith, Peter Slaughter, Kyle Niemeyer, Yolanda Gil, Martin Fenner, Krzysztof Nowak, Mark Hahnel, Luke Coy, Alice Allen, Mercè Crosas, Ashley Sands, Neil Chue Hong, Patricia Cruse, Daniel S. Katz, Carole Goble. 2017. CodeMeta: an exchange schema for software metadata. Version 2.0. KNB Data Repository. doi:10.5063/schema/codemeta-2.0
swh:1:dir:39c509fd2002f9e531fb4b3a321ceb5e6994e54a;origin=https://github.com/codemeta/codemeta

Oct 31 2018, 4:00 PM
moranegg added a comment to T1110: document GitHub caseness caveats.

When using the save code now feature with https://github.com/codemeta/codemeta.git the origin created was exactly as requested.
Now there are 2 different origins:

Oct 31 2018, 11:03 AM · GitHub lister, Development documentation

Oct 30 2018

moranegg triaged T1299: Configuration file when empty returns AttributeError: 'NoneType' object has no attribute 'get' as Low priority.
Oct 30 2018, 5:00 PM · Core & foundations
moranegg created P328 swh-indexer test fails with tox -r.
Oct 30 2018, 4:31 PM
moranegg edited P169 One year plan.
Oct 30 2018, 12:30 PM · Metadata workflow
moranegg renamed T1298: Review Wikidata property proposal for swh-id release from Review Wikidata property for swh-id release to Review Wikidata property proposal for swh-id release.
Oct 30 2018, 11:43 AM · Wikidata, Metadata workflow
moranegg triaged T1298: Review Wikidata property proposal for swh-id release as Normal priority.
Oct 30 2018, 11:41 AM · Wikidata, Metadata workflow

Oct 25 2018

moranegg created P324 ghost error with Meatadata Indexer.
Oct 25 2018, 2:47 PM
moranegg added a comment to T1237: Update mappings to CodeMeta crosswalk table .

Noted Invalid because D591 by @vlorentz uses the most up-to-date mappings with the CodeMeta crosswalk table.

Oct 25 2018, 1:55 PM · Metadata workflow, Indexer
moranegg closed T1237: Update mappings to CodeMeta crosswalk table , a subtask of T1236: Refactor metadata translator to parse different types of files, as Invalid.
Oct 25 2018, 1:52 PM · Metadata workflow, Indexer
moranegg closed T1237: Update mappings to CodeMeta crosswalk table as Invalid.
Oct 25 2018, 1:52 PM · Metadata workflow, Indexer
moranegg accepted D591: Make mappings into a hierarchy of classes that can be easily extended..

I'm accepting this diff- it looks great.
Nevertheless, I think there should be at least one test for CodeMeta (even without the json-ld resolution)
and I added a comment about the tool version.

Oct 25 2018, 1:51 PM
moranegg added a comment to T1288: Web-app: Improve visibility of an accepted "save code now request" on submission.

I think that an alert would work in this case, just need to see when it appears.
This is also to prevent re-submission by mistake.

Oct 25 2018, 12:27 PM · Web app
moranegg added a comment to P323 Codemeta test.

This test doesn"t pass but it's normal.
We should see how do we want to address this.
The CodeMeta file is a json-ld file and contains keys that are not detailed in the codemeta.csv table.

Oct 25 2018, 12:10 PM · Metadata workflow
moranegg created P323 Codemeta test.
Oct 25 2018, 12:06 PM · Metadata workflow
moranegg added a comment to D591: Make mappings into a hierarchy of classes that can be easily extended..

I need some more time to play with this diff before accepting it

Oct 25 2018, 11:44 AM
moranegg accepted D587: Include and load codemeta's crosswalk table..
Oct 25 2018, 11:43 AM
moranegg triaged T1288: Web-app: Improve visibility of an accepted "save code now request" on submission as Normal priority.
Oct 25 2018, 11:06 AM · Web app

Oct 24 2018

moranegg added a comment to P321 Error with D558.

Now that D558 and D557 have landed this error is no longer happening

Oct 24 2018, 3:12 PM
moranegg closed T1019: Prepare Crossminer dataset as Resolved.
Oct 24 2018, 9:40 AM · Metadata workflow