Build has FAILED

Add test to demonstrate we visit twice the artifacts for 2 visits (with no
change in between)

• debian.loader: Update typing annotations
• debian: Explicit we visit twice the same artifacts across 2 visits
• package.debian: Check for known revisions using snapshot if any

Rebase to latest master

Branch diff to master

Diff against package-loader (not master :/)

• test_debian: Add test around get_package_metadata function

Fix wrong typing import

Fix docstring

Use latest pytest_plugin fixture with http support

• debian.tests: Update pytest_plugin version use

Update to look for file in top-level directory as <http_scheme>_<hostname>

I'd rather change that after merging the package-loader branch if you don't mind.

Update according to the right suggestion of not mixing http/https data folder

It's really just a mv of the top level directory; But I was really suggesting adding support, not replacing the current implementation.

Could we make the top-level directory <domain_name>_http or http_<domain_name> for http-only requests?

Doesn't this need a rebase?

Looks good.

Rebase on latest master

Unify logger variable

Rebase on latest master

• debian: Expose debian loader implementation first

Improve dosctrings

Add missing type annotations

• debian: Simplify build revision code

• debian: Remove dead code

• package.loader: Clarify download_package contract
• package.debian: Compute the dsc information
• debian: Remove duplicated computations step

Improve docstrings

Branch diff to debian-loader branch

Remove unneeded overridden implementation (gnu)

• package: Fix py3.5 incompatibilities

Build has FAILED

• package.loader: Fix type check annotation invalid in py3.5

Build has FAILED

In D2135#49709, @ardumont wrote:

Build has FAILED

I'm not sure the ci can build a diff when not on master...

[tox] $ git reset --hard origin/master
HEAD is now at c0af471 tox.ini: Fix py3 environment to only tests the swh/loader tests
[tox] $ git clean -fd -f
[tox] $ git submodule update --init --recursive
[tox] $ arc patch --diff 7167 --nocommit --nobranch --force --conduit-uri=https://forge.softwareheritage.org/ ********

This diff is against origin/package-loader...

Build has FAILED

Current input of the debian loader (without the optimization) (outputed from the lister):

I don't recall that what we saw (and it's way better as that seems consistent with the current loader ;).