- User Since
- Sep 7 2015, 3:42 PM (293 w, 3 d)
I stand by what i said regarding the scheduling logic, it's as simple as I described
lgtm, one typo inline.
ok for me
beware the typo in the diff and commit message.
Trying to bisect the issue and failed (multiple dimensions got the best of me, master ok, debian build in stable ko... i need to improve my tooling there).
looks good to me, request changes for the sake of suggestions though.
So, the debian/unstable broke which is fixed now  (it wasd missing one new deps to
test the migration part).
Wed, Apr 21
Landed. Remains to deploy. I'll attend to that tomorrow.
Thanks @ardumont ... so it appears that adapting the logic is easy... may you do it?
All checks green both for production/staging and hg/svn/git,
For the support of other origin visit types, @ardumont should know better than me how this could be integrated in the scheduler.
ok, i think ;)
Update existing tests
Adapt according to review (rework existing code drop duplicated code)
Update endpoint docstring (still remains to add test)
So there is actually just trying to add some more coverage (trying to find where it's supposed to be) and the actual documentation endpoint to update, right?
Cool, you should update the tests checking that newly added value in the model.
Pushed and tag swh.web.client v0.3.0 with the new endpoint ^
(ideally we could want at least 2 other endpoints, one to check the status
on one save code now request, another to possibly list in a paginated way
the status of the save code now, a-la ui to be symmetric with that new
endpoint, tasks to open ;)
Adapt last comment ;)
Nevertheless, that error should have been detected on the first loading so some adaptation is needed in the svn loader.
In any case, independently from this, for the monitoring, I was set on modifying the
actual svn origin used to something else not hosted on github.
On a related note, it may be useful to regularly report requests that did not complete (either as success or failure) in a reasonable amount of time after being scheduled.