- User Since
- Sep 7 2015, 3:42 PM (280 w, 5 d)
Refactor existing test to reuse the same mechanism as the new one
Thu, Jan 21
As for the reason:
12:07 <+ardumont> why it was not formatted, might be because of the rebase 12:08 <+ardumont> the `git commit` now feels slugish since we started using pre-commit 12:08 <+ardumont> but the rebase in themselves are not 12:08 <+ardumont> so i don't think pre-commit is run during those 12:10 <+ardumont> and i did the last rebase actually focusing on the stability not the formatting so there you go, that must be how it passed through 12:10 <+olasd> git hooks don't fire on rebase
Use vmod var!
All in all it might be easier to actually use the var vmod ! :D
Wed, Jan 20
1 question about 'enabled' inlined there
We also added a 'failed' status.
Rebase with fix so tests are happy (i missed the modification last time i rebased and
updated this ¯\_(ツ)_/¯)
This needs a rebase to fix the build (i'm on it)
Fix trailing comma which sql is not happy about ¯\_(ツ)_/¯
Adapt according to suggestion
Update interface docstring to mention the length of the output list could be less than
the one from the input.
Adapt back to the first implementation, this returns a list of OriginVisitStats
Adapt diff according to the model update (adding the failed state as well)
- add failed status
- update swh.model.hypothesis_strategies module according to changes
Adapt according to review (most are ok except for the returned type dict change)
Maybe it'd make sense to return a dict (url, type) -> OriginVisitStats instead?
You should consider using psycopg2.extras.execute_values instead of rolling your own implementation (see the implementation of record_listed_origins).
This reminds me that I noticed this morning that the bump to schema version 165 was forgotten in c24d35f86a06 (in db.py and 30-schema.sql).
This makes me wonder if we shouldn't add an explicit failed status too, while we're at it, for explicit failures that couldn't generate a partial snapshot.
Tue, Jan 19
Keep only interesting visits to ask for their visit_stats informations
I forgot that part.
out of pipdeptree:
Adapt according to review (thanks ;)