Page MenuHomeSoftware Heritage

ardumont (Antoine R. Dumont)
UserAdministrator

User Details

User Since
Sep 7 2015, 3:42 PM (189 w, 2 d)
Roles
Administrator

Recent Activity

Fri, Apr 19

ardumont renamed T1676: Bug: the deposit metadata is not added to the revision while those are present from Bug: the deposit metadata is not added to the revision (it is recieved) to Bug: the deposit metadata is not added to the revision while those are present.
Fri, Apr 19, 9:16 AM · SWORD deposit
ardumont accepted D1423: Make sure that revision metadata is passed through from the caller.
Fri, Apr 19, 7:42 AM

Wed, Apr 17

ardumont closed T1643: Deposit client: Improve error handling, a subtask of T1581: Deposit: improvments, as Resolved.
Wed, Apr 17, 11:22 PM · SWORD deposit
ardumont closed T1643: Deposit client: Improve error handling as Resolved.

Well, it turned out that it's already the case, there was just a racket hole... T1638

Wed, Apr 17, 11:22 PM · SWORD deposit
ardumont renamed T1582: deposit: Update debian packages from deposit: Adapt debian package for the least surprise effect to deposit: Update debian packages.
Wed, Apr 17, 11:20 PM · SWORD deposit
ardumont updated subscribers of T1582: deposit: Update debian packages.

@zack @douardda @moranegg Latest adaptations packaged and deployed

Wed, Apr 17, 7:11 PM · SWORD deposit
ardumont updated the task description for T1648: Change `url` and `external-id` from mandatory to optional metadata.
Wed, Apr 17, 7:04 PM · SWORD deposit
ardumont added a comment to T1579: Deposit: Refactor tests.

The deposit cli is not though.

Wed, Apr 17, 6:46 PM · SWORD deposit
ardumont closed T1638: Deposit: error when submitting through cli, a subtask of T1581: Deposit: improvments, as Resolved.
Wed, Apr 17, 3:42 PM · SWORD deposit
ardumont closed T1638: Deposit: error when submitting through cli as Resolved.
Wed, Apr 17, 3:42 PM · SWORD deposit
ardumont closed T1650: Generate xml for SWORD protocol with deposit client, a subtask of T1646: Enable compliance scenario for deposits, as Resolved.
Wed, Apr 17, 3:41 PM · SWORD deposit
ardumont closed T1650: Generate xml for SWORD protocol with deposit client as Resolved.
Wed, Apr 17, 3:41 PM · SWORD deposit
ardumont committed rDDEPd075c56e7cd5: Remove unnecessary leftover check on no longer existing url fields (authored by ardumont).
Remove unnecessary leftover check on no longer existing url fields
Wed, Apr 17, 3:39 PM
ardumont committed rDDEP708beba5c223: cli.deposit: Add mandatory flags to generate the metadata xml (authored by ardumont).
cli.deposit: Add mandatory flags to generate the metadata xml
Wed, Apr 17, 3:39 PM
ardumont closed D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Wed, Apr 17, 3:39 PM
ardumont updated the diff for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

Plug on master

Wed, Apr 17, 3:35 PM
ardumont updated the diff for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

Rebase on latest master

Wed, Apr 17, 3:32 PM
ardumont committed rDDEP3b19233c6d66: tests: Reformat some deposit tests (authored by ardumont).
tests: Reformat some deposit tests
Wed, Apr 17, 3:32 PM
ardumont committed rDDEP793b0d18e453: deposit: Wrongly formatted xml should return a 400 bad request (authored by ardumont).
deposit: Wrongly formatted xml should return a 400 bad request
Wed, Apr 17, 3:32 PM
ardumont closed D1422: deposit: Wrongly formatted xml should return a 400 bad request.
Wed, Apr 17, 3:32 PM · SWORD deposit
ardumont updated the diff for D1422: deposit: Wrongly formatted xml should return a 400 bad request.

Plug on master

Wed, Apr 17, 3:26 PM · SWORD deposit
ardumont updated the diff for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
  • Remove unnecessary leftover check on no longer existing url fields
Wed, Apr 17, 3:25 PM
ardumont added a project to D1422: deposit: Wrongly formatted xml should return a 400 bad request: SWORD deposit.
Wed, Apr 17, 2:24 PM · SWORD deposit
ardumont updated the diff for D1422: deposit: Wrongly formatted xml should return a 400 bad request.

Fix typo and flake8 error

Wed, Apr 17, 2:22 PM · SWORD deposit
ardumont moved T1638: Deposit: error when submitting through cli from In progress to In code review on the SWORD deposit board.
Wed, Apr 17, 2:20 PM · SWORD deposit
ardumont created D1422: deposit: Wrongly formatted xml should return a 400 bad request.
Wed, Apr 17, 2:19 PM · SWORD deposit
ardumont added a comment to D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

I'm going to try and run it, but am a bit blocked with swh-deposit command................

Wed, Apr 17, 2:16 PM
ardumont added a comment to T1638: Deposit: error when submitting through cli.

the metadata file linuxperf-v4.3.1.27.metadata.xml (as per the parsing error xml.parsers.expat.ExpatError: syntax error: line 1, column 49 implies something badly formatted).

Wed, Apr 17, 12:00 PM · SWORD deposit
ardumont updated the diff for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

Rebase on latest master

Wed, Apr 17, 11:58 AM
ardumont updated the task description for T1648: Change `url` and `external-id` from mandatory to optional metadata.
Wed, Apr 17, 11:56 AM · SWORD deposit
ardumont committed rDDEP56e903728210: check: Remove url and external_identifier from mandatory fields (authored by ardumont).
check: Remove url and external_identifier from mandatory fields
Wed, Apr 17, 11:56 AM
ardumont committed rDDEP45aeec443d7a: utils: Enforce necessary setup for deposit and associated client (authored by ardumont).
utils: Enforce necessary setup for deposit and associated client
Wed, Apr 17, 11:56 AM
ardumont committed rDDEP3bff42e429ce: deposit_read: Compute origin-url from the deposit's setup (authored by ardumont).
deposit_read: Compute origin-url from the deposit's setup
Wed, Apr 17, 11:56 AM
ardumont closed D1421: Change `url` and `external-id` from mandatory to optional metadata.
Wed, Apr 17, 11:56 AM
ardumont updated the diff for D1421: Change `url` and `external-id` from mandatory to optional metadata.

Plug to master

Wed, Apr 17, 11:51 AM
ardumont updated the diff for D1421: Change `url` and `external-id` from mandatory to optional metadata.
  • utils: Enforce necessary setup for deposit and associated client
Wed, Apr 17, 11:46 AM
ardumont added inline comments to D1421: Change `url` and `external-id` from mandatory to optional metadata.
Wed, Apr 17, 11:29 AM
ardumont moved T1638: Deposit: error when submitting through cli from High priority to In progress on the SWORD deposit board.
Wed, Apr 17, 11:19 AM · SWORD deposit
ardumont moved T1637: Adapt deposit's creation/publication date to the SWH data-structure from In code review to Integration tests on the SWORD deposit board.
Wed, Apr 17, 11:19 AM · SWORD deposit
ardumont closed T1637: Adapt deposit's creation/publication date to the SWH data-structure as Resolved.
Wed, Apr 17, 11:19 AM · SWORD deposit
ardumont closed T1637: Adapt deposit's creation/publication date to the SWH data-structure, a subtask of T1646: Enable compliance scenario for deposits, as Resolved.
Wed, Apr 17, 11:19 AM · SWORD deposit
ardumont closed T1637: Adapt deposit's creation/publication date to the SWH data-structure, a subtask of T1581: Deposit: improvments, as Resolved.
Wed, Apr 17, 11:19 AM · SWORD deposit
ardumont added a comment to D1416: deposit: Adapt revision dates setting according to new rules.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Apr 17, 10:52

Wed, Apr 17, 11:17 AM · SWORD deposit
ardumont updated the diff for D1421: Change `url` and `external-id` from mandatory to optional metadata.

Fix in-between interactive rebase

Wed, Apr 17, 11:00 AM
ardumont updated the diff for D1421: Change `url` and `external-id` from mandatory to optional metadata.

Rebase on latest master

Wed, Apr 17, 10:53 AM
ardumont updated the diff for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

Rebase on latest master

Wed, Apr 17, 10:52 AM
ardumont committed rDDEPa7a7170df586: utils: Make parsing date result in a reasonable date (authored by ardumont).
utils: Make parsing date result in a reasonable date
Wed, Apr 17, 10:52 AM
ardumont committed rDDEPc183276262e1: Refactor: Extract date utils manipulation function into utils module (authored by ardumont).
Refactor: Extract date utils manipulation function into utils module
Wed, Apr 17, 10:52 AM
ardumont committed rDDEP00a8abd44f36: tests: Factorize metadata xml duplication to explicit tested date (authored by ardumont).
tests: Factorize metadata xml duplication to explicit tested date
Wed, Apr 17, 10:52 AM
ardumont committed rDDEP37b48717a83f: loader: Use metadata date as author/committer date if provided (authored by ardumont).
loader: Use metadata date as author/committer date if provided
Wed, Apr 17, 10:52 AM
ardumont committed rDDEP0138edcadef7: deposit_read: Refactor to clarify intents and docstring (authored by ardumont).
deposit_read: Refactor to clarify intents and docstring
Wed, Apr 17, 10:52 AM
ardumont closed D1416: deposit: Adapt revision dates setting according to new rules.
Wed, Apr 17, 10:52 AM · SWORD deposit
ardumont updated the diff for D1416: deposit: Adapt revision dates setting according to new rules.

Plug on master branch

Wed, Apr 17, 10:46 AM · SWORD deposit
ardumont updated the diff for D1421: Change `url` and `external-id` from mandatory to optional metadata.

Rebase on dedicated branch

Wed, Apr 17, 10:45 AM
ardumont lowered the priority of T1638: Deposit: error when submitting through cli from High to Normal.
Wed, Apr 17, 10:02 AM · SWORD deposit
ardumont added a comment to T1638: Deposit: error when submitting through cli.

I have badly dealt with this issue.

Wed, Apr 17, 10:02 AM · SWORD deposit
ardumont added inline comments to D1416: deposit: Adapt revision dates setting according to new rules.
Wed, Apr 17, 9:34 AM · SWORD deposit
ardumont added a comment to D1411: Refactor deposit cli and some other improvments.

@douardda @olasd I have changed the migration to run the 4 steps
mentioned \m/

To do that, i iterated with git (amending) and reused the data files
generated through multiple calls to make db-prepare (wrapper on
swh.deposit.manage makemigrations)...

In the end, I checked the following command to see the sql generated
(in between last version with the old type and the new one):

python3 -m swh.deposit.manage sqlmigrate deposit 0015_depositrequest_typemigration
BEGIN;
--
-- Add field type2 to depositrequest
--
ALTER TABLE "deposit_request" ADD COLUMN "type2" varchar(8) NULL;
--
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
--
--
-- Remove field type from depositrequest
--
SET CONSTRAINTS "deposit_request_type_id_e9882b75_fk_deposit_request_type_id" IMMEDIATE; ALTER TABLE "deposit_request" DROP CONSTRAINT "deposit_request_type_id_e9882b75_fk_deposit_request_type_id";
ALTER TABLE "deposit_request" DROP COLUMN "type_id" CASCADE;
--
-- Rename field type2 on depositrequest to type
--
ALTER TABLE "deposit_request" RENAME COLUMN "type2" TO "type";
--
-- Delete model DepositRequestType
--
DROP TABLE "deposit_request_type" CASCADE;
COMMIT;

Expectedly, that does not show the data migration part which happens
through python. But that indeed mentions the migration step ;)

Wed, Apr 17, 9:26 AM

Tue, Apr 16

ardumont added reviewers for D1419: cli.deposit: Add mandatory flags to generate the metadata xml: moranegg, douardda.
Tue, Apr 16, 7:31 PM
ardumont updated the diff for D1416: deposit: Adapt revision dates setting according to new rules.

Update test docstring to match the reality of the test

Tue, Apr 16, 7:26 PM · SWORD deposit
ardumont moved T1648: Change `url` and `external-id` from mandatory to optional metadata from In progress to In code review on the SWORD deposit board.
Tue, Apr 16, 7:21 PM · SWORD deposit
ardumont created D1421: Change `url` and `external-id` from mandatory to optional metadata.
Tue, Apr 16, 7:09 PM
ardumont claimed T1648: Change `url` and `external-id` from mandatory to optional metadata.
Tue, Apr 16, 6:32 PM · SWORD deposit
ardumont moved T1648: Change `url` and `external-id` from mandatory to optional metadata from High priority to In progress on the SWORD deposit board.
Tue, Apr 16, 6:31 PM · SWORD deposit
ardumont moved T1650: Generate xml for SWORD protocol with deposit client from In progress to In code review on the SWORD deposit board.
Tue, Apr 16, 5:21 PM · SWORD deposit
ardumont moved T1650: Generate xml for SWORD protocol with deposit client from High priority to In progress on the SWORD deposit board.
Tue, Apr 16, 5:21 PM · SWORD deposit
ardumont updated the language for P381 deposit-client: metadata xml generated from new cli flags from autodetect to python.
Tue, Apr 16, 5:16 PM · SWORD deposit
ardumont added a comment to P381 deposit-client: metadata xml generated from new cli flags.

Related D1419

Tue, Apr 16, 5:16 PM · SWORD deposit
ardumont edited P381 deposit-client: metadata xml generated from new cli flags.
Tue, Apr 16, 5:16 PM · SWORD deposit
ardumont updated the test plan for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Tue, Apr 16, 5:13 PM
ardumont updated the test plan for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Tue, Apr 16, 5:12 PM
ardumont added a comment to D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

ardumont: could you do a paste with the generated xml? I can't seem to be able to run the client today (i'll have more time to reconstruct that part locally tomorrow)

Tue, Apr 16, 5:10 PM
ardumont edited P381 deposit-client: metadata xml generated from new cli flags.
Tue, Apr 16, 5:06 PM · SWORD deposit
ardumont created P381 deposit-client: metadata xml generated from new cli flags.
Tue, Apr 16, 5:06 PM · SWORD deposit
ardumont updated the diff for D1416: deposit: Adapt revision dates setting according to new rules.
  • utils: Make parsing date result in a reasonable date
Tue, Apr 16, 5:02 PM · SWORD deposit
ardumont added inline comments to D1416: deposit: Adapt revision dates setting according to new rules.
Tue, Apr 16, 3:13 PM · SWORD deposit
ardumont updated the diff for D1416: deposit: Adapt revision dates setting according to new rules.
  • Refactor: Extract date utils manipulation function into utils module
Tue, Apr 16, 3:11 PM · SWORD deposit
ardumont updated the diff for D1416: deposit: Adapt revision dates setting according to new rules.
  • tests: Factorize metadata xml duplication to explicit tested date
Tue, Apr 16, 2:50 PM · SWORD deposit
ardumont updated the diff for D1416: deposit: Adapt revision dates setting according to new rules.
  • deposit_read: Refactor to clarify intents and docstring
Tue, Apr 16, 2:39 PM · SWORD deposit
ardumont added a comment to D1416: deposit: Adapt revision dates setting according to new rules.

I would add/change the date formats in tests (because we can recieve dates in different styles)
and/or test only the _parse_date and compute_date functions.
Here some examples:

<date type="whenSubmitted">2018-02-27 10:45:10</date>
<date type="whenWritten">2012</date>
<date type="whenModified">2018-06-11 17:02:02</date>
<date type="whenReleased">2018-03-20 13:09:08</date>
<date type="whenProduced">2012</date>
<date type="whenEndEmbargoed">2018-02-27</date>
Tue, Apr 16, 1:53 PM · SWORD deposit
ardumont committed rDDEP93a168e8ad7a: Expose optional external id in deposit status endpoint (authored by ardumont).
Expose optional external id in deposit status endpoint
Tue, Apr 16, 1:49 PM
ardumont committed rDDEP76b3ff6aa038: deposit_status: Simplify the deposit status computation (authored by ardumont).
deposit_status: Simplify the deposit status computation
Tue, Apr 16, 1:49 PM
ardumont committed rDDEP3dd15b494eb3: deposit.cli: Generate uuid as is (authored by ardumont).
deposit.cli: Generate uuid as is
Tue, Apr 16, 1:49 PM
ardumont closed D1418: deposit.cli: Generate uuid as is.
Tue, Apr 16, 1:49 PM
ardumont added inline comments to D1416: deposit: Adapt revision dates setting according to new rules.
Tue, Apr 16, 1:49 PM · SWORD deposit
ardumont updated the diff for D1418: deposit.cli: Generate uuid as is.

Plug diff on master

Tue, Apr 16, 1:45 PM
ardumont updated the summary of D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Tue, Apr 16, 1:39 PM
ardumont updated the test plan for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Tue, Apr 16, 12:32 PM
ardumont updated the test plan for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Tue, Apr 16, 12:31 PM
ardumont updated the summary of D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Tue, Apr 16, 12:28 PM
ardumont updated the diff for D1419: cli.deposit: Add mandatory flags to generate the metadata xml.

Make it work using tempfile.mkstemp instead of NamedTemporaryFile

Tue, Apr 16, 12:27 PM
ardumont planned changes to D1419: cli.deposit: Add mandatory flags to generate the metadata xml.
Tue, Apr 16, 12:02 PM
Herald added a reviewer for D1419: cli.deposit: Add mandatory flags to generate the metadata xml: Reviewers.
Tue, Apr 16, 12:01 PM
ardumont added a project to D1416: deposit: Adapt revision dates setting according to new rules: SWORD deposit.
Tue, Apr 16, 9:54 AM · SWORD deposit

Mon, Apr 15

ardumont updated the diff for D1418: deposit.cli: Generate uuid as is.
  • deposit_status: Simplify the deposit status computation
Mon, Apr 15, 6:50 PM
ardumont added inline comments to D1418: deposit.cli: Generate uuid as is.
Mon, Apr 15, 6:46 PM
ardumont moved T1650: Generate xml for SWORD protocol with deposit client from Backlog to High priority on the SWORD deposit board.
Mon, Apr 15, 6:29 PM · SWORD deposit
ardumont moved T1648: Change `url` and `external-id` from mandatory to optional metadata from In progress to High priority on the SWORD deposit board.
Mon, Apr 15, 6:29 PM · SWORD deposit
ardumont moved T1648: Change `url` and `external-id` from mandatory to optional metadata from High priority to In progress on the SWORD deposit board.
Mon, Apr 15, 6:29 PM · SWORD deposit
ardumont moved T1637: Adapt deposit's creation/publication date to the SWH data-structure from In progress to In code review on the SWORD deposit board.
Mon, Apr 15, 6:29 PM · SWORD deposit