Page MenuHomeSoftware Heritage

templates/snapshot-context: Visit origin URL in a new browser tab
ClosedPublic

Authored by anlambert on Tue, Jul 6, 12:00 PM.

Details

Summary

When clicking on the "Go to origin" icon, open a new browser tab to
keep Software Heritage one.

Depends on D5982

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D5969 (id=21506)

Rebasing onto 7759503780...

Current branch diff-target is up to date.
Changes applied before test
commit cfeb5acc640b811ec488685ed8aea66633af4e9f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/925/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/925/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jul 6, 12:18 PM
Harbormaster failed remote builds in B22479: Diff 21506!

Build is green

Patch application report for D5969 (id=21512)

Rebasing onto 36b44ef08e...

Current branch diff-target is up to date.
Changes applied before test
commit c62ce202d502df8e3b4ed486ebe91bd0083c21c3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/927/ for more details.

This revision is now accepted and ready to land.Thu, Jul 8, 1:30 PM

Update:

  • Rebase
  • Open origin in browser tab in save code now UI too

Build has FAILED

Patch application report for D5969 (id=21560)

Rebasing onto 25c639f292...

Current branch diff-target is up to date.
Changes applied before test
commit cc1cc338361b4f517355b972d40b5b261263e925
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/954/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/954/console

Build has FAILED

Patch application report for D5969 (id=21560)

Rebasing onto 25c639f292...

Current branch diff-target is up to date.
Changes applied before test
commit cc1cc338361b4f517355b972d40b5b261263e925
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/955/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/955/console

Build has FAILED

Patch application report for D5969 (id=21560)

Rebasing onto 25c639f292...

Current branch diff-target is up to date.
Changes applied before test
commit cc1cc338361b4f517355b972d40b5b261263e925
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/956/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/956/console

Rebase on top of D5982 fixing flaky cypress test

Build is green

Patch application report for D5969 (id=21564)

Could not rebase; Attempt merge onto 25c639f292...

Updating 25c639f2..e12202c4
Fast-forward
 assets/src/bundles/admin/origin-save.js          |  3 ++-
 assets/src/bundles/save/index.js                 |  3 ++-
 cypress/integration/layout.spec.js               | 18 ++++++++++++------
 cypress/integration/origin-save.spec.js          |  2 +-
 swh/web/templates/includes/snapshot-context.html |  3 ++-
 5 files changed, 19 insertions(+), 10 deletions(-)
Changes applied before test
commit e12202c4b3730568477b25d91f07f45098e9f188
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 6 11:58:28 2021 +0200

    templates/snapshot-context: Visit origin URL in a new browser tab
    
    When clicking on the "Go to origin" icon, open a new browser tab to
    keep Software Heritage one.

commit a9688b3a981847d71c56e340c25f743c94a8d85a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Jul 8 19:08:14 2021 +0200

    cypress/layout: Fix cypress anti-pattern use
    
    Cypress commands should not be invoked in a loop as it is an anti-pattern
    that can produce flaky tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/958/ for more details.