Page MenuHomeSoftware Heritage

assets: Upgrade highlight.js to version 11.x
ClosedPublic

Authored by anlambert on Fri, Jul 9, 5:11 PM.

Details

Summary

This new major version of highlight.js brings notable improvements in
terms of language parsing.

As the github theme we were using has been updated to match the current
github.com one, we now use a custom theme adapted from the old github
one to keep the same look and feel for code highlighting as before.

Closes T3368

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5987 (id=21589)

Rebasing onto 3bfc6942fe...

Current branch diff-target is up to date.
Changes applied before test
commit 66b3a6c480c8aefb979ca93b54bab7cc07c5d0f5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 31 17:37:00 2021 +0200

    assets: Upgrade highlight.js to version 11.x
    
    This new major version of highlight.js brings notable improvements in
    terms of language parsing.
    
    As the github theme we were using has been updated to match the current
    github.com one, we now use a custom theme adapted from the old github
    one to keep the same look and feel for code highlighting as before.
    
    Closes T3368

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/964/ for more details.

vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
static/json/highlightjs-languages.json
231–232

we didn't have elixir so far? ._.

This revision is now accepted and ready to land.Fri, Jul 9, 5:32 PM
static/json/highlightjs-languages.json
231–232

Yes we had it, see that file for instance.

As we have a fallback checking in pygments language database, the language gets correctly detected.